DDraceNetwork

This visual bug appears when using the search function, posting it here in case you wanna look in to this.

That is absurd, @Jupstar ✪ maybe something in the text renderer choking on a weird character or sth?

Learath2

That is absurd, @Jupstar ✪ maybe something in the text renderer choking on a weird character or sth?

I've seen this multiple times already. Since @Robyt3 reworked it

ryuma

This visual bug appears when using the search function, posting it here in case you wanna look in to this.

Which exact git revision (see F1) is this? This should already be fixed in latest nightly (steam beta) and the bug was introduced after version 17.3, so the latest release should also not be affected.

Robyt3

Which exact git revision (see F1) is this? This should already be fixed in latest nightly (steam beta) and the bug was introduced after version 17.3, so the latest release should also not be affected.

I am not using the latest 17.3 version, this might have been the problem. You wanna see my git revision hash or what exactly do you wanna see? (edited)

ryuma

I am not using the latest 17.3 version, this might have been the problem. You wanna see my git revision hash or what exactly do you wanna see? (edited)

Yeah

git revision hash: 3bfa2d36f4b094d9feb240cbb76da128

Hm, that's already a month old

11:51AM

Also doesn't appear to belong to ddnet repo directly

It doesn't its the latest T-Client update for 17.3

11:51AM

My bad for pointing out a bug even tho I am not on latest DDNet version

11:52AM

Hm, so Tater didn't port the fix for this bug yet

Seems so

11:52AM

@Tater get back to work

11:52AM

Jupstar ✪

I've seen this multiple times already. Since @Robyt3 reworked it

I wanted to rework the rendering of highlighted text using the textrender, so the text color can be specified for individual spans of characters, but it didn't seem easily possible with the current text containers. Is it possible to change IGraphics::RenderText so it doesn't take a single text color as argument? Does it even need the color arguments? (edited)

Robyt3

I wanted to rework the rendering of highlighted text using the textrender, so the text color can be specified for individual spans of characters, but it didn't seem easily possible with the current text containers. Is it possible to change IGraphics::RenderText so it doesn't take a single text color as argument? Does it even need the color arguments? (edited)

Can't u simply rebuild the texture containers when text changes?

I don't want to use 3 text containers to render one browser entry

Ah

12:00PM

U don't need

12:00PM

Text containers it self support multi color

12:00PM

Just not the Render function

12:00PM

U need to do multiple append calls

12:00PM

But u need to do that anyway i guess

Yeah, I'd also need to think about a good API to make multi-color labels without to much effort

Just trade some performance xd

12:02PM

Ui Code is meant to be slow

12:02PM

And allocate 500mb ram

Using the text render directly would already make a lot of the UI text faster

12:03PM

If we don't need all the other hacks

Jupstar ✪

And allocate 500mb ram

Well, 17.3 just trades some memory for performance

12:03PM

Each UI element is leaked

12:03PM

So there is no issue of data being old

Robyt3

Well, 17.3 just trades some memory for performance

That's something u should always do xd

Robyt3

Each UI element is leaked

Oh

12:04PM

That sounds like a bug xd

Yeah, if you keep refreshing the server list you will increase your RAM usage (edited)

Mhh

But the fix for that introduced the above bug in two different ways (edited)

ok so what exactly is your plan? u could simply write a "builder" that takes text and it's color as array as parameter and builds a container out of that

12:06PM

on top of that put some kind of cache logic that checks if any parameter changed, then it's simple enough i guess

Yeah, either something like a builder or just specify a vector of STextSpan for a CTextCursor, which specifies stuff like m_Color, m_Underlined for a range of text etc. (edited)

and then handle it directly in the text.cpp logic?

Builder would be cleaner, then you don't need to ensure manually that the spans have the correct start/end indices

Jupstar ✪

and then handle it directly in the text.cpp logic?

Yeah

mh yeah.. our text engine is simply not very powerful. i guess a builder would be easier if you aren't motivated to rewrite many parts of the text engine

There's a lot that could be moved to the textrender instead

12:10PM

I want to avoid rewriting every single DoLabel call though

12:11PM

Text alignment is also currently done in CUI, on upstream this is already done in the textrender

well if u rework it, i'd suggest to create some richtext class instead of working with ranges. The rich layout engine simply has an array of text and its color and its alignment and then work block by block or smth like that

12:14PM

on the quick i also can't come up with something really useful, but it's usually easier to keep stuff that works together also together in a data structure

it'd be nice if that data structure wouldn't need to allocate, as it's in a very hot path

ui is not hot

12:15PM

also heap allocations are less worse than you think.

We can assume it will be used to support color broadcasts at the very least

the only hot paths are ingame UI stuff

Jupstar ✪

also heap allocations are less worse than you think.

if it's done every frame, then it's hot, no?

12:16PM

text also exists ingame

but not colored text

it's only a matter of time, once you make it more usable

anyway, i don't even see why we should store it as heap object. i agree that on c++ it sucks a bit, since strings are null terminated, a slice would solve these issues.. the text is only used during the call anyway

12:19PM

we don't really save the content of the string

12:19PM

the caller could decide what to use, just as we do it right now

sounds good!

how did i survive without the ease of rust std library types: https://github.com/Jupeyy/dd-pg/tree/test5/lib/pool/src having pools to allocate from is really easier for these situations, since the number of allocations maxes out to something specific

@Jupstar ✪: wrong channel but whatever. How is this an English sentence? https://github.com/Jupeyy/dd-pg/blob/a3c9d4b6a329f85c02ca56cf95c36a4b3f2ae0ed/lib/pool/src/pool.rs#L5

dd-pg/lib/pool/src/pool.rs at a3c9d4b6a329f85c02ca56cf95c36a4b3f2ae...

don't use or read this code. Contribute to Jupeyy/dd-pg development by creating an account on GitHub.

chillerdragon

@Jupstar ✪: wrong channel but whatever. How is this an English sentence? https://github.com/Jupeyy/dd-pg/blob/a3c9d4b6a329f85c02ca56cf95c36a4b3f2ae0ed/lib/pool/src/pool.rs#L5

no crate fullfilled our requirements => own implementation

7:08PM

better like that?=

Much better

7:08PM

Or add some verb to the second part

bloat

7:09PM

xd

Verbs are bloat indeed

7:09PM

Minimal comments

chillerdragon

@Jupstar ✪: wrong channel but whatever. How is this an English sentence? https://github.com/Jupeyy/dd-pg/blob/a3c9d4b6a329f85c02ca56cf95c36a4b3f2ae0ed/lib/pool/src/pool.rs#L5

No crate fulfilled our requirements so we made our own implementation

Jupstar ✪

bloat

Yea but you're wasting cycles on every user trying to understand the sentence

User brain cycles lmao

yea

Ewan

No crate fulfilled our requirements so we made our own implementation

u wasting cycles on every user having to read this overly long, over the average attention span of gen-z user, sentence

7:26PM

you must strike a balance

Jupstar ✪

no crate fullfilled our requirements => own implementation

^ this is

it took me a long time to understand

7:28PM

and chiller i guess

Link a TikTok

Replying to @Jupstar ✪ u wasting cycles on every user having to read this overly long, over the…

instead of saying that it's "fulfilled" instead of "fullfilled" @Ewan u native speaker

7:28PM

i'm sad

Xd

what

Stay in school ewan

it's spelled fulfilled

7:29PM

google it

Jupstar ✪

u wasting cycles on every user having to read this overly long, over the average attention span of gen-z user, sentence

basically our brains threw an exception when we read this illogical nonsense and we had to take another, more careful pass to parse it (edited)

Jupstar ✪

no crate fullfilled our requirements => own implementation

i missspelled it here tho

7:29PM

sssssss

yea u did misspell it

7:30PM

so why are u disappointed in me

7:30PM

xd

u didnt notice

7:30PM

u, my chat gpt

i am not gonna point out ur typos

Would be too many

tru story

just your colossal grammatical shortcomings

well that's a problem in ur brain tho

7:30PM

i understand my sentence

i didn't get the jupstar feature update

good that we are always talking about bugs in #bugs

7:32PM

brain bugs

yea

7:32PM

your brain is bugged

yeah now do your homeworks lmao, instead of continuing spaming bugs channel

what homework think_bot

u better stop spamming or ill call heinrich

xddd

7:36PM

that will end bad for me

see, i can be a mod, i can ruin convos not worse than them

MilkeeyCat

see, i can be a mod, i can ruin convos not worse than them

i voted for u

did u vote for me

u too young

7:41PM

25+

oh my bad

7:41PM

my eyes seem to be failing me recently

xDD

7:42PM

esp. bcs milkeeycat is also only 18

oh i didn't know that

7:42PM

u big troll

7:42PM

we rly should go channel tho

Jupstar ✪

i voted for u

hell yeah, thanks

it supports vulkan backend only >:(

7:50PM

laptop burns but aint gonna run me dd-pg xd

gerdoe

it supports vulkan backend only >:(

wtf how do u know xd

7:52PM

did u test it

i built it rn

8:00PM

and it will not run unless i'll buy new laptop/pc

gerdoe

and it will not run unless i'll buy new laptop/pc

does ur laptop not support vulkan? xD

8:01PM

but u can use lavapipe

Jupstar ✪

does ur laptop not support vulkan? xD

it seems

Jupstar ✪

but u can use lavapipe

lavapipe on win?

gerdoe

lavapipe on win?

ah, well exists too, but probably not very stable

gerdoe

lavapipe on win?

https://github.com/pal1000/mesa-dist-win last time i tested it (around 6 months ago) it had to support for windows surface tho

GitHub - pal1000/mesa-dist-win: Pre-built Mesa3D drivers for Windows

Pre-built Mesa3D drivers for Windows. Contribute to pal1000/mesa-dist-win development by creating an account on GitHub.

8:06PM

so u could use vulkan, but only without a window xdd

1

Jupstar ✪

so u could use vulkan, but only without a window xdd

of course the linux programmer wouldnt want a window

9:18PM

what

server settings vote menu is empty for me

11:10PM

no filter on

11:11PM

and it's a real ddnet server

11:11PM

just voted a new map with /map and it is back tho

11:11PM

maybe shouldn't have done that >_>