Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2023-10-14 00:00:00Z and 2023-10-15 00:00:00Z
Avatar
goodmorning
🌅 1
Avatar
Avatar
Robyt3
So the maximum size of a square game layer should be 23170x23170
that's sad 😭
03:57
ig I'll start the long long int revolution
Avatar
Avatar
Jupstar ✪
i mean somehow tokio does this internally. all i want is control over it xd try_run_tasks so i guess it doesn't exists, rip
i used a different executor now, which does exactly what i wanted to have: https://docs.rs/async-executor/1.5.4/async_executor/struct.LocalExecutor.html#method.try_tick
Avatar
morning
Avatar
hai
Avatar
Use member instead of static variables for demo player snapshot data. The static variables would otherwise cause issues when multiple demo players are playing at the same time, especially demo players used in background jobs for replay demo slicing. This hopefully closes #7068. Previously all demo players checked IVideo::Current to render a video, which would cause issues when rendering a demo while a demo slicing background job is running. Now video rendering can be toggled for each dem...
Avatar
Avatar
Teero
ig I'll start the long long int revolution
what for
Avatar
Avatar
Robyt3
In the map format yes, in other functions we try to switch to size_t
we should limit map sizes. size_t is a red herring, I think
11:14
@Patiga didn't you have some statistics about plausible max sizes?
Avatar
yes, I agree with Patiga that 8192x8192 would be a sensible limit for layer sizes. I considered maximum 5000 when I added validation on teeworlds at some point
Avatar
5000 would also be good
11:16
I would've loved 4096, however there already are maps on ddnet bigger than that
Avatar
I would use size_t for the parameters anyway, so we can check if Size > MAX_INT and fail the saving
👍 1
Avatar
all tilemaps over 4096
Avatar
668e6fb Use member variables for demo player snapshot data - Robyt3 d00283e Enable use of video recording for each demo player individually - Robyt3 2ddde45 Merge pull request #7344 from Robyt3/Engine-Demo-Antistatic - def-
Avatar
not really sure how how to decide on a good limit, maybe 5000 is the next best conservative size
11:28
huh, I didn't know chill let's climb 2 and 3 have the same height
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [X] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...
Avatar
Avatar
heinrich5991
we should limit map sizes. size_t is a red herring, I think
why would you limit them?
Avatar
d9a7df0 Add tests and documentation for swap_endian function - Robyt3 46c7229 Merge pull request #7345 from Robyt3/Tests-Swap-Endian - def-
Avatar
Avatar
Teero
why would you limit them?
it should at least not cause overflows
12:30
overruns
Avatar
memory safety
Avatar
Avatar
Robyt3
So the maximum size of a square game layer should be 23170x23170
so it should atleast be this no?
Avatar
That's just one limit in the map format, there could be more limits elsewhere. And it makes no sense to allow maps that cause crashes due to out of memory for the majority of the users
12:36
Even if you can load a map that has a game layer of size 23170x23170, the editor would probably crash if you added a few tile layers (of the same size) to the same group (edited)
12:36
20x20k works fine in the editor
Avatar
How many tile layers did you add?
Avatar
Idk 3 maybe 4
12:37
New technique to avoid map piracy just dropped poggers2
Avatar
It's simpler to add more than 1024 small items to the map though, then the editor can no longer save it
12:39
That's an arbitrary limitation that I'll eventually remove
Avatar
@Jupstar ✪ hey is there a reason why we don't have every gfx backend store things like we do with OpenGL 1.x?
Avatar
it doesnt store anything
12:43
and i answered it yesterday alraedy
12:43
besides any memory corruption, physics will be less deterministic anyway
Avatar
Avatar
Teero
New technique to avoid map piracy just dropped poggers2
I would add the same limit to loading maps
12:46
generally, any limitation that is present solely in the editor is probably a bug
Avatar
generally tho, limits suck indeed
12:51
they not future ready
Avatar
we need live editing of maps.
12:57
Procedurally generated maps owo
12:57
Would also open a new world for mods
Avatar
mineworlds
Avatar
I suggest a tile that can spawn more tiles
Avatar
As the shell script is pretty slow, taking roughly 84 seconds in the CI, whereas the equivalent Python script takes only 1 second.

Checklist

  • [X] Tested the change (by adding unused header files)
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] ...
Avatar
Reported by lolkildal on Discord: !assert m_DemolistSelectedIndex invalid for POPUP_RENDER_DEMO 151394630fb29ca11a2be94118f366aeafe0d307 @furo321:
I see the issue, it happens if you have something in the search bar that won't match what you named the demo cut.
15:04
db17539 Rewrite unused header style check shell script in Python - Robyt3 575fc6c Merge pull request #7346 from Robyt3/Scripts-Check-Unused-Header-Python - heinrich5991
Avatar
Avatar
Learath2
I wonder if we can have the bot watch that channel and publish everything
if not, maybe we should not make it look like an announcement channel
Avatar
The map version was only checked if the version item is present, which is different from how client and editor load maps. Now a missing version item is considered an unsupported version. Additional log messages are also added to the tools.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration te...
Avatar
60bb48c Fix map version checks in map_diff and map_extract tools - Robyt3 788a2ad Merge pull request #7348 from Robyt3/Tools-Map-Version-Check - heinrich5991
Avatar
@Jupstar ✪ fakes on ALIVE
18:36
Avatar
hobbyless kiddos xd
Avatar
yeah :/
Avatar
they dont even put effort into names ;(
Avatar
@heinrich5991 Firefox has the nice graphic. How do they generate it? Is there a script?
Avatar
Is it possible to build a .dmg file (for distributing apps) from a non-Mac platform? And if yes, how?
Avatar
Avatar
deen
@heinrich5991 Firefox has the nice graphic. How do they generate it? Is there a script?
hmm this answer suggests we might only need to copy the .DS_Store from dmg created on macOS
Exported 66 message(s)