What do you think of the following classes? They store the data in the normal mapitems to allow implementing the envelope accessor.
c++
class CCurveInfo
{
enum class EType
{
LINEAR,
STEP,
} m_Type;
vec2 GetBezierTangentOffsetStart() const;
void SetBezierTangentOffsetStart(vec2 TangentOffset);
vec2 GetBezierTangentOffsetEnd() const;
void SetBezierTangentOffsetEnd(vec2 TangentOffset);
private:
CEnvPointBezier m_BezierInfo;
};
struct CTransform
{
float OffsetX;
float OffsetY;
float Rotation;
};
class CEnvelopePoint
{
public:
float GetTime() const;
void SetTime(float Time);
float GetVolume() const;
void SetVolume(float Volume);
CTransform GetTransform() const;
void SetTransform(const CTransform &Transform);
ColorRGBA GetColor() const;
void SetColor(const ColorRGBA &Color);
std::array<float, 4> GetValues() const;
void SetValues(const std::array<float, 4>& Values);
CCurveInfo m_CurveInfo;
private:
// also store the points inheriting from CEditorObject in this class
// std::vector<std::array<CEnvelopeEditorPoint, 4>> m_vEditorPoints;
CEnvPoint m_PointInfo;
};
What do you think of the following classes? They store the data in the normal mapitems to allow implementing the envelope accessor.
c++
class CCurveInfo
{
enum class EType
{
LINEAR,
STEP,
} m_Type;
vec2 GetBezierTangentOffsetStart() const;
void SetBezierTangentOffsetStart(vec2 TangentOffset);
vec2 GetBezierTangentOffsetEnd() const;
void SetBezierTangentOffsetEnd(vec2 TangentOffset);
private:
CEnvPointBezier m_BezierInfo;
};
struct CTransform
{
float OffsetX;
float OffsetY;
float Rotation;
};
class CEnvelopePoint
{
public:
float GetTime() const;
void SetTime(float Time);
float GetVolume() const;
void SetVolume(float Volume);
CTransform GetTransform() const;
void SetTransform(const CTransform &Transform);
ColorRGBA GetColor() const;
void SetColor(const ColorRGBA &Color);
std::array<float, 4> GetValues() const;
void SetValues(const std::array<float, 4>& Values);
CCurveInfo m_CurveInfo;
private:
// also store the points inheriting from CEditorObject in this class
// std::vector<std::array<CEnvelopeEditorPoint, 4>> m_vEditorPoints;
CEnvPoint m_PointInfo;
}; 
1
Get prefix for getters CEnvelopePoint::Time and CEnvelopePoint::SetTime?CEnvelopePoint::Time and CEnvelopePoint::SetTime? CCurveType::m_Type seems redundant since we already have constants in mapitems.h CCurveInfo(EType Type) is a bit nicer than CCurveInfo(int Type), but that doesnt really matter. Or I can also make them a seperate enum in mapitems and then use thatint Type with a comment for now, instead of changing mapitems.h 1
(a, b) => { return b.frequency - a.frequency; } because only the sign matters(a, b) => { return b.frequency - a.frequency; } because only the sign matters as any is the safest thing in the world 
1
1 (sorry to interrupt drama) (sorry to interrupt drama) 
(sorry to interrupt drama) 
1
1 back
1
1 
We can go back to having fun 1
You have to click twice to access the news page when you're already in the browser. First, on the top left corner (which takes you back to the main menu), and then once more on the not-so-easily noticeable news button in the bottom left. You have to click twice to access the news page when you're already in the browser. First, on the top left corner (which takes you back to the main menu), and then once more on the not-so-easily noticeable news button in the bottom left. 
1
1
