DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2023-10-02 00:00:00Z and 2023-10-03 00:00:00Z

sup

hello

just learned about uiua

05:50

and array languages in general

05:50

hard to read but its compactness is truly wonderful

[ddnet/ddnet] Issue opened: #7281 Allow changing demo markers when slicing demo

I think the demo marker feature would be more useful if markers could be added after a demo has already been recorded. The demo player could support removing/adding markers from/to existing demos, which would be saved by demo slicing.

[ddnet/ddnet] Pull request opened: #7282 Teleport the player to their cursor if they aren't in pause

tele and /tp will now teleport the player to their cursor if they aren't paused or used one of the optional arguments. https://github.com/ddnet/ddnet/assets/141338449/8a217199-c13d-47fc-a077-3b4360afe3f4

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered poss...

[ddnet/ddnet] Pull request opened: #7283 Fix images using indexed color palette not being loadable

The wrong color channel count was being used for loading images that use an indexed color palette, which was causing the loading to fail with the error "bytes in row incorrect". Now the correct color channel count is retrieved using the libpng API. Closes #7157.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added ...

10:26

[ddnet/ddnet] Issue closed: #7248 Quad selection not reverted correctly

for the love of god, can someone pls implement an option to only see the own team in freeview (/pause) ❤️

Gumba

for the love of god, can someone pls implement an option to only see the own team in freeview (/pause) ❤️

/specteam :)

1

menus_settings.cpp How do I summon?

Image attachment

owo

1

summon what? (edited)

Update function from Discord

[ddnet/ddnet] Pull request opened: #7284 Fix crashes when rendering tees after skins are updated

At least with the method I described in https://github.com/ddnet/ddnet/issues/7205#issuecomment-1742842164, I cannot reproduce the assertion anymore. It previously happened in several components. In particular, this assertion also happened when rendering players and the HUD, for which the only explanation was that the gameclient render info was already wrong, which is fixed by 96ef1fbc88d21966c581176afab71ed5dca69004. Closes #6882. Closes #7205.

Checklist

[X] Tested the change i...

Image attachment

14:21

teeobserver now supports websockets (edited)

14:21

to listen to master server events

14:22

ima setup a instance

14:23

xd

14:25

https://github.com/edg-l/teeobserver

GitHub - edg-l/teeobserver: This tool continuously fetches the DDNe...

This tool continuously fetches the DDNet master server and observes the changes, broadcasting the events and providing a API. - GitHub - edg-l/teeobserver: This tool continuously fetches the DDNet ...

14:25

AGPL3 ofc

14:26

it has a setup to connect to a psql db but i dont use the db yet

Ryozuki

to listen to master server events

how did you design the protocol? is there some documentation?

not yet

15:01

the protocol is however serde serializes the enum for events i made

15:02

xd

15:02

which i need to add more

forgot to set it online xd

uhoh

16:16

idk why my websocket connection doesnt work when i deploy

16:16

through cloudflare

16:16

well i havent tried without it

github-merge-queue[bot]

[ddnet:master] 7 new commits

9029fb9 Remove CTeeRenderInfo member variables of CPlayers - Robyt3 1dedde5 Refactor ghost skin updating, ensure current ghost is updated - Robyt3 e41b3a9 Use bool instead of int for m_GotAirJump - Robyt3 6094061 Add CTeeRenderInfo::Reset, ensure everything is initialized - Robyt3 96ef1fb Fix client render info not being updated when skin not found - Robyt3 589b047 Track team killmessage victims separately, ensure initialization - Robyt3 161a256 Merge pull request #7284 from Robyt3/Client-Skin-Assertion-Refactoring - def-

16:32

[ddnet/ddnet] Pull request closed: #7284 Fix crashes when rendering tees after skins are updated

16:32

[ddnet/ddnet] Issue closed: #7205 Assertion error when connecting dummy (See explanation)

16:32

[ddnet/ddnet] Issue closed: #6882 Crash due to invalid texture being used for tee in killmessage

16:33

github-merge-queue[bot]

[ddnet:master] 2 new commits

7e045d4 Teleport the player to their cursor if no argument is specified. - furo321 78b70eb Merge pull request #7282 from furo321/tele-cursor - def-

16:33

[ddnet/ddnet] Pull request closed: #7282 Teleport the player to their cursor if they aren't in pause

im lost idk what going on

Image attachment

finally i got it

17:10

after a fight with nginx

17:11

server {
    # Add index.php to the list if you are using PHP
    server_name observer.ddstats.org;

      access_log /var/log/nginx/teeobserver-access.log;
      error_log /var/log/nginx/teeobserver-error.log;


    location /ws {
        client_max_body_size 10M;
        proxy_set_header Host $host;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-Proto $scheme;
        proxy_pass_request_headers on;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
        proxy_http_version 1.1;
        proxy_pass http://127.0.0.1:6688/ws;
    }

    location / {
        client_max_body_size 10M;
        proxy_set_header Host $host;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-Proto $scheme;
        proxy_pass_request_headers on;
        proxy_pass http://127.0.0.1:6688/;
    }



    listen 443 ssl http2;
        listen [::]:443 ssl http2;
        ssl_certificate /etc/ssl/cloudflare-ddstats.pem;
        ssl_certificate_key /etc/ssl/cloudflare-ddstats.key;
}

the glorious result thats probs not good

17:11

https://observer.ddstats.org/

thats what i call logging!

soon ill add a nice frontend on ddstats.org directly

17:14

wss://observer.ddstats.org/ws here is the websocket endpoint (edited)

Sedonya

menus_settings.cpp How do I summon?

Discord()->Update();

The screenshot clearly shows that an error is occurring, which is why it is highlighted in red

17:48

А

17:48

Update()

17:48

Pls wait

[ddnet/ddnet] Issue opened: #7285 Add admin interface for maps (or files) upload

Ewan

Discord()->Update();

Don’t work

it probably takes parameters

17:49

idk

17:49

but you can never call a function without parentheses

17:50

closest you can get is (Discord()->Update)()

I downloaded assets from skins.tw and added them to the game's entity file, but it was not activated, what should I do? Please help...

Ewan

it probably takes parameters

no

@Ryozuki: rusterion

Replying to @Rusterion I downloaded assets from skins.tw and added them to the game's entity fi…

can u show me the function def instead of just telling me that it doesn't work

17:50

i';m not psychic

What’s the error?

Replying to @Sedonya Don’t work

lol this is how the client does it

Image attachment

Image attachment

Image attachment

so idk

Sedonya

Update()

Show me your code now

17:54

Did you forget the semicolon or something

Image attachment

what is the error?

owo

Image attachment

my OCR doesn't like the russian

17:58

C: \Users\user\Documents\GitHub\S-C1ient_Private\src\engine\c1ient\discord. cpp C:\Proqram Files (x86)\Windows error C2011: IStorage: nepeonpeaeneHne T"na Private\src\enqine/storaqe.h(16): note: CM. 06ygsneHwe "lStorage" "class" [30/891 Building CXX [31/891 Building CXX ninja: build stopped: object object subcommand failed.

17:58

can't translate that

pls wait

17:59

objidl.h(10694): error C2011: IStorage: override of type "class"

17:59

/storage.h(16): note: see "IStorage" declaration

❓

17:59

how is this happening

idk

17:59

xd

you shouldn't be using IDL at all

18:00

maybe your build is misconfigured

18:00

oh i know it's the damn interface stuff

Ewan

you shouldn't be using IDL at all

default ddnet lmao

18:01

I didn't add anything

okay i'm gonna ignore that for now

18:01

are you making a class called class?

18:01

don't do that

This likely means you included Windows.h or another Windows header that includes it without #define WIN32_LEAN_AND_MEAN

once it's defined it doesn't undef itself

A Windows header defines IStorage which collides with our own interface with the same name

I don't understand what I need to do :(

i feel like i have had this issue before

Search all files for Windows.h and make sure there is a line #define WIN32_LEAN_AND_MEAN somewhere before #include <Windows.h> in that file

windows.h is somewhere in the ddnet source code?

It should work with original ddnet, have you tried that?

18:06

Otherwise it's somewhere in the code you added

My IDE couldn't find it in the ddnet code, but found it outside the

Sorry, I mean search for the text Windows.h not the file

ah..

18:08

wait

18:09

:O

Image attachment

there should be more

18:10

You don't need to look at those in /external/ folder

18:11

Which includes are in your discord.cpp?

Image attachment

Robyt3

Which includes are in your discord.cpp?

Image attachment

Try to build with only one thread so it's clear which file contains the include (edited)

aaaah..

18:15

How do you do that? owo

owo

What IDE are you using?

CLion

https://www.jetbrains.com/help/clion/cmake-profile.html#build-options

CMake profiles | CLion

I'm too dumb to understand what's required of me, sry

Specifying -j 1 as the argument should make the build use only one thread, so the error messages should be in a readable order

Cmake?

don't use the ninja generator & don't use --parallel

Image attachment

Robyt3

Specifying -j 1 as the argument should make the build use only one thread, so the error messages should be in a readable order

next?

If you specified the argument, rebuild and post the log

Image attachment

18:25

\menus_settings.cpp(2348): error C3861: Discord: identifier not found

Just comment out that line

18:26

And try without to see where the issue with the include is

I did, but I need the Update to run :O

Try to solve one issue first

Working (edited)

Image attachment

S-Client?

18:33

tee_thinking

tee_thinking

sedonya-client

yeah

18:38

Robyt afk

Is this the birth moment of yet another bot?

nooooooooooooo

i don't think this is the birth moment of anything?

For now, yes, but I have big plans for this client

bug? Why am I in the table below

Image attachment

Image attachment

its only sorted by seconds and if theyre the same then by alphabet (edited)

σℓí♡

bug? Why am I in the table below

Milliseconds don't count, but the order of letters in the alphabet does, so your "Symbolic" nickname is lower.

TY

1

unicode symbols are after all ascii

19:02

if u wanna be first add a number or !

19:02

this is why servers back then all had "! - name"

19:02

in the name

people with those types of names are all ego

19:03

minus stormax

u also appear last on the discord mod list

yea

gigachad

gay #1

Image attachment

19:04

gigachad

Sedonya

Working (edited)

@Robyt3

Well, it's working?

Yes

19:06

but...

Image attachment

That compiles?

Yes

if(...)
// code

Seems like it shouldn't compile

kek

Image attachment

19:08

brain

But, it doesn't work without a comment

Why do you want to update discord there?

19:09

Discord already gets updated like all other components

I want to make a function "Show the map you're playing on - in Discord". And I want it to be updated immediately after changing a parameter

It will be updated basically the next frame, that should be immediate enough

Image attachment

Robyt3

It will be updated basically the next frame, that should be immediate enough

AH?

Discord()->Update() is already called in CClient::Update in client.cpp

Fuck, I've been trying to solve this problem all day feelsamazingman

feelsamazingman

19:14

Now can I remove the -j 1?

Yes

It only updates when you re-enter the map

19:16

justatest

Ah, you need to call void SetGameInfo(const NETADDR &ServerAddr, const char *pMapName, bool AnnounceAddr) if you want to update the info

19:17

It's normally only called when connecting

How do I summon her in that place?

justatest

justatest

[ddnet/ddnet] Issue opened: #7286 add into frend list into f1

some times u need add friend pll who already left server (simple if u flw him) . it will be great if u can add on friend list on f1.

wut

cyberFighter

wut

server prediction seems off , on tunings (maps) since yesterday or some dayz ago? and even before that I think? if u decrease sv_dragger_range and laser would have hit u (with normal value) tee shaking weird may this has something to do with it https://github.com/ddnet/ddnet/pull/7267

Fix the fix to dead reckoning by Learath2 · Pull Request #7267 · dd...

I missed the fact that the world does not stay nullptr should have tested more thoroughly. Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combinatio...

AAAAAAAAAAa

teini94

server prediction seems off , on tunings (maps) since yesterday or some dayz ago? and even before that I think? if u decrease sv_dragger_range and laser would have hit u (with normal value) tee shaking weird may this has something to do with it https://github.com/ddnet/ddnet/pull/7267

Tell me how to reproduce

20:43

Preferably with a map

lol rip

Cursed PR

pepeW

he disappeared before sharing repro steps

20:52

guess I'll just mess around with sv_dragger_range and some draggers to see if I can make it happen

sad

Fix the fix to the fix to dead reckoning

He sent me those demos as well

Tiny_Hawk_2023-10-02_22-16-17.demo

281.58 KB

UpNDown_2023-10-02_21-53-24.demo

831.49 KB

it does look like a reckoning issue pepeW

pepeW

21:11

aaaaaaaaaaaaa

21:12

This is what I get for thinking I can find a better way than matricks

3

Lol

Learath2

it does look like a reckoning issue pepeW

pepeW

Could be due to ecaded8cce59e463cdb6c1300d55cdee4a7521bc that added tunezones for ReckoningCore? The client and servers have to use the same tunings for evolve/reckoning, and currently the client doesn't use tunezones when evolving (since the client/server doesn't have any way to agree on exactly which tunezone to use for it)

trml

Could be due to ecaded8cce59e463cdb6c1300d55cdee4a7521bc that added tunezones for ReckoningCore? The client and servers have to use the same tunings for evolve/reckoning, and currently the client doesn't use tunezones when evolving (since the client/server doesn't have any way to agree on exactly which tunezone to use for it)

AHA, yes, I even thought about this when making the initial patch, I wonder why I never removed it

[ddnet/ddnet] Issue closed: #7285 Add admin interface for maps (or files) upload

AH, I was fooled by the creation of the TempWorld

21:26

It uses the tunes of the World

21:26

I should also be passing the tunes of the world, not tunes of the tunezone since the client can't know the tunezone with vanilla prediction

yes, I think it just uses the default tuning values of worldcore. but the code for that isn't very obvious

[ddnet/ddnet] Pull request opened: #7287 store editor tooltip in optional string

Currently when you want to use str_format for the tooltip you have to create a buffer for it. But when setting the tooltip from other classes this becomes a bit problematic, because the buffer still has to be part of CEditor to avoid nullptr exceptions.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added ...

Exported 207 message(s)