DDraceNetwork - developer

[ddnet/ddnet] Pull request opened: #7257 Add votes command to rcon

Adds votes command, which lists votes along with their description and command. it's paginated with 20 votes per page. Closes #7160 !image

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] C...

const std::_Func_impl_no_alloc<class <lambda_ad6ba1eaea12b458f340b402ad5b91bc>,void,class std::vector<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::allocator<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > > const & __ptr64>::vftable

01:26

C++ moment

this is bad code

02:06

typedefs/type usings would make this totally reasonable but they chose to leave it obtuse

02:06

xd

heinrich5991

just looking at a scoreboard with two adjacent teams, they're pretty much indistinguishable for my eyes

This can also be true when we have only certain team numbers playing at a given time

heinrich5991

an option added if ppl rly are having a hard time differentiating

please no

heinrich, its really sad. so many things have changed in ddnet in the past, and I think I was against all of those where the community strikes now. Starting with the freeze bar, which was not allowed to be an option either. You just forced it onto us. Learath promised a feature to get it back after he had to see that the community is in favour. Then there's this, and again no option. I think there was sonething else aswell. When do you notice that you should maybe start doing votes beforehand? You don't stick to your own rules: Discussing things before they're made, actually listening to other people's opinions and maybe simply discarding things. Same for all the protocol changes in the past again. It's so sad.

5

06:19

You don't want options, you don't want anything. Just force everything onto the community. Also nobody of you admins did want to actually make a vote or whatever for the freeze bar. And still, up to this date there's no feature to revert it.

I like the new colors, but just an idea if people keep complaining: bring back old colors but add a little spacing between teams so they're visually separated that way

Ravie

I like the new colors, but just an idea if people keep complaining: bring back old colors but add a little spacing between teams so they're visually separated that way

I’m just wondering why it wasn’t implemented like this in the first place

fokkonaut

heinrich, its really sad. so many things have changed in ddnet in the past, and I think I was against all of those where the community strikes now. Starting with the freeze bar, which was not allowed to be an option either. You just forced it onto us. Learath promised a feature to get it back after he had to see that the community is in favour. Then there's this, and again no option. I think there was sonething else aswell. When do you notice that you should maybe start doing votes beforehand? You don't stick to your own rules: Discussing things before they're made, actually listening to other people's opinions and maybe simply discarding things. Same for all the protocol changes in the past again. It's so sad.

#metoo I stand with fokkonaut. I also feel r@pd by heinrich

1

08:44

He did unspeakable things to me with his brand new freeze bars

Bad devs

Just because I download DDNet doesnt mean im "asking for it". He took my client and rammed his big freezebar into it

u can still use older clients

He left :p

I too have had enough, all these changes, it's just too much. It doesn't even feel like ddnet anymore

Learath2

I too have had enough, all these changes, it's just too much. It doesn't even feel like ddnet anymore

I mean have you ever seen a bar in teeworlds? No

09:59

This is

reality

Well ig maybe the community is against some things, but 1-2 person aren't enough to assume that. Maybe sometimes a survey can be cool (edited)

Waaiit, a handful of people that are extremely correlated isn't a good representative sample of this entire community? Nooo

ReiTW

Well ig maybe the community is against some things, but 1-2 person aren't enough to assume that. Maybe sometimes a survey can be cool (edited)

Yeah surveys are a good idea especially for visual things like the color change. I was too busy so it slipped my mind to ask for one

10:04

Every ui change is extremely controversial, should always get a vote for them

Speaking of ui changes, the info/friends/filters also got moved up.. not that I am against it, but was used to the old one and adapting, I guess

I mean not a survey for just a single feature

10:07

But like some features are already here since, maybe get a feedback through a survey after some time

That is actually not a bad idea, maybe a week after every release we can do a forum post so people can post complaints and things they want improved

2

Starting with the freeze bar, which was not allowed to be an option either. You just forced it onto us. Learath promised a feature to get it back after he had to see that the community is in favour.

it was allowed to be a client-side option. no one implemented it

10:24

Same for all the protocol changes in the past again.

this seems like something most of the community does not care about. I didn't ask about https masterservers, they got complaints in the beginning, but I think they're the clearly superior option

10:24

for the colors, it's not as clear-cut, I agree

10:25

but I don't like that you tell me that I'm sad

10:25

I don't go around doing such stuff to you or others

heinrich5991

but I don't like that you tell me that I'm sad

Maybe he was saying the situation is sad? At least that’s how I read it

ah, fair

Im sad ;(

Learath2

I too have had enough, all these changes, it's just too much. It doesn't even feel like ddnet anymore

Tell em

heya

11:44

im finally back

11:44

got internet

1

1

11:44

xD

wb

11:53

what did you do?

https://discord.com/channels/252358080522747904/252358080522747904/1155943568125480960

github-merge-queue[bot]

[ddnet:master] 3 new commits

d165f9e Add votes command to rcon - furo321 eabe59b Change format of votes - furo321 875c51e Merge pull request #7257 from furo321/votes-command - def-

12:05

def-

[ddnet/ddnet] Pull request closed: #7257 Add votes command to rcon

12:05

def-

[ddnet/ddnet] Issue closed: #7160 Add a command to list the (available) votes

heinrich5991

I don't go around doing such stuff to you or others

true, you instanrly ban but keep projecting that i specifically called you sad haha

heinrich5991

Starting with the freeze bar, which was not allowed to be an option either. You just forced it onto us. Learath promised a feature to get it back after he had to see that the community is in favour.

it was allowed to be a client-side option. no one implemented it

No, you never accept options because it's too much of maintenance

heinrich5991

Same for all the protocol changes in the past again.

this seems like something most of the community does not care about. I didn't ask about https masterservers, they got complaints in the beginning, but I think they're the clearly superior option

ok, now who said anything about http masterservers? it's about those small, weekly protocol changes. those where you tell me all the time we need to discuss them properly etc. anything not by me will not be discussed but rather be merged immediately.

13:15

(and i only focus on that part right here; that they DO NOT get discussed properly BEFOREHAND)

13:15

therefore its also not a good idea to ask everyone a week later, after all the implementations have been made, protocol changes are done, etc etc

13:15

you simply don't follow your own rules, it seems, or well maybe YOU do, but not the other admins then

13:16

that's sad, whether you personally are sad: i dont know xd

I'd prefer it if you said "I'm sad about this" instead of "this is sad"

no sorry, this situation is sad

13:16

in an objective way

I do think that changing the network code to be more maintainable while keeping backcompat with old clients is fine

heinrich, you like arguing, but then please get some good arguments

I do not think that supporting old protocol edge cases that mods use is the way forward

usually i'd agree, but if those things are used all over the place since 10+ years, even in ddnet itself, and even on the clientside where only the server can't control it anymore while it's still implemented the same way...

13:19

then it's something else, imo

heinrich5991

I do not think that supporting old protocol edge cases that mods use is the way forward

thinking like this you should probably fix all the bugs in ddnet, because they have only been used in old maps, that's not so important

no, I'm specifically referring to mods

13:20

I do think that keeping old ddnet maps working is good

mods are part of ddnet, no? you like mod diversity, no? you want developers for this game and the community, no?

yes, I do. I don't want to support edge cases, however

13:21

I'd like to encourage mods to contribute non-edgecase behavior instead

13:21

like Kaffeine is doing

so that every mod has to maintain their own set of backward compatibilitys?

heinrich5991

like Kaffeine is doing

i think it's way too much, but that's somethign else.

13:21

if we'd have proper mod support : great

we don't, no point here

not like this tho where we support 100 versions and handle everything differently

13:22

even supporting 2 major versions

you're welcome to drop tw 0.6 and tw 0.7 support in your mod

13:23

I don't think we should put effort in helping mod developers to support 0.6 and 0.7

heinrich5991

you're welcome to drop tw 0.6 and tw 0.7 support in your mod

???????????????????

13:23

oh boi

13:25

it's simply tiring to talk to you, most of the time

heinrich5991

I do think that keeping old ddnet maps working is good

and u didnt get any of my points xD