Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2023-09-25 00:00:00Z and 2023-09-26 00:00:00Z
07:45
Gm
Avatar
Morning 🍵
Avatar
Avatar
murpi
Why does the second if condition not return? licenses = ["CC0", "CC BY", "CC BY-SA"] if re_match.group('license'): print(re_match.group('license')) for license in licenses: print(license) if not any(license in re_match.group('license') for license in licenses): return The string to be matched: "Testing" by Tester (CC BY SA) The Prints: CC BY SA CC0 CC BY CC BY-SA
any(license is always true
Avatar
Avatar
murpi
Why does the second if condition not return? licenses = ["CC0", "CC BY", "CC BY-SA"] if re_match.group('license'): print(re_match.group('license')) for license in licenses: print(license) if not any(license in re_match.group('license') for license in licenses): return The string to be matched: "Testing" by Tester (CC BY SA) The Prints: CC BY SA CC0 CC BY CC BY-SA
the if looks bad anyway, it should be something like re_match.group("license") in licenses
Avatar
When moving the mouse fast there can be a discrepancy between where I aimed and where my weapon or hook actually go's. This is because of the fact that the mouse can move after I've shot/hooked and the mouse position at the end of the tick gets send, not the one when shot/hooked. This makes aiming these actions kind of random and tick dependent, if you did the action right before the tick ends its really accurate but if its all the way in the beginning the mouse can move up to 20 ms longer, ...
Avatar
Avatar
heinrich5991
any(license is always true
import re def abc(string) -> bool: regex = re.compile(r'^\((?P<license>.{3,8})\)$') re_match = regex.match(string) licenses = ["CC0", "CC BY", "CC BY-SA"] if re_match.group('license'): if not any(license in re_match.group('license') for license in licenses): return False return True result = abc("(CC SA-BY)") print(result) Result is False
11:02
if I use CC BY-SA result is True and if I use CC BY SA it also returns True
Avatar
Avatar
ChillerDragon
@heinrich5991 the http master is so pog i just wrote 2 lines of ruby to check if a ip is in the master for user input validation. Stuff like that would never have been possible with the old master
cool 🙂
Avatar
Avatar
ReiTW
hi, is it me or https://github.com/ddnet/ddnet/pull/5829 is not fully implemented ? Msg.AddString("", 0); // HTTPS map download URL
it's only implemented on the client side, and for third-party servers
Avatar
Avatar
Learath2
If there are any python users amogus, what does one use to format their code nowadays?
black
Avatar
Avatar
ChillerDragon
Click to see attachment 🖼️
all inside the training data
Avatar
Avatar
Learath2
Yeah, it was meant to always be removed
we should simply fix our skins
Avatar
Avatar
murpi
import re def abc(string) -> bool: regex = re.compile(r'^\((?P<license>.{3,8})\)$') re_match = regex.match(string) licenses = ["CC0", "CC BY", "CC BY-SA"] if re_match.group('license'): if not any(license in re_match.group('license') for license in licenses): return False return True result = abc("(CC SA-BY)") print(result) Result is False
I think you want re_match.group("license") in licenses
Avatar
Avatar
heinrich5991
I think you want re_match.group("license") in licenses
Yes, that's what im using now. 😄
Avatar
your check also allows ABCC0DEF
Avatar
any() seems to turn hyphens into spaces or something
Avatar
no
11:36
any is a function that turns a list of booleans into a boolean
Avatar
Avatar
murpi
if I use CC BY-SA result is True and if I use CC BY SA it also returns True
I can't think of any other reason why this would be True
Avatar
because you check whether CC0, CC BY or CC BY-SA appear in your license string
11:36
this meands ABCC0DEF will also be accepted by the check
Avatar
Why is CC BY SA True?
11:37
Ah
11:37
I see, nevermind xD
11:39
Adding those licenses into the regex itself would've been an alternative so it doesn't match substrings
Avatar
do we have a friend only mode or something like that in ddnet right now
11:47
like in which you can only see names / clans in your friend list (edited)
11:47
apparently people are now changing their names to banned names and doing stream sniping to trigger auto bans for chinese streamers (edited)
11:47
monkaStop
Avatar
Avatar
Sedonya
All folders are empty
@Robyt3 Infinite afk mode
Avatar
Avatar
heinrich5991
we should simply fix our skins
It was fixed weeks ago. But in some countries they still get the broken one
Avatar
Avatar
TsFreddie
apparently people are now changing their names to banned names and doing stream sniping to trigger auto bans for chinese streamers (edited)
I don't understand how this is related to friendlist. Are the streamers changing the name or what xd
Avatar
other peoples changing names and joining the same server
11:59
cl_nameplate 0 probably can avoid this but maybe a friend only mode can let them still see friend's name and chat
Avatar
Ah they change name to disallowed words?
12:00
Now i get it xd
Avatar
But i guess we don't directly have this. /Dnd is the cost
12:01
Closest
12:01
But whisper might still work
Avatar
apparently major streaming platform here in china are doing OCR occationally just to auto bans
12:01
owo
12:02
dnd still shows names i think?
12:02
they'd probably need to turn off both chat and nameplates to be safe which might be quite alone lol.
12:03
Catxplosion i might PR on holiday i guess
Avatar
Avatar
heinrich5991
we should simply fix our skins
If a skin ends up in there that isn't correct the results seem to be far more catastrophic than intended
Avatar
Avatar
Learath2
If a skin ends up in there that isn't correct the results seem to be far more catastrophic than intended
seems like we wouldn't notice it otherwise
12:37
it's intended to be somewhat obvious so that instances of it will be reported
Avatar
We can't even fix it in a reasonable amount of time due to how aggressive cloudflare caches them
Avatar
we can probably empty cloudflare caches. it'd be nice to add a check to the process of adding skins to the db
Avatar
Avatar
heinrich5991
it's intended to be somewhat obvious so that instances of it will be reported
It locks all input killing runs, somewhat obvious is probably desirable, killing runs is not. I think it does more harm than good, we can just make sure there is only one way to add a skin and it's checked
Avatar
might be better to make it dismissable with tab instead of locking input
Avatar
So or so.would be nice if smbdy with cloudflare access can check
Avatar
Avatar
Jupstar ✪
So or so.would be nice if smbdy with cloudflare access can check
emptying cloudflare caches?
Avatar
Avatar
Sedonya
All folders are empty
Maybe you could help?
12:47
@Jupstar ✪
Avatar
Avatar
heinrich5991
emptying cloudflare caches?
Yes
Avatar
Avatar
Sedonya
Maybe you could help?
I think u also need to change info. Ddnet for that to work. It gets the version number from there
Avatar
Avatar
Jupstar ✪
Yes
I purged skins.ddnet.tw and skins.ddnet.org
Avatar
Except you coded that out already. I didn't follow your development
Avatar
Avatar
heinrich5991
I purged skins.ddnet.tw and skins.ddnet.org
Ok nice
Avatar
Avatar
Sedonya
All folders are empty
Then something with your download didn't work
Avatar
Okay, I'll take a look later
Avatar
is furo on discord the furo on github?
14:55
we gained quite an active contributor recently 🙂
Avatar
there goes my plan not to ping random people 😄
Avatar
Ah, no worries. Yeah, it's me.
Avatar
Avatar
furo
@heinrich5991 Hey, I'm furo from #7181. I kinda have no clue how I would introduce the new server packet. Where would I start?
Just investigate I guess 😄 (Don't worry i turned off the ping)
Avatar
ah nice 🙂
Avatar
This mostly reverts #6937 by making our IOHANDLE effectively FILE * on all systems again. We still use CreateFileW to open a HANDLE initially so we can specify the necessary flag so the file can be moved/deleted while open, which we can't do with the FILE * based fopen functions on Windows. This brings back the automatic I/O buffering on Windows, causing significantly less system calls when saving files. Closes #7226.

Checklist

  • [X] Tested the change ingame
  • [ ] Provid...
Avatar
Once you loaded an audio file that's playing or you closed the dialog. It will keep playing the audio preview.
Avatar
8ebe3c1 Use FILE * on Windows again, only use HANDLE for opening - Robyt3 296d141 Merge pull request #7254 from Robyt3/Windows-File-Buffering - heinrich5991
Avatar
i keep getting ads for log2base2
18:19
is it any good
Avatar
you should install an ad blocker ^^
Avatar
why did 17.3 break so much
Avatar
the real question is: why is everyone allowed to break ddnet except me
Avatar
incredible
Avatar
Avatar
heinrich5991
you should install an ad blocker ^^
mobile plus im lazy
18:42
like i have newpipe but the subscription transfer is so complex
Avatar
Avatar
fokkonaut
why did 17.3 break so much
What broke?
Avatar
My hack to show a predicted hook attached to a tee without showing the tee, i didnt investigate, idk why yet. also rainbowname has gotten way more un-nice, lets say it like that
Avatar
I don't think hook was touched in 17.3 so maybe an accidental breakage
Avatar
i couldnt spot anything suspicous on the first looks through the affected files
Avatar
The other one I don't even consider breakage, it's just a change
Avatar
(most like affected)
Avatar
Avatar
fokkonaut
i couldnt spot anything suspicous on the first looks through the affected files
I'd just git bisect if I were you
Avatar
Yea probably
19:03
oh, and also the new order in teams makes my spec menu page selector in the wrong order
19:03
cuz yellow is now after red and blue (for my flag spectaing)
19:03
spectating*
19:03
anyways
Avatar
Though I don't consider it breakage, there is something to be said about whether or not it's the best solution to the problem
19:04
Maybe drawing a border around teams would be better
Avatar
Avatar
Learath2
Though I don't consider it breakage, there is something to be said about whether or not it's the best solution to the problem
Ik
19:05
the hook bug annoys me tho
Avatar
Hook one sounds like unintentional breakage so if you find it let us know
Avatar
Avatar
fokkonaut
cuz yellow is now after red and blue (for my flag spectaing)
i mean you could make it another color right
19:07
search one for me, please
19:07
im color blind
Avatar
really
Avatar
how did i never know that lol
Avatar
maybe you're aswell
Avatar
nah i see them all fine
Avatar
then you would've known it
Avatar
in a perfect world you can set your own team color
Avatar
in a perfect world ddnet is an own game, not a mod of teeworlds
19:09
possibilities
Avatar
Avatar
Voxel
in a perfect world you can set your own team color
If this ever becomes a thing we definitely need borders around teams
Avatar
in a perfect world you actually worked on your server
19:10
troll
Avatar
Avatar
fokkonaut
in a perfect world ddnet is an own game, not a mod of teeworlds
true
Avatar
Avatar
cyberFighter
in a perfect world you actually worked on your server
in a perfect world i had time for that
Avatar
99cee23 Add assertion when double-freeing texture index - Robyt3 96a6845 Ensure OpenGL texture vectors are large enough - Robyt3 958676a Merge pull request #7251 from Robyt3/Graphics-Texture-Index-DoubleFree-Assertion - Jupeyy
Avatar
if i knew anything about low level coding id want to make ddrace 2.0
Avatar
do it
Avatar
ok but where do i start
Avatar
define ddrace 2.0
19:13
what is it
Avatar
Avatar
fokkonaut
My hack to show a predicted hook attached to a tee without showing the tee, i didnt investigate, idk why yet. also rainbowname has gotten way more un-nice, lets say it like that
I don't usually consider hacks to be part of backward compatibility promises
19:15
I think the better solution is to make them non-hacks
Avatar
Avatar
fokkonaut
define ddrace 2.0
current ddnet version but built from the ground up and optimized accordingly
Avatar
urfunny
Avatar
you waited
19:16
justatest
Avatar
i mean heinrich
Avatar
I'm mostly curious because something else might have been broken, not to necessarily restore the behaviour
Avatar
yay modding ddnet is so fun
19:18
protocol changes every week and breaking things which have been there since forever and also work on 0.7
19:18
xd
19:18
afk
Avatar
I want a rust with a stable ABI
19:46
so that I can have dynamic libraries
Avatar
the best part of rust would be destroyed
Avatar
is the best part "not being able to do shared libraries with rust interfaces"?
Avatar
the best part is not sharing anything
Avatar
rust can use shared libraries with C interfaces and can expose them, too, today (edited)
Avatar
yeah, bloat from the 1990 😂
Avatar
part of why rust is successful, probably
19:59
because it can interact with the rest of the world
Avatar
yes, but imagine we'd have all knowledge from today and hardware from today but no software what would we do?
Avatar
I'd think shared libraries are still the way to go
20:00
especially for stuff like TLS libraries
Avatar
true, i was 15 years in future
20:00
let me ask again in 15 years
Avatar
so that they can change without hte underlying program changing
Avatar
many people are still trying to figure out why the new team color change actually exists
22:33
it being easier to distinguish adjacent teams seems pretty moot since you're rarely ever watching 2 teams at a time, which is probably the only situation you'd ever be confused in if the team colors are similar
22:34
maybe it should be reverted, or an option added if ppl rly are having a hard time differentiating
Avatar
an option added if ppl rly are having a hard time differentiating
please no
Avatar
i don't see why not
Avatar
having an option is worse than selecting either
22:42
maintenance overhead
22:42
is there anything bad about the new colors?
Avatar
peoples' team colors are all screwed up
22:50
and some people don't like how it looks in the scoreboard
Avatar
people join a certain team number and expect a certain color
Avatar
Avatar
heinrich5991
is there anything bad about the new colors?
theres nothing BAD about the change but its just so unnessecary in my eyes
22:55
i liked how it was before more but maybe thats just me being accustomed to it
Avatar
Avatar
heinrich5991
is there anything bad about the new colors?
Yes, everyone is used to the old colors and it looked nice in scoreboard
👍 1
Avatar
Avatar
deen
Yes, everyone is used to the old colors and it looked nice in scoreboard
the first part can be said about any change
23:33
everyone is used to having a kog and a ddnet tab
23:33
the second part is a statement about the change, at least
Avatar
they're not just used to it like it's disorienting to see a different color on a certain team
23:40
some people have their binds to auto join a certain team, usually because of a color
23:40
and there are also certain teams that ppl know not to use since there are known frequent users of said team (edited)
23:41
it's silly to make the players go thru this extra work of relearning their & others' preferred teams for something that i've never seen anyone complain about
Avatar
just looking at a scoreboard with two adjacent teams, they're pretty much indistinguishable for my eyes
Avatar
i think arguments for both side is valid
Avatar
can you count that as a complaint?
23:44
ah, I'm not saying the other argument is invalid
Avatar
they did use to be hard to see, but that could be solved with a border or gap as well
23:44
(which i think wouldve been the smarter solution)
Avatar
I'm just trying to add the arguments that Ewan left out
Avatar
if it's hard for you to see then alright, that's why i think it should be an option
Avatar
no, options are bad
23:45
for code maintenance reasons
23:46
also, if people care how their color looks for others
Avatar
fundamentally speaking sure but this is a 1 line change seems p low maintenance
Avatar
then the option doesn't help you
Avatar
Avatar
heinrich5991
also, if people care how their color looks for others
sure but if given the option i'm sure 95% of users will use the team number as hue option (edited)
Avatar
even if it's not the default?
23:47
well think the golden angle colors should be opt in
23:47
*i think
23:47
if ur colorblind and have a hard time differentiating between a certain range of teams, which i can see as more realistic
Avatar
what I'm saying is that by adding the option, you're taking away the possibility to get a consistent team color for yourself
23:47
if that's what your'e into
23:47
I'm not colorblind afaik
Avatar
yea i mean you generally
Avatar
ah
Avatar
it can also be a screen issue. or just difficult eyeballs. but i can see different adjacent team colors fine
Avatar
why not add a colorblind option that toggles everything related to accessibility
Avatar
Avatar
heinrich5991
what I'm saying is that by adding the option, you're taking away the possibility to get a consistent team color for yourself
i understand what you mean but i think this isn't too important because most people won't care if someone else sees their team as a different color
23:49
i use the team i do because it looks nice on my screen
23:49
idc about other
Avatar
I mean you could just mod your client if you want the other color I guess
23:50
it'd be nice if client modding was easier
Avatar
Avatar
louis
why not add a colorblind option that toggles everything related to accessibility
^?
Avatar
we can do that, but for me, the change didn't have anything to do with accessibility, so the comment seemed unrelated to em
Avatar
although i dont have knowledge or experience abt such things in other games
23:51
not sure if ddnet would benefit
Avatar
yea and what other options are there for colorblindness?
23:52
maybe if there were a second one that could be helpful in such a scenario
23:52
but just for one then naw
Exported 217 message(s)