Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.org/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2023-09-24 00:00:00Z and 2023-09-25 00:00:00Z
06:58
43ff8ad admin: Remove sh and sql commands - murpii 281b26e github: Ignore single and triple backticks in #developer - murpii ddf71e4 guild_log: Don't log certain tickets - murpii 1d22061 misc: Remove invite command, fixes - murpii 25f0e60 moderator: renamed a couple of things, clean-up - murpii 62d0609 playerfinder: refactoring - murpii 5787275 profile: Fix Keyerror: Fun - murpii e2c641d records: fixes - murpii 4f9b5c0 skindb: Use alpha_composite instead of paste - murpii bae2989 status: Include persia in countryflags - murpii 4e2e96d mt_init: Remove debug command - murpii 7ebbd4e add all files in data/welcome_banners required by cogs/welcome.py - murpii 17ed1b2 Merge pull request #57 from murpii/update-master - def-
Avatar
fixed in 17.3? it is impossible to control the character when this window pops up
Avatar
that never was a bug in the client.. if ppl still get this, i can only imagine it's cloudflare's fault
Avatar
Avatar
Jupstar ✪
that never was a bug in the client.. if ppl still get this, i can only imagine it's cloudflare's fault
sure, but why this skin not removed?
Avatar
it was fixed months ago actually
07:14
where ever u live.. it apparently is still cached wrongly
Avatar
some CDN's cached it? Russia
Avatar
at least that is what i assume
07:14
i can't imagine another reason
Avatar
Avatar
Jupstar ✪
that never was a bug in the client.. if ppl still get this, i can only imagine it's cloudflare's fault
not a client bug, but you can't play when the window is displayed) I think it should not be displayed during the game.
Avatar
@murpi can u like, tell cloudflare to clear the caches or smth
Avatar
e93325b Increase freeview radius to kill tile border - furo321 bcb84d6 Merge pull request #7245 from furo321/freeview-radius - def-
Avatar
Avatar
GitHub
Click to see attachment 🖼️
I can't believe it was this easy to fix the entire time, I assumed this was a technical limitation and never checked (edited)
Avatar
Avatar
Matodor
not a client bug, but you can't play when the window is displayed) I think it should not be displayed during the game.
The whole point of this popup is to be annoyingly shown during the game, else the players would not know why some textures in maps and skins are missing
Avatar
Avatar
Robyt3
The whole point of this popup is to be annoyingly shown during the game, else the players would not know why some textures in maps and skins are missing
As a player it's not my problem that I get a cached version of the skin in the wrong format, why should I for example fail a map I've been playing for a long time because of this bug?
Avatar
Avatar
Matodor
As a player it's not my problem that I get a cached version of the skin in the wrong format, why should I for example fail a map I've been playing for a long time because of this bug?
The popup wasn't really designed to be shown in the middle of gameplay I guess. It being show for skins from the database is a bug (because the skins should all be compatible) and this popup is likely the only way we would have caught it.
08:35
Maybe it could be shown only when you open the menu
Avatar
check skins before inserting them into the database?)
Avatar
it sucks
Avatar
Avatar
Matodor
check skins before inserting them into the database?)
Yes, the skin in the database is and has always been correct though
Avatar
but question is wtf is happening here anyway
Avatar
As far as we understand it, either the webserver or some cache changes the image in transit
Avatar
Avatar
Robyt3
Yes, the skin in the database is and has always been correct though
So the original skin in the database is in the correct format? i mean skin first version
Avatar
Avatar
Matodor
So the original skin in the database is in the correct format? i mean skin first version
Yeah, but when the client downloads it, it sometimes ends up in a different format
Avatar
i think murpi already confirmed the original upload was wrong
08:40
back then we uploaded the skins manually
08:40
now the download bot converts them
08:40
that's why i assume it must be some cloudflare cache
08:41
the upload bot*
08:41
@SkinDB my fellow
08:44
also let's face it. we shouldnt ever have added that libpng doesn't load these skins. pnglite simply failed (it didnt crash the client) so this still would have been kinda backward compatible in a sense that it doesnt break old clients
08:44
then we could use any format we want
08:45
this whole backward compability argument is just flawed
Avatar
Do we have statistics how many players are still using versions before we added libpng (anything older than 16.3)?
Avatar
@Jupstar ✪ Can you clear the metadata from the skins before uploading them?
Avatar
deen can generate it
Avatar
Avatar
murpi
@Jupstar ✪ Can you clear the metadata from the skins before uploading them?
i really doubt they are saved at all
Avatar
AFAIK that solved the issue seen in the screenshot (edited)
Avatar
i convert it to RGBA pixels first
08:46
it doesnt remember anything from the original image
Avatar
So the meta data was also because it was an old skin that was uploaded manually?
Avatar
yes i assume so
Avatar
I removed the metadata and uploaded it via @SkinDB
Avatar
yes, it is 100% fixed
08:47
that's why i can only still imagine cloudflare caches
Avatar
(back then)
08:48
No, the current one still has all the metadata from the original
08:48
I think
08:48
Let me check
Avatar
Avatar
Robyt3
Do we have statistics how many players are still using versions before we added libpng (anything older than 16.3)?
u can ping deen, he ignores me lately 😂
Avatar
Avatar
Jupstar ✪
u can ping deen, he ignores me lately 😂
I'll ask
Avatar
Ah hm, the skin is noninterlaced properly
Avatar
What kind of agressive caching is this even? Hasn't it been like weeks since we removed the interlaced one?
Avatar
yes xd
Avatar
Q: What exactly happens if an old client tries to load an interlaced skin?
Avatar
before libpng: it fails to load after libpng: it fails to load because of our check and shows an error (edited)
Avatar
What happens when pnglite fails? Fallback to default?
Avatar
it's simply as if the skin does not exist
Avatar
So default tee
10:41
If that's the case then it might be a good idea to remove the warning now
Avatar
it was a good idea before libpng was merged
10:44
but some ppl whos name is not to be named went full ego xd
Avatar
It's controlled by a feature-flag in https://info.ddnet.org/info so we could easily disable the warning also for old clients
Avatar
Yeah, it was meant to always be removed
Avatar
Avatar
Jupstar ✪
it's simply as if the skin does not exist
I don’t think so, I have this error every time I open my client but I can use the skin / see other ppl using it (edited)
Avatar
Avatar
Gwendal
I don’t think so, I have this error every time I open my client but I can use the skin / see other ppl using it (edited)
what client version do you use?
Avatar
the last stable one I think, I tell you in a minute
Avatar
it's ok
12:30
i didnt mean you(your client) then anyway
Avatar
Avatar
Jupstar ✪
i didnt mean you(your client) then anyway
oh mb, you guys want to remove warning for versions olders than 16.3 ?
Avatar
we talked about what happens to old clients
12:38
btw this is the error in F1 if needed : 2023-09-24 14:34:23 I png: warning for file "skins/Pom Pom.png": Interlace handling should be turned on when using png_read_image
Avatar
yeah
Avatar
Hello! There are certain areas in Factorio that we haven't really had the courage to change for a long time. One of those areas has been the rail system...
12:47
massive
Avatar
According to very rough statistics, the number of active players using client versions older than 17.x seems to be smaller than 5%.
Avatar
drop(other);
Avatar
Avatar
Jupstar ✪
Can you generate a current version of this? i'd like to see how much stuff changed in ~1 year 😄
^ still waiting, would also be interesting to know
12:55
@Robyt3 do u have steam access xd
Avatar
Avatar
Jupstar ✪
@Robyt3 do u have steam access xd
no
Avatar
sad
Avatar
@Davide ger10 never seems to auto verify anymore, can we get that fixed again?
Avatar
Avatar
Learath2
@Davide ger10 never seems to auto verify anymore, can we get that fixed again?
I'll look into it
Avatar
Fixed so that sv_register_extra, sv_register_url and sv_ipv4only all call OnConfigChange when changed.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
-...
Avatar
i turned on hibernation for my pc a few days ago because it solved the issue of the computer randomly waking up from sleep in the middle of the night
14:41
but maybe i shouldn't have done that
14:41
writing then reading up to 64GB from the disk evey day for pretty much no reason doesn't seem like an awesome idea
Avatar
most annoying change award goes to the new team color sorting
15:07
breaks like 3 or 4 things at once in my mod
15:07
or makes it worse
Avatar
We're there any changes regarding Cl_ChangeInfo? It should only get sent when things in the menu update or using f1 commands. It appears to get sent as soon as I press a or d for walking. (edited)
15:24
It was not like that before. When I change the skin from the serverside the client would not want to send Cl_ChangeInfo because that hasnt been triggered until you change ur skin options or smth.
Avatar
Avatar
Ewan
writing then reading up to 64GB from the disk evey day for pretty much no reason doesn't seem like an awesome idea
It's fine for a hdd but you get shit wake up times, for an ssd an awful idea indeed
Avatar
ChillerDragon BOT 2023-09-24 16:04:42Z
@fokkonaut whats your a and d bind? Is it only walking or do you also set something like a skin?
Avatar
walking
Avatar
ChillerDragon BOT 2023-09-24 16:05:01Z
hm
16:05
thats weird
Avatar
I found a cool new vscode feature
16:05
It can keep a per cursor paste buffer
Avatar
ChillerDragon BOT 2023-09-24 16:05:39Z
u forgot a s in vcode
16:05
lerato dislexic fuk
Avatar
also the framerate of this video is actual shit wtf
Avatar
ChillerDragon BOT 2023-09-24 16:06:53Z
i dont get the feature
16:07
you mean copy paste a word in multiple lines
16:07
thats in vscode since i remember
Avatar
each line has its own copy and paste buffer, so when you paste you get a different thing in each line
Avatar
ChillerDragon BOT 2023-09-24 16:07:25Z
or do i not get the video
16:07
yea no front but isnt that the most basic vscode edit there is?
16:08
i think even sublime had that right?
Avatar
sorry, I guess I was just not as cool as you
Avatar
ChillerDragon BOT 2023-09-24 16:08:24Z
yea but no you are right
16:08
its very cool
16:08
and i use it all the time since im just a copy paste engineer anyways
Avatar
i use regex, bcs im cool
Avatar
anyway, for some reason predicted and current disagree on the hook, that's what I'm poking around in
Avatar
ChillerDragon BOT 2023-09-24 16:10:36Z
those kind of things are the reason while i often have to switch from vim to vscode to get something done fast
16:10
s/while/why/
Avatar
I bet vim has this too, it's probably just behind 5 keypresses
Avatar
ChillerDragon BOT 2023-09-24 16:11:08Z
for sure
16:11
but i cant figure out how
16:11
i have some scuffed vim extension that does parts of it
16:13
oh lerato
16:13
u know what makes me really nervouse
16:14
you using vscode darkmode but your top menu bar is white .-.
16:14
16:14
this gives me the chills
Avatar
it's a weird linux issue that I really cba to figure out :/
Avatar
ChillerDragon BOT 2023-09-24 16:16:16Z
buy gnome pro
16:16
it comes with dark mode
Avatar
There is a rather big issue with dead reckoning, we do lots of things to m_Core without reflecting it to m_ReckoningCore, do you think these are worth fixing?
Avatar
ChillerDragon BOT 2023-09-24 16:17:45Z
dont fix that before your vscode colors are fixed
16:17
obv
Avatar
mh, we really should have never added stuff to inside the CCharacterCore
Avatar
Avatar
Learath2
I bet vim has this too, it's probably just behind 5 keypresses
i'd probably use regex to replace everything
16:22
dude took me way to long
16:22
and felt super wonkey
16:22
vim is nice and all but i probably will not stop booting up electron for smooth multi cursoring
Avatar
@trml is there anyway we can delay Evolve until CNetObj_DDNetCharacter is read?
Avatar
Avatar
Learath2
@trml is there anyway we can delay Evolve until CNetObj_DDNetCharacter is read?
yes, I think one could just loop through all the characters afterwards
Avatar
Or maybe reuse the previous extended data before Evolve happens
16:36
Currently if you set cl_predict 0 and jump in start of the tutorial map you'll get a weird jolt
16:36
it seems to be because we forget the value of m_Jumps
Avatar
Avatar
fokkonaut
most annoying change award goes to the new team color sorting
agree
Avatar
Avatar
Learath2
I found a cool new vscode feature
this was originally in notepad++
16:45
i also enjoy this feature
Avatar
Dead reckoning has been broken for quite some time now due to a Reset call clearing out past state in an unintended way. (#7170) This is my proposed replacement for #7171

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [x] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [x] Considered possible null pointers and out of bound...
Avatar
ChillerDragon BOT 2023-09-24 16:59:33Z
the thing fokko discovered might be some UB i can only reproduce it in debug mode i guess that should not be the case
Avatar
Reported by Pipou on discord: "Selecting a point of a quad selects the same point of every other quad too" Only the corners of selected quads should be selected.
Avatar
Avatar
Learath2
it seems to be because we forget the value of m_Jumps
I could take a look later maybe, unless you found the solution already
Avatar
How does it update ddnet.exe?
17:26
Nowhere is this file listed
Avatar
it's so essential that it is hardcoded
Avatar
I want it to download updates from my site, how do I update ddnet.exe if I want to?
17:29
Avatar
"client": true probably means the client will update the client executable
17:30
"server": true the same
Avatar
So where does it get ddnet.exe from?
Avatar
It seems to be hard-coded in src/engine/client/updater.cpp line 35
17:34
static const char *GetUpdaterUrl(char *pBuf, int BufSize, const char *pFile) { str_format(pBuf, BufSize, "https://update.ddnet.org/%s", pFile); return pBuf; }
Avatar
str_format(pBuf, BufSize, "https://update.ddnet.org/%s", pFile);
Avatar
Replace this with your own server URL
Avatar
Yes, it downloads that file
Avatar
It only downloads regular files, but not ddnet.exe
Avatar
The name also contains the platform
17:37
For binaries
17:37
Look in updater.h
Avatar
Avatar
Robyt3
The name also contains the platform
aaaaaaa
Avatar
Or just add dbg_msg and run it
17:38
To see the actual URL that is downloaded
Avatar
thxxxx
17:42
win
17:42
I got it
Avatar
Avatar
trml
I could take a look later maybe, unless you found the solution already
I fed the prev snap extended data into evolve and that kinda fixes it but it's technically wrong
Avatar

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...
Avatar
Avatar
GitHub
Click to see attachment 🖼️
what's happening here and what exactly fixes it?
Avatar
To Foreground and Background respectively.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck...
Avatar
4476dfa Configs used in OnConfigChange should trigger Conchain - furo321 9933c13 Merge pull request #7246 from furo321/register_conchain - Robyt3
Avatar
2a17d1b Rename variables containing ForeGround and BackGround - Robyt3 bca21dc Merge pull request #7250 from Robyt3/Cleanup-Background-Foreground-Names - def-
19:03
ecaded8 Fix dead reckoning - Learath2 003d96e Add IConfigManager getter to CGameClient and CComponent - Robyt3 708b263 Merge pull request #7249 from Robyt3/Gameclient-ConfigManager-Getter - def- 60046c7 Merge pull request #7247 from Learath2/pr_reckon - def-
Avatar
Simplify the handling of free texture indices by using -1 only for indices which are currently in use, whereas the size of the vector is now used to indicate the last free index. Otherwise the assertions incorrectly detect the last texture index always being in use because -1 was used for both states. Ensure OpenGL texture index vectors are large enough, in the unlikely case that the wanted texture slot is larger than twice the size of the original texture vector.

Checklist

  • ...
Avatar
friend opened my client
21:08
eng vers
21:20
480458d Add new settings/commands for wiki - Zwelf 9b95f1c Merge pull request #49 from Zwelf/pr-wiki2 - def-
Avatar
Avatar
Learath2
@Davide ger10 never seems to auto verify anymore, can we get that fixed again?
Should be fixed, if you still have issues, please send me a traffic capture (pcap) while you try to connect to the server
Avatar
2ff6d97 Update settings & commands - def-
21:22
That should hopefully be all missing descriptions, added for demo_slice_start, demo_slice_end, gplay, mute and mutes

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect ...
Avatar
Avatar
Sedonya
eng vers
Avatar
@Robyt3 owo
Avatar
Avatar
Sedonya
Click to see attachment 🖼️
Do the files in update exist?
Avatar
only folders
21:54
and update.json
21:56
All folders are empty
Avatar
25101d2 Add missing descriptions of commands. - furo321 6b8a376 Merge pull request #7252 from furo321/missing-cmd-desc - Robyt3
Exported 214 message(s)