is fix-style.py supposed to wrap long lines cause i have a 195 character long if statement

um. ouch

00:24

anyway i feel like it's not

00:24

i've run into a few situations where i wish the clang format style had that specified

at least its not the longest line in the file

if your branching is dependent on many factors you can keep a validity indicator around (e.g. bool proceed) and turn it on/off as the factors are determined

or return incrementally

00:39

u know

00:39

restructuring stuff

theres another similar long if statement below it so i'm just sticking to that style

00:45

i had to add another localization string, i read the readme in scripts/languages i dont think im supposed to do anything?

I believe strings requested by Localize() calls are automatically added to the source string index

it does if i do ./update_all.py but then it adds a bunch of other strings

you can ignore localizations, they'll be added in the next release

ok i'll just pr this little change then and see if its something you guys would want

ArijanJ

[ddnet/ddnet] Pull request opened: #6991 Add hook sound toggle

Adds a checkbox below 'Enable gun sound' for the hook sound, defaults to on, just like the others. It's frustrating having to mute all game sounds just so you don't hear the hook; sometimes hearing the mouse clicks instead are a more responsive representation of the hook in tight gores parts. !image

Checklist

[X] Tested the change ingame
[X] Provided screenshots if it is a visual ...

i am splitting the images and tweaking visuals along the way

Technical details: 32x32 grid size still applies I fixed the cutting off of the ninja muzzles, and I redid the hook positioning, so that it ACTUALLY looks like it loops

03:33

old chain top new chain bottom its a very small change no one will notice but i think it looks better, don't you think?

yea

03:40

will you provide a gameskin converter tool

03:41

wonder if it should be python or if it should be a static exe in the game dir like dilate is, similar use case makes me think the latter though it would be easier with python bcs magick

yeah definitely, but idk how to do that yet

again i want to sort them into its most logical setup

05:41

because game.png is so disorganized LOL

05:45

gonna try cleaning this all up soon because like

05:45

is it like this IN GAME? if it is then it should be fixed

when doing that, we should provide a tool to split old game.pngs automatically. iirc minecraft does the same

Voxel

gonna try cleaning this all up soon because like

grasjj

Marmare314

[ddnet/ddnet] Pull request opened: #6992 Switch order in which envelope points are selected

When multiple envelope points could be selected, switch the order such that the one that is visible is selected first. The mouse is hovering the second point in both pictures. Before: !screenshot_2023-08-10_08-20-30 After: !screenshot_2023-08-10_08-20-01

Checklist

[x] Tested the change ingame
[x] Pr...

Marmare314

[ddnet/ddnet] Pull request opened: #6993 Ignore hidden channels when selecting envelopes

When two envelope points overlap it can happen that the hidden one will be marked as hot. Then neither can be selected. Fixes #6989.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no phys...

Marmare314

[ddnet/ddnet] Pull request opened: #6994 Disallow adding overlapping envelope points

Also now round is used to convert the mouse position to fixed precision time which places the added point closer to the mouse. Fixes #6986.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed ...

Would it ever be possible that there's a setting that when you enter a by player specified teleporter you get killed? Would make speedrunning solo and race more comfortable

I wonder if the client knows the number of a teleport.

cauldron

I wonder if the client knows the number of a teleport.

im pretty sure they in some way do because of this feature in the beta version

[Client] Add goto_switch and goto_tele commands [ChillerDragon]

So you want this for training or for runs? Because you could run your own server in lan tab and replace the tele with kill tiles a the desired spot, but I guess that‘s too much work troll

cauldron

I wonder if the client knows the number of a teleport.

of course

it must

It could just send the tees coordinate, and the server tells what is there

10:11

Theoreticalallyally

10:11

A-lly

10:16

Isn‘t it actually that the client searches for the position of tele/switch in the goto function?

10:18

https://github.com/ddnet/ddnet/pull/6887#discussion_r1289903593

Add goto_switch and goto_tele by ChillerDragon · Pull Reque...

Set the clients view to a given teleporter or switch number TRIGGER WARNING The use of the keyword goto may offend some developers UPDATE: This code is clean and can be red without caution. Wat it ...

client has the map so it knows the layers

But in a way it has to first search for it?

Steinchen

Would it ever be possible that there's a setting that when you enter a by player specified teleporter you get killed? Would make speedrunning solo and race more comfortable

Anyway would be interesting to have this feature. I am thinking it further. You could have „bind“ tiles where you can define your own bind if you touch the tile. Not just kill, but also switch to hammer… jump or anything.

my .org domain costs 24€ on gandi but 12€ on google

10:35

i guess its time to change

cauldron

So you want this for training or for runs? Because you could run your own server in lan tab and replace the tele with kill tiles a the desired spot, but I guess that‘s too much work troll

What does it help me with if i want that feature so I don't have to manually kill x times on official servers? Am I gonna speedrun on lan server or what

Steinchen

What does it help me with if i want that feature so I don't have to manually kill x times on official servers? Am I gonna speedrun on lan server or what

Ok. I like your request, find it interesting and want to invest more time in it.

Steinchen

Would it ever be possible that there's a setting that when you enter a by player specified teleporter you get killed? Would make speedrunning solo and race more comfortable

its oddly specific, the problem with having million of features like this is them breaking in the future

11:11

so one has to consider how much people will use such features

11:11

and if they are worth

That‘s a design specific question. I think such a feature could bloat the client, if you have like 100 such features, but if you could make it modular somehow you could keep it tiny. It would be sad if features would not be done only because they would bloat the client/server. In my opinion „feature overhead“ is just another problem that can be solved for the good of the whole project. (edited)

i guess

11:21

ddnet code is not that modular tho xd

Voxel

Technical details: 32x32 grid size still applies I fixed the cutting off of the ninja muzzles, and I redid the hook positioning, so that it ACTUALLY looks like it loops

Hi, are you doing the tweaks in vector? I mean: would we have to recreate the images again (see https://github.com/ddnet/ddnet-data-svg/pull/32/files) to have them in HD quality? Higher textures resolution becomes even more important now when the game has video recorder (renderer) and zoom.

(edited)

Add game.svg by mind & Voxel by Jupeyy · Pull Request #32 · ddnet/d...

i'll leave this draft until the new shield icons on the ddnet repo's game.png is decided

cauldron

That‘s a design specific question. I think such a feature could bloat the client, if you have like 100 such features, but if you could make it modular somehow you could keep it tiny. It would be sad if features would not be done only because they would bloat the client/server. In my opinion „feature overhead“ is just another problem that can be solved for the good of the whole project. (edited)

Is also the question if such features are desirable.. if u have 100 features like that it's kind of hidden features to most ppl.. ^^

11:31

Bloat can also not happen code wise but feature wise... Ppl will lose the overview

@Jupstar ✪ prepare tomorrow rust class question

Xd

It's important

How do you guys understand the source code at all? I feel so dumb when i look at this lol

u simply need to learn more c++

Ryozuki

u simply need to learn more c++

That would probably help

Jupstar ✪

Bloat can also not happen code wise but feature wise... Ppl will lose the overview

That‘s what I meant. Feature bloat not the code. I played this other game that‘s still actively played and developed from 90s. Oldschool runescape. They have a very strict poll system where the community decided via votes/polls what features they want. It‘s really unique.

It seems like every function i look at just calls another function that is in another file

https://secure.runescape.com/m=poll/oldschool/

If you're a RuneScape veteran hungry for nostalgia, get stuck right in to Old School RuneScape. Sign up for membership and re-live the adventure.

11:39

They only implement features with >70% pro votes.

cauldron

https://secure.runescape.com/m=poll/oldschool/

But do also sometimes remove features

pilonpl

How do you guys understand the source code at all? I feel so dumb when i look at this lol

Besides the design is maybe not the best.. if the function name says renderhook.. I guess it's kinda clear what it tries to do xdd

DestroyHumans()

executeC0d3()

Jupstar ✪

Bloat can also not happen code wise but feature wise... Ppl will lose the overview

just make a src/bloat folder kek

Jupstar ✪

But do also sometimes remove features

Which is good. When it turns out bad, throw it out. Or what‘s your point?

Jupstar ✪

Besides the design is maybe not the best.. if the function name says renderhook.. I guess it's kinda clear what it tries to do xdd

10 indentation levels also doesn't seem right