1
[*] launch server
[*] launch client 1
Terminated
Terminated
[*] shutting down server
[*] shutting down client1
[*] shutting down client2
Error: Process completed with exit code 143.
Already made some more changes so valgrind/san log files are also printed to the CI, but it seems like the script terminates even sooner.
Currently trying to get this branch to work: https://github.com/Robyt3/ddnet/tree/Graphics-Buffer-Refactoring
@Jupstar ✪ Somehow integration test with valgrind fails without a useful error message after adding more assertions for graphics buffer allocation, so maybe we actually found some bug.CGraphics_Threaded::AddCmd and CGraphics_Threaded::AllocCommandBufferData the command buffer is cleared so it should always be possible to allocated memory successfully on the second try. Therefore assertions are added and the return values and inconsistent checks of the functions are removed."
==7110== Warning: set address range perms: large range [0x59c87040, 0x159c8703f) (undefined)valgrind --tool=memcheck --gen-suppressions=all --suppressions=../memcheck.supp --track-origins=yes
&str instead of &String is also good. using '\n' instead of "\n" is also good in replace. I personally like for _ in container.iter() → for _ in &container. removing clone() is goodconst fn)ToString is always wrong, no?Display insteadToString for freeToString, but often DisplayString.: i32) compared to vscode
[*] launch server
[*] launch client 1
Terminated
Terminated
[*] shutting down server
[*] shutting down client1
[*] shutting down client2
Error: Process completed with exit code 143.
Already made some more changes so valgrind/san log files are also printed to the CI, but it seems like the script terminates even sooner.
Currently trying to get this branch to work: https://github.com/Robyt3/ddnet/tree/Graphics-Buffer-Refactoring
@Jupstar ✪ Somehow integration test with valgrind fails without a useful error message after adding more assertions for graphics buffer allocation, so maybe we actually found some bug.
ZoomMouseTarget) are quite different and need a lot of members of CEditor (edited)size_t the right type for the width of a texture? why is it a different type depending on the cpu architecture? maybe uint32_t would fit better?ZoomMouseTarget) are quite different and need a lot of members of CEditor (edited)struct that contains all the smooth zoom variables and logic for one axis and then use two objects of those structs for the X and Y axis. Your struct can have a pointer to CEditor so it can use the shared editor functions as well (edited)size_t makes sensesize_t for e.g. SubOffsetX but I guess it's okayunsigned makes sense to meauto?size_t change or the other changes causing Valgrind to crash?
size_t change or the other changes causing Valgrind to crash? 
size_t change causes the crashsize_t commit it doesn't work
1size_t change according to the CI 
image_null = Image("null", "")
image_particles = Image("particles", "particles.png")
image_game = Image("game", "game.png")
...image_null that has an empty filenameset_tee = SpriteSet("tee", image_null, 8, 4)
unironically
and ✔ are the only emotes i use unironically
Twitter • 2023-07-20 03:51:31Z 
Twitter • 2023-07-20 12:51:50Z 
Twitter • 2023-07-20 09:00:03Z 
21bbc8b Improve filename length check for images - Robyt3
b432feb Add assertion in CGraphics_Threaded::LoadTextureRawSub - Robyt3
3134d42 Extract CGraphics_Threaded::FreeTextureIndex function - Robyt3
a96242b Extract CGraphics_Threaded::FindFreeTextureIndex function - Robyt3
78e2306 Add assertions for graphics command buffer allocation - Robyt3
58927cd Use size_t more in engine graphics - Robyt3
5c00dd3 Merge pull request #6899 from Robyt3/Graphics-Buffer-Refactoring - def-
