Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2023-07-13 00:00:00Z and 2023-07-14 00:00:00Z
Avatar
Learath2 2023-07-13 00:02:18Z
@heinrich5991 apparently it is a real thing, took someone in #C to tell me but 6.9, the syntax for a translation-unit is: translation-unit: external-declaration translation-unit external-declaration
Avatar
GitHub BOT 2023-07-13 04:38:13Z
Author icon
ddnet-maps
[ddnet-maps:master] 1 new commit
c354243 A powerless - ddnet-maps
Avatar
GitHub BOT 2023-07-13 07:28:24Z
Author icon
Zwelf
[ddnet/ddnet-web] Pull request opened: #261 Update libtw2 doc
https://github.com/heinrich5991/libtw2/commit/f18969c11be892047ea0827ac8c3904e332b8e78 https://github.com/heinrich5991/libtw2/commit/c4e045d43f1af3636c3e0a7d95d98ab81c61c389
07:31
Author icon
heinrich5991
[ddnet/ddnet-web] Pull request closed: #261 Update libtw2 doc
07:31
Author icon
heinrich5991
[ddnet-web:master] 1 new commit
2492c27 Update libtw2 doc - Zwelf
Avatar
Avatar
Learath2
@heinrich5991 apparently it is a real thing, took someone in #C to tell me but 6.9, the syntax for a translation-unit is: translation-unit: external-declaration translation-unit external-declaration
heinrich5991 2023-07-13 07:33:39Z
ah. annoying
Avatar
ChillerDragon BOT 2023-07-13 07:50:55Z
@heinrich5991 poggers new docs
Avatar
heinrich5991 2023-07-13 07:54:58Z
ChillerDragon: I described the ddnet token protocol and also updated the wireshark-dissector to finally have support for it
Avatar
ChillerDragon BOT 2023-07-13 07:56:07Z
yes im currently reading through it i really appreciate it
Avatar
Ryozuki 2023-07-13 07:57:12Z
nice docs
Avatar
heinrich5991 2023-07-13 07:59:34Z
thanks
Avatar
ChillerDragon BOT 2023-07-13 08:07:33Z
Embedded image
08:07
whats new?
Avatar
heinrich5991 2023-07-13 08:09:45Z
have you recompiled it?
Avatar
ChillerDragon BOT 2023-07-13 08:09:51Z
@heinrich5991 i deleted my plugins folder and recompiled master i was expecting to see a TKEN note here
Avatar
heinrich5991 2023-07-13 08:09:54Z
it should show the token and the token magic
Avatar
ChillerDragon BOT 2023-07-13 08:09:59Z
did you test it?
Avatar
heinrich5991 2023-07-13 08:10:01Z
yes
Avatar
ChillerDragon BOT 2023-07-13 08:10:04Z
woah
08:10
how does it not show for me
Avatar
heinrich5991 2023-07-13 08:10:24Z
send me the pcap pls
08:10
have you fetched and merged master?
Avatar
ChillerDragon BOT 2023-07-13 08:10:54Z
i compiled master
08:10
and fetched yes
Avatar
heinrich5991 2023-07-13 08:11:01Z
and merged?
Avatar
ChillerDragon BOT 2023-07-13 08:11:11Z
ou shit
08:11
im outdated :D
08:11
forgot to pull -.-
08:11
omg sori
08:12
Embedded image
08:12
pog
Avatar
heinrich5991 2023-07-13 08:12:50Z
\o/
Avatar
ChillerDragon BOT 2023-07-13 08:13:04Z
ok so when docs on the uuid extension thingies?
Avatar
heinrich5991 2023-07-13 08:13:17Z
these are quite easy :p
Avatar
ChillerDragon BOT 2023-07-13 08:13:21Z
-.-
Avatar
heinrich5991 2023-07-13 08:13:28Z
message ID 0, put the UUID as bytes after it
08:13
done
Avatar
ChillerDragon BOT 2023-07-13 08:13:33Z
ok nice
Avatar
heinrich5991 2023-07-13 08:13:39Z
here's your doc :p
Avatar
ChillerDragon BOT 2023-07-13 08:13:46Z
thank
Avatar
heinrich5991 2023-07-13 08:16:08Z
(note you still need to set system/game flag in the message ID. you can also observe it in the dissector btw)
Avatar
ChillerDragon BOT 2023-07-13 08:20:57Z
ok yea no idea when i get to that anyways i will first look into my snap crc being wrong again :c
Avatar
GitHub BOT 2023-07-13 08:43:11Z
Author icon
heinrich5991
[ddnet/ddnet] Issue opened: #6839 cl_refresh_rate causes the network to ignore any new packets for some time
https://github.com/ddnet/ddnet/blob/573d9cabbe8ed07b298be6ffb330fe30885cc3e9/src/engine/client/client.cpp#L3348-L3354 Introduced in #6781. See also https://github.com/ddnet/ddnet/pull/6781#issuecomment-1612603071 and below. The correct way to do it would be to process network packets when they come in. Currently, the net_socket_read_wait loop is equivalent to a sleep.
Avatar
heinrich5991 2023-07-13 08:51:52Z
ChillerDragon: what are you doing again?
Avatar
Ewan 2023-07-13 09:09:13Z
botting
Avatar
ChillerDragon BOT 2023-07-13 09:30:13Z
no proof
09:30
@heinrich5991 ddnet 0.7 support breaks on crc as soon as the server starts splitting up the snap into multiple messages
09:30
client support*
Avatar
heinrich5991 2023-07-13 09:31:34Z
your PR?
Avatar
ChillerDragon BOT 2023-07-13 09:31:36Z
yes
Avatar
heinrich5991 2023-07-13 09:32:01Z
have you verified that you receive the same bytes in total?
09:32
e.g. check length and sha256sum of the complete bytes
Avatar
ChillerDragon BOT 2023-07-13 09:32:42Z
im still on a side quest to get a proper local testing setup
09:33
flooding my localhost with tees
09:33
but sounds like a good debug start :)
Avatar
GitHub BOT 2023-07-13 09:43:25Z
Author icon
murpii
[ddnet-web:master] 1 new commit
bdcc46d Knuski stepped down - murpii
SOBS 1
Avatar
ChillerDragon BOT 2023-07-13 10:10:52Z
is uuid considered a alternative to system and game?
10:11
oh no u just said
10:11
a uuid can be system or game i see
Avatar
heinrich5991 2023-07-13 10:12:14Z
what do you need it for? ^^
10:12
I wonder in what kind of project this is needed
Avatar
ChillerDragon BOT 2023-07-13 10:13:24Z
bot
10:13
wops wrong chat
10:13
xd
10:13
Im now tinkering with my python network parser
10:14
I want it to not crash for now when it receives a uuid
Avatar
heinrich5991 2023-07-13 10:14:22Z
why does it crash on unknown packets?
Avatar
ChillerDragon BOT 2023-07-13 10:14:28Z
because i made it do so
10:14
to ensure i can parse all properly
10:15
haven't decided what i want to do when it gets more mature
10:15
if i force users to call try catch or return some error object or silently ignore
Avatar
heinrich5991 2023-07-13 10:15:48Z
you can have that as a parameter
Avatar
ChillerDragon BOT 2023-07-13 10:15:57Z
how to handle errors?
Avatar
heinrich5991 2023-07-13 10:15:59Z
in tests, you might want to have the error
10:16
if it talks to other impls over the network, you likely want to ignore messages that you can't parse
Avatar
ChillerDragon BOT 2023-07-13 10:16:39Z
https://peps.python.org/pep-0020/
PEP 20 – The Zen of Python | peps.python.org
Python Enhancement Proposals (PEPs)
10:17
Errors should never pass silently.
10:17
Unless explicitly silenced.
Avatar
heinrich5991 2023-07-13 10:17:31Z
receiving an unknown message is not an error in the tw protocol
10:17
you're supposed to ignore the message
10:17
it's like an unknown http header
Avatar
ChillerDragon BOT 2023-07-13 10:18:50Z
i see
10:20
quoted you on that :p
10:20
https://gitlab.com/teeworlds-network/twnet_parser/-/issues/2
Should this lib raise errors or silently ignore issues? (#2) · Issu...
What to do with malformed data? Is the lib user supposed to wrap stuff in try catch? Should we return error objects? Continue trying to parse if a...
Thumbnail
10:23
A regular client for sure should ignore it. I was just wondering because I want to offer a flexible low level network lib not a client.
10:24
i could see low level http parsers used by high level http clients also handling unknown headers but idk
Avatar
heinrich5991 2023-07-13 10:24:45Z
but they're never going to error on an unknown one
10:25
almost all http servers also ignore unknown query parameters
Avatar
ChillerDragon BOT 2023-07-13 10:26:26Z
Yea okay
10:27
Im just thinking I might want to use that lib to also investigate unknown traffic like an dissector and would want to see the errors
Avatar
heinrich5991 2023-07-13 10:27:28Z
yea, makes sense
Avatar
ChillerDragon BOT 2023-07-13 10:27:37Z
for example the !p command of the irc bot when i dump some packet dump in here to see if its ddos or something
10:27
i dont want to paste in 512 bytes and then get back its a valid 0.7 packet with two messages
Avatar
heinrich5991 2023-07-13 10:27:59Z
makes sense
10:28
so two different modes?
Avatar
ChillerDragon BOT 2023-07-13 10:28:45Z
or force users to use try catch to avoid complexity on my side
10:29
but yea a option that by default does not crash would be nicer
10:29
only power users want to crash anyways
Avatar
breton BOT 2023-07-13 11:09:54Z
hi folks. Could you please help us identify the person who spams across ddnet inviting people to join an infclass server? We do not condone this kind of stuff and would like to ban them on our side too.
Avatar
ChillerDragon BOT 2023-07-13 11:35:02Z
didnt see any
11:35
breton: what servers do you host?
11:35
or why do you care
Avatar
breton BOT 2023-07-13 11:40:19Z
ChillerDragon: i care about infclass and moderate the server @ 195.123.214.91
Avatar
ChillerDragon BOT 2023-07-13 11:41:36Z
so they do ads for your competition on official ddnet and your server?
Avatar
breton BOT 2023-07-13 11:43:35Z
they do spam for the server that i moderate
Avatar
ChillerDragon BOT 2023-07-13 11:43:46Z
which makes you look shady
11:43
i see
11:44
just take the free ad :D
Avatar
breton BOT 2023-07-13 11:46:57Z
i would rather not
Avatar
Ryozuki 2023-07-13 11:49:59Z
i noticed i didnt have valgrind installed on my gentoo
11:50
i installed it and turned on glibc debug symbols
Avatar
ChillerDragon BOT 2023-07-13 11:56:54Z
ou i just realized the crc is shared accross all snap parts
11:59
Embedded image
11:59
and once again the dissector carried my ass
Avatar
ChillerDragon BOT 2023-07-13 12:25:05Z
e wot
Avatar
TsFreddie 2023-07-13 12:26:14Z
it's too hot
12:26
35c right now
12:27
i'm soaked in sweat
Avatar
ChillerDragon BOT 2023-07-13 12:31:01Z
ye same here
12:31
but pog progress
12:31
Embedded image
Avatar
TsFreddie 2023-07-13 12:31:42Z
aren't german houses very good at staying confortable
Avatar
ChillerDragon BOT 2023-07-13 12:32:46Z
doesnt feel like munich was prepared for the heat
12:32
we dont do ACs here
Avatar
salmonzik BOT 2023-07-13 12:33:06Z
what are you guys doing? (<@749222324980416602_=43hiller=44ragon>)
ChillerDragon#0000
https://zillyhuhn.com/cs/.1689251447.png
2023-07-13 12:31:07Z
Avatar
TsFreddie 2023-07-13 12:33:08Z
👀
12:35
guangzhou doesn't have heating. it's very cold for me to live here in the winter even tho my hometown have much colder winter.
Avatar
ChillerDragon BOT 2023-07-13 12:35:39Z
@salmonzik ddnet 0.7 client
12:36
who needs heating when u got a blanket
Avatar
TsFreddie 2023-07-13 12:36:49Z
em
12:36
me
Avatar
Ryozuki 2023-07-13 12:36:56Z
funny thing
12:37
llvm crashes with segfault giving it valid mlir ir
12:37
c++ things you know
Avatar
salmonzik BOT 2023-07-13 12:39:18Z
Interesting, are planned making any drastic changes to gameplay or additions in just terms of code? (<@749222324980416602_=43hiller=44ragon>)
ChillerDragon#0000
@salmonzik ddnet 0.7 client
2023-07-13 12:35:40Z
Avatar
ChillerDragon BOT 2023-07-13 12:40:35Z
me? no
12:40
i just wanna allow the ddnet client to join also 0.7 servers
Avatar
Ryozuki 2023-07-13 12:44:59Z
@Jupstar ✪ did u prepare tomorrow friday rust talk
12:45
@Learath2 please become a c++ llvm engineer and fix their segfaults
Avatar
Learath2 2023-07-13 12:46:27Z
Segfaults are a part of the joy of using C++. I wouldn't dream of depriving you of them
Avatar
Ryozuki 2023-07-13 12:46:40Z
troll
12:47
c++ #0 mlir::detail::StorageUserBase<mlir::LLVM::LLVMVoidType, mlir::Type, mlir::TypeStorage, mlir::detail::TypeUniquer>::classof<mlir::Type> (val=...) at /home/edgar/data/llvm-project-16.0.6.src/mlir/include/mlir/IR/StorageUniquerSupport.h:112 #1 0x0000555555deecda in llvm::CastInfo<mlir::LLVM::LLVMVoidType, mlir::Type const, void>::isPossible (ty=...) at /home/edgar/data/llvm-project-16.0.6.src/mlir/include/mlir/IR/Types.h:350 #2 llvm::DefaultDoCastIfPossible<mlir::LLVM::LLVMVoidType, mlir::Type const, llvm::CastInfo<mlir::LLVM::LLVMVoidType, mlir::Type const, void> >::doCastIfPossible (f=...) at /home/edgar/data/llvm-project-16.0.6.src/llvm/include/llvm/Support/Casting.h:312 #3 llvm::dyn_cast<mlir::LLVM::LLVMVoidType, mlir::Type> (Val=...) at /home/edgar/data/llvm-project-16.0.6.src/llvm/include/llvm/Support/Casting.h:652 #4 mlir::Type::dyn_cast<mlir::LLVM::LLVMVoidType> (this=<optimized out>) at /home/edgar/data/llvm-project-16.0.6.src/mlir/include/mlir/IR/Types.h:271 #5 llvm::detail::TypeSwitchBase<llvm::TypeSwitch<mlir::Type, llvm::Type*>, mlir::Type>::castValue<mlir::LLVM::LLVMVoidType, mlir::Type const&> (value=...) at /home/edgar/data/llvm-project-16.0.6.src/llvm/include/llvm/ADT/TypeSwitch.h:77 #6 llvm::TypeSwitch<mlir::Type, llvm::Type*>::Case<mlir::LLVM::LLVMVoidType, mlir::LLVM::detail::TypeToLLVMIRTranslatorImpl::translateType(mlir::Type)::{lambda(mlir::LLVM::LLVMVoidType)#1}>(mlir::LLVM::detail::TypeToLLVMIRTranslatorImpl::translateType(mlir::Type)::{lambda(mlir::LLVM::LLVMVoidType)#1}&&) (this=<optimized out>, caseFn=...) at /home/edgar/data/llvm-project-16.0.6.src/llvm/include/llvm/ADT/TypeSwitch.h:121 #7 llvm::detail::TypeSwitchBase<llvm::TypeSwitch<mlir::Type, llvm::Type*>, mlir::Type>::Case<mlir::LLVM::detail::TypeToLLVMIRTranslatorImpl::translateType(mlir::Type)::{lambda(mlir::LLVM::LLVMVoidType)#1}>(mlir::LLVM::detail::TypeToLLVMIRTranslatorImpl::translateType(mlir::Type)::{lambda(mlir::LLVM::LLVMVoidType)#1}&&) (this=<optimized out>, caseFn=...) at /home/edgar/data/llvm-project-16.0.6.src/llvm/include/llvm/ADT/TypeSwitch.h:60 #8 mlir::LLVM::detail::TypeToLLVMIRTranslatorImpl::translateType (this=0x555556399d40, type=...) at /home/edgar/data/llvm-project-16.0.6.src/mlir/lib/Target/LLVMIR/TypeToLLVM.cpp:39 #9 0x0000555555e219ac in convertOperationImpl (opInst=..., builder=..., moduleTranslation=...) at tools/mlir/include/mlir/Dialect/LLVMIR/LLVMConversions.inc:144 #10 0x0000555555cbc1c7 in mlir::LLVM::ModuleTranslation::convertOperation (this=this@entry=0x7fffffffcf90, op=..., builder=...) at /home/edgar/data/llvm-project-16.0.6.src/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:567 #11 0x0000555555cbc817 in mlir::LLVM::ModuleTranslation::convertBlock (this=this@entry=0x7fffffffcf90, bb=..., ignoreArguments=<optimized out>, builder=...) at /home/edgar/data/llvm-project-16.0.6.src/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:613 #12 0x0000555555cbdc89 in mlir::LLVM::ModuleTranslation::convertOneFunction (this=this@entry=0x7fffffffcf90, func=...) at /home/edgar/data/llvm-project-16.0.6.src/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:858
12:47
yes ima enjoy this
Avatar
Learath2 2023-07-13 12:47:49Z
Looks excellent
Avatar
Ryozuki 2023-07-13 12:47:54Z
c++ ish
Avatar
Learath2 2023-07-13 12:48:12Z
You should go back to C, much prettier backtraces 😄
Avatar
Ryozuki 2023-07-13 12:48:21Z
the thing is im just using their tool
12:48
mlir-translate
12:48
with a given .mlir file
12:48
im not coding at all
12:48
XD
12:49
its a null pointer deref
Avatar
ChillerDragon BOT 2023-07-13 12:49:31Z
anyone else getting SDL leak sanitizer alerts?
12:49
SDL_realloc_REAL
Avatar
Ryozuki 2023-07-13 12:50:11Z
(gdb) i r rdi rdi 0x0 0
12:50
(gdb) disassemble 0x0000555555deecda, +16 Dump of assembler code from 0x555555deecda to 0x555555deecea: 0x0000555555deecda <_ZN4mlir4LLVM6detail26TypeToLLVMIRTranslatorImpl13translateTypeENS_4TypeE+202>: test %al,%al 0x0000555555deecdc <_ZN4mlir4LLVM6detail26TypeToLLVMIRTranslatorImpl13translateTypeENS_4TypeE+204>: je 0x555555deecf0 <_ZN4mlir4LLVM6detail26TypeToLLVMIRTranslatorImpl13translateTypeENS_4TypeE+224> 0x0000555555deecde <_ZN4mlir4LLVM6detail26TypeToLLVMIRTranslatorImpl13translateTypeENS_4TypeE+206>: test %rbx,%rbx 0x0000555555deece1 <_ZN4mlir4LLVM6detail26TypeToLLVMIRTranslatorImpl13translateTypeENS_4TypeE+209>: je 0x555555deecf0 <_ZN4mlir4LLVM6detail26TypeToLLVMIRTranslatorImpl13translateTypeENS_4TypeE+224> 0x0000555555deece3 <_ZN4mlir4LLVM6detail26TypeToLLVMIRTranslatorImpl13translateTypeENS_4TypeE+211>: mov (%r14),%rdi 0x0000555555deece6 <_ZN4mlir4LLVM6detail26TypeToLLVMIRTranslatorImpl13translateTypeENS_4TypeE+214>: call 0x55555623fa00 <_ZN4llvm4Type9getVoidTyERNS_11LLVMContextE> End of assembler dump.
12:50
😬
Avatar
ChillerDragon BOT 2023-07-13 12:51:08Z
hax
Avatar
Avatar
Ryozuki
@Jupstar ✪ did u prepare tomorrow friday rust talk
Jupstar ✪ 2023-07-13 13:02:13Z
I'll think about a topic later xd
Avatar
GitHub BOT 2023-07-13 13:16:39Z
Author icon
Robyt3
[ddnet/ddnet] Pull request opened: #6840 Fix enter not working in server browser when no server selected, fix enter not working in editor save dialog when no map selected

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresss...
Avatar
Avatar
TsFreddie
aren't german houses very good at staying confortable
deen 2023-07-13 13:17:57Z
If it only gets hot for a day and cools down at night they are great since lots of heavy bricks, and they take a while to get warm. But once you have tropical nights it becomes impossible to cool them down again. The houses are built for "there is only 1 week over 30°C per year, so we can survive it being unbearable for a bit". But this 1 week turned into 3 weeks already.
Avatar
ChillerDragon BOT 2023-07-13 13:24:56Z
ye my flat was still 30 degree at 2 in the night the last few days unless it starts to rain
Avatar
Jupstar ✪ 2023-07-13 13:25:48Z
Now that deen is dad, he has to take climate change double as serious 😎
Avatar
ChillerDragon BOT 2023-07-13 13:25:54Z
haha
Avatar
Ryozuki 2023-07-13 13:32:03Z
is he dad already
13:32
i dont live in a house but apartment
13:32
and barcelona has stupidly high humidity
13:32
u just sweat shitloads
13:33
during morning which is when humidy reaches its high it can go to 95$
13:33
95%
Avatar
Avatar
deen
in 2 months I will
Jupstar ✪ 2023-07-13 13:42:20Z
Well the day after tomorrow its 2 months since the msg @Ryozuki So it happens very very soon
13:42
Ok in 5 days lol
Avatar
GitHub BOT 2023-07-13 13:48:56Z
Author icon
bors[bot]
[ddnet:master] 3 new commits
8fad911 Fix enter not working in server browser when no server selected - Robyt3 71ed093 Fix enter not working in editor save dialog when no map selected - Robyt3 8d9843d Merge #6840 - bors[bot]
13:48
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6840 Fix enter not working in server browser when no server selected, fix enter not working in editor save dialog when no map selected
Avatar
Kaffeine 2023-07-13 13:49:26Z
Hi devs, what do you think about "shadow" mute/spam? I mean the mute/ban without a notification to the target. I see you want to be clear for the players but let's be fair — we're not capable to deal with all spammers. They use "unfair" techniques and we have to spend a lot of energy fighting with them. For example, I suggest to add text-based shadow mute. This way we can add an advertising message to an auto-mute list and calm down the spammers. It is much easier for them to detect 'clear' bans and 'mutes' and rotate IPs / join another servers. On the other hand, it is hard for us to manually mute all the bots. Instead on the ddnet level it can be "for server in all_servers: econ block_message "EVERYONE GO TO THIS SERVER FAST! LET'S MAKE THE MEAT!!!" 600 "new spam" putting all whoever say this in a 10 minutes shadow mute, so other players won't see any message from those who are muted but the muted players 'll receive proper chat respond from the server. It 'll take time for the spammers to beat it (though I see how to overcome it).
13:51
Another "unfair" feature is name-based shadow autoban. Use-case: there was a racist person (maybe you've seen/remember him — elban). I banned him, he reconnected from a different IP. And then it repeated like 10 times, until one of us gave up. He connected with the same username, and noone else used that name, so this could be automated. "Shadow" part here is the idea to make the spammer spend more time on realizing what is going on. We can just ignore/drop his network packets without a reply. (edited)
Avatar
Learath2 2023-07-13 13:51:55Z
@Ryozuki do you know if there is something like str_utf8_forward in Rust?
Avatar
Ryozuki 2023-07-13 13:51:59Z
shadow banning
13:52
what does str_utf8_forward
Avatar
Learath2 2023-07-13 13:52:16Z
Skips n utf8 codepoints
13:52
I guess I could (ab)use an iterator
Avatar
Ryozuki 2023-07-13 13:52:54Z
@Learath2 isnt the chars iterator that
13:53
i dont remember but i think they are graphemes
13:53
or smth
13:53
https://doc.rust-lang.org/std/primitive.str.html#method.chars
str - Rust
String slices.
13:53
Returns an iterator over the chars of a string slice.
>
As a string slice consists of valid UTF-8, we can iterate through a string slice by char. This method returns such an iterator.
>
It’s important to remember that char represents a Unicode Scalar Value, and might not match your idea of what a ‘character’ is. Iteration over grapheme clusters may be what you actually want. This functionality is not provided by Rust’s standard library, check crates.io instead.
Avatar
Learath2 2023-07-13 13:53:26Z
Doubt they are graphemes, graphemes are extremely hard to decode, require a massive table
13:53
Yeah regular codepoints is what I want anyway
Avatar
Ryozuki 2023-07-13 13:53:50Z
then its that ye
13:54
u can make the iterator peekable()
Avatar
Learath2 2023-07-13 13:54:08Z
I need to keep track of my byte position through the string aswell
13:54
So I guess a peekable char_indices
13:54
Was just wondering if there was a more non-iterator way to do it 😄
Avatar
Ryozuki 2023-07-13 13:55:26Z
https://doc.rust-lang.org/std/primitive.str.html#method.char_indices
str - Rust
String slices.
Avatar
Avatar
Learath2
Was just wondering if there was a more non-iterator way to do it 😄
Ryozuki 2023-07-13 13:55:42Z
i mean good thing about iterator is u dont have to allocate a vec
Avatar
Learath2 2023-07-13 13:56:38Z
Problem with iterator is when I read a character there is no going back without making it peekable, but with a peekable iterator I can't use all the cool functions like .skip_while()
13:56
Anyway, I'll just do one loop and not use the cool functions I guess
Avatar
Ryozuki 2023-07-13 13:57:10Z
@Learath2 check if itertools has what u want
13:57
https://docs.rs/itertools/latest/itertools/
itertools - Rust
Extra iterator adaptors, functions and macros.
Avatar
Learath2 2023-07-13 13:57:46Z
Ah, I'd forgotten it was a thing in rust aswell
Avatar
Ryozuki 2023-07-13 13:58:25Z
https://docs.rs/itertools/latest/itertools/trait.Itertools.html#method.peeking_take_while
Itertools in itertools - Rust
An Iterator blanket implementation that provides extra adaptors and methods.
13:58
it has some take whiles
Avatar
Learath2 2023-07-13 13:58:58Z
Exactly what I'm looking for
13:59
Thanks Rustman
Avatar
Ryozuki 2023-07-13 13:59:14Z
np
14:00
btw a neat thing i discovered recentely
Avatar
Learath2 2023-07-13 14:00:05Z
I wonder if there is any overhead fo peekable, it should be free for iterating arrays if specialized enough
Avatar
Ryozuki 2023-07-13 14:00:10Z
if u have a iterator over options
14:00
u can filter all nones with .flatten()
14:00
its pretty neat
Avatar
Learath2 2023-07-13 14:00:55Z
Ah yep, I've used this before
Avatar
Ryozuki 2023-07-13 14:01:14Z
impl<K, V, S> MyHashmap<K, V, S> where K: Eq + Hash, S: BuildHasher, { fn resize(&mut self) { let new_storage: Vec<Option<(K, V)>> = (0..self.storage.len() * 2).map(|_| None).collect(); // Replace the storage with the new one, so we can use self.x methods to rehash. let old_storage = std::mem::replace(&mut self.storage, new_storage); self.len = 0; for (k, v) in old_storage.into_iter().flatten() { self.insert(k, v); } } }
14:01
i used it on my blog post
14:01
and i discovered this thanks to...
14:01
clippy!
14:02
gigachad
Avatar
Avatar
Ryozuki
i used it on my blog post
Jupstar ✪ 2023-07-13 14:02:19Z
Did it get Fame?
14:02
What was the Reddit link again
Avatar
Ryozuki 2023-07-13 14:02:30Z
it reached frontpage for some time
14:02
https://www.reddit.com/r/rust/comments/14vtc8f/implementing_a_simple_hashmap_in_rust/
r/rust - Implementing a simple Hashmap in Rust
22 votes and 5 comments so far on Reddit
14:02
it has some comments
14:02
but im lazy rn to address them
14:02
one is rly nice
14:02
the one mentioning the cycles
14:03
Image attachment
14:03
these are the stats
14:03
from reddit
Avatar
Learath2 2023-07-13 14:04:49Z
@Ryozuki any idea what the best way would be to consume all?
Avatar
Ryozuki 2023-07-13 14:05:08Z
google search
Image attachment
Avatar
Learath2 2023-07-13 14:05:11Z
I don't need what I take technically
Avatar
Avatar
Learath2
@Ryozuki any idea what the best way would be to consume all?
Ryozuki 2023-07-13 14:05:27Z
consume?
14:05
skip?
14:05
technically collect consumes all xd
Avatar
Avatar
Ryozuki
impl<K, V, S> MyHashmap<K, V, S> where K: Eq + Hash, S: BuildHasher, { fn resize(&mut self) { let new_storage: Vec<Option<(K, V)>> = (0..self.storage.len() * 2).map(|_| None).collect(); // Replace the storage with the new one, so we can use self.x methods to rehash. let old_storage = std::mem::replace(&mut self.storage, new_storage); self.len = 0; for (k, v) in old_storage.into_iter().flatten() { self.insert(k, v); } } }
Voxel 2023-07-13 14:05:57Z
what does this do
Avatar
Avatar
Ryozuki
skip?
Learath2 2023-07-13 14:06:02Z
Yes, but there is no peeking_skip so I need to discard what I get from peeking_take_while
Avatar
Avatar
Voxel
what does this do
Ryozuki 2023-07-13 14:07:12Z
resizes the hashmap
14:07
using mem replace for minimum copies
Avatar
Voxel 2023-07-13 14:08:19Z
weird
Avatar
Avatar
Learath2
Yes, but there is no peeking_skip so I need to discard what I get from peeking_take_while
Ryozuki 2023-07-13 14:08:35Z
i dont get it much
14:08
maybe example
Avatar
Avatar
Voxel
weird
Ryozuki 2023-07-13 14:08:50Z
whats weird
Avatar
Avatar
Ryozuki
maybe example
Learath2 2023-07-13 14:10:26Z
fn foo(s: &str) { let mut it = s.char_indices().peekable(); it.peeking_take_while(|(u, c)| { c.is_whitespace() }) }
14:10
I now need to consume all of the new iterator peeking_take_while returned
Avatar
Ryozuki 2023-07-13 14:11:20Z
ah
14:11
dont u simply want to filter?
14:11
tell me what u want to do with the chars
Avatar
Learath2 2023-07-13 14:11:49Z
No, I technically just need peeking_skip I need to skip all whitespace without consuming the first non-whitespace character
Avatar
Ryozuki 2023-07-13 14:12:19Z
filter doesnt consume non filtered iirc
14:12
it.filter(|x| x.is_whitespace() ) with this u have a iterator over non whitespace chars
Avatar
cyberFighter 2023-07-13 14:12:41Z
hi
Avatar
ChillerDragon BOT 2023-07-13 14:14:02Z
coberfita
Avatar
cyberFighter 2023-07-13 14:14:04Z
can we have a public archive for reports since its private rn (unless its already public and i havent found it)
Avatar
Avatar
Ryozuki
it.filter(|x| x.is_whitespace() ) with this u have a iterator over non whitespace chars
Learath2 2023-07-13 14:14:04Z
I had this idea aswell but I can't just iterate over non whitespace, I need to know where the whitespaces are. I'm rewriting my lexer
Avatar
Ryozuki 2023-07-13 14:14:14Z
why u writing a lexer
14:14
use logos
Avatar
ChillerDragon BOT 2023-07-13 14:14:23Z
why you writing a hashmap
Avatar
Ryozuki 2023-07-13 14:14:28Z
https://docs.rs/logos/latest/logos/
logos - Rust
Logos
Avatar
Learath2 2023-07-13 14:14:32Z
This I why I asked an XY question instead of telling you exactly what I'm doing 😄
Avatar
Ryozuki 2023-07-13 14:14:37Z
xd
14:14
hmm
14:15
maybe some fold where the acc is a storage of whitespace indexes or smth
14:15
but logos will be faster than anything u write by hand
14:15
atleast thats what they claim
Avatar
ChillerDragon BOT 2023-07-13 14:15:30Z
ethos
14:15
pathos
14:15
logos
Avatar
Ryozuki 2023-07-13 14:15:52Z
Image attachment
14:15
cute logo too
Avatar
Avatar
Ryozuki
but logos will be faster than anything u write by hand
Learath2 2023-07-13 14:16:16Z
I'm just trying to get more comfy with rust, using a lexer generator won't help
Avatar
Avatar
Learath2
I'm just trying to get more comfy with rust, using a lexer generator won't help
Ryozuki 2023-07-13 14:16:25Z
just make 2 iterators?
14:16
one for whitespaces one for none
14:16
or simply do a for loop
Avatar
ChillerDragon BOT 2023-07-13 14:16:40Z
ryo send like on gh issue pls
14:16
https://github.com/PathosEthosLogos/Leave-a-message-beep/issues/1
yo look in chat on fng · Issue #1 · PathosEthosLogos/Leave-a-messa...
Thumbnail
14:16
i need attention from this guy
14:17
he creator of logos
Avatar
Avatar
Ryozuki
whats weird
Voxel 2023-07-13 14:17:32Z
idk im just dumb
Avatar
Ryozuki 2023-07-13 14:17:32Z
@Learath2 ur gonna need to save the whitespace indexes so
14:17
make a hashset and save the indexes there
14:17
well
14:17
a vec
14:17
the indexes will be unique anyway xd im dum
Avatar
Avatar
Voxel
idk im just dumb
Ryozuki 2023-07-13 14:18:15Z
no u just need to learn rust
14:19
@Learath2 what about https://docs.rs/itertools/latest/itertools/fn.multipeek.html
multipeek in itertools - Rust
An iterator adaptor that allows the user to peek at multiple .next() values without advancing the base iterator.
Avatar
Avatar
Ryozuki
@Learath2 what about https://docs.rs/itertools/latest/itertools/fn.multipeek.html
Learath2 2023-07-13 14:20:06Z
I don't need to peek further than one
14:20
On a scale of 0-10, how ugly is just doing .for_each(|_| {}) on the PeekingTakeWhile?
Avatar
Ryozuki 2023-07-13 14:21:09Z
i usually use for loops inteast
14:21
instead
Avatar
Learath2 2023-07-13 14:21:24Z
So just a for loop with an empty body?
Avatar
Ryozuki 2023-07-13 14:21:40Z
whait
14:21
thats ugly
14:22
im still confused
14:22
idk if im an idiot
Avatar
Learath2 2023-07-13 14:22:24Z
Or I guess I could do this the ancient way, just not have it peekable and have one big state machine handle everything
Avatar
Ryozuki 2023-07-13 14:22:40Z
you want to save all whitespace ranges?
Avatar
Avatar
Ryozuki
idk if im an idiot
Learath2 2023-07-13 14:22:44Z
Noo, it's probably my ancient coding style that doesn't match with your mental image of what I'm doing
14:22
I want to skip the whitespace, nothing more
Avatar
Ryozuki 2023-07-13 14:22:55Z
but then why no filter?
Avatar
Avatar
ChillerDragon
https://github.com/PathosEthosLogos/Leave-a-message-beep/issues/1
cyberFighter 2023-07-13 14:23:08Z
wtf LOL
Avatar
Avatar
Ryozuki
but then why no filter?
Learath2 2023-07-13 14:23:25Z
I want to skip the whitespace until the first non-whitespace, then I need to do other stuff that require me to no longer ignore the whitespace
Avatar
cyberFighter 2023-07-13 14:23:34Z
@Voxel did u make the new banners in welcome channel
Avatar
Learath2 2023-07-13 14:23:42Z
If I have a filtered iterator I can't unfilter it after I hit the first non-whitespace
Avatar
Avatar
Learath2
I want to skip the whitespace until the first non-whitespace, then I need to do other stuff that require me to no longer ignore the whitespace
Ryozuki 2023-07-13 14:23:44Z
ahh
14:24
https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.skip_while
Iterator in std::iter - Rust
A trait for dealing with iterators.
14:24
this ?
14:24
Creates an iterator that skips elements based on a predicate.
>
skip_while() takes a closure as an argument. It will call this closure on each element of the iterator, and ignore elements until it returns false.
>
After false is returned, skip_while()’s job is over, and the rest of the elements are yielded.
14:25
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=8d940200647edaabba130c6f6005b9e2
Rust Playground
A browser interface to the Rust compiler to experiment with the language
14:25
looks like what uwant
Avatar
Avatar
cyberFighter
@Voxel did u make the new banners in welcome channel
murpi 2023-07-13 14:25:53Z
@Pipou drew the backgrounds, I did the font.
Avatar
Ryozuki 2023-07-13 14:26:17Z
Image attachment
14:26
@Learath2
14:26
@murpi ur announcement is a bit meh
14:26
Image attachment
14:26
"no access" received a make over
14:26
xd
Avatar
murpi 2023-07-13 14:27:13Z
Yes, just fixed that
Avatar
Learath2 2023-07-13 14:27:38Z
Oh, skip_while returns an iterator aswell, I didn't think of that
Avatar
Avatar
murpi
@Pipou drew the backgrounds, I did the font.
cyberFighter 2023-07-13 14:28:17Z
ok it looks good
Avatar
Ryozuki 2023-07-13 14:28:27Z
@murpi u dont link the wiki anywhere PES3_Cry
Avatar
Avatar
cyberFighter
can we have a public archive for reports since its private rn (unless its already public and i havent found it)
cyberFighter 2023-07-13 14:28:30Z
@murpi btw
Avatar
Avatar
Ryozuki
@murpi u dont link the wiki anywhere PES3_Cry
murpi 2023-07-13 14:28:42Z
👀
14:29
It's linked in multiple places
Avatar
Ryozuki 2023-07-13 14:29:12Z
@murpi i also host this
14:29
https://codedoc.ddnet.org/
14:29
oh u link it
14:29
im blind
14:29
(the wiki)
Avatar
Avatar
cyberFighter
@Voxel did u make the new banners in welcome channel
Voxel 2023-07-13 14:30:15Z
not yet
Avatar
Ryozuki 2023-07-13 14:30:32Z
@murpi do only admins see complains or all mods?
Avatar
Avatar
Ryozuki
@murpi do only admins see complains or all mods?
murpi 2023-07-13 14:30:40Z
Just admins
Avatar
cyberFighter 2023-07-13 14:30:49Z
mods would abuse
Avatar
Ryozuki 2023-07-13 14:31:07Z
ok nice
Avatar
louis 2023-07-13 14:31:44Z
add content creator role 😎
Avatar
Ryozuki 2023-07-13 14:31:52Z
u could also add this on the for developers section: https://edgarluque.com/categories/ddracenetwork/
Home
My personal website.
14:31
totally not self inserted
14:32
but imho its good for incoming devs
14:32
blobwhistle
Avatar
louis 2023-07-13 14:32:07Z
also wiki curator color would be cool
Avatar
Avatar
Ryozuki
but imho its good for incoming devs
louis 2023-07-13 14:32:12Z
i agree actually
14:32
add more posts though
Avatar
Ryozuki 2023-07-13 14:32:19Z
ye
14:32
i added one last time
14:32
about UI
14:32
what could be next
Avatar
murpi 2023-07-13 14:32:55Z
it'd override the Dev color though
Avatar
Ryozuki 2023-07-13 14:33:00Z
nooo
14:33
dev is important
14:33
for me
14:33
its sad discord doesnt detach color priority from role priority
Avatar
Avatar
Ryozuki
what could be next
louis 2023-07-13 14:33:42Z
did u ever finish adidng map tiles?
Avatar
murpi 2023-07-13 14:33:45Z
@Ryozuki Maybe pin all the useful resources here?
Avatar
louis 2023-07-13 14:33:46Z
iirc last time it wasnt complete
Avatar
Avatar
louis
did u ever finish adidng map tiles?
Ryozuki 2023-07-13 14:33:55Z
i never made a post about that iirc
14:34
i know how to do it cuz i did telegun so its a good idea
Avatar
louis 2023-07-13 14:34:10Z
there was a link about it somewhere on ur site
14:34
or a mention
14:34
but no post
Avatar
Ryozuki 2023-07-13 14:34:28Z
@murpi pin this
14:34
https://wiki.ddnet.org/wiki/Development#External_resources
Development
14:34
or should it be without the #
14:35
https://wiki.ddnet.org/wiki/Development
Avatar
Voxel 2023-07-13 14:36:14Z
@cyberFighter im gonna do the concepts and stuff in clip studio paint and then probably hand it to someone like ravie or pipou so they can make it look game accurate
Avatar
cyberFighter 2023-07-13 14:36:57Z
wtf is studio paint
14:37
clip studio paint
Avatar
Voxel 2023-07-13 14:37:46Z
the art program i use (edited)
murpi pinned a message to this channel. 2023-07-13 14:39:44Z
Avatar
louis 2023-07-13 14:51:53Z
is the skin channel discord integration finished?
Avatar
ChillerDragon BOT 2023-07-13 15:06:35Z
Did anyone ever use the client console command callvote ? Seems kinda cool but super unused.
Avatar
cyberFighter 2023-07-13 15:07:51Z
yes i used it a day ago
Avatar
Ryozuki 2023-07-13 15:08:13Z
i used it a second ago
Avatar
cyberFighter 2023-07-13 15:08:39Z
btw chiller ur switch spectate command is good
15:08
when add it to official ddnet
Avatar
Avatar
ChillerDragon
Did anyone ever use the client console command callvote ? Seems kinda cool but super unused.
Kaffeine 2023-07-13 15:08:58Z
I used it a few times a while ago. It is not really convenient for immediate use but works fine with binds or scripts (econ).
Avatar
ChillerDragon BOT 2023-07-13 15:13:03Z
wowo i have been missing out
15:13
i could also see that being super helpful on city servers where vote options are menus to bind something
15:14
@thatonehotcougar yea i also use it from time to time i forgot why i never prd it to ddnet maybe because i was too lazy to clean up the code to get it merged
Avatar
quarpit 2023-07-13 15:15:51Z
wtf
Image attachment
Avatar
cyberFighter 2023-07-13 15:17:17Z
ok and
Avatar
Learath2 2023-07-13 15:23:23Z
@Ryozuki assert_eq!(lexer.get_token(), Ok("hello")); fn Lexer::get_token() -> Result<String, Error> Is the correct thing to do here just doing .to_string() on the "hello"? I thought Strings could be compared with &str np
Avatar
Ryozuki 2023-07-13 15:23:39Z
no
15:23
do the opposite
15:23
as_str() on the token
15:24
map it ofc
Avatar
Avatar
Ryozuki
as_str() on the token
Learath2 2023-07-13 15:24:05Z
It's in a result though, I'd need to map
Avatar
Ryozuki 2023-07-13 15:24:16Z
whats wrong with map
15:24
map on a result is not lazy, u get another result
15:24
maybe .as_ref works but probs not here
15:25
lexer.get_token().as_ref()
Avatar
Jupstar ✪ 2023-07-13 15:26:18Z
@murpi why don't I see the first channel in #announcements
Avatar
Avatar
Ryozuki
whats wrong with map
Learath2 2023-07-13 15:26:26Z
Actually can you even map this? Can't get that ref out of the mapping closure, no?
Avatar
Avatar
Jupstar ✪
@murpi why don't I see the first channel in #announcements
murpi 2023-07-13 15:27:04Z
because of bugs and debugging on production servers is hell and takes forever
Avatar
Voxel 2023-07-13 15:27:26Z
How is info stored inside demo files? And where can I find how kill messages are stored inside them?
Avatar
murpi 2023-07-13 15:27:33Z
should be visible now
Avatar
Avatar
Learath2
Actually can you even map this? Can't get that ref out of the mapping closure, no?
Ryozuki 2023-07-13 15:29:34Z
try it
15:29
u can most probs
Avatar
Avatar
Ryozuki
u can most probs
Learath2 2023-07-13 15:30:49Z
error[E0515]: cannot return reference to function parameter `s` --> src/lexer.rs:105:48 | 105 | assert_eq!(lexer.get_token().map(|s| { s.as_str() }), Ok("a'b'bb")); | ^^^^^^^^^^ returns a reference to data owned by the current function
Avatar
Ryozuki 2023-07-13 15:31:02Z
true true
15:31
just save the get_token in a var
Avatar
Avatar
Voxel
How is info stored inside demo files? And where can I find how kill messages are stored inside them?
Robyt3 2023-07-13 15:31:40Z
Demos contain the snapshots and messages that the client has received from the server
Avatar
Learath2 2023-07-13 15:31:51Z
That doubles the size of my test function to avoid allocating a couple strings 😄
Avatar
Ryozuki 2023-07-13 15:32:00Z
but it doesnt allocate
15:32
xd
15:32
its ur call
15:32
to_string is shorter but allocs
Avatar
Avatar
Robyt3
Demos contain the snapshots and messages that the client has received from the server
Voxel 2023-07-13 15:32:47Z
I see. I found a strange bug where teamkills don't bring over the tees
Image attachment
15:33
I'm trying to fix it but I'm not sure where it could be located.
Avatar
Robyt3 2023-07-13 15:34:27Z
Maybe it's related to #3795 or #4545
Avatar
DDNet BOT 2023-07-13 15:34:28Z
https://github.com/ddnet/ddnet/issues/3795 https://github.com/ddnet/ddnet/issues/4545
Teams are not shown in demo viewer anymore · Issue #3795 · ddnet/dd...
Fails with this message on any client version when playing, so the problem is probably the recording: [2021-04-29 00:31:51][client]: dropped weird message 'invalid' (0), failed on '(typ...
Thumbnail
Teams are not properly displayed in demo viewer · Issue #4545 · ddn...
Not sure if this is related/dupelicate to #3795 Some players are rendered incorrectly, as if they don't belong in the same team. Most noticeable by skipping huge parts of the timeline in the de...
Thumbnail
Avatar
Robyt3 2023-07-13 15:35:27Z
Maybe the demo doesn't contain all the information because recording started too late (edited)
Avatar
Voxel 2023-07-13 15:36:07Z
Oh dang. Well I'm going to publish my fix for #6838 right now, because I think this is too complex for the time I have LOL
Avatar
DDNet BOT 2023-07-13 15:36:07Z
https://github.com/ddnet/ddnet/issues/6838
Killfeed not showing deaths in teams · Issue #6838 · ddnet/ddnet
If a tee dies in an unlocked team mid run, they will not show up in the kill feed. asdas.mp4
Thumbnail
Avatar
Avatar
Ryozuki
but it doesnt allocate
Learath2 2023-07-13 15:38:58Z
My obsession with using less memory is usually restricted to runtime, but it does sort of annoy me
Avatar
GitHub BOT 2023-07-13 15:40:17Z
Author icon
VoxelDoesCode
[ddnet/ddnet] Pull request opened: #6841 Send KillMsg for started + unlocked teams
Fixes #6838

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [x] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#u...
Avatar
Avatar
Voxel
I see. I found a strange bug where teamkills don't bring over the tees
Voxel 2023-07-13 15:40:59Z
I'll post this issue on github for futureproof purposes
Avatar
Avatar
Ryozuki
maybe .as_ref works but probs not here
Learath2 2023-07-13 15:41:02Z
.as_ref() doesn't but .as_deref() does, someone on the rust dc gave me the tip 😄
Avatar
Ryozuki 2023-07-13 15:41:11Z
as true
15:41
oh*
15:41
i forgot about it
Avatar
Learath2 2023-07-13 15:49:03Z
I can not believe this, I wrote a lexer in one try without any issues that can parse a ridiculous string like "hello w\"o\"rl'd' a'\"a\"a'a a\"'b'b\"b \"a a\" 'b b'"
Avatar
Jupstar ✪ 2023-07-13 15:49:58Z
@Learath2 ping me if u have trouble with setup 😬
Avatar
Avatar
Jupstar ✪
@Learath2 ping me if u have trouble with setup 😬
Learath2 2023-07-13 15:50:41Z
tell me where find the key for the skin thing
Avatar
Avatar
Learath2
tell me where find the key for the skin thing
Jupstar ✪ 2023-07-13 15:51:03Z
the key for the skindatabase crew role?
15:51
or the password?
Avatar
Avatar
Jupstar ✪
or the password?
Learath2 2023-07-13 15:51:55Z
the username and pw for the http auth thing
15:52
I guess it's somewhere in nginx configs now that I think about it
Avatar
Jupstar ✪ 2023-07-13 15:52:14Z
@Ravie pm learath the user and pw pls
Avatar
Learath2 2023-07-13 15:52:19Z
I didn't think it was just basic_auth
Avatar
Jupstar ✪ 2023-07-13 15:52:20Z
for skin database
Avatar
Avatar
Learath2
I didn't think it was just basic_auth
Jupstar ✪ 2023-07-13 15:52:25Z
not?
Avatar
Avatar
Learath2
I can not believe this, I wrote a lexer in one try without any issues that can parse a ridiculous string like "hello w\"o\"rl'd' a'\"a\"a'a a\"'b'b\"b \"a a\" 'b b'"
Ryozuki 2023-07-13 15:52:30Z
rust power
Avatar
Jupstar ✪ 2023-07-13 15:52:30Z
well that sucks xd
Avatar
Ryozuki 2023-07-13 15:52:48Z
this lexer also has no segfaults
15:52
no out of bounds
Avatar
Avatar
Ryozuki
rust power
Learath2 2023-07-13 15:52:54Z
I don't think you'd like what I created, it's very oldschool
Avatar
Ryozuki 2023-07-13 15:52:59Z
its ok
15:53
if it doesnt have unsafe
15:53
ur lexer is memory safe tm
15:53
lexers are prone to segfaults iirc
15:53
in cpp xd
Avatar
GitHub BOT 2023-07-13 15:53:29Z
Author icon
VoxelDoesCode
[ddnet/ddnet] Issue opened: #6842 Demos sometimes not rendering Teams Killfeed right
Sometimes it renders the tees in Team KillMsgs, but sometimes it doesn't. It might have to do with if it's your team that kills or another team. This is purely in demos. !image Robyt3 says it might be related to #3795 or #4545, following with:
Maybe the demo doesn't contain all the information because recording started too late
Avatar
Avatar
Learath2
I don't think you'd like what I created, it's very oldschool
Ryozuki 2023-07-13 15:53:43Z
where can i check
15:53
and what does clippy say
15:53
troll
15:54
i know heinrich disagrees, but clippy often makes ur code idiomatic
Avatar
Avatar
Ryozuki
where can i check
Learath2 2023-07-13 15:54:36Z
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9e857abceed853aac445b547371b4c2d
Rust Playground
A browser interface to the Rust compiler to experiment with the language
Avatar
Avatar
Ryozuki
i know heinrich disagrees, but clippy often makes ur code idiomatic
Jupstar ✪ 2023-07-13 15:54:42Z
does it rewrite code even at the cost of perf?
Avatar
Learath2 2023-07-13 15:55:00Z
I didn't do fmt or clippy on it yet, let's see if it hates anything
Avatar
Avatar
Jupstar ✪
does it rewrite code even at the cost of perf?
Ryozuki 2023-07-13 15:55:02Z
clippy doesnt rewrite code as is
15:55
and clippy has lints for perfomance
15:55
it makes ur code faster usually
Avatar
Jupstar ✪ 2023-07-13 15:55:16Z
chillerdragon: how can i demoativate you? XD
Avatar
Ryozuki 2023-07-13 15:55:16Z
by pointing out perf errors
Avatar
Avatar
Ryozuki
clippy doesnt rewrite code as is
Jupstar ✪ 2023-07-13 15:55:31Z
but why should heinrich disagree xd
Avatar
Ryozuki 2023-07-13 15:55:35Z
https://rust-lang.github.io/rust-clippy/master/index.html#?groups=perf
Clippy Lints
A collection of lints to catch common mistakes and improve your Rust code.
Avatar
Jupstar ✪ 2023-07-13 15:55:43Z
i soon want to use all clippy warnings too
Avatar
Learath2 2023-07-13 15:55:52Z
huh, clippy doesn't complain
15:55
Maybe I'm holding it wrong
15:56
how do you run clippy?
Avatar
Ryozuki 2023-07-13 15:56:12Z
@Learath2 try this cargo clippy -- -D warnings
15:56
if u want to be daring
15:56
do
15:56
cargo clippy -- -D warnings -D clippy::nursery``
15:56
more daring
15:56
cargo clippy -- -D warnings -D clippy::nursery -D clippy::pedantic
Avatar
Avatar
murpi
because of bugs and debugging on production servers is hell and takes forever
Jupstar ✪ 2023-07-13 15:56:52Z
i see, but welcome now looks fancy af, good job
Avatar
Ryozuki 2023-07-13 15:56:58Z
cargo clippy -- -D warnings -D clippy::nursery -D clippy::pedantic -D clippy::all (edited)
Avatar
Avatar
Jupstar ✪
i see, but welcome now looks fancy af, good job
murpi 2023-07-13 15:57:17Z
Thanks 🙂
Avatar
Ryozuki 2023-07-13 15:57:43Z
Image attachment
15:57
i found this on my code just now
Avatar
Jupstar ✪ 2023-07-13 15:58:56Z
ryo stop spam, ravie has to read important messages
15:59
i waited over a month for this day
15:59
lol
Avatar
Ryozuki 2023-07-13 15:59:11Z
#⁠developer - Get a glimpse into the exciting realm of game development!
And:
  • philosophy
  • free software
  • economics
  • global crisis
  • climate change
  • nuclear energy and fision fusion
  • rust
  • random tech convos
Avatar
Avatar
Ryozuki
cargo clippy -- -D warnings -D clippy::nursery -D clippy::pedantic -D clippy::all (edited)
Learath2 2023-07-13 15:59:34Z
Just 2 things, I called ok_or once instead of ok_or_else and I didn't derive Eq when I already derived PartialEq
Avatar
Avatar
Learath2
Just 2 things, I called ok_or once instead of ok_or_else and I didn't derive Eq when I already derived PartialEq
Ryozuki 2023-07-13 15:59:40Z
nice
15:59
fix fix
15:59
read the eq thing
16:00
but most probs u need eq
16:00
or makes sense*
Avatar
Learath2 2023-07-13 16:00:18Z
Read the Eq thing, it doesn't really matter for now, but no reason not to derive that aswell
Avatar
Ryozuki 2023-07-13 16:00:26Z
https://doc.rust-lang.org/std/cmp/trait.Eq.html
Eq in std::cmp - Rust
Trait for equality comparisons which are equivalence relations.
Avatar
Learath2 2023-07-13 16:00:29Z
if it doesn't end up used it'll go away in dead-code elimination
Avatar
Avatar
Learath2
Read the Eq thing, it doesn't really matter for now, but no reason not to derive that aswell
Ryozuki 2023-07-13 16:00:44Z
good api checklist guidelines tell library authors to derive eagerly these traits
16:00
https://rust-lang.github.io/api-guidelines/checklist.html
Checklist - Rust API Guidelines
This is a set of recommendations on how to design and present APIs for the Rust programming language.
16:01
Image attachment
Avatar
Jupstar ✪ 2023-07-13 16:01:19Z
@Learath2 have you looked for .htaccess inside www/skins/edit
Avatar
Avatar
Ryozuki
where can i check
Learath2 2023-07-13 16:01:38Z
Do you like the way I wrote it? Would you do it differently?
Avatar
Avatar
Jupstar ✪
@Learath2 have you looked for .htaccess inside www/skins/edit
Learath2 2023-07-13 16:01:43Z
let me look
Avatar
Avatar
Learath2
Just 2 things, I called ok_or once instead of ok_or_else and I didn't derive Eq when I already derived PartialEq
Ryozuki 2023-07-13 16:01:46Z
i guess u dont have pub methods? otherwise it would tell u to add lots of docs XD
16:01
oh
16:02
i didnt check ur code yet
Avatar
Learath2 2023-07-13 16:02:05Z
Yeah, I'll make it pub and it'll annoy me about that
Avatar
Ryozuki 2023-07-13 16:02:13Z
was making weird shenanigans at work
16:02
allocating a hashmap in rust and using it in mlir
Avatar
Learath2 2023-07-13 16:02:26Z
get_token is self documenting, no? It gets a token 😄
Avatar
Ryozuki 2023-07-13 16:02:38Z
#[no_mangle] pub unsafe extern "C" fn blabla__alloc_dict() -> *mut std::ffi::c_void { let map: Box<HashMap<[u8; 32], NonNull<()>>> = Box::default(); Box::into_raw(map) as _ }
16:02
justatest
Avatar
Avatar
Ryozuki
#[no_mangle] pub unsafe extern "C" fn blabla__alloc_dict() -> *mut std::ffi::c_void { let map: Box<HashMap<[u8; 32], NonNull<()>>> = Box::default(); Box::into_raw(map) as _ }
Learath2 2023-07-13 16:02:54Z
it has unsafe in it, you are officially exiled from rust
Avatar
Avatar
Jupstar ✪
@Learath2 have you looked for .htaccess inside www/skins/edit
Learath2 2023-07-13 16:03:36Z
no such luck, let me check the nginx conf
Avatar
Jupstar ✪ 2023-07-13 16:03:43Z
LETS GO
Avatar
Learath2 2023-07-13 16:03:59Z
found it
Avatar
Jupstar ✪ 2023-07-13 16:04:04Z
EPIC
Avatar
Learath2 2023-07-13 16:04:19Z
Oh it seems everyone has their own key
Avatar
Jupstar ✪ 2023-07-13 16:04:31Z
uff, but as long its basic auth
Avatar
Learath2 2023-07-13 16:04:59Z
Hm, I guess the bot can get a key and we can use the #📬submit-skins channel as a sort of audit log
Avatar
Jupstar ✪ 2023-07-13 16:05:31Z
@Learath2 btw if only ppl with skin db crew role can write in #📬submit-skins , u also have ot give that role to the bot
16:05
(write stuff other than skins)
16:06
if u need a name for the bot: ✪✪Net
16:06
😬
Avatar
Learath2 2023-07-13 16:06:28Z
It'll be YAYADDB
Avatar
Jupstar ✪ 2023-07-13 16:06:35Z
even better xD
Avatar
Learath2 2023-07-13 16:06:47Z
Or SkinDB maybe
Avatar
Voxel 2023-07-13 16:07:34Z
SkinDB makes more sense
Avatar
Jupstar ✪ 2023-07-13 16:07:44Z
CSGOSkinTrade
Avatar
Ryozuki 2023-07-13 16:09:15Z
@Learath2 why allocate a string tho? why not keep track of a range
16:09
start end idx
Avatar
Avatar
Ryozuki
@Learath2 why allocate a string tho? why not keep track of a range
Learath2 2023-07-13 16:09:37Z
That was my initial idea, but I hadn't thought about quotes, I need to be discarding them
Avatar
Ryozuki 2023-07-13 16:09:45Z
oh i see
Avatar
GitHub BOT 2023-07-13 16:09:49Z
Author icon
def-
[ddnet/ddnet] Issue opened: #6843 server: double free or corruption (!prev)
`` Core was generated by ./DDRace64-Server_sql -f servers/block2.cfg'. Program terminated with signal SIGABRT, Aborted. #0 pthread_kill_implementation (threadid=, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. [Current thread is 1 (Thread 0x7f5e12c0ba00 (LWP 1469313))] (gdb) bt #0 pthread_kill_implementation (threadid=, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 #1 0x000...
Avatar
Ryozuki 2023-07-13 16:09:55Z
btw if u want ur code to be panicless, use .get instead of slicing
Avatar
Avatar
Ryozuki
btw if u want ur code to be panicless, use .get instead of slicing
Learath2 2023-07-13 16:10:04Z
Aha, that's a good idea
Avatar
Jupstar ✪ 2023-07-13 16:10:35Z
@Learath2 btw does the upload bot already check if a 256x128 skin is present? like can u upload 512x256 only, or does it throw an error?
Avatar
Avatar
Jupstar ✪
@Learath2 btw does the upload bot already check if a 256x128 skin is present? like can u upload 512x256 only, or does it throw an error?
Learath2 2023-07-13 16:10:57Z
The current bot? Don't we disable that part of it when we deploy yours?
Avatar
Avatar
Learath2
The current bot? Don't we disable that part of it when we deploy yours?
Jupstar ✪ 2023-07-13 16:11:08Z
no
16:11
mine is fancy af ez upload only
Avatar
Ryozuki 2023-07-13 16:11:17Z
@Learath2 btw in ur test u dotn need to escape
16:11
let mut lexer = Lexer::new(r#"a "b" sadsa "#);
Avatar
Avatar
Jupstar ✪
@Learath2 btw does the upload bot already check if a 256x128 skin is present? like can u upload 512x256 only, or does it throw an error?
murpi 2023-07-13 16:11:43Z
It does: def check_image_resolution(message: discord.Message): for attachment in message.attachments: if (attachment.height != 128 or attachment.width != 256) and (attachment.height != 256 or attachment.width != 512): return (False, 'One of the attached skins does not have the correct image resolution. Resolution must be 256x128, and if possible provide a 512x256 along with the 256x128') return (True, None)
Avatar
Avatar
Jupstar ✪
mine is fancy af ez upload only
Learath2 2023-07-13 16:12:08Z
Wait, it doesn't check anything?
Avatar
Avatar
Learath2
Wait, it doesn't check anything?
Jupstar ✪ 2023-07-13 16:12:17Z
i added a few checks
16:12
but murpi told me it also checks
Avatar
Avatar
murpi
It does: def check_image_resolution(message: discord.Message): for attachment in message.attachments: if (attachment.height != 128 or attachment.width != 256) and (attachment.height != 256 or attachment.width != 512): return (False, 'One of the attached skins does not have the correct image resolution. Resolution must be 256x128, and if possible provide a 512x256 along with the 256x128') return (True, None)
Jupstar ✪ 2023-07-13 16:12:39Z
to me that doesnt look like it prevents 512x256 only tho does it?
Avatar
Learath2 2023-07-13 16:12:41Z
Two bots need to coordinate to ensure proper operation, that's ddnet engineering 😄
Avatar
Jupstar ✪ 2023-07-13 16:12:46Z
bcs the database refuses to upload this
Avatar
Avatar
Learath2
Two bots need to coordinate to ensure proper operation, that's ddnet engineering 😄
Jupstar ✪ 2023-07-13 16:13:01Z
well i think i check all stuff except this
16:13
and i only noticed that the database script refuses it by luck
16:13
bcs actually the database can handle hd skins only
16:13
but we disallowed this purposely
Avatar
Voxel 2023-07-13 16:13:31Z
if you make it SkinDB can you make the icon this? (It's the same tee design from #📍info
Image attachment
Avatar
cyberFighter 2023-07-13 16:13:36Z
true i agree with you voxel
Avatar
Learath2 2023-07-13 16:14:12Z
@Jupstar ✪ can you link me the source again btw?
Avatar
cyberFighter 2023-07-13 16:14:15Z
holy shit its the mega tee @Voxel (i meant to ping keb what a brainfart) (edited)
🔥 1
Avatar
Jupstar ✪ 2023-07-13 16:14:15Z
@Learath2 also in worst case the skin will simply not be uploaded, nothing more
Avatar
Avatar
Learath2
@Jupstar ✪ can you link me the source again btw?
Jupstar ✪ 2023-07-13 16:14:25Z
https://github.com/ddnet/discord-skin-upload-bot
GitHub - ddnet/discord-skin-upload-bot: A bot that helps and automa...
A bot that helps and automates skin uploading to the databse - GitHub - ddnet/discord-skin-upload-bot: A bot that helps and automates skin uploading to the databse
Thumbnail
Avatar
Avatar
Jupstar ✪
to me that doesnt look like it prevents 512x256 only tho does it?
murpi 2023-07-13 16:17:15Z
It prevents all images not equal to 256x128 or 512x256
Avatar
Avatar
murpi
It prevents all images not equal to 256x128 or 512x256
Jupstar ✪ 2023-07-13 16:18:30Z
yeah but the db would also need no hd always
16:18
not hd only skins
Avatar
GitHub BOT 2023-07-13 16:21:21Z
Author icon
Jupeyy
[discord-skin-upload-bot:main] 1 new commit
a8e5e98 Check if 256x128 skin file is present - Jupeyy
Avatar
Avatar
GitHub
Click to see attachment 🖼️
Jupstar ✪ 2023-07-13 16:21:47Z
^ @Learath2 git pull xd
Avatar
louis 2023-07-13 16:26:49Z
is having accepted pull requests the only criteria for dev role 👀
Avatar
Ryozuki 2023-07-13 16:27:08Z
lous like lynn inc
16:27
which did 1 commit to get the role and done
16:27
imho u should atleast be semi active xd
Avatar
Avatar
GitHub
Click to see attachment 🖼️
louis 2023-07-13 16:27:38Z
maybe if theres only 512x256 the bot can just downscale it
Avatar
Avatar
Ryozuki
which did 1 commit to get the role and done
louis 2023-07-13 16:27:58Z
role collector
16:28
like me
Avatar
Voxel 2023-07-13 16:28:04Z
I think it should work the same way as the Discord Dev badge
16:28
where if you don't make a valid PR in a month the dev role gets removed
Avatar
louis 2023-07-13 16:28:23Z
what even was her pr
Avatar
Voxel 2023-07-13 16:28:29Z
(i still get to keep mine because i did a bug fix ha ha!)
Avatar
Avatar
Voxel
where if you don't make a valid PR in a month the dev role gets removed
louis 2023-07-13 16:28:29Z
no
Avatar
Voxel 2023-07-13 16:28:47Z
ok fine
16:28
yeah why doesnt louis have dev role wtf
Avatar
Avatar
louis
maybe if theres only 512x256 the bot can just downscale it
Jupstar ✪ 2023-07-13 16:29:27Z
xd, i doubt @Ravie likes automatic downscale, so i better wont touch it now
Avatar
louis 2023-07-13 16:29:30Z
my prs were pretty ez
Avatar
Voxel 2023-07-13 16:29:36Z
same-ish
Avatar
Avatar
Jupstar ✪
xd, i doubt @Ravie likes automatic downscale, so i better wont touch it now
louis 2023-07-13 16:29:46Z
as long as u use correct downscaler idt it matters
16:29
and if a skin guy rly cares for good quality they can uplaod 2 vers
Avatar
Ryozuki 2023-07-13 16:30:08Z
@Jupstar ✪ im gonna make a pr to ur crate
Avatar
Avatar
Voxel
same-ish
louis 2023-07-13 16:30:11Z
not
Avatar
Avatar
louis
not
Voxel 2023-07-13 16:30:17Z
wdym
Avatar
Avatar
Ryozuki
@Jupstar ✪ im gonna make a pr to ur crate
Jupstar ✪ 2023-07-13 16:30:22Z
now comes the rust gang xD
Avatar
Avatar
Jupstar ✪
xd, i doubt @Ravie likes automatic downscale, so i better wont touch it now
Ravie 2023-07-13 16:30:24Z
I do, just use a good interpolation
Avatar
Avatar
Ravie
I do, just use a good interpolation
Jupstar ✪ 2023-07-13 16:30:40Z
but anyway, for now its ok to not do it right?
16:30
i prefer to finally have the bot running
Avatar
louis 2023-07-13 16:30:51Z
yes
16:30
it shouldnt be hard to add later anyways
16:31
is it a separate bot?
Avatar
Ravie 2023-07-13 16:31:18Z
uploading one file is always better than 2
Avatar
louis 2023-07-13 16:31:36Z
one of us could probably add it later anyways
Avatar
Avatar
louis
is it a separate bot?
Jupstar ✪ 2023-07-13 16:31:44Z
what do u mean?
16:31
the skin upload bot is an own bot
Avatar
Ravie 2023-07-13 16:31:53Z
also better to have a consistent way to downscale them than however someone decides to do it
16:32
someone might pick a terrible interpolation or somehow introduce artifacts
Avatar
Jupstar ✪ 2023-07-13 16:32:17Z
first of all i'd like to have feedback if u even like the bot xD
16:32
except me nobody ever used it xD
Avatar
Voxel 2023-07-13 16:32:39Z
duude i LOVE the idea of not having to download like 30 skins to manually upload them
16:32
this is going to be worth it
Avatar
Ravie 2023-07-13 16:33:21Z
where is the bot?
Avatar
Jupstar ✪ 2023-07-13 16:33:23Z
then lets cheer @Learath2 show him love in his quest to start the bot after his exams
Avatar
Avatar
Ravie
where is the bot?
Jupstar ✪ 2023-07-13 16:33:32Z
learath is setting it up rn
Avatar
Ravie 2023-07-13 16:33:53Z
ah thought I was supposed to give feedback on something already
Avatar
GitHub BOT 2023-07-13 16:34:03Z
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #6838 Killfeed not showing deaths in teams
16:34
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6841 Send KillMsg for started + unlocked teams
Avatar
Voxel 2023-07-13 16:34:14Z
yay!
16:34
#6843
Image attachment
Avatar
DDNet BOT 2023-07-13 16:34:23Z
https://github.com/ddnet/ddnet/issues/6843
server: double free or corruption (!prev) · Issue #6843 · ddnet/ddn...
Core was generated by `./DDRace64-Server_sql -f servers/block2.cfg'. Program terminated with signal SIGABRT, Aborted. #0 __pthread_kill_implementation (threadid=<optimized out>, signo=sig...
Thumbnail
Avatar
Avatar
Jupstar ✪
now comes the rust gang xD
Ryozuki 2023-07-13 16:34:26Z
ye
Avatar
Voxel 2023-07-13 16:34:36Z
"noby to the rescue" is something I never expected deen to say LOL (edited)
Avatar
Learath2 2023-07-13 16:34:48Z
um massive roadblock
16:34
ddnet.tw ran out of disk space 😄
⚠️ 1
Avatar
louis 2023-07-13 16:35:06Z
delete some maps
Avatar
Avatar
Voxel
"noby to the rescue" is something I never expected deen to say LOL (edited)
Jupstar ✪ 2023-07-13 16:35:06Z
why do u even read these issues xD
Avatar
louis 2023-07-13 16:35:09Z
ive got some suggestions
16:35
troll
Avatar
Jupstar ✪ 2023-07-13 16:35:18Z
are u subscribed to whole repo?
Avatar
Avatar
Jupstar ✪
why do u even read these issues xD
Voxel 2023-07-13 16:35:22Z
because im bored and reading issues is kinda fun
Avatar
Avatar
Learath2
ddnet.tw ran out of disk space 😄
Jupstar ✪ 2023-07-13 16:35:30Z
NO WAY XD rip
Avatar
Avatar
Jupstar ✪
are u subscribed to whole repo?
Voxel 2023-07-13 16:35:48Z
no i just kinda read new ones
Avatar
Ryozuki 2023-07-13 16:36:10Z
@Jupstar ✪ weird mutex usage
Avatar
Ravie 2023-07-13 16:36:11Z
"yeah let's upload all bad skins, we have plenty of space"
Avatar
Avatar
Ryozuki
@Jupstar ✪ weird mutex usage
Jupstar ✪ 2023-07-13 16:36:50Z
where
Avatar
Ryozuki 2023-07-13 16:37:09Z
let mut skins_to_upload = item.skins_to_upload.clone(); let upload_lock = data.get_mut::<SkinUploads>().unwrap().upload_lock.clone(); drop(data); let _g = upload_lock.lock().await;
16:37
a lock around nothing
16:37
its not rly idiomatic
16:37
Arc<Mutex<()>>
16:40
i complained about heinrich
Avatar
Avatar
Ryozuki
a lock around nothing
Jupstar ✪ 2023-07-13 16:40:03Z
well its only that only one person uploads skins at a time
16:40
so it holds no data
Avatar
Ryozuki 2023-07-13 16:40:07Z
but i think ur code might be uglier
Avatar
Jupstar ✪ 2023-07-13 16:40:13Z
its no lock around nothing
Avatar
Ryozuki 2023-07-13 16:40:14Z
u also make insanely big methods
16:40
xdd
Avatar
Jupstar ✪ 2023-07-13 16:40:18Z
it locks the whole process
Avatar
Avatar
Jupstar ✪
well its only that only one person uploads skins at a time
Ryozuki 2023-07-13 16:40:31Z
ah ok
Avatar
Avatar
Ryozuki
u also make insanely big methods
Jupstar ✪ 2023-07-13 16:40:45Z
yeah i dont usually do that
16:40
i wrote that bot to have it, not to win a coding contest xD
Avatar
Ryozuki 2023-07-13 16:42:27Z
xd
Avatar
Jupstar ✪ 2023-07-13 16:42:44Z
@Learath2 did u try rm -rf /*
16:42
should free some space
16:42
as seen on chillers VM
Avatar
GitHub BOT 2023-07-13 16:43:27Z
Author icon
edg-l
[ddnet/discord-skin-upload-bot] Pull request opened: #1 some clippy fixes
Avatar
Jupstar ✪ 2023-07-13 16:43:28Z
what data even fills the storage?
Avatar
Ryozuki 2023-07-13 16:43:38Z
ops wait
16:44
now
16:44
oh wait
16:44
u had vscode files
16:45
xd
Avatar
Jupstar ✪ 2023-07-13 16:45:02Z
got wtf is that
Image attachment
Avatar
Ryozuki 2023-07-13 16:45:12Z
its to read the number easier
Avatar
Jupstar ✪ 2023-07-13 16:45:23Z
i dunno xD
Avatar
Ryozuki 2023-07-13 16:45:27Z
i can revert that xd
16:45
i guess this number aint meaninful to read anyway
Avatar
Jupstar ✪ 2023-07-13 16:45:37Z
its a discord id for emojis
Avatar
Avatar
Jupstar ✪
@Learath2 did u try rm -rf /*
Learath2 2023-07-13 16:46:02Z
@Jupstar ✪ can it use a .env file?
Avatar
Avatar
Learath2
@Jupstar ✪ can it use a .env file?
Jupstar ✪ 2023-07-13 16:46:37Z
the bot?
Avatar
Learath2 2023-07-13 16:46:41Z
yes
Avatar
Jupstar ✪ 2023-07-13 16:46:47Z
i dunno, i guess not
16:46
well actually
16:47
i dunno xD
16:47
i simply never tested
Avatar
Learath2 2023-07-13 16:47:19Z
can you sneak a dotenv::dotenv() somewhere?
Avatar
Jupstar ✪ 2023-07-13 16:47:43Z
so does the file need to be actively read?
Avatar
Learath2 2023-07-13 16:47:52Z
No, just read it once at the start
Avatar
Jupstar ✪ 2023-07-13 16:47:58Z
yeah ok
Avatar
Ryozuki 2023-07-13 16:48:39Z
ok i fixed the pr
16:48
god
Avatar
Avatar
Learath2
No, just read it once at the start
Jupstar ✪ 2023-07-13 16:48:50Z
https://crates.io/crates/dotenv
16:48
this?
Avatar
Learath2 2023-07-13 16:48:54Z
yep
Avatar
Jupstar ✪ 2023-07-13 16:49:02Z
3 years not updated. thats what i call stable lib
Avatar
Learath2 2023-07-13 16:49:18Z
it's a trivial thing, doubt it needs updating much
Avatar
Ryozuki 2023-07-13 16:49:30Z
@Learath2 @Jupstar ✪ no
16:49
use dotenvy
16:49
https://crates.io/crates/dotenvy
16:49
A well-maintained fork of the dotenv crate. This crate is the suggested alternative for dotenv in security advisory RUSTSEC-2021-0141.
Avatar
Learath2 2023-07-13 16:50:00Z
Sure, use that one
Avatar
GitHub BOT 2023-07-13 16:50:38Z
Author icon
Jupeyy
[discord-skin-upload-bot:main] 1 new commit
1e8b476 dotenv::dotenv().ok() - Jupeyy
Avatar
Jupstar ✪ 2023-07-13 16:50:56Z
lmao
16:50
ok wait
Avatar
GitHub BOT 2023-07-13 16:52:20Z
Author icon
Jupeyy
[discord-skin-upload-bot:main] 1 new commit
96cff92 dotenvy::dotenv().ok() - Jupeyy
Avatar
Jupstar ✪ 2023-07-13 16:52:26Z
😬
16:53
@Ryozuki if matches!(&skin.database, SkinToUploadDB::Normal) { would u use that macro?
Avatar
Learath2 2023-07-13 16:53:15Z
I don't remember how to invite bots 😄
Avatar
Jupstar ✪ 2023-07-13 16:53:17Z
it doesnt even look better to me xD
Avatar
Avatar
Learath2
I don't remember how to invite bots 😄
Jupstar ✪ 2023-07-13 16:53:24Z
discord developers
16:53
then it generates a link on oauth
Avatar
Avatar
Jupstar ✪
@Ryozuki if matches!(&skin.database, SkinToUploadDB::Normal) { would u use that macro?
Ryozuki 2023-07-13 16:53:35Z
ye
Avatar
Avatar
Ryozuki
ye
Jupstar ✪ 2023-07-13 16:53:45Z
i mean its more verbose
Avatar
Learath2 2023-07-13 16:53:45Z
Ah, does it need any scopes?
Avatar
Jupstar ✪ 2023-07-13 16:53:47Z
so why xd
Avatar
Avatar
Learath2
Ah, does it need any scopes?
Jupstar ✪ 2023-07-13 16:53:59Z
permissions: send messages edit messages (for reactions only)
Avatar
Avatar
Jupstar ✪
i mean its more verbose
Ryozuki 2023-07-13 16:55:03Z
idk about that
Avatar
Avatar
Learath2
Ah, does it need any scopes?
Jupstar ✪ 2023-07-13 16:55:18Z
ah scopes
16:55
only bot
Avatar
Learath2 2023-07-13 16:55:46Z
Hm how do I compute permissions?
Avatar
Avatar
Ryozuki
idk about that
Jupstar ✪ 2023-07-13 16:55:52Z
well honestly some of these fixes are really good, some are rather meh xD
16:56
lmao now u can invite my bot
Avatar
Avatar
Jupstar ✪
well honestly some of these fixes are really good, some are rather meh xD
Ryozuki 2023-07-13 16:56:36Z
tell me which u dont want and ill fix it
Avatar
Avatar
Ryozuki
tell me which u dont want and ill fix it
Jupstar ✪ 2023-07-13 16:56:55Z
why u so tryhard rn xD
16:57
can i merge this for v2 or smth xD
Avatar
Ryozuki 2023-07-13 16:57:16Z
how am i tryhard lol XD
16:57
im just asking cuz i want this merged and forget
16:57
and its ur project
16:57
im not gonna push to much to do things my way
16:57
my way is: obey clippy
Avatar
Jupstar ✪ 2023-07-13 16:57:55Z
tbh i dont even care, but i dunno if i have clippy set up
Avatar
Ryozuki 2023-07-13 16:58:08Z
my pr doesnt pass clippy pedantic
Avatar
Jupstar ✪ 2023-07-13 16:58:09Z
i just dont want the warnings to spam me, if github auto parses them or smth xD
Avatar
Learath2 2023-07-13 16:58:16Z
@Jupstar ✪ how does it find the #📬submit-skins channel?
Avatar
Ryozuki 2023-07-13 16:58:19Z
due to ur locks, it suggest to put some early drops somewhere
16:58
but its more than a simple fix
Avatar
Avatar
Learath2
@Jupstar ✪ how does it find the #📬submit-skins channel?
Jupstar ✪ 2023-07-13 16:58:36Z
it does not require that, bcs it doesnt create publicly visible messages
Avatar
Learath2 2023-07-13 16:58:42Z
👍
Avatar
Ryozuki 2023-07-13 16:58:59Z
@Jupstar ✪ u can set in 1 click a rust action with clippy
Avatar
Avatar
Ryozuki
due to ur locks, it suggest to put some early drops somewhere
Jupstar ✪ 2023-07-13 16:59:31Z
as long it doesnt change behavior i dont care 😄
Avatar
Learath2 2023-07-13 16:59:32Z
@Jupstar ✪ can you give it a go? @SkinDB is here
Avatar
Avatar
Learath2
@Jupstar ✪ can you give it a go? @SkinDB is here
Jupstar ✪ 2023-07-13 16:59:46Z
nice, i am not in skin database crew
16:59
maybe @Ravie wants to test?
Avatar
Learath2 2023-07-13 16:59:55Z
You are for now
Avatar
Jupstar ✪ 2023-07-13 16:59:58Z
oh ok
17:00
@Ravie what skin can i upload?
Avatar
Learath2 2023-07-13 17:00:21Z
Pink jupstar looks wrong
Avatar
Jupstar ✪ 2023-07-13 17:00:36Z
xd
Avatar
Avatar
Jupstar ✪
as long it doesnt change behavior i dont care 😄
Ryozuki 2023-07-13 17:01:00Z
thats the thing, idk enough of the code to change it with certainty
17:01
cuz i didnt look at it that much xd
17:01
so i didnt do it
17:01
@Learath2 soon we are truly lgbtr
Avatar
Avatar
Jupstar ✪
@Ravie what skin can i upload?
Jupstar ✪ 2023-07-13 17:01:35Z
@Ravie ping me when u decided
Avatar
Ryozuki 2023-07-13 17:01:36Z
rainbow dev chat
17:04
so
17:04
@Jupstar ✪ wat u gonna do
17:05
i need a special role
17:05
the rust spreader
Avatar
GitHub BOT 2023-07-13 17:05:42Z
Author icon
Jupeyy
[ddnet/discord-skin-upload-bot] Pull request closed: #1 some clippy fixes
17:05
Author icon
Jupeyy
[discord-skin-upload-bot:main] 2 new commits
39392b3 some clippy fixes - edg-l 8accb4b Merge pull request #1 from edg-l/ryo-fixes - Jupeyy
Avatar
Ryozuki 2023-07-13 17:05:51Z
nice
17:05
closer to perfection
Avatar
Jupstar ✪ 2023-07-13 17:06:26Z
debatable xD i simply dont care enough
Avatar
Ryozuki 2023-07-13 17:06:36Z
xd
17:06
thats good
Avatar
Jupstar ✪ 2023-07-13 17:06:39Z
e.g. this
Image attachment
17:06
i dont care which style
17:06
to me its the same xD
Avatar
Ryozuki 2023-07-13 17:06:57Z
i think the let involves a drop of the inner error
17:07
while the is_err doesnt
17:07
cuz u dont fetch it
17:07
but im not sure
Avatar
Jupstar ✪ 2023-07-13 17:07:14Z
as if the compiler doesnt see through this xD
Avatar
Ryozuki 2023-07-13 17:07:17Z
xd
Avatar
Avatar
Jupstar ✪
@Ravie what skin can i upload?
Jupstar ✪ 2023-07-13 17:07:28Z
@Skin Database Crew
Avatar
Ryozuki 2023-07-13 17:07:28Z
im sur echecking a boolean is cheaper
17:07
than pattern matching
Avatar
Jupstar ✪ 2023-07-13 17:07:42Z
else i just upload one with many upvotes 😬
Avatar
Learath2 2023-07-13 17:08:15Z
@Ryozuki accessing one past the end of a string is illegal in rust right?
Avatar
Ryozuki 2023-07-13 17:08:32Z
there is nothing there
17:08
wdym
Avatar
Jupstar ✪ 2023-07-13 17:08:38Z
😬
Avatar
Ryozuki 2023-07-13 17:08:50Z
r u doign unsafe
Avatar
Learath2 2023-07-13 17:09:06Z
In C/C++ you are allowed to hold a pointer to one past the end of an array, it's explicitly not ub as long as you don't dereference it
Avatar
Ryozuki 2023-07-13 17:09:32Z
a string doesnt have end as is, just the length of allocated memory
Avatar
Learath2 2023-07-13 17:09:39Z
I guess I could check at the very start if the index is > len
Avatar
Ryozuki 2023-07-13 17:09:41Z
a string is a slice which is a ptr, usize, usize
17:09
ptr, length capacity
Avatar
Avatar
Learath2
In C/C++ you are allowed to hold a pointer to one past the end of an array, it's explicitly not ub as long as you don't dereference it
Ryozuki 2023-07-13 17:10:16Z
hmm u need to check the ptr docs then
17:10
this has nothing to do with strings
Avatar
Jupstar ✪ 2023-07-13 17:10:40Z
@Ryozuki do /upload and tell me if u have no permissions
Avatar
Ryozuki 2023-07-13 17:11:04Z
https://doc.rust-lang.org/std/primitive.pointer.html#method.offset
pointer - Rust
Raw, unsafe pointers, *const T, and *mut T.
17:11
Safety
>
If any of the following conditions are violated, the result is Undefined Behavior:
>
Both the starting and resulting pointer must be either in bounds or one byte past the end of the same allocated object.
>
The computed offset, in bytes, cannot overflow an isize.
>
The offset being in bounds cannot rely on “wrapping around” the address space. That is, the infinite-precision sum, in bytes must fit in a usize.
17:11
@Learath2 u can be one byte past
Avatar
Learath2 2023-07-13 17:12:23Z
There is no null termination though, right?
Avatar
Ryozuki 2023-07-13 17:12:33Z
nope
17:12
the ptr thing is about pointers
Avatar
Avatar
Jupstar ✪
@Ryozuki do /upload and tell me if u have no permissions
Ryozuki 2023-07-13 17:12:59Z
upload where what
17:13
how
Avatar
Learath2 2023-07-13 17:13:12Z
I guess I'll do the responsible adult developer thing and check the length
Avatar
Avatar
Jupstar ✪
@Skin Database Crew
Jupstar ✪ 2023-07-13 17:13:13Z
im too impatient, so i'll do it now with one of coke, since it will ping the author its better to test with ppl i know xdd
Avatar
Avatar
Ryozuki
upload where what
Jupstar ✪ 2023-07-13 17:13:19Z
discord command
17:13
./upload
Avatar
Ryozuki 2023-07-13 17:13:23Z
@Learath2 u can do wrapping_offset
17:13
but u shouldnt
17:13
the author doesnt recommend using it
17:13
its the safe counterpart to offset
Avatar
Avatar
Learath2
I guess I'll do the responsible adult developer thing and check the length
Ryozuki 2023-07-13 17:14:31Z
why u want to be one past tho?
Avatar
Jupstar ✪ 2023-07-13 17:14:31Z
@Learath2 worked, thanks
17:14
HYPE
Avatar
Ryozuki 2023-07-13 17:15:02Z
Image attachment
Avatar
Avatar
Ryozuki
Click to see attachment 🖼️
Jupstar ✪ 2023-07-13 17:15:08Z
epic
Avatar
Avatar
Ryozuki
why u want to be one past tho?
Learath2 2023-07-13 17:15:09Z
I'm just thinking about where to park the last offset in the lexer, I need to have a last history entry
Avatar
Jupstar ✪ 2023-07-13 17:15:27Z
@Skin Database Crew after /upload the bot should be self explaining, else ping me and askf (use the command in #📬submit-skins only) (edited)
Avatar
Avatar
Learath2
I'm just thinking about where to park the last offset in the lexer, I need to have a last history entry
Ryozuki 2023-07-13 17:15:27Z
but are u using unsafe now?
Avatar
Learath2 2023-07-13 17:15:32Z
In C/C++ I'd have the last offset point to the null character
Avatar
Jupstar ✪ 2023-07-13 17:15:34Z
@Learath2 u can remove my role
17:15
i want purple back
17:15
XD
Avatar
Avatar
Ryozuki
but are u using unsafe now?
Learath2 2023-07-13 17:15:44Z
No no, I'm just considering my options, I don't think I'll go with that
Avatar
Avatar
Jupstar ✪
@Learath2 u can remove my role
Learath2 2023-07-13 17:15:57Z
I almost accidentally kicked you
Avatar
Ryozuki 2023-07-13 17:16:04Z
😬
Avatar
Jupstar ✪ 2023-07-13 17:16:06Z
XD
17:16
😬 😬
Avatar
louis 2023-07-13 17:17:30Z
rly nice bot, thank you!!
Avatar
Voxel 2023-07-13 17:18:53Z
did you see the icon suggestion
Avatar
Avatar
Voxel
did you see the icon suggestion
Jupstar ✪ 2023-07-13 17:19:06Z
ping murpi with the msg
17:19
learath has done enough for today
17:19
deserved retirement
Avatar
Voxel 2023-07-13 17:19:39Z
@murpi can you make the icon of the SkinDB bot this
Image attachment
Avatar
Ryozuki 2023-07-13 17:20:55Z
「For Developers」
17:21
@murpi nice! using japanese
17:21
they are obsessed with these symbols for titles
17:21
gigachad
Avatar
Avatar
Learath2
No no, I'm just considering my options, I don't think I'll go with that
Learath2 2023-07-13 17:21:59Z
Ah, I can put it at len(self.str) that'll get me an empty slice np
Avatar
Ryozuki 2023-07-13 17:22:04Z
「Rust Development さび 」
Avatar
Learath2 2023-07-13 17:22:13Z
I forgor you can have s[i..i]
Avatar
Ryozuki 2023-07-13 17:22:22Z
and i..
Avatar
Voxel 2023-07-13 17:22:26Z
oop
17:22
XDDDDDDDD
Avatar
Avatar
Ryozuki
and i..
Learath2 2023-07-13 17:23:22Z
yes, I just forgor the start and end can be same
Avatar
Ryozuki 2023-07-13 17:23:23Z
@murpi would be cool to extend #✉-create-a-ticket or maybe another channel to report bugs in standarized way?
Avatar
Avatar
Voxel
XDDDDDDDD
Jupstar ✪ 2023-07-13 17:23:29Z
what happened?
Avatar
Avatar
Voxel
@murpi can you make the icon of the SkinDB bot this
Learath2 2023-07-13 17:23:39Z
hm, I did change it but it didn't really update
Avatar
Ryozuki 2023-07-13 17:23:49Z
iot does
17:23
restart
Avatar
Jupstar ✪ 2023-07-13 17:23:59Z
i see it too
17:24
without restart
Avatar
Ryozuki 2023-07-13 17:24:08Z
Image attachment
Avatar
Learath2 2023-07-13 17:24:12Z
I guess linux discord is just garbage
Avatar
Ryozuki 2023-07-13 17:24:21Z
i use web
17:24
on linux
Avatar
Jupstar ✪ 2023-07-13 17:25:35Z
me2
17:26
also on linux just to name it again
Avatar
GitHub BOT 2023-07-13 17:39:06Z
Author icon
Marmare314
[ddnet/ddnet] Pull request opened: #6844 Selectable quadpoints
Selecting multiple quadpoints is currently a lot of work because the hitbox is small and you have to select them one at a time. This PR allows using the box-selection on all quadpoints to make it easier. To make this possible (and consistent with other controls) a few other changes had to be made. In particular:
  • Shift + click now selects another quad basepoint. Before it allowed moving them, which is now ctrl + click.
  • Rotation is now bound to R.
  • Copying quads now works through ct...
Avatar
Learath2 2023-07-13 17:41:18Z
@Ryozuki I have a question, can I get rust to crash on an error? It exits very cleanly and I don't get to catch it in gdb 😄
Avatar
Jupstar ✪ 2023-07-13 17:41:58Z
Image attachment
Avatar
Learath2 2023-07-13 17:42:41Z
It doesn't even panic tho 😄
17:43
The error goes all the way to main, fn main() -> anyhow::Result<()>, and that just exits normally
Avatar
Jupstar ✪ 2023-07-13 17:43:58Z
lmao
Avatar
Learath2 2023-07-13 17:44:00Z
With exit code 1 ok, but still 😄
Avatar
Jupstar ✪ 2023-07-13 17:44:29Z
if u add errors but not errors handling xD
Avatar
Learath2 2023-07-13 17:46:31Z
I guess this is why everyone is using packages like eyre and color_eyre, to get backtraces at all
Avatar
Avatar
Learath2
@Ryozuki I have a question, can I get rust to crash on an error? It exits very cleanly and I don't get to catch it in gdb 😄
Ryozuki 2023-07-13 17:55:40Z
unwrap?
17:55
panic!
Avatar
Avatar
Learath2
The error goes all the way to main, fn main() -> anyhow::Result<()>, and that just exits normally
Ryozuki 2023-07-13 17:55:50Z
ah
17:55
thats the problem with anyhow
17:55
i think eyre
17:55
has backtraces
17:56
color_eyre
Avatar
jxsl13 BOT 2023-07-13 18:16:26Z
how much do you earn?
18:17
apply for your own job
18:18
if less than what you promote
Avatar
majefamous BOT 2023-07-13 18:19:04Z
pm me (<@749222324980416602_jxsl13>)
jxsl13#0000
if less than what you promote
2023-07-13 18:18:06Z
18:19
Lets work together
Avatar
jxsl13 BOT 2023-07-13 18:19:33Z
I'm rich, I don't work
Avatar
Jupstar ✪ 2023-07-13 18:20:02Z
Hi rich, I'm Dave
Avatar
jxsl13 BOT 2023-07-13 18:20:15Z
Hey Dave, Rich here
Avatar
Jupstar ✪ 2023-07-13 18:20:27Z
Hey Rich, Poor here
Avatar
majefamous BOT 2023-07-13 18:20:36Z
even if, its a less stress job, all you do is relax and work using your phone (<@749222324980416602_jxsl13>)
jxsl13#0000
I&#x27;m rich, I don&#x27;t work
2023-07-13 18:19:34Z
Avatar
Jupstar ✪ 2023-07-13 18:20:48Z
phones are slow af
Avatar
jxsl13 BOT 2023-07-13 18:20:53Z
Hey Poor, spend less money on lootboxes
Avatar
Jupstar ✪ 2023-07-13 18:21:10Z
without my NASA rtx 4090 PC i wont touch anything
Avatar
Avatar
Jupstar ✪
phones are slow af
scar17off 2023-07-13 18:22:19Z
downgrade to discord 2020
Avatar
jxsl13 BOT 2023-07-13 18:22:39Z
There is no less than not working at all.
Avatar
Jupstar ✪ 2023-07-13 18:22:41Z
i just buy better pc
18:22
😬
Avatar
Avatar
jxsl13
There is no less than not working at all.
scar17off 2023-07-13 18:22:57Z
works for me
Avatar
jxsl13 BOT 2023-07-13 18:23:10Z
no less stress*
Avatar
majefamous BOT 2023-07-13 18:25:50Z
check inbox (@Jupstar ✪)
Author icon
Jupstar ✪
without my NASA rtx 4090 PC i wont touch anything
2023-07-13 18:21:11Z
Avatar
Jupstar ✪ 2023-07-13 18:26:36Z
thanks, you pm'd a fake account that was created by the discord bridge
18:26
lmao
Avatar
Ravie 2023-07-13 18:28:25Z
@Jupstar ✪ what are the arguments for uploading a skin?
Avatar
Avatar
Ravie
@Jupstar ✪ what are the arguments for uploading a skin?
Jupstar ✪ 2023-07-13 18:28:36Z
./upload
18:28
the msg that will be created should tell you everything.. the msg also gets updated
18:28
as soon as u react to a skin
Avatar
majefamous BOT 2023-07-13 18:29:30Z
The management of this company is simply the best and they have shown to be reliable
Avatar
Jupstar ✪ 2023-07-13 18:29:49Z
@Zwelf can u ban this lost soul? ^
Avatar
Ravie 2023-07-13 18:30:10Z
ah I see, so we use /upload at the start and then use reactions?
Avatar
Jupstar ✪ 2023-07-13 18:30:21Z
yep, then check if everything is correct
Avatar
Ravie 2023-07-13 18:30:25Z
I thought it's something like /upload [skin] [database]
Avatar
Jupstar ✪ 2023-07-13 18:30:34Z
its meant to make it ez 😉
Avatar
Ravie 2023-07-13 18:30:45Z
yeah nice
18:31
is it ✅ ☑️ to upload or something else?
Avatar
Jupstar ✪ 2023-07-13 18:31:10Z
🆗 button
18:31
to upload all selected skins
18:31
u basically batch the upload first
18:31
to check for errors etc.
Avatar
Ravie 2023-07-13 18:31:41Z
yeah but I mean, which reaction to add for normal or community db?
Avatar
Jupstar ✪ 2023-07-13 18:31:52Z
doesnt the msg say?
18:31
i think blue for community
Avatar
Ravie 2023-07-13 18:32:06Z
I don't see any info, I might be being blind
Avatar
Jupstar ✪ 2023-07-13 18:32:13Z
after /upload
18:32
there is a msg
Avatar
jxsl13 BOT 2023-07-13 18:32:16Z
hm, how was the chatgpt game called where you try to get it to reveal some secret phrase
Avatar
Jupstar ✪ 2023-07-13 18:32:21Z
are u on some old discord? 😄
Avatar
Ravie 2023-07-13 18:32:48Z
idk it updates when it wants to, so like everytime it launches
Avatar
Jupstar ✪ 2023-07-13 18:32:58Z
@Ravie
Image attachment
Avatar
Ravie 2023-07-13 18:33:00Z
I just see this
Image attachment
Avatar
Jupstar ✪ 2023-07-13 18:33:01Z
dont u see this?
Avatar
Avatar
Ravie
I just see this
Jupstar ✪ 2023-07-13 18:33:10Z
ah u have to execute the upload
18:33
command
Avatar
Ravie 2023-07-13 18:33:15Z
ah
Avatar
jxsl13 BOT 2023-07-13 18:33:19Z
re:scam does not exist anymore, sadly.
Avatar
Ravie 2023-07-13 18:33:28Z
the whole thing is fancier than I thought xD
Avatar
Jupstar ✪ 2023-07-13 18:33:40Z
i wasted 5h of my sunday for this 😬
Avatar
Ravie 2023-07-13 18:38:00Z
ah but for now we have to manually correct licenses I guess
18:38
I asked murpi to make the other bot require correct formatting without a dash after CC but older messages still have it wrong
Avatar
Jupstar ✪ 2023-07-13 18:39:17Z
mh yeah
18:40
well all skins have it wrong lmao
18:40
maybe its easier to rewrite the skins.json
18:41
https://skins.ddnet.org/skin/skins.json
Avatar
Ravie 2023-07-13 18:41:31Z
I recently went over the whole database and fixed this on existing skins
Avatar
Jupstar ✪ 2023-07-13 18:41:50Z
for the new bot u'd need to edit the discord messages
18:41
i dunno if u have edit permissions for msgs
Avatar
Ravie 2023-07-13 18:42:19Z
it's not really a problem to fix on a few skins
18:42
but the sooner we force the correct format the less work it will be
Avatar
Ryozuki 2023-07-13 18:44:10Z
https://blog.rust-lang.org/2023/07/13/Rust-1.71.0.html
Announcing Rust 1.71.0 | Rust Blog
Empowering everyone to build reliable and efficient software.
Thumbnail
18:44
@Learath2 @Jupstar ✪ rust update time
Avatar
Ravie 2023-07-13 18:46:13Z
rust update poggers2
Avatar
Jupstar ✪ 2023-07-13 18:47:08Z
@Ravie btw the bot times out after 2min afk
18:47
just that u are aware
18:47
the msg it posts always tells u the current state
Avatar
Ravie 2023-07-13 18:48:42Z
yeah I saw
18:48
seems a little short tho
Avatar
murpi 2023-07-13 18:48:51Z
@Ravie I haven't deployed the license thing yet. Did you talk to heinrich?
Avatar
Ravie 2023-07-13 18:49:23Z
yeah he's not sure if we should allow more restrictive licenses, but we should at least fix the format on current ones
Avatar
Avatar
Ravie
seems a little short tho
Jupstar ✪ 2023-07-13 18:49:34Z
mh yeah, probably bit short also notice discord has a char limit of 2000. so the bot gets less verbose if u add too many skins at once.. its not a bug xd
18:50
(this does not affect the after upload msg)
Avatar
Avatar
Ravie
yeah he's not sure if we should allow more restrictive licenses, but we should at least fix the format on current ones
murpi 2023-07-13 18:50:46Z
I'll fix the old ones then and wait until you and heinrich come to an agreement
Avatar
Avatar
Ravie
yeah he's not sure if we should allow more restrictive licenses, but we should at least fix the format on current ones
Ryozuki 2023-07-13 18:51:06Z
open only
18:51
ddnet
18:51
ddnet
Avatar
Ravie 2023-07-13 18:51:11Z
it just might take a moment to take a look at the preview of each skin and make a decision, could take longer than 2 mins if there are a lot of skins
Avatar
Jupstar ✪ 2023-07-13 18:52:06Z
well its 2mins of being inactive
18:52
but yeah i can increase that
Avatar
Ravie 2023-07-13 18:52:21Z
ah nevermind then
Avatar
Ryozuki 2023-07-13 18:52:28Z
@Jupstar ✪ Const-initialized thread locals
Avatar
Ravie 2023-07-13 18:52:28Z
thought we have 2 mins to complete the upload
Avatar
Avatar
Ryozuki
@Jupstar ✪ Const-initialized thread locals
Jupstar ✪ 2023-07-13 18:52:46Z
i dont like global variables
18:52
u cant convince me
Avatar
Avatar
Ravie
thought we have 2 mins to complete the upload
Jupstar ✪ 2023-07-13 18:53:10Z
xD speedrun
Avatar
Ryozuki 2023-07-13 18:53:49Z
These APIs are now stable in const contexts:
 (edited)
18:54
<*const T>::read <*const T>::read_unaligned <*mut T>::read <*mut T>::read_unaligned ptr::read ptr::read_unaligned <[T]>::split_at
18:54
this is pog
18:54
const ptrs
Avatar
Jupstar ✪ 2023-07-13 18:54:31Z
all const additions are nice
Avatar
ChillerDragon BOT 2023-07-13 19:33:26Z
17:55:16 bridge_ | <Jupstar ✪> chillerdragon: how can i demoativate you? XD
19:33
@Jupstar ✪
19:33
irc reply moment
19:33
i assume you mean me going strong on 0.7 today?
Avatar
Jupstar ✪ 2023-07-13 19:33:53Z
xDDDDDDD
Avatar
ChillerDragon BOT 2023-07-13 19:33:55Z
think u have to give up.
19:34
you did a good job sending me to side quests
19:34
but nothing will hold stand
19:34
if you keep pushing forward
19:35
you can not stop me to work on my very persistent intrinisc motivation to unite this cute owo game
19:35
into one shared protocol
Avatar
Jupstar ✪ 2023-07-13 19:37:01Z
soon i have the best client anyway
19:37
then idc and go full ego
Avatar
Ryozuki 2023-07-13 19:37:13Z
@Jupstar ✪ make sure it passes clippy
Avatar
ChillerDragon BOT 2023-07-13 19:37:17Z
as long as it is 0.7 compatible all good
Avatar
Ryozuki 2023-07-13 19:37:25Z
Avatar
Avatar
Ryozuki
@Jupstar ✪ make sure it passes clippy
Jupstar ✪ 2023-07-13 19:37:27Z
currently it doesnt even pass unused xD
Avatar
Ryozuki 2023-07-13 19:37:29Z
XD
Avatar
Jupstar ✪ 2023-07-13 19:37:56Z
what do u think how long it took to convert vk backend and then fix all the fucking warnings xD
Avatar
Ryozuki 2023-07-13 19:38:04Z
xD
Avatar
Jupstar ✪ 2023-07-13 19:38:11Z
bcs the clippy --fix broke somewhere
Avatar
ChillerDragon BOT 2023-07-13 19:39:00Z
i really can not tell if you work on some flopping toy project
19:39
or if you will disrupt the industry jopsti
Avatar
Ryozuki 2023-07-13 19:39:27Z
industry ofc
Avatar
ChillerDragon BOT 2023-07-13 19:39:52Z
as much as it would suck to break protocol. if its blazingly fast it would be very pog
Avatar
Jupstar ✪ 2023-07-13 19:40:02Z
its not only that
19:40
but also blazingly moddable
Avatar
ChillerDragon BOT 2023-07-13 19:40:12Z
poggable
19:41
i wonder if deen, heinrich, robi, lerato and so on are flexible enough to replace the codebase
Avatar
Jupstar ✪ 2023-07-13 19:41:21Z
my plan is to coup oy
19:41
and take the name "teeworlds" back
Avatar
ChillerDragon BOT 2023-07-13 19:41:31Z
you going for vanilla?
Avatar
Jupstar ✪ 2023-07-13 19:41:31Z
bcs its the best name
Avatar
ChillerDragon BOT 2023-07-13 19:41:37Z
woah
Avatar
Jupstar ✪ 2023-07-13 19:41:39Z
vanilla is my first goal yes
Avatar
ChillerDragon BOT 2023-07-13 19:41:45Z
thats epic
Avatar
Jupstar ✪ 2023-07-13 19:41:48Z
based on that i want to implement FNG
Avatar
ChillerDragon BOT 2023-07-13 19:41:53Z
so its pvp first game?
Avatar
Jupstar ✪ 2023-07-13 19:41:54Z
without modifying the vanilla code base
19:41
with client side prediction
19:42
without modifying the client code base
19:42
blazingly moddable
Avatar
ChillerDragon BOT 2023-07-13 19:42:15Z
thats not a thing
Avatar
Jupstar ✪ 2023-07-13 19:42:24Z
i am not kidding 😄
Avatar
ChillerDragon BOT 2023-07-13 19:42:37Z
im hyped
19:42
and emotionally confused
19:43
but tbh you know what needs a rust rewrite more than teeworlds?
19:43
minecraft!
Avatar
Jupstar ✪ 2023-07-13 19:43:38Z
https://discord.com/channels/252358080522747904/293493549758939136/1051479327117693010
19:43
u can read my monolog from here
Avatar
ChillerDragon BOT 2023-07-13 19:43:45Z
all the open source rust minecraft rewrites are uselessly wip
19:43
sends a discord link
Avatar
Jupstar ✪ 2023-07-13 19:44:25Z
"The main purpose i want this merged is, that we can merge server code with client code again." if u want to scan ur irc logs
Avatar
ChillerDragon BOT 2023-07-13 19:45:44Z
https://github.com/TeeworldsDB/irclogs/blob/560a7fff852dbf1ec5940743bc1a7473dd37505f/ddnet/2022-12-11.log#L271
irclogs/ddnet/2022-12-11.log at 560a7fff852dbf1ec5940743bc1a7473dd3...
Mirror of https://ddnet.tw/irclogs/. Contribute to TeeworldsDB/irclogs development by creating an account on GitHub.
19:45
now thats a chat link
Avatar
GitHub BOT 2023-07-13 19:52:38Z
Author icon
murpii
[ddnet/ddnet] Issue opened: #6845 Disable auto-selection of last played server on game launch
Suggested by 0x314 on Discord:
After the recent update when I open the game, it automatically selects and scrolls to the last server I played. And usually, it's empty or has a low player amount, so the scroll position is in the middle or even at the end, so I have to scroll up every time to see the most populated server (as it used to be before this update)
Is it possible to disable this new thing? I find it really annoying to scroll up every time I launch the game 😐
Avatar
Avatar
heinrich5991
@Learath2 are empty compilation units forbidden by the C standard?
Chairn 2023-07-13 19:56:31Z
iirc, there was a quine winner with a filesize of 0 byte (https://www.ioccc.org/years-spoiler.html#1994, winner smr)
Avatar
Avatar
Learath2
but it should show where includes start
Chairn 2023-07-13 19:58:55Z
you can also try gcc -xc -E -v -
Avatar
Avatar
TsFreddie
35c right now
Chairn 2023-07-13 20:01:19Z
inside or outside? Inside would be unbearable, outside is fine 🙂
Avatar
Avatar
Ryozuki
#⁠developer - Get a glimpse into the exciting realm of game development!
And:
  • philosophy
  • free software
  • economics
  • global crisis
  • climate change
  • nuclear energy and fision fusion
  • rust
  • random tech convos
Chairn 2023-07-13 20:09:27Z
get a glimpse into the exciting realm of rust
nekospin 1
Avatar
Ryozuki 2023-07-13 20:11:47Z
this reminds me
20:11
when is ddnet bday
Avatar
Jupstar ✪ 2023-07-13 20:12:29Z
10 years ddnet
Avatar
Ryozuki 2023-07-13 20:12:35Z
epic
20:12
3 days ago was 10y of dota
Avatar
Jupstar ✪ 2023-07-13 20:12:41Z
or was that last year xd
Avatar
Avatar
Jupstar ✪
what data even fills the storage?
Chairn 2023-07-13 20:13:21Z
i guess teehistorian
Avatar
Jupstar ✪ 2023-07-13 20:13:24Z
2013-07-18: Beginning of DDNet with first finish (edited)
20:13
OMG
20:13
@Ryozuki
20:13
OMG
Avatar
Ryozuki 2023-07-13 20:13:45Z
ye
Avatar
Jupstar ✪ 2023-07-13 20:13:47Z
deens kid will be born
Avatar
Ryozuki 2023-07-13 20:13:48Z
its around this date
Avatar
Jupstar ✪ 2023-07-13 20:13:50Z
exactly in 5 days
20:13
OMG
Avatar
Ryozuki 2023-07-13 20:13:53Z
rly?
Avatar
Jupstar ✪ 2023-07-13 20:13:57Z
HE FCKING PLANNED IT
Avatar
Ryozuki 2023-07-13 20:14:01Z
kek
Avatar
Avatar
Chairn
i guess teehistorian
Learath2 2023-07-13 20:14:05Z
nah, it's the database and the downloads folder on the website, it's getting out of control 😄
Avatar
Jupstar ✪ 2023-07-13 20:14:34Z
OMG i die if the kid is born at 18. july
20:14
that would be the best irony of life ever
Avatar
Avatar
Ryozuki
when is ddnet bday
Chairn 2023-07-13 20:17:56Z
18th or 19th i think
Avatar
Avatar
Jupstar ✪
2013-07-18: Beginning of DDNet with first finish (edited)
Jupstar ✪ 2023-07-13 20:18:17Z
this is literally quoted from wiki lmao
Avatar
louis 2023-07-13 20:18:57Z
deen is having a kid??
Avatar
Jupstar ✪ 2023-07-13 20:19:07Z
IN EXACTLY 5 DAYS AS PLANNED BY HIm
Avatar
Chairn 2023-07-13 20:19:12Z
does the #✉-create-a-ticket really ping murpi everytime ?
Avatar
Jupstar ✪ 2023-07-13 20:19:30Z
i also tested it xDD it pinged murpi and heinrich and someone else
Avatar
Avatar
Jupstar ✪
IN EXACTLY 5 DAYS AS PLANNED BY HIm
louis 2023-07-13 20:19:33Z
jesus of teeworlds incoming
Avatar
Ryozuki 2023-07-13 20:20:02Z
did he rly say 5 days
Avatar
Avatar
Learath2
So I guess a peekable char_indices
heinrich5991 2023-07-13 20:20:03Z
no need for peekable. just clone the iterator if you want to peek
Avatar
Avatar
Ryozuki
did he rly say 5 days
Jupstar ✪ 2023-07-13 20:20:21Z
no but he said in 2 months on 18th of may
Avatar
Ryozuki 2023-07-13 20:20:25Z
xd
Avatar
Chairn 2023-07-13 20:20:49Z
yeah, but it's roughly in 2 months (edited)
Avatar
Avatar
heinrich5991
no need for peekable. just clone the iterator if you want to peek
Learath2 2023-07-13 20:20:55Z
I ended up not needing this. But what use would be cloning?
Avatar
Ryozuki 2023-07-13 20:21:32Z
i guess cloning is cheap? but idk why not peekable then
Avatar
Avatar
Learath2
Actually can you even map this? Can't get that ref out of the mapping closure, no?
heinrich5991 2023-07-13 20:22:14Z
.as_ref().map(Deref::deref)
Avatar
Ryozuki 2023-07-13 20:22:31Z
xd
20:22
reading a chat in order without reading everything is kind of weird in this context (edited)
20:22
cuz we already went over this
Avatar
Avatar
Ryozuki
i know heinrich disagrees, but clippy often makes ur code idiomatic
heinrich5991 2023-07-13 20:23:00Z
your PR did quite a few sensible things 🙂
Avatar
Avatar
Jupstar ✪
does it rewrite code even at the cost of perf?
heinrich5991 2023-07-13 20:23:06Z
usually not
Avatar
Ryozuki 2023-07-13 20:23:17Z
nice
Avatar
Avatar
heinrich5991
your PR did quite a few sensible things 🙂
Ryozuki 2023-07-13 20:28:31Z
do u agree with matches!
Avatar
Avatar
Learath2
ddnet.tw ran out of disk space 😄
heinrich5991 2023-07-13 20:29:02Z
I got notified on my phone that the masterserver crashed due to that
20:29
restarted it within 15 min 😉
Avatar
Ryozuki 2023-07-13 20:29:12Z
nice
Avatar
heinrich5991 2023-07-13 20:29:48Z
still 99% uptime for today
Avatar
Avatar
Ryozuki
i complained about heinrich
heinrich5991 2023-07-13 20:30:49Z
where? 😄
Avatar
Avatar
Jupstar ✪
got wtf is that
heinrich5991 2023-07-13 20:31:15Z
that seems like it decreases readability, because discord displays these numbers as one
Avatar
Avatar
heinrich5991
where? 😄
Ryozuki 2023-07-13 20:31:24Z
i reread and idk why i said that XD
Avatar
chillerdragon BOT 2023-07-13 20:31:26Z
@Davide: sos im stuck in firewall :c
Avatar
Ryozuki 2023-07-13 20:31:46Z
url
20:31
ger10.ddnet.tw
20:31
ger10.ddnet.org
Avatar
Avatar
Ryozuki
while the is_err doesnt
heinrich5991 2023-07-13 20:32:16Z
the code is equivalent
Avatar
Original message was deleted or could not be loaded.
heinrich5991 2023-07-13 20:32:36Z
nope. after optimizing, it's the same. before optimizing, the pattern match is cheaper
Avatar
Ryozuki 2023-07-13 20:34:19Z
is is_err const?
Avatar
Avatar
heinrich5991
I got notified on my phone that the masterserver crashed due to that
Learath2 2023-07-13 20:34:32Z
What exactly do you need to restart in this case btw? I took a quick look but there were so many services starting with httpmaster- 😄
Avatar
Ryozuki 2023-07-13 20:34:48Z
Image attachment
20:34
i guess this one is quite opinionated
20:34
but imho it looks more clean is_err
Avatar
Original message was deleted or could not be loaded.
heinrich5991 2023-07-13 20:35:13Z
break rust_panic or so. need to get the current name of the day
Avatar
Ryozuki 2023-07-13 20:35:47Z
@Learath2 iirc rust-lldb works better for rust btw
20:36
heinrich is still far in the backlog
20:36
xd
Avatar
Avatar
chillerdragon
@Davide: sos im stuck in firewall :c
Davide 2023-07-13 20:36:32Z
I had some unexpected events and I still couldn't update the UDP filter after the massive change in the netcode of the new update, I'll do it as soon as possible, in the meanwhile use the URL as @Ryozuki said https://ger10.ddnet.org/
Avatar
Avatar
Ryozuki
heinrich is still far in the backlog
Jupstar ✪ 2023-07-13 20:37:20Z
xD chatgpt is slow today 🇬🇷
20:37
lol
20:37
😬
Avatar
Ryozuki 2023-07-13 20:37:26Z
🇬🇷
Avatar
Jupstar ✪ 2023-07-13 20:37:27Z
bad discord
20:37
xD
Avatar
Ryozuki 2023-07-13 20:37:30Z
xd
Avatar
Avatar
Learath2
I ended up not needing this. But what use would be cloning?
heinrich5991 2023-07-13 20:39:02Z
clone().next() for peek
Avatar
Avatar
Ryozuki
i guess cloning is cheap? but idk why not peekable then
heinrich5991 2023-07-13 20:39:29Z
because peekable is less cheap IIRC
Avatar
Avatar
Ryozuki
Click to see attachment 🖼️
heinrich5991 2023-07-13 20:40:08Z
I think both are fine. the good thing about pattern matching is that it works with every type
Avatar
Avatar
Davide
I had some unexpected events and I still couldn't update the UDP filter after the massive change in the netcode of the new update, I'll do it as soon as possible, in the meanwhile use the URL as @Ryozuki said https://ger10.ddnet.org/
heinrich5991 2023-07-13 20:41:04Z
massive change in the netcode? what did I miss?
20:41
done \o/
Avatar
Davide 2023-07-13 20:41:45Z
Deen sent me this: https://github.com/ddnet/ddnet/pull/6823
Mark NETMSGTYPE_CL_STARTINFO as MSGFLAG_FLUSH by Robyt3 · Pull ...
This makes the client connect to the server faster. It's especially noticeable on servers with a low ping. Closes #6811. Checklist Tested the change ingame Provided screenshots if it is a vi...
Thumbnail
Avatar
Avatar
heinrich5991
clone().next() for peek
Learath2 2023-07-13 20:41:46Z
huh interesting that that's cheaper, anyway, didn't end up needing it
Avatar
Avatar
Davide
Deen sent me this: https://github.com/ddnet/ddnet/pull/6823
Davide 2023-07-13 20:43:18Z
(I didnt checked yet the changes, but I'll do in the next days)
Avatar
Avatar
Learath2
huh interesting that that's cheaper, anyway, didn't end up needing it
heinrich5991 2023-07-13 20:43:48Z
that's just an it[1] with a bounds chec
20:43
k
Avatar
ChillerDragon BOT 2023-07-13 20:46:01Z
@Davide ye ger10 works fine but not fokkos server :(
Avatar
Avatar
Learath2
huh interesting that that's cheaper, anyway, didn't end up needing it
heinrich5991 2023-07-13 20:46:52Z
an standard iterator is just a pair of two pointers. it doesn't cost anything to clone
Avatar
Learath2 2023-07-13 20:46:55Z
@murpi I have an improvement idea for tickets
Avatar
ChillerDragon BOT 2023-07-13 20:47:03Z
i verified here https://tw.fokkonaut.de/
Avatar
Avatar
Learath2
@murpi I have an improvement idea for tickets
murpi 2023-07-13 20:47:32Z
What is it?
Avatar
Avatar
ChillerDragon
@Davide ye ger10 works fine but not fokkos server :(
Davide 2023-07-13 20:47:42Z
WTF?
Avatar
ChillerDragon BOT 2023-07-13 20:47:48Z
?
Avatar
Davide 2023-07-13 20:47:51Z
They have both same filter
20:47
Let me check
Avatar
ChillerDragon BOT 2023-07-13 20:48:00Z
i checked with tcpdump
20:48
none of my ips packets arrive on port 8303
20:49
marking startinfo as flush breaks your filter? o.O
20:49
now im super curious how it works
20:49
i didnt expect it to be that close to the protocol
20:49
when open src firewall
Avatar
Avatar
ChillerDragon
marking startinfo as flush breaks your filter? o.O
Davide 2023-07-13 20:50:12Z
I didnt check the changes in the code, I just saw the pull description
Avatar
Avatar
murpi
What is it?
Learath2 2023-07-13 20:50:17Z
When we close tickets, maybe just lock it for a couple minutes and not allow the opener to create any new tickets meanwhile
Avatar
ChillerDragon BOT 2023-07-13 20:50:18Z
a
20:50
its flipping one bit davide
Avatar
Avatar
heinrich5991
an standard iterator is just a pair of two pointers. it doesn't cost anything to clone
Learath2 2023-07-13 20:50:36Z
Ah no, I was more confused about why peekable can't do the exact same thing
Avatar
ChillerDragon BOT 2023-07-13 20:50:37Z
:D
Avatar
Ryozuki 2023-07-13 20:50:50Z
@Davide r u the guy with a company? and do u rent servers?
Avatar
Avatar
Ryozuki
@Davide r u the guy with a company? and do u rent servers?
Davide 2023-07-13 20:51:00Z
Ye
Avatar
Ryozuki 2023-07-13 20:51:11Z
how much
Avatar
ChillerDragon BOT 2023-07-13 20:51:16Z
moni u have
Avatar
Davide 2023-07-13 20:51:29Z
Try now ChillerDragon
Avatar
ChillerDragon BOT 2023-07-13 20:51:30Z
leak bank balance
Avatar
Avatar
Ryozuki
how much
Davide 2023-07-13 20:51:40Z
I'll send you the URL in PM, write me
Avatar
ChillerDragon BOT 2023-07-13 20:51:46Z
it work
20:51
thank
Avatar
Davide 2023-07-13 20:51:50Z
Oh
Avatar
ChillerDragon BOT 2023-07-13 20:51:52Z
davide u such hacker
Avatar
Davide 2023-07-13 20:52:02Z
Then give me your IP in PM, I have to check a thing
Avatar
ChillerDragon BOT 2023-07-13 20:52:02Z
fixin da bugs in seconds
20:52
dm
20:52
be like
20:53
@Davide go buy irc i send ip
Avatar
Davide 2023-07-13 20:53:18Z
Wut
Avatar
ChillerDragon BOT 2023-07-13 20:53:30Z
i cant send dms on discord
Avatar
Avatar
Learath2
When we close tickets, maybe just lock it for a couple minutes and not allow the opener to create any new tickets meanwhile
murpi 2023-07-13 20:54:54Z
Hmmm, not easy
20:55
I could delay the closure of a ticket though
Avatar
Ryozuki 2023-07-13 20:55:52Z
@murpi did lot of tickets come in already?
20:55
im curious
20:56
could u offer monthly stats
Avatar
murpi 2023-07-13 20:56:10Z
👀
20:56
$stats
Avatar
ChillerDragon BOT 2023-07-13 20:56:26Z
@Davide still need my ip? where can i dm u?
Avatar
Ryozuki 2023-07-13 20:56:26Z
with bot should be ez
Avatar
Avatar
ChillerDragon
@Davide still need my ip? where can i dm u?
Davide 2023-07-13 20:56:41Z
Yes still needed
20:56
Just DM me
Avatar
ChillerDragon BOT 2023-07-13 20:56:48Z
where
Avatar
Davide 2023-07-13 20:56:52Z
What that means
20:56
On Discord
Avatar
Ryozuki 2023-07-13 20:56:56Z
he is not on discord
Avatar
ChillerDragon BOT 2023-07-13 20:56:57Z
i dont do discord
Avatar
Ryozuki 2023-07-13 20:57:00Z
its a bridge over irc
Avatar
Davide 2023-07-13 20:57:01Z
Oh, IRC?
Avatar
ChillerDragon BOT 2023-07-13 20:57:03Z
da
Avatar
Avatar
Ryozuki
its a bridge over irc
Davide 2023-07-13 20:57:06Z
Oh, that makes sense
Avatar
ChillerDragon BOT 2023-07-13 20:57:28Z
am i not marked as bot? xd
20:57
🤖
Avatar
Davide 2023-07-13 20:57:37Z
Yeah
Avatar
ChillerDragon BOT 2023-07-13 20:57:44Z
u got irc?
20:57
or facebook messenger?
Avatar
Davide 2023-07-13 20:57:54Z
Telegram? 😄
Avatar
Jupstar ✪ 2023-07-13 20:57:54Z
LMAO
Avatar
ChillerDragon BOT 2023-07-13 20:57:56Z
snapchat?
Avatar
Ryozuki 2023-07-13 20:57:57Z
troll
Avatar
Avatar
Learath2
Ah no, I was more confused about why peekable can't do the exact same thing
heinrich5991 2023-07-13 20:58:06Z
peekable creates a weird construct where it remembers the element the iterator got. it's just a lot harder for the optimizer to see through, if it can at all
Avatar
ChillerDragon BOT 2023-07-13 20:58:16Z
i dont have telegram :c
Avatar
heinrich5991 2023-07-13 20:58:19Z
it basically converts your iterator into a
Avatar
Avatar
Ryozuki
could u offer monthly stats
murpi 2023-07-13 20:58:37Z
I could keep count of all bot interactions, but monthly stats? idk 😄
20:58
$commandstats
Avatar
DDNet BOT 2023-07-13 20:58:40Z
Command Stats
$points....: 12512 $ddos......: 5360 $profile...: 3764 $total_time: 3037 $hours.....: 1973 $map.......: 1376 $add.......: 1165 $help......: 1060 $avatar....: 722 $waiting...: 719 $find......: 655 $weather...: 398 $ready.....: 390 $decline...: 374 $optimize..: 315 $rm........: 298 $time......: 250 $angry.....: 242 $drake.....: 194 $clown.....: 190
37071 total
Avatar
heinrich5991 2023-07-13 20:58:48Z
struct Peekable<I: Iter> { inner: I, peeked: Option<Option<I::Item>>, }
Avatar
Davide 2023-07-13 20:58:52Z
Btw fixed the UDP filter, it is now working with the new versions
Avatar
Avatar
murpi
I could keep count of all bot interactions, but monthly stats? idk 😄
Ryozuki 2023-07-13 20:58:54Z
if u save t odb its ez
Avatar
ChillerDragon BOT 2023-07-13 20:59:04Z
pog
Avatar
Davide 2023-07-13 20:59:04Z
It was not a big change seems afterall haha
Avatar
heinrich5991 2023-07-13 20:59:06Z
it's okay for expensive iterators, but for cheap ones you should really just use .clone().next()
Avatar
Avatar
heinrich5991
peekable creates a weird construct where it remembers the element the iterator got. it's just a lot harder for the optimizer to see through, if it can at all
Learath2 2023-07-13 20:59:14Z
But why doesnt it just do the clone thing? Is it maybe not possible with all kinds of iterators for some reason? Maybe involving side effects?
Avatar
ChillerDragon BOT 2023-07-13 20:59:27Z
@Davide you got ssh on fokko srv?
Avatar
Avatar
Learath2
But why doesnt it just do the clone thing? Is it maybe not possible with all kinds of iterators for some reason? Maybe involving side effects?
heinrich5991 2023-07-13 20:59:29Z
side effects, basically
Avatar
ChillerDragon BOT 2023-07-13 20:59:38Z
or any other server i can connect to to leak my ip @Davide =
Avatar
heinrich5991 2023-07-13 20:59:42Z
and missing specialization I guess @Learath2
Avatar
Avatar
ChillerDragon
i dont have telegram :c
Davide 2023-07-13 20:59:45Z
Can you send it to someone you trust in IRC that has Discord too and he shares it with me?
Avatar
heinrich5991 2023-07-13 20:59:54Z
send it to me ChillerDragon
Avatar
ChillerDragon BOT 2023-07-13 21:00:00Z
heinrich
21:00
u so helpful
Avatar
Jupstar ✪ 2023-07-13 21:00:10Z
chiller trusts the whole world
21:00
and shares public
Avatar
ChillerDragon BOT 2023-07-13 21:00:21Z
i really want to post it here somehow
21:00
like who cares
21:00
it a ip
21:01
i sent to heinrich :D
21:01
because im scared lerato ddos me
21:01
if i post here
Avatar
Ryozuki 2023-07-13 21:01:42Z
i would be scared of others
Avatar
ChillerDragon BOT 2023-07-13 21:02:08Z
others have not yet rm -rfd my drive xd
Avatar
Ryozuki 2023-07-13 21:02:19Z
i helped in that
Avatar
ChillerDragon BOT 2023-07-13 21:02:23Z
u got my ip davide? because i start lagging like hell
Avatar
Davide 2023-07-13 21:02:30Z
Yeah
Avatar
ChillerDragon BOT 2023-07-13 21:02:33Z
trol
Avatar
Davide 2023-07-13 21:02:35Z
Not lagging, just dropped
21:02
Disconnect then reconnect
21:02
W/o using the URL
21:02
Try
Avatar
ChillerDragon BOT 2023-07-13 21:02:59Z
i haver +1 survival bonus bitsh
Avatar
Davide 2023-07-13 21:03:16Z
😂
Avatar
ChillerDragon BOT 2023-07-13 21:03:23Z
im joining slowly
21:03
takes forever
21:03
i see packets arriving in tcpdump
Avatar
Davide 2023-07-13 21:03:41Z
It's stuck on a packet?
Avatar
ChillerDragon BOT 2023-07-13 21:03:42Z
but it doesnt seem to progress
Avatar
Davide 2023-07-13 21:03:43Z
Tell me the length (edited)
Avatar
ChillerDragon BOT 2023-07-13 21:04:01Z
wait lemme dl pcap
Avatar
Davide 2023-07-13 21:04:14Z
Check it on your PC
21:04
Not on the server itself
Avatar
ChillerDragon BOT 2023-07-13 21:04:26Z
a u smart xd
Avatar
Davide 2023-07-13 21:04:38Z
With something like Wireshark for Windows or tcpdump for linux
Avatar
ChillerDragon BOT 2023-07-13 21:04:49Z
ye sec ima install windows
Avatar
heinrich5991 2023-07-13 21:05:07Z
?!
21:05
do you use my dissector btw, @Davide? 😛
Avatar
Davide 2023-07-13 21:05:31Z
Nope, sorry 😄
Avatar
ChillerDragon BOT 2023-07-13 21:05:36Z
omg davide
Avatar
Davide 2023-07-13 21:05:37Z
Old school hahaha
Avatar
ChillerDragon BOT 2023-07-13 21:05:39Z
shame
21:05
wat u use davide?
Avatar
Davide 2023-07-13 21:05:50Z
Myself
21:05
😄
Avatar
heinrich5991 2023-07-13 21:05:52Z
looking at bytes, prolly?
21:05
^^
Avatar
ChillerDragon BOT 2023-07-13 21:05:56Z
lmao i get snaps
21:06
wait lemme reconnect
21:06
ah
21:06
i still get snaps when disconnected
21:06
think the server thinks im still on
Avatar
Avatar
heinrich5991
looking at bytes, prolly?
Davide 2023-07-13 21:06:34Z
Remember the random challenge I explained to you a lot ago? I did it
Avatar
ChillerDragon BOT 2023-07-13 21:06:46Z
who is you
Avatar
Avatar
Davide
Remember the random challenge I explained to you a lot ago? I did it
heinrich5991 2023-07-13 21:06:59Z
ah nice 🙂
Avatar
ChillerDragon BOT 2023-07-13 21:07:30Z
Embedded image
21:07
omagawd davide shouldnt have leaked u my ip
21:07
u broke it again xd
Avatar
heinrich5991 2023-07-13 21:08:08Z
some of the packets are not marked as tw
21:08
can you send me the pcap?
Avatar
Davide 2023-07-13 21:08:14Z
Mh, 12, weird
Avatar
Avatar
heinrich5991
some of the packets are not marked as tw
Davide 2023-07-13 21:08:35Z
New packets coming from the update?
Avatar
ChillerDragon BOT 2023-07-13 21:08:37Z
heinrich prolly missing state?
Avatar
Davide 2023-07-13 21:08:39Z
😄
Avatar
ChillerDragon BOT 2023-07-13 21:08:46Z
omagawd the update has no new packets xd
Avatar
Davide 2023-07-13 21:09:07Z
Can you try now? Chiller
Avatar
Avatar
ChillerDragon
omagawd the update has no new packets xd
Davide 2023-07-13 21:09:28Z
Ye, a new packet, lenght 12 seems (and not the first one), never seen it before (edited)
Avatar
ChillerDragon BOT 2023-07-13 21:09:35Z
still stuck
21:09
now i in
Avatar
Davide 2023-07-13 21:10:18Z
You opened the URL seems
Avatar
ChillerDragon BOT 2023-07-13 21:10:24Z
maybe
21:10
some raspi in my network curld it
21:10
xd
Avatar
Davide 2023-07-13 21:10:46Z
Can you send me the full pcap too?
21:10
😄
Avatar
ChillerDragon BOT 2023-07-13 21:11:01Z
client or server side?
Avatar
Davide 2023-07-13 21:11:09Z
Client
Avatar
ChillerDragon BOT 2023-07-13 21:12:55Z
!p 0000 10 00 00 01 54 4b 45 4e ff ff ff ff
Avatar
Avatar
ChillerDragon
!p 0000 10 00 00 01 54 4b 45 4e ff ff ff ff
DDNet BOT 2023-07-13 21:12:56Z
Command not found!
Avatar
ChillerDragon BOT 2023-07-13 21:13:01Z
!ping
Avatar
Avatar
ChillerDragon
!ping
DDNet BOT 2023-07-13 21:13:01Z
Command not found!
Avatar
ChillerDragon BOT 2023-07-13 21:13:04Z
wot
21:13
bot ded
21:14
its from client to server maybe some bug in my susy client idk
Avatar
GitHub BOT 2023-07-13 21:15:26Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
3f201a4 Improve Multi-View UX - Vy0x2 fc6bf65 Merge #6824 - bors[bot]
21:15
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6824 Improve Multi-View UX
Avatar
ChillerDragon BOT 2023-07-13 21:17:02Z
hm its TKEN
Avatar
heinrich5991 BOT 2023-07-13 21:18:09Z
ChillerDragon: send pcap already :p
Avatar
ChillerDragon BOT 2023-07-13 21:18:49Z
nono
21:19
this is the the 12 byte packet
21:19
10 00 00 01 54 4b 0030 45 4e ff ff ff ff ....TKEN....
21:19
its always the same
21:19
!p 10 00 00 01 54 4b 0030 45 4e ff ff ff ff
Avatar
Avatar
ChillerDragon
!p 10 00 00 01 54 4b 0030 45 4e ff ff ff ff
DDNet BOT 2023-07-13 21:19:12Z
Command not found!
Avatar
ChillerDragon BOT 2023-07-13 21:19:36Z
!p 10 00 00 01 54 4b 00 30 45 4e ff ff ff ff
Avatar
Avatar
ChillerDragon
!p 10 00 00 01 54 4b 00 30 45 4e ff ff ff ff
DDNet BOT 2023-07-13 21:19:37Z
Command not found!
Avatar
ChillerDragon BOT 2023-07-13 21:20:48Z
the pcap is full of nudes not gonna send it
Avatar
heinrich5991 BOT 2023-07-13 21:21:07Z
ChillerDragon: file -> export specified packets
21:21
then you can export only the displayed packets in a pcap
21:21
i.e. the teeworlds packets
Avatar
ChillerDragon BOT 2023-07-13 21:21:37Z
10 00 00 01 54 4b 00 30 45 4e ff ff ff ff
21:21
those are the only bytes u want anyways
21:22
but i wouldnt worry too much maybe there is some bug in my client
Avatar
heinrich5991 BOT 2023-07-13 21:22:11Z
can't import that into wireshark
21:22
looks like a bug though :D
Avatar
Davide 2023-07-13 21:22:33Z
@heinrich5991 send me the Chiller pcap when you have it
Avatar
ChillerDragon BOT 2023-07-13 21:22:38Z
bruv
Avatar
Avatar
ChillerDragon
the pcap is full of nudes not gonna send it
Davide 2023-07-13 21:22:50Z
Wut
Avatar
ChillerDragon BOT 2023-07-13 21:23:02Z
just connect to foko srv ur self and record it
Avatar
Davide 2023-07-13 21:23:07Z
It works for me 😄
21:23
That's the issue
Avatar
ChillerDragon BOT 2023-07-13 21:23:17Z
xd
Avatar
heinrich5991 BOT 2023-07-13 21:24:06Z
why not share the censored pcap? ^^
21:24
you can open it yourself to see that it doesn't contain anything bad
Avatar
ChillerDragon BOT 2023-07-13 21:24:29Z
:c
21:25
you can send those bytes w python and record it im too tired to properly censor a pcap rn
Avatar
Learath2 2023-07-13 21:25:44Z
Your ! is triggering the other bot
Avatar
ChillerDragon BOT 2023-07-13 21:26:01Z
sorry guys but ima go sleep now :c if you so hyped about the pcap and for whatever reason can not work with the relevant bytes i can give it a go again tomorrow
21:26
lerato my bot clearly was here before
21:28
i assume the client got in a weird state due to the server acting all firewall and it failed to send the TKEN package correctly
Avatar
heinrich5991 BOT 2023-07-13 21:34:07Z
give pcap before sleep, ChillerDragon
21:34
:D
21:34
hype hype
Avatar
Ryozuki 2023-07-13 21:43:22Z
is this real heinrich
21:43
also i thought netcode was supposed to not change
21:43
or is this a fokko sv thing
Avatar
Ewan 2023-07-13 21:49:53Z
just buy a new computer :3Head
Avatar
Avatar
Ryozuki
also i thought netcode was supposed to not change
heinrich5991 2023-07-13 22:16:12Z
netcode didn't really change
22:16
basically only the pacing of packets
Avatar
Learath2 2023-07-13 22:17:35Z
I would have expected the inverse 😄
Image attachment
Avatar
Ewan 2023-07-13 22:18:47Z
why?
Avatar
Learath2 2023-07-13 22:18:55Z
Turns out people with filthy mouths are better C coders, take that cs people
Avatar
chillerbot BOT 2023-07-13 22:19:44Z
error
Avatar
Ewan 2023-07-13 22:19:50Z
error
Avatar
chillerbot BOT 2023-07-13 22:24:42Z
error
Avatar
murpi 2023-07-13 22:24:56Z
error
Avatar
Gwendal 2023-07-13 22:35:10Z
Hey i think that's quite a problem
Image attachment
22:35
if you don't enter a name, the bot will try your username instead of trying with your nickname (edited)
Avatar
murpi 2023-07-13 22:37:09Z
Blame discord
Avatar
Gwendal 2023-07-13 22:37:36Z
xd
Avatar
murpi 2023-07-13 22:37:38Z
uNiQuE UsErNAmEs
Avatar
Gwendal 2023-07-13 22:37:43Z
i can try to fix that tonight if you wish
22:37
(it must be 1 line to change)
Avatar
Avatar
Gwendal
i can try to fix that tonight if you wish
murpi 2023-07-13 22:48:23Z
No, we just have to update our discord.py version. What you experience is a bug that hasn't been fixed in discord.py 2.2.2 yet
22:53
granted the problem couldn't have been resolved in discord.py 2.2.2 because the username migration took place after the release of that version but still
23:00
@Zwelf Please kick "majefamous" from IRC
Avatar
Zwelf BOT 2023-07-13 23:01:00Z
done now
👍 1
Avatar
Knuski 2023-07-13 23:10:44Z
yo, what about adding an option for sorting the skins by last added or recently used?
Avatar
Avatar
murpi
No, we just have to update our discord.py version. What you experience is a bug that hasn't been fixed in discord.py 2.2.2 yet
Chairn 2023-07-13 23:42:22Z
cant you use the name that is used only by this discord rather than the uNiQuE UsErNAmE ?
Avatar
murpi 2023-07-13 23:43:20Z
if I update the discord.py lib, yes.
Avatar
Avatar
Learath2
I would have expected the inverse 😄
louis 2023-07-13 23:59:17Z
is that even proper statistical analysis
Avatar
Chairn 2023-07-13 23:59:43Z
it is if you only consider the average
23:59
but the second gaussian fit is far fetched
Avatar
louis 2023-07-13 23:59:59Z
it doenst compare code with to code without swear words really
Exported 1,316 message(s)