DDraceNetwork - developer

ddnet-maps

[ddnet-maps:master] 1 new commit

6703d15 A Wanderlust - ddnet-maps

def-

[ddnet/zcatch] Issue opened: #3 Segfault in CCharacter::TakeDamage

``


Core was generated by

./zCatch-Server_sql -f servers/8400.cfg'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x000055be3a788364 in CCharacter::TakeDamage (this=0x55be3a870150 , Force=..., Force@entry=..., Dmg=6, From=From@entry=1, Weapon=Weapon@entry=3) at src/game/server/entities/character.cpp:888 888 if(g_Config.m_SvRespawnProtection && From >= 0 && (m_pPlayer->m_RespawnProtection > Server()->Tick() || GameServer()->m_apPlayers[From]->m_RespawnProtection > ...

08:11

def-

[zcatch:zCatch] 1 new commit

431950c Fix segfault in TakeDamage (fixes #3) - def-

08:11

def-

[ddnet/zcatch] Issue closed: #3 Segfault in CCharacter::TakeDamage

def-

[zcatch:zCatch] 1 new commit

5edca2a Fix linking in newer GCC - def-

@Chairn

Hey, just tried building the master, but I get make[3]: *** No rule to make target 'release/libddnet_engine_shared.a', needed by 'DDNet.exe'. Stop.. I use Windows + MinGW. Earlier, I see [40%] Built target rust_engine_shared_target, last time I built there was no rust code in DDNet I think... Is this related? Any hints appreciated

(edited)

also, if I run make again the console prints

build> make DDNet
[  6%] Built target game-shared
[  8%] Built target engine-gfx
[ 33%] Built target engine-shared
[ 41%] Built target zlib
[ 43%] Built target wavpack
[ 43%] Built target md5
[ 45%] Built target json
[ 46%] Generating release/libddnet_engine_shared.a
    Finished release [optimized] target(s) in 0.04s
[ 46%] Built target rust_engine_shared_target
[ 46%] Built target glew
[ 46%] Built target rust-bridge-shared
[ 48%] Built target steam_api
make[3]: *** No rule to make target 'release/libddnet_engine_shared.a', needed by 'DDNet.exe'.  Stop.
make[2]: *** [CMakeFiles\Makefile2:593: CMakeFiles/game-client.dir/all] Error 2
make[1]: *** [CMakeFiles\Makefile2:626: CMakeFiles/DDNet.dir/rule] Error 2
make: *** [Makefile:383: DDNet] Error 2

did you regenerate the makefiles

Oh yea, a few times. Or do you mean after a specific step?

GutZuFusss

also, if I run make again the console prints

build> make DDNet
[  6%] Built target game-shared
[  8%] Built target engine-gfx
[ 33%] Built target engine-shared
[ 41%] Built target zlib
[ 43%] Built target wavpack
[ 43%] Built target md5
[ 45%] Built target json
[ 46%] Generating release/libddnet_engine_shared.a
    Finished release [optimized] target(s) in 0.04s
[ 46%] Built target rust_engine_shared_target
[ 46%] Built target glew
[ 46%] Built target rust-bridge-shared
[ 48%] Built target steam_api
make[3]: *** No rule to make target 'release/libddnet_engine_shared.a', needed by 'DDNet.exe'.  Stop.
make[2]: *** [CMakeFiles\Makefile2:593: CMakeFiles/game-client.dir/all] Error 2
make[1]: *** [CMakeFiles\Makefile2:626: CMakeFiles/DDNet.dir/rule] Error 2
make: *** [Makefile:383: DDNet] Error 2

Wasn't that fixed already in latest ddnet code

08:53

What version do u compile

master

Up to date?

yea sure

08:54

just cloned

Guess u can manually move that file for now

huh?

It will be somewhere in the build directory

08:55

Simply at the wrong place

the following works for me git clone https://github.com/ddnet --recurse-submodules cd ./ddnet cmake -B ./build -S . && cmake --build ./build creates all targets as expected

08:59

gcc.exe (Rev6, Built by MSYS2 project) 13.1.0

09:00

i could try -G to make it use make

09:00

i use ninja normally

Jupstar ✪

It will be somewhere in the build directory

doesn't seem to be the case... I did a full directory search. Interestingly, I can see the file in CMakeRuleHashes.txt: bd543074308499423d5b2703dffb2685 release/libddnet_engine_shared.a The file is not there though, just .rlib and and .d extensions.

GutZuFusss

doesn't seem to be the case... I did a full directory search. Interestingly, I can see the file in CMakeRuleHashes.txt: bd543074308499423d5b2703dffb2685 release/libddnet_engine_shared.a The file is not there though, just .rlib and and .d extensions.

Do you have a target dir in root dir?

nope

Ewan

the following works for me git clone https://github.com/ddnet --recurse-submodules cd ./ddnet cmake -B ./build -S . && cmake --build ./build creates all targets as expected

output of that command: https://pastebin.com/0YqiSqpD

09:06

gcc.exe (Rev6, Built by MSYS2 project) 10.2.0 ^ is this too old?

<Jupstar> oh sry, i didnt read carefully

09:06

<Jupstar> u have no rust compiler installed?

i don't think that's the issue. i just added mine as a snapshot of around when my env has been updated last. sys upgrade couldn't hurt. it's prob rustc/cargo tho

ws-client

<Jupstar> u have no rust compiler installed?

I have. otherwise CMake doesn't even run through

try installing ninja and doing -G Ninja ig

09:07

cuz that's what works for me

PS C:\Users\l.ccc\Documents\Repositories\ddnet> rustc --version
rustc 1.70.0 (90c541806 2023-05-31)

seems like it could be a build system thing

Ewan

try installing ninja and doing -G Ninja ig

sure, I can do that... but would be nice to pin the root cause and if its not an issue on my end fix the cause upstream!?

not suggesting as a fix. just to see if it is related to which build tool

<Jupstar> You could share the Makefile that was generated by the cmake command

i tried a make build just for the fun of it and wow i forgot how slow

09:14

my poor little cpu putting along

09:15

tho i feel like it should be using more jobs by default right?

<Jupstar> with ninja or make?

make

<Jupstar> make usually uses only 1 core

i feel like it was a cmake pref

<Jupstar> pass --parallel to cmake

ah there it is

<Jupstar> when u also build with cmake