DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2023-07-04 00:00:00Z and 2023-07-05 00:00:00Z

the word blazingly is now associated with the rust community good job

I don’t think so

06:46

when i hear ‘blazingly fast’ i think of JS toolkits

i doubt thats true

you doubt that’s what I think?

Ewan

when i hear ‘blazingly fast’ i think of JS toolkits

this is what blazingly fast is nowadays ^

It fills your memory blazingly fast

yea

Ryozuki

namespace WTF {

using namespace JSC;

It’s short for Web Template Framework and provides commonly used functions all over the WebKit codebase.

wtf

6

They knew what they were doing

my map textures flew off what to do?

justatest

2

miamyra

my map textures flew off what to do?

Read #bugs

14:59

Also don't spam in multiple channels

[ddnet/ddnet] Issue opened: #6806 Incorrect text alignment in large confirmation popups with long text

For example when deleting a demo with a very long name: !screenshot_2023-07-04_18-09-12

[ddnet/ddnet] Pull request opened: #6807 Fix online clan friends not being removable via UI

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...

@Chairn https://web.archive.org/web/20100228145846/http://x264dev.multimedia.cx/?p=317

16:55

i remember u mentioning wavelets

16:55

over fourier

im no video compression expert, but i thought they could just use a different wavelet function to get more sharpiness

17:02

like the Haar wavelet which keeps edges https://en.wikipedia.org/wiki/Haar_wavelet

In mathematics, the Haar wavelet is a sequence of rescaled "square-shaped" functions which together form a wavelet family or basis. Wavelet analysis is similar to Fourier analysis in that it allows a target function over an interval to be represented in terms of an orthonormal basis. The Haar sequence is now recognised as the first known wavelet...

that might make very sharp edges easier but will likely have much bigger problems with anything that's not sharp

18:45

like more blurred edges, gradients, and finer textures

[ddnet/ddnet] Issue opened: #6808 Add verify_url to recognized master server server entries

This url can then be used by the client to verify yourself, e.g making a curl request or opening it in the browser. We can also show a hover tooltip for clueless tees

@Robyt3 what ya think

19:19

many ppl ask why long times etc

19:19

solution:

Seems straightforward to implement, but the main question is security again. Are you only going to allow it for official servers? Having the server make the client open an arbitrary URL in a browser seems like a recipe for disaster, given that our open_link is also generally unsafe.

@Robyt3 does it need to be in the browser?

19:21

idk how the verify happens

19:21

but if its just a simple request

19:21

curl can do

19:21

and it doesnt execute js

19:21

so we can just timeout

19:21

on 2seconds

19:21

or so

true, although that would still leak the IP at the very least

but its still a action the user takes

19:22

like connecting

19:22

not automated

I don't know how the verification works, but it doesn't seem like any JS is involved right now.

Is making the client do an empty GET request to an arbitrary url a security issue. That's I guess the question we are looking to answer

Not more risk than having the server with that IP in the server list to begin with I'd say

Maybe we should only allow a port so people don't make requests to any other url? Though that might be unnecessarily restrictive I guess

maybe we are being overly cautios

19:38

the IP leak from master was a big thing

19:38

because simply loading the game leaked it to all the server list

19:38

here its a action the user takes willingly

19:38

like connecting

[ddnet:master] 2 new commits

ef7a8d6 Fix online clan friends not being removable via UI - Robyt3 c555d04 Merge #6807 - bors[bot]

19:41

[ddnet/ddnet] Pull request closed: #6807 Fix online clan friends not being removable via UI

19:47

[ddnet/ddnet] Pull request opened: #6809 Fix text alignment in large confirmation popups with long text, increase buffer size for generic popup message

Closes #6806. The message can contain a filename, so it should be large enough to contain that and the message itself. Screenshots:

Before:

!screenshot_2023-07-04_18-09-12

After:

!screenshot_2023-07-04_21-43-45

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual c...

Ryozuki

here its a action the user takes willingly

Which results in a connection to an ip that isn't shown anywhere that might not be related at all though

the internet isnt safe

19:47

u visit random webs

19:47

all day

19:48

idk

The only thing I'd be really concerned about is something like "verify_url": "vodafone.station/reset_config_and_blow_up_router"

justatest

5

[ddnet/ddnet] Issue opened: #6810 Text does not wrap correctly with very long Unicode strings

Example when deleting a file with a name containing a long sequence of Unicode characters: !screenshot_2023-07-04_21-49-33 When disabling the font scaling for the dialog it looks like this: !screenshot_2023-07-04_21-46-27 The red rectangle which illustrates the size of the rect where the message is rendered. A...

[ddnet:master] 3 new commits

3f50729 Fix text alignment in large confirmation popups with long text - Robyt3 89a5281 Increase buffer size for generic popup message - Robyt3 f63ff62 Merge #6809 - bors[bot]

20:27

[ddnet/ddnet] Issue closed: #6806 Incorrect text alignment in large confirmation popups with long text

20:27

[ddnet/ddnet] Pull request closed: #6809 Fix text alignment in large confirmation popups with long text, increase buffer size for generic popup message

[ddnet/ddnet] Issue opened: #6811 Client answer to NETMSG_CON_READY is not marked as MSGFLAG_FLUSH

This means that sending the packet will be delayed until it hits the send timeout, which is 500ms.

Image attachment

justatest

4

this

1

Learath2

The only thing I'd be really concerned about is something like "verify_url": "vodafone.station/reset_config_and_blow_up_router"

I think this can also be caused by a simple <img src="http://vodafone.station/reset_config_and_blow_up_router">

True, I guess it's fine then

Ryozuki

Click to see attachment 🖼️

wait for template error in c++

Anyone a clue why the CMysqlConnection doesnt accept Uint64?

void CMysqlConnection::BindUInt64(int Idx, uint64_t Value)
{
    m_NewQuery = true;
    Idx -= 1;
    dbg_assert(0 <= Idx && Idx < (int)m_vStmtParameters.size(), "index out of bounds");

    m_vStmtParameterExtras[Idx].i = Value;
    MYSQL_BIND *pParam = &m_vStmtParameters[Idx];
    pParam->buffer_type = MYSQL_TYPE_LONGLONG;
    pParam->buffer = &m_vStmtParameterExtras[Idx].i;
    pParam->buffer_length = sizeof(m_vStmtParameterExtras[Idx].i);
    pParam->length = nullptr;
    pParam->is_null = nullptr;
    pParam->is_unsigned = true;
    pParam->error = nullptr;
}

Avolicious

Anyone a clue why the CMysqlConnection doesnt accept Uint64?

void CMysqlConnection::BindUInt64(int Idx, uint64_t Value)
{
    m_NewQuery = true;
    Idx -= 1;
    dbg_assert(0 <= Idx && Idx < (int)m_vStmtParameters.size(), "index out of bounds");

    m_vStmtParameterExtras[Idx].i = Value;
    MYSQL_BIND *pParam = &m_vStmtParameters[Idx];
    pParam->buffer_type = MYSQL_TYPE_LONGLONG;
    pParam->buffer = &m_vStmtParameterExtras[Idx].i;
    pParam->buffer_length = sizeof(m_vStmtParameterExtras[Idx].i);
    pParam->length = nullptr;
    pParam->is_null = nullptr;
    pParam->is_unsigned = true;
    pParam->error = nullptr;
}

Oh I see, because the C API Type Code expect a long long int... sadge

Exported 68 message(s)