DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2023-07-02 00:00:00Z and 2023-07-03 00:00:00Z

Ryozuki

@Learath2 https://jorengarenar.github.io/blog/less-known-c (edited)

I knew most of these, nice to see

[ddnet/ddnet] Pull request opened: #6799 Fix wrongly calculated reload timer for ninja in prediction

This fixes a bug where ninja didn't get predicted when you fired a weapon right before picking it up and then tried to use ninja immediately afterwards

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[x] Chan...

The compile time checks thru enums were cool tho

[ddnet/ddnet] Pull request opened: #6800 Update spanish.txt

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

[ddnet-maps:master] 1 new commit

d76c3ec M Bollermann, A Delirium - ddnet-maps

[ddnet:master] 2 new commits

1801c43 Update spanish.txt - n0Ketchp bd97482 Merge #6800 - bors[bot]

07:45

[ddnet/ddnet] Pull request closed: #6800 Update spanish.txt

[ddnet:master] 2 new commits

8335fda Fix wrong predicted reload timer after ninja pickup - trml 793271c Merge #6799 - bors[bot]

08:05

[ddnet/ddnet] Pull request closed: #6799 Fix wrongly calculated reload timer for ninja in prediction

[ddnet/ddnet] Issue opened: #6801 /swap not possible while paused

https://github.com/ddnet/ddnet/pull/6790#issuecomment-1615801115

Jupstar ✪

i wanted to know if u could implement the same logic pin does

you can implement the same logic as Pin does, however Pin doesn't actually implement any logic at all

09:19

it's the Unpin trait doing the work

09:19

but you could also re-implement the Unpin trait in user code

09:19

AFAICT

Embedded image

09:35

why is that called crc?

09:35

i thought crc was more sophisticated than just adding up all the data in a unsigned int?

09:35

looks like an intentional overflow

crc just means "cyclic redundancy check"

09:37

there are concrete crcs that are also called crc though

09:37

https://en.wikipedia.org/wiki/Cyclic_redundancy_check

Cyclic redundancy check

A cyclic redundancy check (CRC) is an error-detecting code commonly used in digital networks and storage devices to detect accidental changes to digital data. Blocks of data entering these systems get a short check value attached, based on the remainder of a polynomial division of their contents. On retrieval, the calculation is repeated and, i...

i just scimmed that very wiki page

09:39

which made me think its more than just adding stuff up

09:40

they mention fancy words such as polynominal long division

09:40

The concept of the CRC as an error-detecting code gets complicated when an implementer or standards committee uses it to design a practical system. Here are some of the complications:

09:40

they even make use of the word "complicated"

I have not understood the article well enough to know whether simply summing the contents modulo 2**32 is a CRC or not

is all crc in tw so also for maps just adding up all data and then representing it as one unsigned int that might have overflown multiple times?

no, map CRC (which is outdated, we use SHA256 these days) is a variant of the CRC that zlib implements

so tw uses a diff crc for snaps than for maps o.O

yep

cant complain

09:42

i really like this crc algo

09:42

it makes sense to me

09:43

helps me debug

09:43

is a overflow undefined behavior in c++?

[ddnet:master] 2 new commits

69ba84e CSound: Initialize all members (fixes #6795) - def- c955905 Merge #6796 - bors[bot]

09:43

[ddnet/ddnet] Issue closed: #6795 Conditional jump or move depends on uninitialised value(s) in CSound::Shutdown()

09:43

[ddnet/ddnet] Pull request closed: #6796 CSound: Initialize all members (fixes #6795)

ChillerDragon

is a overflow undefined behavior in c++?

For signed integer types yes, for unsigned types no

ChillerDragon

is a overflow undefined behavior in c++?

not of unsigned integers

https://en.cppreference.com/w/cpp/language/ub

cpp/language/ub

09:44

yea just came to the same conclusion

09:45

interesting

09:45

i always thought all kinds of overflow are bad

09:45

this is epic

09:45

thats the most simple hashing code i ever saw

all overflows can be bad if not intended

09:54

also newer c++ versions make it not undefined anymore

integer overflow?

as far as i remember yes

09:54

let me find

09:55

"Out-of-range cast to int is legal starting from C++20" mh i see only when casting

09:56

so not for calculations

09:56

https://en.cppreference.com/w/cpp/language/implicit_conversion#Integral_conversions

cpp/language/implicit conversion

09:56

i guess they dont know what they want

09:57

i wonder what arch blocks them to make it defined behavior, or unexpected result or smth the word undefined behavior is always so unspecified

09:58

left shifting is now defined

I think they just want int i = 0; i <= limit + 1; i++ to be equivalent to int i = 0; i < limit; i++

10:00

and a + b > a + c equivalent to b > c

10:00

and so on

main@debian:~/Desktop/git/DDNetPP/build$ ./DDNetPP 
./DDNetPP: error while loading shared libraries: libcrypto.so.3: cannot open shared object file: No such file or directory
main@debian:~/Desktop/git/DDNetPP/build$ ldd DDNetPP | grep libcrypto.so.3
        libcrypto.so.3 => /lib/x86_64-linux-gnu/libcrypto.so.3 (0x00007f9531e00000)
main@debian:~/Desktop/git/DDNetPP/build$ ls -lah /lib/x86_64-linux-gnu/libcrypto.so.3
-rw-r--r-- 1 root root 4.5M May 30 18:12 /lib/x86_64-linux-gnu/libcrypto.so.3

wot?

did u try a clean build dir

yes

10:07

but even if it wasnt clean

try strace

the error makes no sense does it?

10:07

alr

ah yeah u starting an exec lel

writev(2, [{iov_base="./DDNetPP", iov_len=9}, {iov_base=": ", iov_len=2}, {iov_base="error while loading shared libra"..., iov_len=36}, {iov_base=": ", iov_len=2}, {iov_base="libcrypto.so.3", iov_len=14}, {iov_base=": ", iov_len=2}, {iov_base="cannot open shared object file", iov_len=30}, {iov_base=": ", iov_len=2}, {iov_base="No such file or directory", iov_len=25}, {iov_base="\n", iov_len=1}],

10:08

10./DDNetPP: error while loading shared libraries: libcrypto.so.3: cannot open shared object file: No such file or directory

that's the printing of the error message

ah wait

10:08

ye

10:08

i saw above the juicy part

10:09

its looking everywhere

10:09

but not at the location ldd shows

10:09

how is that possible

apparently ldd and the dynamic linker have different search paths

woah

maybe check which dynamic linker was selected for your executable

there is no fix for that in ddnet is there?

10:10

so i must have messed soemthing up in my fork

I have not seen the problem before

how ever i managed to achive that

10:11

im using gold linker

10:11

the same that works for ddnet

10:11

time to diff cmakelists i guess

10:11

also its debian 12 only issue

10:11

on archlinux it works

10:12

my laptop only issue*

10:12

on my deb12 vps it works too xd

how did u compile the binary?

10:13

on same machine?

ye

10:13

time to buy new laptop

yeah

xd

its bcs u dont have rtx 4090

are those even in laptops?

10:14

my laptop has a 2080 mobile o.O

if not, spam nvidia

dear mr nvidia, can i has pls gaming laptop thank

10:14

for better ddnet linking

10:14

omg what a side quest i just wanted to debug crc issues

ChillerDragon

10./DDNetPP: error while loading shared libraries: libcrypto.so.3: cannot open shared object file: No such file or directory

Maybe it's a symlink to a non-existing file?

no

10:16

the ls -lah would have catched that

No execute permissions for your user?

o

10:17

OMG

10:17

deen u so smart

10:17

yes indeed

I didn't even see the ls -lha output

10:17

Should've scrolled up a bit, then would've been obvious

nah its my apparmor profile

10:17

that broke on debian 12 update xd

10:17

i forgot it still active

aah

i was testing with my fork

10:17

good idea deen!

nice error msg from linux xd

yes

10:18

sudo dmesg

10:18

bae

That makes sense now, you don't need +x

[ 2293.564473] audit: type=1400 audit(1688292479.405:126): apparmor="DENIED" operation="open" profile="ddpp" name="/usr/lib/x86_64-linux-gnu/libcrypto.so.3" pid=30229 comm="DDNetPP" requested_mask="r" denied_mask="r" fsuid=1000 ouid=0

Well, apparmor is probably implemented in a hacky way that uses the existing interfaces, and then it looks to the linker like the file doesn't exist

apparmor pog

10:18

i just gotta not forget i have it on

10:24

omg jopsti

10:24

new ddnet emotes

10:24

slow af

10:25

unplayable

on kog?

on ddnet

10:25

i just merged my fork w master

they are slow again?

or i broke merge idk

ah

10:26

i renamed vars. they behave differently now

10:26

sry

10:26

didnt see a better way

wait so is ddnet supposed to be fast?

ddnet is fast, but u can do whatever u want

10:26

i dunno what ddnets current config is

omg how did i manage to get it slow then xd

as said

10:27

var is renamed

delay var?

10:27

in config

sv_emoticon_ms_delay

sv_emoticon_ms_delay

10:27

bru

sv_emoticon_ms_delay 20 is basically per tick

no deprecation warning

it was in seconds before xd

10:28

that sucked

changelog

10:28

breaking version

xd

you broke the internet

i mean slow emotes are a deal breaker

10:28

not gonna deny

renaming config without deprecation warnings or major changelog announcement

10:29

is rude

its a good way to find out if the downstream maintainers are still active

10:30

trol

break compat

10:30

without warnings

ima break ur spine

10:30

without warnings

rood

over-head emoticon

10:33

xd

10:33

lyrical genius

10:38

jopsti u had those in school?

10:38

Embedded image

Tageslichtprojektoren?

10:41

or whatever they were called xd

OVERHEAD PROJEKTOR

10:42

we called em

i remember in a latin class the teacher once destroyed one when moving the board down hitting it and then falling down on the ground xD

lol

never again where all students awake so much

10:42

true, overhead projektor

ye latin is low enegery

10:43

overhead emoticons

[ddnet/ddnet] Pull request opened: #6802 Fix height of layer popup when automapper properties shown, fix incorrect popup being closed when gametile popup used

Both are regressions in 17.1 and should be added to the release.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or v...

pls dont tag inside a commit chiller. i get notified every time u change the commit or merge it or whatever huge troll

i know

10:54

u break api

10:54

u suffer

but dw pushed straight to master

10:55

wont rebase it

10:55

i get hughe warning message now evertime i start a server

10:56

Embedded image

deserved

-.-

10:57

toxic developers

warning: bin/backup is measured in gigabytes

10:58

wtf is that warning xD

hehe

10:58

leak

10:59

Embedded image

10:59

ye i should clean that

xd

i keep server binaries on update

in case u want to downgrade 2 years?

yes

clever

never happend

11:00

mostly to debug crashes

11:00

to have the exact binary that crashed

11:01

or revert to last working version when there is a bug that crashes server on launch

382

(Chiller got the edit to my old pin)

a lol

11:18

https://github.com/ddnet/ddnet/issues/5466

Signal SIGPIPE still appears · Issue #5466 · ddnet/ddnet

Used master branch - commit 02/06/2022 at 17:00 (Merge #5311) Thread 4 "DDNet-Server" received signal SIGPIPE, Broken pipe. [Switching to Thread 0x7ffff4b9a700 (LWP 1530826)] __libc_write...

11:18

this should be closed

11:18

@faulty

@Faulty

[ddnet/ddnet] Issue closed: #6637 Masterserver problems

https://github.com/ddnet/ddnet/issues/6189

ECON usage · Issue #6189 · ddnet/ddnet

I am interested if there are some users of eCON out there. Is it widely used?

11:20

also this is missing lables

11:20

thats not a relevant issue

yeah, I was looking for that

11:21

I added a label "question" for issues like this

[ddnet/ddnet] Issue closed: #6549 teleport prediction

@Jupstar ✪ i think they advanced baldurs gate release

12:44

GOAT

12:44

We will be releasing the game in order of platform readiness. Baldur’s Gate 3 will first come to PC on August 3rd, before launching on PlayStation 5 a few weeks later on September 6th.

12:45

dude

12:45

this game will be a true GOTY

12:45

More on those new heights: Baldur’s Gate 3 has more cinematic dialogue than three times all three Lord of the Rings novels combined. It has 174 hours of cinematics, making it more than twice the length of every season of Game of Thrones combined.

yeah

12:47

even the EA is insane xd

12:47

sadly im on holidays then

Image attachment

justatest

2

14:34

@Learath2

14:34

gigachad

what does this flag in variables say? CFGFLAG_INSENSITIVE

It determines which client variables are factored into the client checksum

17:53

For example the password client config is not used for checksum of course

so i should use it when i introduce a new client variable? justatest

justatest

(edited)

Depends on what it's used for

Vy0x2

what does this flag in variables say? CFGFLAG_INSENSITIVE

i dont know whats wrong with me but i just read the flag in your message as if you were screaming in my head justatest

justatest

justatest

1

Seems like all gameplay and tee related variables are used for the checksum

1

ah i got it, "insensitive" says its non sensitive data.. I thought it has something todo with case sensitive (edited)

[ddnet:master] 3 new commits

b252e74 Fix height of layer popup when automapper properties shown - Robyt3 e2ef536 Fix incorrect popup being closed when gametile popup used - Robyt3 ac6ee58 Merge #6802 - bors[bot]

18:47

[ddnet/ddnet] Pull request closed: #6802 Fix height of layer popup when automapper properties shown, fix incorrect popup being closed when gametile popup used

how do i update ddnet client to newest version? im not on steam (arch linux + downloaded client) and whenever i do yay it says everything is updated tho

Steinchen

how do i update ddnet client to newest version? im not on steam (arch linux + downloaded client) and whenever i do yay it says everything is updated tho

why dont u install from AUR?

Jupstar ✪

why dont u install from AUR?

thats pretty much aur, right?

19:53

i did yay ddnet and chose 1 now, lets see..

Steinchen

thats pretty much aur, right?

mh ok thought u meant "downloaded client" = downloaded manually

Steinchen

thats pretty much aur, right?

https://aur.archlinux.org/packages/ddnet-git

19:54

did u use ddnet-git

yes

19:55

and just ddnet

well seems like the packet is simply not updated yet

19:55

u can ping the maintainer rafaelff

19:55

he is here

Steinchen

how do i update ddnet client to newest version? im not on steam (arch linux + downloaded client) and whenever i do yay it says everything is updated tho

this depends on whoever updates the aur

19:59

i used to do it

19:59

but i upgraded to gentoo

19:59

so im now maintaining the gentoo ebuild

20:00

a good way to update ur ddnet is to upgrade to gentoo

20:00

gigachad

i downloaded this one and its on 17.03 for now

Image attachment

idk who even maintains it

;-:

hey where is this litte sht drawn?

Image attachment

21:47

ah nvm i found it its in hud.cpp (edited)

[ddnet/ddnet] Pull request opened: #6803 Improve font scaling of long editor texts, improve ellipsis

For long editor texts (group name, layer name, image name, sound name, file names, tooltips) make use of the font scaling and ellipsis functionality implemented in DoLabel instead of implementing it separately in the editor. Screenshots:

File dialog:
- Before:

!filedialog old

After:

!filedialog new ...

Teero

hey where is this litte sht drawn?

what r u gonna do with this? :o

cool animations :)

2

[ddnet:master] 3 new commits

0a73610 Add ellipsis flag to DoLabel, support stop-at-end with max width - Robyt3 2b64a66 Improve font scaling of long editor texts, improve ellipsis - Robyt3 35f8475 Merge #6803 - bors[bot]

22:47

[ddnet/ddnet] Pull request closed: #6803 Improve font scaling of long editor texts, improve ellipsis

Exported 281 message(s)