



























































































e3fed7d Update libraries - def-
374229f Version 17.0 - def-
661cf63 Update translations for upcoming 17.0 release - def-
431cfd6 Add Russian and Ukrainian translations by StormA - def-
874ebd5 Update hungarian.txt - RIH-Cellegen
c3a5399 Update hungarian.txt - RIH-Cellegen
61106cc Improve German translation (by murpi) - def-
858e9b1 Render tees for online friends in friends list - Robyt3
f9814ca Change friend info text to Map | Mode | Country/Ping - Robyt3
01eeeb2 Reduce duplicate UI spacing code - Robyt3
03557b4 Show official server icon in friends list - Robyt3
388c6ff Show race disconnect confirmation when joining friend - Robyt3
d221ed6 Add popup to confirm connecting to friend on non-official server - Robyt3
cc7a708 Fixes for Russian and Ukrainian (by StormA) - def-
8a2789a Revert "Add popup to confirm connecting to friend on non-official server" - def-
6de2e5c Slightly increase font size of friend name - Robyt3
54a0bd4 Fix use of invalid text container index for finish message HUD - Robyt3
d636da7 Update simplified_chinese.txt - RemakePower
24c2579 Use different color for offline clanmates in friends list - Robyt3
7c4e9cf Update french translations (by Sukya) - def-




















Core was generated by ../DDRace64-Server_sql -f servers/test3.cfg'.
Program terminated with signal SIGABRT, Aborted.
warning: Section `.reg-xstate/2426011' in core file too small.
#0 GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
[Current thread is 1 (Thread 0x7f0ad00bb100 (LWP 2426011))]
(gdb) bt
#0 GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007f0ad0ba...[2022-05-23 20:10:34][server]: ClientID=4 rcon='super'
[2022-05-23 20:10:36][chat-command]: 4 used /tele
[2022-05-23 20:10:38][chat-command]: 4 used /pause
[2022-05-23 20:10:38][assert]: /home/teeworlds/src/master/src/engine/shared/network_server.cpp(747): erroneous client id
Happened on test server yesterday






std::bitset too small

TEAM_SUPER == 64

std::bitset too small 







































fn main() {
'outer: loop {
println!("Entered the outer loop");
'inner: loop {
println!("Entered the inner loop");
// This would break only the inner loop
//break;
// This breaks the outer loop
break 'outer;
}
println!("This point will never be reached");
}
println!("Exited the outer loop");
}





cppcoreguidelines-avoid-goto yeah disappointed in all of you
FAILED: CMakeFiles/game-server.dir/src/engine/server/server.cpp.o
/usr/local/bin/cmake -E __run_co_compile --tidy="clang-tidy;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/home/runner/work/ddnet/ddnet/src/engine/server/server.cpp -- /usr/bin/c++ -DCONF_DEBUG -DCONF_INFORM_UPDATE -DCONF_OPENSSL -DCONF_VIDEORECORDER -DGAME_RELEASE_VERSION=\"16.9\" -DGLEW_STATIC -I/home/runner/work/ddnet/ddnet/clang-tidy/src -I/home/runner/work/ddnet/ddnet/src -I/home/runner/work/ddnet/ddnet/src/rust-bridge -isystem /home/runner/work/ddnet/ddnet/ddnet-libs/curl/include -g -std=c++17 -fdiagnostics-color=always -fstack-protector-all -fno-exceptions -Wall -Wextra -Wno-psabi -Wno-unused-parameter -Wno-missing-field-initializers -Wformat=2 -Wno-nullability-completeness -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wrestrict -Wshadow=global -Wsuggest-override -MD -MT CMakeFiles/game-server.dir/src/engine/server/server.cpp.o -MF CMakeFiles/game-server.dir/src/engine/server/server.cpp.o.d -o CMakeFiles/game-server.dir/src/engine/server/server.cpp.o -c /home/runner/work/...
/home/runner/work/ddnet/ddnet/src/engine/server/server.cpp:1473:7: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
goto join;
^~~~~~~~~
/home/runner/work/ddnet/ddnet/src/engine/server/server.cpp:1492:4: note: label defined here
join:
^
/home/runner/work/ddnet/ddnet/src/engine/server/server.cpp:1484:8: error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]
goto join;
^~~~~~~~~
/home/runner/work/ddnet/ddnet/src/engine/server/server.cpp:1492:4: note: label defined here
join:
^
514 warnings generated.



goto
















returns if they're easily translatable intto huge if-else blocks?







void Method(out int answer, out string message, out string? stillNull)
{
answer = 44;
message = "I've been returned";
stillNull = null;
}


return



? (edited)
















_unchecked variant for certain methods





we
































































gfx_refresh_rate 0; cl_refresh_rate 0; gfx_asyncrender_old 1; gfx_vsync 0; gfx_backend Vulkan; cl_showhud_ddrace 0; cl_showhud_dummy_actions 0; cl_showhud_healthammo 0; cl_showhud_jumps_indicator 0; cl_showhud_player_angle 0; cl_showhud_player_position 0; cl_showhud_score 0; cl_showhud_player_speed 0; cl_showfps 1; cl_overlay_entities 100
















return; in every components ::OnRender ?











































:hissnail:\:hisnail:<\:hisnail:768893210726367232>




CPlasma::m_aTargetIdInTeam that contains for every team the client ID of the team member currently being dragged by this dragger.
The client IDs in this array also need to be swapped accordingly or the dragger will not switch target correctly when swapping.
Closes #5865.








1





ui_smooth_scroll_time 0 the highlight for the hovered list item is sometimes delayed by one frame.
Reported by @Jupeyy











goto 
CheckReservedAuth might be doing






time bash -c 'mkdir build && cd build && cmake .. -GNinja -DCMAKE_BUILD_TYPE=Release && ninja'real 1m14.154suser 3m37.487s


gfx_refresh_rate 0; cl_refresh_rate 0; gfx_asyncrender_old 1; gfx_vsync 0; gfx_backend Vulkan; cl_showhud_ddrace 0; cl_showhud_dummy_actions 0; cl_showhud_healthammo 0; cl_showhud_jumps_indicator 0; cl_showhud_player_angle 0; cl_showhud_player_position 0; cl_showhud_score 0; cl_showhud_player_speed 0; cl_showfps 1; cl_overlay_entities 100; gfx_fullscreen 1; cl_background_entities ""




















































































































































































cl_threadsoundloading default 0? Did threaded sound loading ever cause issues on any system? I think we could change the default to 1 and also remove the settings checkbox for this, because it doesn't seem relevant and understandable enough for users to be in the UI.


cl_threadsoundloading default 0? Did threaded sound loading ever cause issues on any system? I think we could change the default to 1 and also remove the settings checkbox for this, because it doesn't seem relevant and understandable enough for users to be in the UI. 
1

1 since always


















self: std::pin::Pin<&mut Self>
why does it need to use a ref

















self: std::pin::Pin<&mut Self>
why does it need to use a ref 









523a3c4 fix- Replaced usage of m_ProofBorders and m_MenuProofBorders with enum EProofBorder - tarunsamanta2k20
61ef621 Modifications in three files - tarunsamanta2k20
f23f74e fixing some error - tarunsamanta2k20
e74c60d Modified some files - tarunsamanta2k20
79d8928 made requested changes - tarunsamanta2k20
ef78e36 replaced second enum - tarunsamanta2k20
fcaab77 modified some files as asked - tarunsamanta2k20
050bf4a Made sugested changes - tarunsamanta2k20
e8a33cf fiing linting issue - tarunsamanta2k20
f982dd7 fixing linting issue - tarunsamanta2k20
03a5dde Merge #6639 - bors[bot]






mem::replace(&mut a, Type::None)







std::future::ready()mem::replace would work for tha
















value: T locally.



future::ready?



let connection = tokio_tungstenite::accept_async(connection.block_on().0); //<-- this is a ready future for simpli
let ws_stream = pin!(connection).poll(cx);
ws_stream.map(|f| match f {
Ok(connection) => Ok(TungsteniteNetworkConnectionWrapper {
con: Arc::new(ConnectionType::Server(connection)),
}),
Err(err) => Err(err.to_string()),
})
Future impl? (edited)










Box<dyn Future<Output=something>>future::ready() returns a known type




Box<dyn Future<Output=something>> 


tokio::sleep returns a nameable type



i32 is a typeDebugtokio::sleep, returns a type named Sleep that implements Futurestd::future::ready returns a type named Ready that implements Future as wellFuture











































u























Hacker News • 2023-05-24 17:28:12Z 




fd0e9b1 Remove unused snd_device config variable - Robyt3
460cda8 Set minimum/maximum values for snd_rate - Robyt3
70b5e4b Remove settings edit box for snd_rate - Robyt3
b5637df Enable threaded sound loading per default again - Robyt3
60ac3b3 Remove settings checkbox for cl_threadsoundloading - Robyt3
34b66d2 Pass nullptr instead of unused UI rect - Robyt3
495a0c7 Merge #6661 - bors[bot]






CleanerFunctions.push([pKernel, pClient]() {
pKernel->Shutdown();
delete pKernel;
delete pClient;
free(pClient);
}); (edited)static CClient *CreateClient()
{
CClient *pClient = static_cast<CClient *>(malloc(sizeof(*pClient)));
mem_zero(pClient, sizeof(CClient));
return new(pClient) CClient;
}
...
// Init client
CClient *pClient = CreateClient();
...
// Deinit (client included)
CleanerFunctions.push([pKernel, pClient]() {
pKernel->Shutdown();
delete pKernel;
pClient->~CClient();
free(pClient);
});