DDraceNetwork - general

who asked fr

yesterday i finished 12 maps

07:01

im back

6

oco can’t be completed is the biggest troll, perfect map

Ryozuki

im back

It’s impossible to leave ddrace

sorry i had to

08:41

my favourite programming language is html

08:41

08:45

I mean.. it is a programming language just as much as CSS is

mine is scratch its ok

1

scratch ma back

erm.. no long fingernails rn

fokkonaut

my favourite programming language is html

True programmers know css is better

.

,

;

Voxel

erm.. no long fingernails rn

0108ben

It’s impossible to leave ddrace

i never left, just had less activity in game

O:

Ryozuki

i never left, just had less activity in game

why the sudden change

10:33

11 maps in a day is a lot xd

well they were the novices i had left

10:34

and some moderates

10:34

if u have a partner to play maps with u can finish lots of maps ez

10:35

Novice Server (150/150 maps finished)

i still have like 27 novices left justatest

UHH, i think something went wrong

its a bug

12:29

prob tied to the other 3 bugs

oh

1 that shows people having a 2h 49m time (i think) for about a second after they join 1 that makes scoreboard unordered (still shows people who have a finish at top, but beyond that it scrambles all the finished times) and another that reverses scoreboard order (also still shows finishers at top)

12:30

no idea why it started happening lmao

thats so odd hahah, well, thank you for letting me know :D

ye

Scoreboard do be upsidedown these days

BRO WHERE IS THE TURKS SERVER

Broso56

1 that shows people having a 2h 49m time (i think) for about a second after they join 1 that makes scoreboard unordered (still shows people who have a finish at top, but beyond that it scrambles all the finished times) and another that reverses scoreboard order (also still shows finishers at top)

@heinrich5991 @deen @Robyt3 know why?

likely because of the pull request you fixed for me (edited)

>>> 9999/60/60
2.7775000000000003
>>> 9999/60 - 120
46.650000000000006

https://github.com/ddnet/ddnet/pull/6585/files

ye im looking at my pr

https://github.com/ddnet/ddnet/pull/6585/files#diff-4b7e0de54578478dbb720a146e73785264c55592e8ba622a241e7eb0af5e2975R355

14:23

this?

does anybody know why my ddnet crashes on boot

fokkonaut

this?

before it was abs(score) * -1 now it is just -score

but score should be positive now(?)

i thought it was always negative

14:26

but i didnt catch up with the differences in the score nowadays, with how we save it and what gets interpreted by the client

14:27

i think what gets sent to the client will always have to be negative, in order for the sorting to work out

ye

14:28

but the server maintains it as a variable containing the number of seconds, I believe

but as negative, no?

no

14:29

I see no negation

ah, sorry

14:33

https://github.com/ddnet/ddnet/pull/6585/files#diff-65908fcaf323f624c0a8e584e92664d0d49640bb139729c6e22a14a5b2170c3fR2270

14:33

what about this btw

14:33

why is it not negative

ah, I saw that the old client code for the serverbrowser time didn't actually require the negative sign to be displayed correctly

alright

https://github.com/ddnet/ddnet/pull/6585/files#diff-4b7e0de54578478dbb720a146e73785264c55592e8ba622a241e7eb0af5e2975L376

0.7 handles it different

so whats the fix

idk

14:37

didnt find anything too suspicious on the first view

https://github.com/ddnet/ddnet/blob/22df50c9bda271fbef4e2c7c28793384d48e0a80/src/game/server/gamemodes/DDRace.cpp#L131

14:38

this one looks wrong, should be -1 instead of -9999

thats it, yes

ohh

like that it will display a positive 9999 to the client = 2h 42min

14:39

thats also why these fucked up scores disappeared then, cuz the scoreworker did it's thing and updated them correctly

also the ternary seems completely useless

yes xd

should just be -1 unconditionally

then remove it entirely, its -1 from CPlayer::Reset() anyways

nice bugfix

14:40

remove buggy line

xd

less code always best

i hope it doesnt break anything tho

14:41

nobody knows

14:41

but should be fine

wait

14:44

@fokkonaut whats -1

old -9999

ah nvm

14:44

but when does score get set to Score()->PlayerData(ClientID)->m_BestTime

then

Ryozuki

but when does score get set to Score()->PlayerData(ClientID)->m_BestTime

i dont know what the best time is used for anymore, but i think it should get its correct score from the scoreworker

14:45

https://github.com/ddnet/ddnet/pull/6585/files#diff-4b7e0de54578478dbb720a146e73785264c55592e8ba622a241e7eb0af5e2975R891

ah true

14:47

it gets set from the isql result ok

15:24

what the heck (edited)

Bugged, already reported

is there a github issue already?

Yep

ah, https://github.com/ddnet/ddnet/issues/6594

how to add a bind