Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2023-05-07 00:00:00Z and 2023-05-08 00:00:00Z
Avatar
Avatar
Voxel
actually fuck off this is exactly the reason why i dont want to learn
that's what people also say about gay people or vegans
00:10
I find it very stupid that people say that
00:23
pretentious rust fans when someone is genuinely happier doing anything other than rust:
Avatar
@Voxel why do respectable rust advocates bother u so much? just look at the language and decide if it offers something that you're interested in (edited)
Avatar
Avatar
Ravie
@Voxel why do respectable rust advocates bother u so much? just look at the language and decide if it offers something that you're interested in (edited)
it doesnt. what angers me is that rust is seen as some holy grail of coding and if you Dont Dare to use it you're trash
00:29
i dont think anyone deserves to put up with this mindset
Avatar
@Voxel you can like something even if you dislike part of its fanbase (ahem)
00:32
also rust is kinda by design meant to be a "holy grail of coding" so it attracts people like that I guess
Avatar
it's very unhealthy. yeah sure it might be extremely powerful but forcing someone to learn it through peer pressure is just
Avatar
i dont think anyone is forcing anyone to learn it
00:38
also their mascot is cute
Avatar
no it isnt >:(
00:38
ok maybe im just salty
f3 1
00:38
it can be
Avatar
Avatar
louis
also their mascot is cute
ye I made a skin of it once but it was kinda weird
Avatar
also that image sent was just a joke about ppl who idolize rust
Avatar
from the amount of rust memes sent here i literally could not tell it was irony
Avatar
Girl Explaining, also known as Girl Bro Explaining or simply Bro Girl, is a photo of an Argentinian woman named Denise "Dinu" Sanchez at a 2018 concert appearing to loudly talk to her boyfriend with a blank expression while wrapping one arm around him and gesturing off towards the distance in the direction of the camera. The reaction image appea...
Avatar
Avatar
Voxel
it doesnt. what angers me is that rust is seen as some holy grail of coding and if you Dont Dare to use it you're trash
Remember one truth, rust is bad, all these people just want you to learn unwanted technology and take your place as REAL programmer using REAL programming languages like c++ troll
Avatar
that doesnt help either
Avatar
Hello, If there is an Anti-Cheating Script, Etc., I don't know if you can Throw it out, I will Install these jobs for my Server
06:20
gores with deep is a crime Ryozuki (edited)
Avatar
oh lol u made a gores map and i never noticed, because i always play in entities xd
Avatar
Avatar
Voxel
it doesnt. what angers me is that rust is seen as some holy grail of coding and if you Dont Dare to use it you're trash
young man, it's not a random incidence that you joined our sanctuary. It was our fate that we meet here. You'll soon learn how warm and wise Rust is. Rust loves every programmer, also those who lost their faith. May Rust bless you and I hope you'll find your way back to Rust. Amen.
Avatar
yo brothers, does anyone know how to kill dummy from CGameClient? There is a SendKill function but it never actually uses the ClientID
Avatar
the client doesnt need to know its id in this case
06:47
the server is aware what client has what id
06:48
its about the network
06:48
there must be smth like m_aNetwork[ClientID]
Avatar
so is it possible to do something like have my dummy autokill if he spends too long in the freeze?
Avatar
Avatar
BillionRay
yo brothers, does anyone know how to kill dummy from CGameClient? There is a SendKill function but it never actually uses the ClientID
wait i need to look in the source
06:48
g_Config.m_ClDummy
06:49
must simply be 1 i guess
06:49
if u want to force it for dummy
Avatar
so force it, send kill, and undo it?
Avatar
would be one way, yes xd
Avatar
good enough for me, i will give it a shot :)
Avatar
Avatar
Chairn
it's just easier to keep same code for both with a file containing the list of censored words, file that is empty on european servers
makes no fucking sense doing it that way, especially if europian / american ddnet servers don't utilize the filter feature for better moderation
06:52
with clientside filters (which is actually fuckin easy to do, even I can do it), people wouldnt need to fear for shit like spamming profanity
Avatar
Avatar
Jupstar ✪
would be one way, yes xd
Works. Thank you bro. Would have taken me a while to figure this out myself
Avatar
Avatar
Voxel
"ughh if you dont program in rust you dont even deserve a programming job"
btw rust has a marketshare of like <10% so the mainstream wouldnt say this. But here with Ryozuki as prophet, you ofc face it every other day xd
Avatar
Avatar
BillionRay
Works. Thank you bro. Would have taken me a while to figure this out myself
nice xd i dunno if i would use negation operator here tho, i dont thing ClDummy is a boolean 😄
06:55
surprising it works actually xD
06:57
well its a logical negation so doesnt matter
Avatar
sometimes i think people either take memes too seriouslu or idk man
Avatar
Avatar
Voxel
pretentious rust fans when someone is genuinely happier doing anything other than rust:
in my experience, its the other way around, lot of salty devs angry at u for using rust or saying ur project uses rust in a blog title. anyway i send these memes here cuz i find them funny, and i never expected anyone to learn rust or say the wont get a job if they dont learn it, in fact, right now rust is not the best lang to learn if a job os what u want
07:20
but if u limit ur learning because x said something, that says a lot about you, i personally would learn it anyway
Avatar
i even learned typescript even tho i hate javascript, simply bcs its still the browser language xd
Avatar
the thing is that rust brings a big change that established C mammoths, usually older devs maybe, dont like, cuz their job depends on knowing this only language, atleast its a theory
07:23
this is why u shouldnt limit urself to 1 lang imho
07:24
i dont like java, golang and i know them xd (edited)
Avatar
Avatar
Ewan
Click to see attachment 🖼️
wait wtf
07:25
i didnt make that right
07:26
where is this from
Avatar
lel
Avatar
he cant remember
07:26
lmao
Avatar
did i make that? i dont remember
Avatar
unless there's another ryozuki
07:26
i'll give u the benefit of the doubt xd
Avatar
ryo forgot he was in a racing clan
Avatar
is there a faker?
07:29
@Ewan can u do mapinfo
07:30
wait no /map
07:30
wtf
Avatar
oh wait
07:31
maybe i did do it
07:31
i remember making this circular hting
07:31
07:31
ye
07:31
i made it lmao
Avatar
i remember this stupid part
07:32
good gores map kek
Avatar
im being trolled by ger kog server
Avatar
ChillerDragon BOT 2023-05-07 08:57:53Z
was the voting changed on ddnet or multeasymap in particular? i just got kick voted in a few secs on a full server thats new to me
Avatar
ChillerDragon BOT 2023-05-07 09:29:54Z
!rob
09:30
fuck i dont have that?
09:30
!robster
09:30
!add_ping_pong rob @Robyt3
09:30
!add_ping_pong robster @Robyt3
09:30
can you send brain real quick?
09:31
imo this check is usless and a clock cycle waste at best and totally misleading at worst https://github.com/ddnet/ddnet/blob/cfd003d9c5c632c1cd6178150e72f80ba4d8a757/src/game/collision.cpp#L279
DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.
09:31
collisions GetTile() gave me a false sense of security because it has the nullptr check
09:31
but asan gave me a use after free
09:32
and i think this is because the memory is allocated and freed by the datafile but the collision pointer is never set to null
Avatar
Yeah, that's what #6565 should fix
Avatar
When a client component (e.g. the menu or the console) disconnects the client, this immediately unloads the map data but the render call continues as normal. This causes all components rendered aft...
Avatar
ChillerDragon BOT 2023-05-07 09:32:07Z
DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.
Avatar
Layers and collision both use the map data, which is unloaded when you disconnect
Avatar
ChillerDragon BOT 2023-05-07 09:32:39Z
wtf
Avatar
So you would either need to unload the map data in layers/collision by setting it to nullptr and adding these nullptr checks everywhere, or delay the unloading like this PR does
Avatar
ChillerDragon BOT 2023-05-07 09:33:36Z
DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.
Avatar
The engine doesn't know about CLayers and CCollision
Avatar
ChillerDragon BOT 2023-05-07 09:34:20Z
as of right now collision is properly nulled on first boot but as soon as a map changes the nullpointer checks all fail
09:34
since its non nulled pointers that point to freed memory
09:34
ah shiet
Avatar
It's possible, but I kept adding more refactorings to it, so the PR I opened is simpler than the alternative that I first coded: https://github.com/Robyt3/ddnet/tree/Client-Map-Disconnect-Invalidate
DDraceNetwork, a cooperative racing mod of Teeworlds - GitHub - Robyt3/ddnet at Client-Map-Disconnect-Invalidate
Avatar
ChillerDragon BOT 2023-05-07 09:36:41Z
oh lol ofc ur already super aware of what i just considered a genious find xd
Avatar
But it's easier to delay the map change/disconnect until after the render call
Avatar
ChillerDragon BOT 2023-05-07 09:37:34Z
wow 14h ago thats new shit
09:38
i hope no merge will be pain if i cherry pick ur pr now :D
09:38
is it production ready?
Avatar
yeah, it's ready from my side
Avatar
ChillerDragon BOT 2023-05-07 09:40:09Z
cool imma yoink this so i do not have to think about fixing my crash bug
Avatar
does it crash consistently for you? I never got to reproduce the crash consistently
Avatar
ChillerDragon BOT 2023-05-07 09:41:15Z
i can get it to in my sus hax bot client
09:41
took me months to pin point it down
09:41
just call GetTile() in OnRender) and then kick the client
09:41
10/10 asan trigger
Avatar
I had like 8 headless clients with dbg_stress 1 for a few hours and some of them had this crash eventually
Avatar
ChillerDragon BOT 2023-05-07 09:42:09Z
ah nice u use headless :)
09:42
i was a bit scared that nobody ever would use the headless other than me and all are just super annoyed by the additional code complexity
09:46
hm i still get the crash with ur pr ._.
Avatar
maybe you are doing the thing that causes the crash manually though
09:48
do you reload the map or disconnect manually somewhere?
Avatar
ChillerDragon BOT 2023-05-07 09:48:19Z
not that i know
Avatar
like from anywhere inside the render function
Avatar
ChillerDragon BOT 2023-05-07 09:48:30Z
lemme extract the crashing code out of my hax client
09:54
Chillers contribution fork of DDraceNetwork, a cooperative racing mod of Teeworlds - GitHub - ChillerDragon/ddnet at Client-Delay-Disconnect_crash
09:55
yea as i thought calling gettile in a clint compoennets render crashes i f the client gets kicked even with your fix
Avatar
I think you still need to check whether you are online or offline before you access Collision in a client component
Avatar
ChillerDragon BOT 2023-05-07 10:00:24Z
ah tru
Avatar
The fix just prevents the collision from becoming invalid during a render call
Avatar
ChillerDragon BOT 2023-05-07 10:00:31Z
i do that in my code by checkng local char i think
Avatar
But if it's invalid the entire time then you shouldn't access it either
10:01
If we see the crash again on ddnet even with the fix then I'll also add the other fix (null-checks everywhere)
Avatar
ChillerDragon BOT 2023-05-07 10:02:07Z
how do i even properly check
10:02
i check for this m_pClient->m_Snap.m_aCharacters[m_pClient->m_aLocalIDs[DummyID]].m_Cur being null before calling collsion stuff
Avatar
there should be a getter for the client state, which should be online or demo-playback if you want to have a valid map
10:03
or you use the OnStateChange component callback
Avatar
ChillerDragon BOT 2023-05-07 10:05:01Z
ah i see thanks a lot
Avatar
ddnet minimum requirement: potato pc
Avatar
ChillerDragon BOT 2023-05-07 10:06:20Z
yea ddnet is becoming more and more bloat tho compared to vanilla
10:06
but its still more light weight than tripple a
Avatar
Avatar
Chairn
ddnet minimum requirement: potato pc
nop
10:08
ddnet refuses work on my old ass pc xd
10:08
that one can die any moment tho
10:08
ide storage is kind of.. ash
Avatar
Avatar
Chairn
ddnet minimum requirement: potato pc
you forgot "sadly"
Avatar
ChillerDragon BOT 2023-05-07 10:09:58Z
but you know what i mean right? @Robyt3 i mean sure in my dbg print example i do no checks. But it works fine initially because m_pTiles is set to 0 on boot. So might as well delete the !m_pTiles check in GetTile if it only works until the first map load
10:10
we are checking if a pointer is 0 that is not nulled on free
10:10
like wot
Avatar
If the fix from the PR doesn't work then we'll have to add this check everywhere in collision
10:11
So it's easier if you just leave it
Avatar
ChillerDragon BOT 2023-05-07 10:11:21Z
the check is broken
10:11
thats what i am trying to say
Avatar
Yeah, right now it's never true
Avatar
ChillerDragon BOT 2023-05-07 10:11:42Z
the check does not work because m_pTiles is not set to 0 when datafile frees the underlying memory
Avatar
But at some point we may want to allow unloading the map, so we'll add that check everywhere
10:12
collision already has these checks for all other layers (front, tele etc.) because they can all be missing from a map file
Avatar
ChillerDragon BOT 2023-05-07 10:13:17Z
my probablem is not that the check is not there everywhere my problem is that the check is there at all but does not work it gives false sense of security
Avatar
but technically a map file can also be missing the game layer, so right now it would crash the game if you load map not containing a game layer
Avatar
ChillerDragon BOT 2023-05-07 10:14:18Z
i guess ill just fix my crash with the state check
10:14
but i feel like in general it would be nicer if m_pTiles is nulled when its freed
10:15
When the client switches to offline or quitting state, cleanly unload map data from CLayer and CCollision to prevent accesses to invalid memory when the classes are used after the map data has ...
10:16
omg c++ is so broken that it lets u do stuff like that in the first place
10:16
im slowly growing the urge to learn rust
Avatar
ChillerDragon BOT 2023-05-07 10:36:04Z
lol
Avatar
I invite you to develop something completely new and bloat free as possible with me^^
Avatar
how much you pay me?
Avatar
With so much devs around here we could easily build smth up
10:37
U have to do it with a motivational source that does not come from money
Avatar
sorry, but my stomach doesn't feed on good will 🙂
Avatar
I never said u must stop working
10:38
Life is a trade
10:38
If u now pay more than u have to. Then maybe u'll get it back twice
Avatar
ChillerDragon BOT 2023-05-07 10:59:43Z
not even money motivates me to dev i hate writing code
Avatar
i only want 300000000000000000000000000 FPS while using 0.00000000001 Wh electricity simulating every atom in the whole universe so i have more than enough motivation
Avatar
ChillerDragon BOT 2023-05-07 11:01:07Z
based desire
Avatar
money is just an illusion
Avatar
ChillerDragon BOT 2023-05-07 11:01:15Z
deep
11:01
new gnome so bugged omaagwd
Avatar
thats what i think at every KDE release too xd
Avatar
ChillerDragon BOT 2023-05-07 11:02:09Z
xd
Avatar
too bloated, but still best feature wise
11:02
sad life
Avatar
ChillerDragon BOT 2023-05-07 11:02:20Z
users love software updates dont they
11:02
:wq
11:02
ops wrong chat
Avatar
so u chatting with ur vi? xd
Avatar
ChillerDragon BOT 2023-05-07 11:04:12Z
-.- wrong pane then mimimi
Avatar
Avatar
Jupstar ✪
i only want 300000000000000000000000000 FPS while using 0.00000000001 Wh electricity simulating every atom in the whole universe so i have more than enough motivation
too bad physics says this is impossible
11:19
viGPT
Avatar
Avatar
Chairn
too bad physics says this is impossible
the physics we know
11:19
but not mathematically
Avatar
i like rust updates the most
Avatar
have u purged the rust package from ur system
12:11
i use rustup for my projects
Avatar
have u ever* (edited)
Avatar
Certified java moment?
13:35
Why java sucks so much 😭
Avatar
See #5143.

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#us...
Avatar

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...
Avatar
b590eff Add missing HUD text container deletion - Robyt3 cfe17fa Merge #6567 - bors[bot]
Avatar
Avatar
Anime.pdf
Certified java moment?
It's good, the worse optimized a piece of software is the more the new generation likes it
Avatar
ChillerDragon BOT 2023-05-07 14:36:02Z
hm suddenly my game got glitchy like my gpu couldnt keep up so i switched from opengl 3.0.0 to vulkan and it got smooth again
14:36
!jup thanks for building stuff like that :)
Avatar
chillerbot BOT 2023-05-07 14:36:11Z
@Jupstar ✪
Avatar
ChillerDragon BOT 2023-05-07 14:36:25Z
very pog
Avatar
np, but can also happen other way around xd
Avatar
ChillerDragon BOT 2023-05-07 14:38:04Z
yes thats why i used vulkan until today
14:38
hm something is still not right
14:38
maybe new gnome broke everything
14:38
time to switch to gentoo and use tiling wm
Avatar
just use everything in fullscreen
14:39
that's what real pros do
Avatar
ChillerDragon BOT 2023-05-07 14:39:29Z
i do
14:40
but gnome is just bloat i dont really need all its features written in garbage javascript xd
Avatar
good, pro
14:40
xd yeah gnome sucks hard
Avatar
@Ryozuki do u have a SQL to check the shortest maps someone does not have finished yet per category? so if moderate is missing, shortest average time of maps that are missing
Avatar
chillerdragon BOT 2023-05-07 15:06:07Z
Ask chat gpt
Avatar
Avatar
Learath2
It's good, the worse optimized a piece of software is the more the new generation likes it
it's not like that all the time, sometimes smth happens and it lags like that, but i don't have such issues in clion or rider, so i just blame java and jvm
Avatar
Zoomer try not to defend bloated software challenge, impossible difficulty 🙃
Avatar
everything too bloated
Avatar
(I only jest, please don't cancel me for not wanting my software bloated)
Avatar
@Learath2 what makes ur OS slow, even if its in low level languages?
Avatar
Laws of Physics
Avatar
why does my file explorer take 1 second to start
Avatar
Bad software engineering
Avatar
even tho my ssd is faster than any hdd ever existed
Avatar
Avatar
Learath2
Zoomer try not to defend bloated software challenge, impossible difficulty 🙃
Millennials try not to confront zoomers about random stuff, impossible difficulty
Avatar
Avatar
Anime.pdf
Millennials try not to confront zoomers about random stuff, impossible difficulty
Zoomers try not to have wrong opinions challenge, heroic difficulty
Avatar
Avatar
Learath2
Zoomers try not to have wrong opinions challenge, heroic difficulty
Millennials try not to call other opinions wrong challenge, epic difficulty
Avatar
internet people try not to argue on internet over stupid stuff, impossible challenge
upp 1
Avatar
Yo can someone tell me how frequently / where the input from CGameClient::m_DummyInput gets sent off? I'm wondering where the best place to modify the dummies inputs is without doing it too frequently/infrequently
Avatar
Avatar
Jupstar ✪
even tho my ssd is faster than any hdd ever existed
probably because it first computes the 1st billion decimal of pi
Avatar
Avatar
Chairn
probably because it first computes the 1st billion decimal of pi
xdd but probably yes
Avatar
Avatar
Jupstar ✪
@Ryozuki do u have a SQL to check the shortest maps someone does not have finished yet per category? so if moderate is missing, shortest average time of maps that are missing
DM :)
brownbear 1
Avatar
then reads the same on disk file to check computer is working correctly 🙂
Avatar
modern software:
  • too many layers wrapping the same stuff and call it security feature
  • too much caching which too often does not work as intended
  • too often reinveted the wheel, which probably makes optimizations harder, and bloat more common
  • too often mixed with slow languages
16:29
  • too few @Learath2 in it
16:32
wat
Avatar
oh nice, are all asserts now displayed like that?
Avatar
Avatar
louis
Click to see attachment 🖼️
i think its fixed in next nightly, if u use nightly
Avatar
Avatar
louis
Click to see attachment 🖼️
bro's deen poggers2
Avatar
Exposed, nouis is deen
Avatar
Avatar
louis
Click to see attachment 🖼️
@Robyt3 is this safe to do? e.g. the showmsgbox in backend_sdl differs quite a bit, since it first destroys the window
16:36
on my amd gpu the messagebox blocked all input, and the mouse was still captured
16:36
and i could only escape with ctrl alt delete
16:37
cant we merge the impl?
Avatar
It's really quite hard to do that safely and properly if SDL doesnt have a bail function
Avatar
also asserts on other threads should never call this
16:37
only from main thread
Avatar
Modern or old, most software seems to lack good handling for errors :/
Avatar
:/
Avatar
Avatar
Jupstar ✪
cant we merge the impl?
you mean implement the messagebox ourself? I tried that first, but I didn't want to figure out how to add gtk3 to cmakelist
Avatar
no
Avatar
Avatar
Jupstar ✪
@Robyt3 is this safe to do? e.g. the showmsgbox in backend_sdl differs quite a bit, since it first destroys the window
maybe we need to add a separate function to graphics to also destroy the window
Avatar
in backend_sdl we already have a messagebox impl
Avatar
the message box should also work when the graphics are not initialized yet
Avatar
mh ok
16:44
we can also create the graphics first
16:44
or simply check if a window was created
Avatar
that increase the time that a blank window is shown, not really nice
16:45
just check if graphics are initialized and then call the special graphics method
16:45
otherwise just the basic popup message
Avatar
c++ bool CGraphicsBackend_SDL_GL::TryCreateMsgBox(bool AsError, const char *pTitle, const char *pMsg) { m_pProcessor->ErroneousCleanup(); SDL_DestroyWindow(m_pWindow); SDL_ShowSimpleMessageBox(AsError ? SDL_MESSAGEBOX_ERROR : SDL_MESSAGEBOX_WARNING, pTitle, pMsg, nullptr); return true; } the function is so small i guess we can live with 2 ifhere
Avatar
How to handle assert in other threads?
16:46
Does the SDL function work or does this currently crash?
Avatar
check if the assert handler thread id == the one that initialized the handler
Avatar
so only show popup for assertions on main thread?
Avatar
Avatar
Robyt3
Does the SDL function work or does this currently crash?
this will not work on macos
Avatar
Avatar
Robyt3
so only show popup for assertions on main thread?
yep i guess so
Avatar
we could add a queue for the assertions I guess
16:48
but it would be simpler to only shown the popup on the main thread
Avatar
This function should be called on the thread that created the parent window, or on the main thread if the messagebox has no parent. It will block execution of that thread until the user clicks a button or closes the messagebox.
16:48
and macos afaik, only allows creating windows on main thread
Avatar
Avatar
Robyt3
we could add a queue for the assertions I guess
problem is, sometimes we wait on other threads
16:49
so this defs increases the complexity by a lot
Avatar
yeah, all the threads adding items to the queue would have to wait until the item is consumed before calling dbg_break
16:49
so probably too much complexity
Avatar
most stuff is in the main thread rn anyway
16:50
and the vulkan backend handles errors already
Avatar
Thread carefully guys^ :))))
Avatar
gentoo is the way to a minimal bloated system
Avatar
Avatar
Ryozuki
gentoo is the way to a minimal bloated system
can u write the config for me xd i want to use it
17:19
but too lazy
Avatar
but even with 10% more perf, slow software is still slow
Avatar
its like arch but u just setup some flags
Avatar
does it have some UI for that?
Avatar
thats bloat
17:20
ur on the wrong path already
Avatar
xd
Avatar
long compile times make u avoid bloated software
Avatar
lmao
Avatar
its a way of life
Avatar
Avatar
Jupstar ✪
c++ bool CGraphicsBackend_SDL_GL::TryCreateMsgBox(bool AsError, const char *pTitle, const char *pMsg) { m_pProcessor->ErroneousCleanup(); SDL_DestroyWindow(m_pWindow); SDL_ShowSimpleMessageBox(AsError ? SDL_MESSAGEBOX_ERROR : SDL_MESSAGEBOX_WARNING, pTitle, pMsg, nullptr); return true; } the function is so small i guess we can live with 2 ifhere
Can we pass m_pWindow to SDL_ShowSimpleMessageBox as the last parameter to make it a modal dialog instead of destroying the window? Or does that also block input to the dialog for you?
Avatar
Avatar
Robyt3
Can we pass m_pWindow to SDL_ShowSimpleMessageBox as the last parameter to make it a modal dialog instead of destroying the window? Or does that also block input to the dialog for you?
yeah it was buggy and there was some open sdl issue for that
Avatar
Is there a reason why the remote console is limited to 199 pages while the console is not? I would be in favor of removing this cap
Avatar
3e810b9 Also print platform, game and OS version in assertion popup - Robyt3 262a2a8 Merge #6568 - bors[bot]
Avatar
does any dev know how the media time value of maps are calculated ? when i use ddstats website i don't find the same values for the median (edited)
19:11
19:12
19:12
Avatar
median != average time
Avatar
i know i've done average time before but extreme values fuck my charts up
19:14
wait my SQL might not be the correct one...
19:14
do you guys know what SQL was done for the value displayed on the website ? (if it was done with SQL in the first place)
19:35

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [X] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...
Avatar
i guess i'll just take average and limit time to 12h
19:53
highest time ever recorded is 498 days and 21h lol
19:53
not sure that's legit actually
19:56
idk what these are
Avatar
Avatar
Marsu
highest time ever recorded is 498 days and 21h lol
yea cuz u get killed if you race for longer justatest
20:06
"died of old age"
Avatar
817d96a Only show assertion popup for assertions on main thread - Robyt3 c841c7a Destroy window before showing popup if graphics initialized - Robyt3 f4d2b56 Merge #6570 - bors[bot]
Avatar
Avatar
bencie
"died of old age"
ahahah bencie knows things noone else does
Avatar
Avatar
Marsu
idk what these are
Hey it’s me
Avatar
Avatar
Marsu
highest time ever recorded is 498 days and 21h lol
Yeah it’s 2^30 milliseconds, and on maps like just every fly and puzzle partners and time shop(all of which include time penalty tiles) you can get the maximum time on without actually waiting nearly 500 days
Avatar
hmmmm okay
20:21
thought Time here is in seconds
20:22
i'm not sure that these times are relevant enough for them to be in the database...
Avatar
What are you working on, if I may ask?
Avatar
Avatar
bencie
yea cuz u get killed if you race for longer justatest
Used to not be the case and you could theoretically get a 1 second time on any map if you waited long enough 🙂 since it rolled over back to 0 again (edited)
Avatar
Avatar
UnlucksMcGee
What are you working on, if I may ask?
i'm just doing silly graphs for fun, i'm training (edited)
Avatar
i need help with cpp basics xd
Avatar
dont ask to ask
20:57
letsgo fixed
Avatar
nice font
20:59
🙂
Avatar
Avatar
bencie
nice font
😄
Avatar
``` 2023-05-07 23:31:02 I console: executing 'mysql.cfg' 2023-05-07 23:31:02 I server: Adding new SqlWriteServer: DB: 'teeworlds' Prefix: 'record' User: 'teeworlds' IP: Port: 3306 2023-05-07 23:31:02 I server: Adding new SqlReadServer: DB: 'teeworlds' Prefix: 'record' User: 'teeworlds' IP: Port: 3306 2023-05-07 23:31:02 I server: starting... 2023-05-07 23:31:02 I net: failed to bind socket with domain 2 and type 2 (98 'Address already in use') 2023-05-07 23:31:02 I server: couldn't op...
Exported 350 message(s)