DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2023-03-05 00:00:00Z and 2023-03-06 00:00:00Z

Chairn

eduroam is the shared wifi network across lots of univerisity/school in europe

world*

00:09

not only univ/schools, everything that is research related, for education purpose yes (edited)

[ddnet-maps:master] 1 new commit

876a7ab M Polarity, A Yeyou 6 - ddnet-maps

@Jupstar ✪ Is there something else you wanted to know or test for #6369 or can we merge it?

https://github.com/ddnet/ddnet/pull/6369

Fix Move also requesting the current canvas size, which should repo...

… a resize event fixes #6368 For some reason KDE seems to set the current window'd size of the window (even if i use fullscreen) for the window when its minimized. And ::Move re-requests the c...

Robyt3

@Jupstar ✪ Is there something else you wanted to know or test for #6369 or can we merge it?

i guess we can merge

[ddnet:master] 2 new commits

c7362ba Fix Move and SetWindowScreen also requesting the current canvas size, which should report a resize event - Jupeyy a14f32c Merge #6369 - bors[bot]

12:11

[ddnet/ddnet] Issue closed: #6368 Regression in text quality when tabbed out, then tab in again

12:11

[ddnet/ddnet] Pull request closed: #6369 Fix Move also requesting the current canvas size, which should report…

@deen ddnet should work with libx11 1.8.4 right?

13:47

for some reason the ebuild in gentoo had <=1.8.2

13:47

but idk why

13:48

does it even need libx11 dep

13:49

Image attachment

13:51

why a gdk dep

13:51

idk who made this before haha

seems weird

13:52

especially for server

13:52

pnglite also wrong

yeah

13:54

this was initially done by a non ddnet dev i guess

13:54

libpng is only needed on client right

13:54

we also dont use libglvnd, a lib from nvidia lol

13:55

nor glib

14:00

LICENSE="CC-BY-SA-3.0 OFL-1.1 BSD"

14:01

do we use ofl?

14:01

ah looks like a font license

see all our license.txt files for the mess we have

[ddnet/ddnet] Pull request opened: #6377 Fix invalid json (partially fixes #6366)

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

1

1

good that jopster is a lawayer

[ddnet:16.8] 10 new commits

462c86e Version 16.8 - def- de29f83 Only call onresize events if actual size changed - Jupeyy f152684 Update brazilian_portuguese.txt - rffontenelle d5f1418 Update spanish.txt - n0Ketchp 574e64b Fix incorrect text wrapping in ingame server info - Robyt3 b86035b Fix client crash when cl_chat_old config is used - Robyt3 4311fda Fix opening file in editor with enter not working after searching - Robyt3 cacf229 Fix Move and SetWindowScreen also requesting the current canvas size, which should report a resize event - Jupeyy 4b6fb9c Fix invalid json (partially fixes #6366) - def- aeb85ab Fix color in json (fixes remaining #6366 hopefully) - def-

14:41

[ddnet:master] 1 new commit

d6f617d Version 16.8 - def-

14:44

[ddnet-web:pr-16.8] 1 new commit

19283ff Version 16.8 - def-

14:45

[ddnet/ddnet] Pull request closed: #6360 Version 16.8

14:46

dependabot[bot]

[ddnet/ddnet] Pull request opened: #6378 Bump warp from 0.3.2 to 0.3.3 in /src/mastersrv

Bumps warp from 0.3.2 to 0.3.3. Release notes Sourced from warp's releases. v0.3.3 Fixes: Fix fs filters path sanitization to reject colons on Windows. Changelog Sourced from warp's changelog. v0.3.3 (September 27, 2022) Fixes: Fix fs filters path sanitization to reject colons on Windows. Commits 4e9c4fd v0.3.3 0074a0a fs: sanitize colons from file requests on windows 3cf1783 Fix test example so it doesn't fail (#988) 5723cac Use stat...

14:46

dependabot[bot]

[ddnet:warp-0.3.3] 1 new commit

a4576d8 Bump warp from 0.3.2 to 0.3.3 in /src/mastersrv - dependabot[bot]

14:46

dependabot[bot]

[ddnet/ddnet] New branch created: warp-0.3.3

wtf

14:48

@Ryozuki the rust gang attacks

this is github bot

14:50

disable it or smth xd

its funny bcs it even can add labels xD

ohhh

14:51

so the json

14:51

was the color

14:51

xddd

14:51

color -> "color"

yeah xD

[ddnet:master] 3 new commits

38933d3 Fix invalid json (partially fixes #6366) - def- 0ff19c6 Fix color in json (fixes remaining #6366 hopefully) - def- fdc425b Merge #6377 - bors[bot]

15:29

[ddnet/ddnet] Issue closed: #6366 Master info sometimes missing skins

15:29

[ddnet/ddnet] Pull request closed: #6377 Fix invalid json (partially fixes #6366)

dependabot[bot]

[ddnet/ddnet] Pull request opened: #6379 Bump tokio from 1.16.1 to 1.18.5 in /src/mastersrv

Bumps tokio from 1.16.1 to 1.18.5. Release notes Sourced from tokio's releases. Tokio v1.18.3 1.18.3 (September 27, 2022) This release removes the dependency on the once_cell crate to restore the MSRV of the 1.18.x LTS release. (#5048) #5048: tokio-rs/tokio#5048 Tokio v1.18.2 1.18.2 (May 5, 2022) Add missing features for the winapi dependency. (#4663) #4663: tokio-rs/tokio#4663 Tokio v1.18.1 1.18.1 (May 2, 2022) The 1.18.0 release broke the build for tar...

15:48

dependabot[bot]

[ddnet:tokio-1.18.5] 1 new commit

e0b0be2 Bump tokio from 1.16.1 to 1.18.5 in /src/mastersrv - dependabot[bot]

15:48

dependabot[bot]

[ddnet/ddnet] New branch created: tokio-1.18.5

15:49

[ddnet/ddnet] Pull request opened: #6380 Cargo update

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

15:53

[ddnet/ddnet-web] Pull request closed: #243 Version 16.8

15:53

[ddnet-web:master] 2 new commits

19283ff Version 16.8 - def- ee83a6a Merge pull request #243 from ddnet/pr-16.8 - def-

did u test the cargo update with a old rust

16:01

i think we need to be compat with debian version or smth

16:02

debian 10 has 1.41

16:02

rustup install 1.41

no

rust-toolchain.toml

[toolchain]
channel = "1.41.0"

16:05

if u crate a file with that it will set it to that

16:05

so its easier for new devs

[ddnet/ddnet] Pull request closed: #6380 Cargo update

https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

Overrides - The rustup book

is the 16.8 update released on steam yet?

Iza

is the 16.8 update released on steam yet?

Yes

16:10

Is something wrong with it or why do you ask?

16:11

If you are on nightly, you only get it in a few hours, but not relevant changes in there for client

Ah okay

deen

Is something wrong with it or why do you ask?

Moderational reasons

God forgive me for I have installer proprietary shitware on my computer

ban all old versions!

Learath2

God forgive me for I have installer proprietary shitware on my computer

nvidia driver?

Well that's not shitware

discord?

Nah, MATLAB and Mathematica

16:14

I'm using the web version of discord on linux because for some reason the desktop version is very slow and I cba to debug it

Use matlab Web too then

Doesn't have the control systems toolbox

Idk matlab but just build one your self hehe

16:16

Make it a browser extension

How would I build proprietary software myself?

Ah toolbox sounded like a button but I guess it’s more :D

16:18

Yea sounds like work

16:18

You screwed then

are you doing some automatism theory?

Learath2

I'm using the web version of discord on linux because for some reason the desktop version is very slow and I cba to debug it

i also use web on linux

Chairn

are you doing some automatism theory?

Automatic control, last boss of engineering course

with my self compiled firefox it runs better

Learath2

Automatic control, last boss of engineering course

not my best memory either

16:29

well, linear control is fine, non linear one on the other hand...

16:29

way too advanced mathematical stuff

Ryozuki

with my self compiled firefox it runs better

when rust browser?

16:30

oh stupid me, firefox is rust already

16:30

but is it 100% rust?

[ddnet/ddnet] Pull request opened: #6381 Flush `NETMSG_PING` and `NETMSG_PING_REPLY`

The client measures the time difference between ping send and ping reply receive. Without MSGFLAG_FLUSH the server keeps the chunk until the next flush which makes the ping dependend on when the next flush happens. Cherry-picked from teeworlds/teeworlds#3194.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added ...

[ddnet:master] 2 new commits

97ac4e7 Flush NETMSG_PING and NETMSG_PING_REPLY - ChillerDragon 775b35c Merge #6381 - bors[bot]

16:53

[ddnet/ddnet] Pull request closed: #6381 Flush `NETMSG_PING` and `NETMSG_PING_REPLY`

[ddnet:master] 10 new commits

d61fcba optimize map update - 0xfaulty 1bb7b5b use length_squared - Valentin Bashkirov 63fe1e2 rewrote pMap filling - Valentin Bashkirov 934546e skip pMap filling on new versions - 0xfaulty bb5f0f8 Cleanup unused or not defined functions - Kaffeine fc3ea43 CMake: Reset EXTRA_TOOL_SRC for each tool - Kaffeine bd22307 Fix manifest for custom executable name on windows - Kaffeine 3ba80cc CMake: Set literal (constant) names for client and server targets - Kaffeine 287d36c fixed comments - 0xfaulty 5107b38 Merge #6324 #6345 - bors[bot]

17:14

[ddnet/ddnet] Pull request closed: #6345 Set constant and uniform names for the server and client CMake targets

17:14

[ddnet/ddnet] Pull request closed: #6324 Optimize client ids map update

Learath2

My C/C++ brain really wants to do a lot more on the stack

you can do most of the stuff on the stack, I tried doing that in libtw2 for the most part. you lose out on some of the niceties of rust though

[ddnet/ddnet] Pull request closed: #6379 Bump tokio from 1.16.1 to 1.18.5 in /src/mastersrv

Learath2

I'm using the web version of discord on linux because for some reason the desktop version is very slow and I cba to debug it

php's memory leaks are no problem because you can just restart apache every 10 requests, you know?

heinrich5991

php's memory leaks are no problem because you can just restart apache every 10 requests, you know?

18:55

The web version is all js

https://en.wikiquote.org/w/index.php?title=Rasmus_Lerdorf&oldid=3062755

18:57

I'm not a real programmer. I throw together things until it works then I move on. The real programmers will say "Yeah it works but you're leaking memory everywhere. Perhaps we should fix that." I’ll just restart Apache every 10 requests.

lmao

Chairn

but is it 100% rust?

No

I'd love to see a bunch of skin color presets you could save (you can already bind them but it's not so convenient). Is it relevant tho?

i requested that long ago but the devs don't see that as important tho i assume (edited)

19:49

we could just steal the profile selector from tater client tho

heartw

1

u can also create skins as .cfg

19:51

and execute them

Ha, true

it still is like 1000x more inconvenient than just having a plain simple profile selector

the plain simple profile selector is something that will make the options tab more complicated for new users. it's also code that needs to be maintained

do we assume that new users have an average iq of 70 or am i missing something?

no, that's not the problem

Iza

do we assume that new users have an average iq of 70 or am i missing something?

They kinda do

the problem is that I don't want to open a program and be shown a lot of irrelevant options at first

19:54

I want to see the ones I'm likely to change

19:54

if calling me IQ 70 helps you, I guess do that?

heinrich5991

I want to see the ones I'm likely to change

Not really the point but why HSL is not 360 instead of 255?

I don't know about you but i am certain that alot of users will find it relevant and are likely to create their own profiles for their need of personalisation

I'd guess it's less than 10% of the users who'd do that

Actually why is everything 255

Floral Strobe

Not really the point but why HSL is not 360 instead of 255?

I don't know, I also dislike that

19:56

255 likely comes from the fact that a byte can represent 256 different values

1

heinrich5991

I'd guess it's less than 10% of the users who'd do that

why not ask the people?

19:57

or just implement it as a test and see what happens

if we implement something, we're lynched if we take it away

19:57

also the problem with asking for features is that people always want more features

19:57

they don't see the new user/code maintainability problem if it's "just one more feature"

heinrich5991

the problem is that I don't want to open a program and be shown a lot of irrelevant options at first

Honestly the amount of parameters is insane as fuck. You can tell this is a game of passionate devs. So to me your point doesn't work well

yes, you're right

19:58

they should be removed or presented in a better way

19:58

"it's bad. no problem to make it worse" is not a slogan I abide to

i mean i totally get the point of maintainability but i do not stand behind this "make everything dumb simple for the new people" policy

am I allowed to make it simple for me?

since when is that your point?

I, too, like simple software with good defaults

heinrich5991

they should be removed or presented in a better way

I actually like it very much like that. Some of them are too precise and not really relevant to the average player, but the most part are very cool to me

20:01

I think it is one of the strongest assets of the game behind gameplay

20:02

Although it's a mess, I can't disagree about the shitty presentation

wouldn't it be its open-source nature instead?

heinrich5991

I, too, like simple software with good defaults

why shouldn't a profile selector be simple?

20:02

thats what i dont understand

heinrich5991

wouldn't it be its open-source nature instead?

Ofc, I was focusing on in-game experience

I remember too complicated config dialogues from other games

20:03

where you had to create profiles to change simple settings

20:03

instead of just be thrown at the configuration options

heartw

1

you don't have to do it like them

20:04

i would just like for a convenience feature that is self explanatory

I guess the "simple profile selector" was too imprecise before

20:04

yea, that's the goal anytime

20:04

how do we make it a convenience feature that is self explanatory?

well the best thing i can refer to here now is to just look at the profile selector from taterclient

20:05

i think they did a solid job

got a screenshot?

Image attachment

20:05

Something resembling this (edited)

20:05

Boxes of given/set colors you could select (edited)

not knowing the game, this looks horribly complicated. maybe it gets better if I knew the game

20:05

ah

20:06

the middle part is probably just selecting shapes

Just the color part, yeah

heinrich5991

got a screenshot?

Image attachment

20:11

i think that's pretty neat

I was picturing smth like that

Image attachment

damn you got the same background as me

^^

Iza

Click to see attachment 🖼️

~~Too many selection boxes~~ Actually I just find it ugly, no real point to make (edited)

20:19

But yeah, it works too

Image attachment

20:38

Clicking on a color box would open its dedicated HSL tab

20:39

Clicking on a skin box would open its dedicated skin selection tab

let's replace the useless prefix thing with presets justatest

justatest

Image attachment

heartw

3

Ravie

let's replace the useless prefix thing with presets justatest

justatest

The default eyes boxes could work as presets along with that

I mean you would just save all the current settings and then you can pick it from the dropdown list

Yeah

20:50

Also thanks a lot to whoever implemented smooth scrolling today, my eyes finally stopped hurting

i'd say if, we'd need to merge TEE and PLAYER tab

Image attachment

20:53

else its confusing gui wise

eh i believe someday heinrich will not be so serious about custom options so i could request for parameter that changes skin box

20:57

4 columns... is too much for my dead eye xd

20:58

also maybe ddnet should have favourite skins box instead of all skins cuz i don't think that player will change skin everyday xd

@heinrich5991 see? the people are in for this

21:46

just need to know how to implement it

[ddnet/ddnet] Pull request closed: #6378 Bump warp from 0.3.2 to 0.3.3 in /src/mastersrv

21:56

[ddnet/ddnet] Issue opened: #6382 Add ingame leaderboards

Since a huge part of this gamemode is speedrunning, it could get some enhancements. My suggestion is to add actual speedrunning leaderboards instead of having it in chat (/top5team, for example). My idea would be like a tab on ESC menu that you could go to and there would be all the possible leaderboards that ddnet has such as /top5, /top5team and whatever.

Can you guy explain this?

Image attachment

22:01

pepedead

22:02

Replicate: right click on the red rectangle press tab, while holding red rectangle release rectangle, the option stuff don't disappear hold the red rectangle again press tab again for visibility right click again

22:02

repeat from step 1

[ddnet/ddnet] Issue opened: #6383 Envelope popups can be opened multiple times when hiding user interface

Reported by Cellegen | RiH on Discord: !screen

Replicate: right click on the red rectangle press tab, while holding red rectangle release rectangle, the option stuff don't disappear hold the red rectangle again press tab again for visibility right click again repeat from step 1

Also affects the popup for the pivot point. We should prevent those popups fr...

heinrich5991

also the problem with asking for features is that people always want more features

@Iza I predicted that people are in favor of new features

freeze bar enters the chat

heinrich5991

if we implement something, we're lynched if we take it away

@Devinci that would be this message

How is windows a serious operating system?

22:52

I had a usb with a corrupted partition table, no matter what tool I used windows couldn't just zero out the damn partition table and start over

22:52

The partition table broke diskpart, made it completely unusable

22:53

Booted into linux, cfdisk -z and it just worked. Not only that I could also just open it in cfdisk and read the broken partition table no problem

22:57

The fact that they can demand money for this summer project level OS actually baffles me

23:00

Even funnier the uefi implementation of mbr read it just fine, even as corrupted, which is hilarious to me

hi @Learath2

1

Exported 210 message(s)