DDraceNetwork - developer

dang

18:27

today i hyperfocused and its already night

18:27

if u hyperfocus again, it will be day

18:36

out smart the hyper focusing by hyper focusing

@Ryozuki good point for Rust giga_chad

18:38

yikes

def-

[ddnet/ddnet] Pull request opened: #6370 Add comic emoticons by Ravie

@HiRavie Fine by you? !Screenshot 2023-02-28 at 19 50 22

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing

...

add them as the default? or just have them in the assets folder?

folder

19:44

Ob-Ewan Kenobi

the release candidate as well as nightly refuses to run for me on windows 10, when running the latest code in debug I get the following exception:

Exception thrown: read access violation.
**CComponent::Graphics**(...) returned nullptr.

in CChat::RebuildChat at the line Graphics()->DeleteQuadContainer(Line.m_QuadContainerIndex);

Please post the entire stack trace for the crash (or the crash dump, which should also contain symbols if you use the debug build)

20:30

I can reproduce the crash when starting with the argument cl_chat_old 0, because the chained command handler assumes that the graphics have already been initialised

works fine for me o win7

But the crash could also be triggered if the window is resized while the graphics are not initialised

20:32

If this event is somehow triggered before the graphics exist

Chairn

works fine for me o win7

Weird. Looks like a nullptr access though, so it should just crash

20:33

Maybe it causes undefined behaviour for you

do i need fullscreen?

20:34

self compiled and rc are always windowed on my setup, easier to debug (prevents cursor locking) (edited)

If you start with ddnet "cl_chat_old 0" is should crash in any case

20:34

Because this causes the chat to be rebuild before graphics are up

20:38

Seems like it can only be caused by cl_chat_old, because the resize listener is not (and cannot be) registered until graphics are up

indeed it crashes on self compiled

Thread 1 received signal SIGSEGV, Segmentation fault.
0x000000000050d735 in CChat::RebuildChat (this=0x7330c98)
    at E:/Teeworlds_DDNet/ddnet/src/game/client/components/chat.cpp:51
51                      Graphics()->DeleteQuadContainer(Line.m_QuadContainerIndex);
(gdb) bt
#0  0x000000000050d735 in CChat::RebuildChat (this=0x7330c98)
    at E:/Teeworlds_DDNet/ddnet/src/game/client/components/chat.cpp:51
#1  0x000000000050dc64 in CChat::ConchainChatOld (pResult=0x225970,
    pUserData=0x7330c98,
    pfnCallback=0x4687bf <IntVariableCommand(IConsole::IResult*, void*)>,
    pCallbackUserData=0x915e40 <CConsole::Init()::Data>)
    at E:/Teeworlds_DDNet/ddnet/src/game/client/components/chat.cpp:145
#2  0x000000000047b90b in CConsole::Con_Chain (pResult=0x225970,
    pUserData=0x63b7ee0)
    at E:/Teeworlds_DDNet/ddnet/src/engine/shared/console.cpp:1241
#3  0x0000000000467899 in CConsole::ExecuteLineStroked (this=0x6324a70,
    Stroke=1, pStr=0x47c7e19 "cl_chat_old 0", ClientID=-1,
    InterpretSemicolons=true)
    at E:/Teeworlds_DDNet/ddnet/src/engine/shared/console.cpp:549
#4  0x0000000000467b75 in CConsole::ExecuteLine (this=0x6324a70,
    pStr=0x47c7e19 "cl_chat_old 0", ClientID=-1, InterpretSemicolons=true)
    at E:/Teeworlds_DDNet/ddnet/src/engine/shared/console.cpp:613
#5  0x000000000047b2a6 in CConsole::ParseArguments (this=0x6324a70,
    NumArgs=1, ppArguments=0x47c7898)
    at E:/Teeworlds_DDNet/ddnet/src/engine/shared/console.cpp:1094
#6  0x00000000004de4b9 in main (argc=2, argv=0x47c7890)
    at E:/Teeworlds_DDNet/ddnet/src/engine/client/client.cpp:4672

20:40

bad bot (as usual)

I'll fix the crash

20:41

Can we not update the bot so it ignores the hash sign in code blocks?

this is old as fuck bugs, where's the ddnet bot code?

https://github.com/ddnet/ddnet-discordbot

GitHub - ddnet/ddnet-discordbot

Contribute to ddnet/ddnet-discordbot development by creating an account on GitHub.

Robyt3

[ddnet/ddnet] Pull request opened: #6371 Fix client crash when `cl_chat_old` config is used

The graphics are not initialised when RebuildChat is called by ConchainChatOld, which causes the client to crash if cl_chat_old is present in the user's config or used as a command line argument.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null poi...

i guess we gotta change this variable use https://github.com/ddnet/ddnet-discordbot/blob/master/cogs/github.py#L16 (edited)

bors[bot]

[ddnet:master] 3 new commits

ab6ffdd Add comic emoticons by Ravie - def- 1b08935 Fix some createivecommons links to use https - def- f57f2f1 Merge #6370 - bors[bot]

20:58

bors[bot]

[ddnet/ddnet] Pull request closed: #6370 Add comic emoticons by Ravie

Chairn

indeed it crashes on self compiled

Thread 1 received signal SIGSEGV, Segmentation fault.
0x000000000050d735 in CChat::RebuildChat (this=0x7330c98)
    at E:/Teeworlds_DDNet/ddnet/src/game/client/components/chat.cpp:51
51                      Graphics()->DeleteQuadContainer(Line.m_QuadContainerIndex);
(gdb) bt
#0  0x000000000050d735 in CChat::RebuildChat (this=0x7330c98)
    at E:/Teeworlds_DDNet/ddnet/src/game/client/components/chat.cpp:51
#1  0x000000000050dc64 in CChat::ConchainChatOld (pResult=0x225970,
    pUserData=0x7330c98,
    pfnCallback=0x4687bf <IntVariableCommand(IConsole::IResult*, void*)>,
    pCallbackUserData=0x915e40 <CConsole::Init()::Data>)
    at E:/Teeworlds_DDNet/ddnet/src/game/client/components/chat.cpp:145
#2  0x000000000047b90b in CConsole::Con_Chain (pResult=0x225970,
    pUserData=0x63b7ee0)
    at E:/Teeworlds_DDNet/ddnet/src/engine/shared/console.cpp:1241
#3  0x0000000000467899 in CConsole::ExecuteLineStroked (this=0x6324a70,
    Stroke=1, pStr=0x47c7e19 "cl_chat_old 0", ClientID=-1,
    InterpretSemicolons=true)
    at E:/Teeworlds_DDNet/ddnet/src/engine/shared/console.cpp:549
#4  0x0000000000467b75 in CConsole::ExecuteLine (this=0x6324a70,
    pStr=0x47c7e19 "cl_chat_old 0", ClientID=-1, InterpretSemicolons=true)
    at E:/Teeworlds_DDNet/ddnet/src/engine/shared/console.cpp:613
#5  0x000000000047b2a6 in CConsole::ParseArguments (this=0x6324a70,
    NumArgs=1, ppArguments=0x47c7898)
    at E:/Teeworlds_DDNet/ddnet/src/engine/shared/console.cpp:1094
#6  0x00000000004de4b9 in main (argc=2, argv=0x47c7890)
    at E:/Teeworlds_DDNet/ddnet/src/engine/client/client.cpp:4672

which language syntax highlighting is this?

murpii

[ddnet/ddnet-discordbot] Pull request opened: #38 Ignore code blocks from all messages using string replacement

(?:\w+\n)? should match optional language identifiers in a codeblock

def-

[ddnet/ddnet-discordbot] Pull request closed: #38 Ignore code blocks from all messages using string replacement

22:20

def-

[ddnet-discordbot:master] 2 new commits

886e444 Ignore code blocks from all messages using string replacement - murpii 2ef1a84 Merge pull request #38 from murpii/patch-1 - def-

22:23

bors[bot]

[ddnet:master] 2 new commits

24fd7e6 Fix client crash when cl_chat_old config is used - Robyt3 5b05f6a Merge #6371 - bors[bot]

22:23

bors[bot]

[ddnet/ddnet] Pull request closed: #6371 Fix client crash when `cl_chat_old` config is used

Robyt3

[ddnet/ddnet] Pull request opened: #6372 Check in CI that no C standard headers are used, replace all usages of C standard headers with C++ headers, replace usages of C math functions

Closes #6334.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/...

murpii

[ddnet/ddnet-discordbot] Pull request opened: #39 Ignore issues between #0-49

as suggested by heinrich5991

def-

[ddnet:master] 1 new commit

2ab5c2e Revert "Add comic emoticons by Ravie" - def-