DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2023-01-07 00:00:00Z and 2023-01-08 00:00:00Z

[ddnet:master] 3 new commits

f79daac Add page up/down, home, end hotkeys to UI - Robyt3 91a23f0 Port CListBox from upstream, smooth scrolling for all lists - Robyt3 73ce759 Merge #6240 - bors[bot]

00:00

[ddnet/ddnet] Issue closed: #5791 Smooth scrolling for all scrollregions

00:00

[ddnet/ddnet] Pull request closed: #6240 Port `CListBox` from upstream, smooth scrolling for all lists

@Jupstar ✪ merge conflict

[ddnet/ddnet] Pull request opened: #6248 src/engine/shared/datafile.cpp: Re-add #include for big endian

This was removed by @Robyt3 in commit 31533d5e2aaa3d071668285af72997d95d631e1c, but it is still used behind #if defined(CONF_ARCH_ENDIAN_BIG) at https://github.com/ddnet/ddnet/blob/master/src/engine/shared/datafile.cpp#L145-L147 resulting in: https://buildd.debian.org/status/fetch.php?pkg=ddnet&arch=s390x&ver=16.4-1&stamp=1665528559&raw=0 ``` /<>/src/engine/shared/datafile.cpp: In member function ‘bool CDataFileReader::Open(IStorage, const char, int)’: /<>/src/engine/shared/datafi...

man, the serverbrowser looks so sexy without a scrollbar

Image attachment

08:24

somehow much more modern

08:29

for some reason in the past weeks i often had this bug in github

Image attachment

Smooth scrolling in server browser & using vulkan 1.1.0 is killing my FPS the longer I scroll

09:14

IPv6 addresses in the server info box in Esc -> Server info is clipping into the game info box

some neat memory leak

09:16

indeed laggs hard when scrolling in debug mode

09:16

but as soon as it stops its over for me

09:17

it looks like it reuploads something. at least the staging buffer always increases for 1-2 frames

@Robyt3 Thanks for copy info box :)

[ddnet-web:master] 1 new commit

b428880 frontpage video - def-

murpi

Smooth scrolling in server browser & using vulkan 1.1.0 is killing my FPS the longer I scroll

@Robyt3 does the new scrollbar update the CUIRect of the rows and did the only scrollbar not do this?

09:52

i see most time is spent in rebuilding the serverbrowser text

09:52

while scrolling

09:53

Image attachment

Image attachment

09:55

i guess as long as width and height of the rects stays the same, we could just move the text call with the in built offset instead of rebuilding it based on x,y changes

The FPS drop while scrolling is basically the same before and after if you scroll continuously for me, but now the FPS drop for the entire duration of the smooth scroll

ah i see

09:56

but just to be sure, it's because the ui rect changes all the time?

09:56

the coordinates

09:57

c++
    virtual void RenderTextContainer(int TextContainerIndex, const ColorRGBA &TextColor, const ColorRGBA &TextOutlineColor, float X, float Y) = 0;

we have a rendertextcontainer that supports offsets

09:57

so this might be fixable easy

09:58

ah yeah

09:58

i think i fixed it

Jupstar ✪

but just to be sure, it's because the ui rect changes all the time?

yeah, the UI rect position y changes whiles scrolling

[ddnet/ddnet] Pull request opened: #6249 Pr fix streamtext rebuild

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

https://github.com/ddnet/ddnet/pull/6249/commits/3a52ad861119e5a7e758f1b309775fe0f8042353

nice, now there is almost no FPS drop while scrolling

its also useful for CUIElement::SUIElementRect::Draw but if i am not blind it's dead code as of now... but i cannot remember where it was used in the past

10:06

@Robyt3 maybe u remember it

[ddnet:master] 2 new commits

abb1979 src/engine/shared/datafile.cpp: Re-add #include <base/math.h> for big endian - AdrianBunk 22a7b00 Merge #6248 - bors[bot]

10:23

[ddnet/ddnet] Pull request closed: #6248 src/engine/shared/datafile.cpp: Re-add #include for big endian

[ddnet:master] 2 new commits

1182180 Add skin to serverbrowser player list - Jupeyy 6993133 Merge #6242 - bors[bot]

10:47

[ddnet/ddnet] Pull request closed: #6242 Add skin to serverbrowser's scoreboard

could this be used to codesign the fat binaries for macos? https://github.com/indygreg/apple-platform-rs/tree/f69ad3207e9a4898e338fbf1a2b24b9985fb5a03/apple-codesign

apple-platform-rs/apple-codesign at f69ad3207e9a4898e338fbf1a2b24b9...

Rust crates supporting Apple platform development. Contribute to indygreg/apple-platform-rs development by creating an account on GitHub.

[ddnet-scripts:master] 1 new commit

9a3e185 Retry steam deploy - def-

how come clang-tidy doesn't catch this as a useless store? https://github.com/ddnet/ddnet/pull/6246/commits/0ef312d739e02408fe64b39e60b5f1ecc9216f3c

I guess it doesn't look into the SetHookedPlayer function, so it has to assume that the function could have changed m_HookState

wrong channel above msg is deleted (for those who are from bridge)

17:06

correct channel was #bugs

who added the smooth scrolling in the server browser? it's very nice!

Robyt did

elon musk did

Ur mom did justatest

justatest

gigachad

Image attachment

21:51

steam reached all time onnline users

21:51

record

32 million teeworlds players poggers2

poggers2

do invisible players also count?

23:28

or only players "conected"

Exported 55 message(s)