Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2023-01-03 00:00:00Z and 2023-01-04 00:00:00Z
Avatar
GitHub BOT 2023-01-03 00:14:44Z
Author icon
def-
[ddnet-web:master] 1 new commit
2ddc9b6 Add bra2 to server stats - def-
Avatar
Ryozuki 2023-01-03 06:57:36Z
someone doing automated tests on gentoo guru found this
06:57
https://bugs.gentoo.org/888875
06:57
idk how much of a problem it is
06:57
but i think its an issue with cmake itself not the ebuild
06:58
Bug 888875 - [guru] games-action/ddnet-16.6 overwrites CFLAGS/CXXFLAGS or adds uncommon ones
06:58
here is the ebuild if ur curious https://gitweb.gentoo.org/repo/proj/guru.git/tree/games-action/ddnet/ddnet-16.6.ebuild
ddnet-16.6.ebuild « ddnet « games-action - repo/proj/guru.git - GUR...
Browse the Gentoo Git repositories
06:59
their build log https://888875.bugs.gentoo.org/attachment.cgi?id=845660
06:59
* Tinderbox QA Notice: This package seems to overwrite CFLAGS/CXXFLAGS or add uncommon ones: * The following flags (probably added by the build system) should be stripped out * * 1) -D_FORTIFY_SOURCE=2 * 2) -fstack-protector-all * * Final size of build directory: 175416 KiB (171.3 MiB) * Final size of installed tree: 66044 KiB ( 64.4 MiB)
07:01
@heinrich5991 what do u think?
Avatar
deen 2023-01-03 08:53:33Z
Yes, we do that, for security
08:53
I didn't know it's bad style to add security related flags
08:54
It's a bit like complaining our source code has runtime check for array out of bounds access because they are too expensive
Avatar
Learath2 2023-01-03 09:16:13Z
I think the gentoo stance is to make all security flags optional if they impact perf
Avatar
Ryozuki 2023-01-03 09:31:04Z
they are probable controlled by portage
09:31
probably
09:31
its more that the package forces this and the user cant choose with their portage flags or smth
09:36
this is a QA by a random user btw
09:37
i did run pkgcheck on the ebuild when making it and it didnt throw any warnings
Avatar
chillerdragon BOT 2023-01-03 10:00:03Z
Who does out of bounds check? Ubsan? Where is that active? (@deen)
Author icon
deen
It's a bit like complaining our source code has runtime check for array out of bounds access because they are too expensive
2023-01-03 08:54:27Z
10:01
Oh wait or do you mean actual handwritten code that checks stuff like if (ClientID > MAX_CLIENTS) return
Avatar
Ryozuki 2023-01-03 10:04:17Z
ye
Avatar
GitHub BOT 2023-01-03 13:38:39Z
Author icon
Robyt3
[ddnet/ddnet] Pull request opened: #6220 Fix signed integer overflow on client input message, refactoring

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [X] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...
13:39
Author icon
def-
[ddnet/ddnet] Pull request opened: #6221 Add -DSECURITY_COMPILER_FLAGS=OFF option
To disable -D_FORTIFY_SOURCE=2 -fstack-protector-all, see https://bugs.gentoo.org/888875 for report. Default behavior is not changed.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no phy...
Avatar
deen 2023-01-03 13:39:34Z
Alright, added an option for them @Ryozuki ^
Avatar
Ryozuki 2023-01-03 13:59:14Z
tyty
Avatar
Avatar
Ryozuki
this is a QA by a random user btw
Ryozuki 2023-01-03 13:59:34Z
not just any random user, its a gentoo dev lol
Avatar
GitHub BOT 2023-01-03 14:07:08Z
Author icon
bors[bot]
[ddnet:master] 5 new commits
25e01eb Add constants for minimum and maximum tick values - Robyt3 e4b1db1 Fix spelling of NETMSG_AUTH_CHALLENGE constant - Robyt3 706eb0d Remove unnecessary include in protocol, move definitions to cpp file - Robyt3 c2c2129 Fix signed integer overflow on client input message - Robyt3 1f392b8 Merge #6220 - bors[bot]
14:07
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6220 Fix signed integer overflow on client input message, refactoring
Avatar
GitHub BOT 2023-01-03 14:47:06Z
Author icon
Robyt3
[ddnet/ddnet] Pull request opened: #6222 Fix undefined demo timeline markers when recording is not stopped
When the demo recording is not stopped properly (e.g. client crashes during recording), the timeline markers and the demo length are not updated. The length is always set to zero when starting the recording, but uninitialized memory is written for the timeline markers, which causes these demos to likely show the maximum number of markers with some markers possibly being outside the ticks that the demo contains. This is fixed by initially setting all timeline marker data to zero when starting ...
Avatar
Ryozuki 2023-01-03 15:32:43Z
https://blog.cloudflare.com/opaque-oblivious-passwords/
OPAQUE: The Best Passwords Never Leave your Device
Imagine passwords for online services that never leave your device, encrypted or otherwise. OPAQUE is a new cryptographic protocol that makes this idea possible, giving you and only you full control of your password.
Thumbnail
Avatar
heinrich5991 2023-01-03 15:35:26Z
I thought there were such protocols before OPAQUE
Avatar
Learath2 2023-01-03 15:46:33Z
Kerberos, ms chap?
Avatar
HahahoupasGR 2023-01-03 15:50:21Z
ad
Avatar
Avatar
Ryozuki
https://blog.cloudflare.com/opaque-oblivious-passwords/
Jupstar ✪ 2023-01-03 15:53:54Z
Tl;dr whats the alternative ?
Avatar
Ryozuki 2023-01-03 15:54:07Z
https://github.com/jbangert/trapcc
GitHub - jbangert/trapcc: Computing with traps
Computing with traps. Contribute to jbangert/trapcc development by creating an account on GitHub.
Thumbnail
15:54
lol
Avatar
Avatar
Jupstar ✪
Tl;dr whats the alternative ?
Ryozuki 2023-01-03 15:54:16Z
its zero proof password auth iirc
Avatar
Avatar
Jupstar ✪
Tl;dr whats the alternative ?
heinrich5991 2023-01-03 15:54:20Z
you can prove that you have the password without sending it to the server
Avatar
Ryozuki 2023-01-03 15:54:22Z
u send a proof u know the password
15:54
so the password is never sent
Avatar
Jupstar ✪ 2023-01-03 15:55:13Z
Ok but u still save ur pw in a key manager which u host online in case ur house burns. Does it solve this too
Avatar
Ryozuki 2023-01-03 15:55:25Z
dont host it online
15:55
just replicate it 3 times locally
15:55
invent a fire proof usb
15:55
kek
Avatar
Learath2 2023-01-03 15:55:57Z
Well when you host it online you usually host it completely encrypted
15:56
So your plaintext pw never makes it anywhere of your computer, theoretically
Avatar
Jupstar ✪ 2023-01-03 15:57:22Z
Yes. So the blog is about the pw being plain text on the server?
Avatar
Ryozuki 2023-01-03 15:57:32Z
http://mainisusuallyafunction.blogspot.com/2014/02/x86-is-turing-complete-with-no-registers.html
x86 is Turing-complete with no registers
In which x86 has too many registers after all. Introduction The fiendish complexity of the x86 instruction set means that even bizarrely r...
Avatar
Avatar
Jupstar ✪
Yes. So the blog is about the pw being plain text on the server?
Learath2 2023-01-03 15:58:16Z
I didn't read the entire thing yet, but yes, that's the idea
Avatar
Avatar
Jupstar ✪
Yes. So the blog is about the pw being plain text on the server?
heinrich5991 2023-01-03 15:58:45Z
yes, basically about preventing that
Avatar
Jupstar ✪ 2023-01-03 15:59:14Z
I see thanks for saving me time xd
Avatar
GitHub BOT 2023-01-03 15:59:23Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
9ea665c Fix undefined demo timeline markers when recording is not stopped - Robyt3 1f5c269 Merge #6222 - bors[bot]
15:59
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6222 Fix undefined demo timeline markers when recording is not stopped
Avatar
Avatar
Jupstar ✪
I see thanks for saving me time xd
Ryozuki 2023-01-03 16:00:03Z
so u dont read everything i post
16:00
noted
16:00
feelsbadman
16:01
@Learath2 @Jupstar ✪ https://startafuckingblog.com/
Start a Fucking Blog
Go on, do it right fucking now - it's the best thing on the web you can do.
Thumbnail
16:01
justatest
16:02
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027108
16:02
its happening
16:03
(removing python 2 from debian)
16:03
ddnet-scripts needs fixing
16:03
it uses python2 xD
Avatar
Learath2 2023-01-03 16:03:47Z
Rip python2, you won't be missed
Avatar
heinrich5991 2023-01-03 16:03:59Z
I tried updating it once
16:04
not sure what problems I encountered
Avatar
Learath2 2023-01-03 16:04:33Z
Veery big problem with ddnet-scripts is the disk caches we use
16:05
The upgrade needs to be instant and recalculate everything from scratch. Python3 version of diskcache chokes hard on the python2 saved caches
Avatar
deen 2023-01-03 16:05:09Z
@Jupstar ✪ hm, do we really want to have translations for the 50 or so error messages for graphics? 😄
Avatar
Avatar
Learath2
The upgrade needs to be instant and recalculate everything from scratch. Python3 version of diskcache chokes hard on the python2 saved caches
deen 2023-01-03 16:05:52Z
How about we use materialized views for the entire website and cache nothing? I might be motivated to do that
Avatar
heinrich5991 2023-01-03 16:06:07Z
what does "materialized views" mean?
Avatar
Learath2 2023-01-03 16:06:11Z
Now this is a group of words idk. Materialized views?
16:06
Ah sql ones
16:06
Yeah, I had something similar in mind
Avatar
Avatar
heinrich5991
what does "materialized views" mean?
deen 2023-01-03 16:06:52Z
Yes, SQL, a view stores the query to access a table, then you can easily select from it and the more complex query is executed
16:07
A materialized view doesn'T just store the query but also the result, so you can actually get it faster
Avatar
HahahoupasGR 2023-01-03 16:07:08Z
fokkonaut
16:07
fokkonaut you nice server
Avatar
heinrich5991 2023-01-03 16:07:29Z
is that always up-to-date? or can you tell it to lag behind to save processing time? (edited)
Avatar
HahahoupasGR 2023-01-03 16:07:34Z
Roolpo on me
16:07
😄
16:07
🙂
Avatar
heinrich5991 2023-01-03 16:07:44Z
@HahahoupasGR use DMs
Avatar
deen 2023-01-03 16:07:47Z
It lags behind in the current implementation in all common databases (mysql, postgres)
Avatar
heinrich5991 2023-01-03 16:07:52Z
nice
Avatar
Ryozuki 2023-01-03 16:08:01Z
oh thats nice
Avatar
deen 2023-01-03 16:08:04Z
There is work in postgres to auto-update it
Avatar
heinrich5991 2023-01-03 16:08:13Z
I like that
Avatar
Ryozuki 2023-01-03 16:08:16Z
so this is like a on-db cache?
Avatar
heinrich5991 2023-01-03 16:08:18Z
sounds like a good use case for a db ^^
Avatar
HahahoupasGR 2023-01-03 16:08:32Z
^ ^
16:08
a
Avatar
Ryozuki 2023-01-03 16:08:37Z
stop spamming
Avatar
HahahoupasGR 2023-01-03 16:08:39Z
🙂
Avatar
Ryozuki 2023-01-03 16:08:40Z
ur annoying
Avatar
HahahoupasGR 2023-01-03 16:08:42Z
❤️
Avatar
deen 2023-01-03 16:08:57Z
And I'm going to start working on a product that does these materialized views for an existing database: https://materialize.com/ So I might start implementing something, it would be a postgres backend though
The Streaming Database | Materialize
Materialize is a streaming SQL database for real-time applications, live dashboards, and streaming data pipelines. It provides the simplicity of SQL queries, but with millisecond-level latency for real-time data.
Thumbnail
Avatar
Ryozuki 2023-01-03 16:09:08Z
postgres best
Avatar
deen 2023-01-03 16:09:10Z
(auto-updating instantly)
Avatar
Ryozuki 2023-01-03 16:09:26Z
as long as what we use is open source
16:09
i dont mmind
Avatar
Avatar
deen
It lags behind in the current implementation in all common databases (mysql, postgres)
Learath2 2023-01-03 16:09:29Z
I never checked how these work. When does it get updated?
16:09
Manually?
Avatar
deen 2023-01-03 16:09:46Z
Yes, you run a refresh command
Avatar
Learath2 2023-01-03 16:09:57Z
And does refresh lock?
Avatar
heinrich5991 2023-01-03 16:09:59Z
then it drops everything and the DB lags for 10 minutes?
Avatar
deen 2023-01-03 16:10:02Z
https://github.com/sraoss/pg_ivm is the repo for the in-progress work for incremental mat views
GitHub - sraoss/pg_ivm: IVM (Incremental View Maintenance) implemen...
IVM (Incremental View Maintenance) implementation as a PostgreSQL extension - GitHub - sraoss/pg_ivm: IVM (Incremental View Maintenance) implementation as a PostgreSQL extension
Avatar
Ryozuki 2023-01-03 16:10:26Z
ohh incremental too
Avatar
Avatar
deen
@Jupstar ✪ hm, do we really want to have translations for the 50 or so error messages for graphics? 😄
Jupstar ✪ 2023-01-03 16:10:43Z
I dunno. Better than answering the question in question every time
Avatar
Learath2 2023-01-03 16:10:52Z
Oh and yes that, is refresh incremental currently?
Avatar
Avatar
heinrich5991
then it drops everything and the DB lags for 10 minutes?
deen 2023-01-03 16:10:56Z
It shouldn't when you use concurrently: https://www.postgresql.org/docs/current/sql-refreshmaterializedview.html
REFRESH MATERIALIZED VIEW
REFRESH MATERIALIZED VIEW REFRESH MATERIALIZED VIEW — replace the contents of a materialized view Synopsis REFRESH MATERIALIZED VIEW [ CONCURRENTLY …
Thumbnail
Avatar
Avatar
Learath2
Oh and yes that, is refresh incremental currently?
deen 2023-01-03 16:11:12Z
Right now every refresh in mysql/postres is a full recalculation, thus expensive
Avatar
Learath2 2023-01-03 16:12:00Z
I can imagine that being a pretty hard problem to solve for dbms ppl
Avatar
deen 2023-01-03 16:12:47Z
Yes, that's the hope with Materialize, that it's too complex and better solved in an on-top-solution where your changes are streamed (via Change Data Capture)
16:13
This blog post on the topic is a nice motivation: https://lironshapira.medium.com/data-denormalization-is-broken-7b697352f405
Data denormalization is broken
Why it’s impossible to write good application-layer code for everyday business logic
Thumbnail
Avatar
Ryozuki 2023-01-03 16:14:18Z
medium meh
16:14
it always looks so uggly
Avatar
Avatar
Jupstar ✪
I dunno. Better than answering the question in question every time
deen 2023-01-03 16:16:20Z
But when we get the error message in Russian it will be harder for us to understand 😄 Can the user do anything with Submitting to graphics queue failed. or No vulkan queue family properties found.?
16:17
The ones with an action like Failed during initialization. Try to change gfx_backend to OpenGL or Vulkan from settings_ddnet.cfg in the config directory and try again. seem helpful
Avatar
Jupstar ✪ 2023-01-03 16:18:28Z
Mh hard part is just to distinguish between both
16:18
Then I've to extend the error strings by a is translatable string
16:19
Open am issue and tag me then i do it soon: tm:
Avatar
GitHub BOT 2023-01-03 16:21:31Z
Author icon
def-
[ddnet/ddnet] Issue opened: #6223 Only translate graphics errors with a user-defined action
I noticed that there are lots of new strings to translate for 16.7, not sure if we win anything by translating these very specific error messages or just confuse the translators and create additional work for us to translate the errors back into English. But when we get the error message in Russian it will be harder for us to understand 😄 Can the user do anything with "Submitting to graphics queue failed." or "No vulkan queue family properties found."? The ones with an action like "Failed ...
16:21
Author icon
bors[bot]
[ddnet:master] 2 new commits
bd815a0 Swap times should be per player, not per team (fixes #6155) - def- b36726b Merge #6156 - bors[bot]
16:21
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #6155 Swap timeout sometimes resets
16:21
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6156 Swap times should be per player, not per team (fixes #6155)
Avatar
Avatar
Jupstar ✪
Then I've to extend the error strings by a is translatable string
heinrich5991 2023-01-03 16:23:15Z
alternatively, include an error code
16:23
rustc does it
16:23
V-0001
16:23
to V-0015
Avatar
Avatar
Ryozuki
https://bugs.gentoo.org/888875
heinrich5991 2023-01-03 16:27:05Z
did you notice it's just a couple of numbers short of 888888?
16:27
newest bug rn is https://bugs.gentoo.org/888885
Avatar
GitHub BOT 2023-01-03 16:33:15Z
Author icon
def-
[ddnet-web:master] 1 new commit
f0314c9 Update Persian mods - def-
Avatar
Ryozuki 2023-01-03 16:40:30Z
true lol
Avatar
Avatar
heinrich5991
alternatively, include an error code
Jupstar ✪ 2023-01-03 16:46:57Z
Yeah could do that too^^
Avatar
Avatar
heinrich5991
did you notice it's just a couple of numbers short of 888888?
Jupstar ✪ 2023-01-03 16:47:32Z
Let's create some ddnet issue xdd
Avatar
GitHub BOT 2023-01-03 16:48:21Z
Author icon
bors[bot]
[ddnet:master] 3 new commits
496b911 Add -DSECURITY_COMPILER_FLAGS=OFF option - def- 4e86bf0 Describe some more cmake flags - def- 5016c70 Merge #6221 - bors[bot]
16:48
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6221 Add -DSECURITY_COMPILER_FLAGS=OFF option
Avatar
deen 2023-01-03 16:48:47Z
You are too late, some issues are not visible because they might have been deleted or are security relevant
Avatar
murpi 2023-01-03 16:48:49Z
I've got a sample of a failed map download, anyone interested in debugging this?
Avatar
deen 2023-01-03 16:48:56Z
They are higher already @heinrich5991 https://bugs.gentoo.org/888890
Avatar
Avatar
murpi
I've got a sample of a failed map download, anyone interested in debugging this?
deen 2023-01-03 16:49:37Z
Got full logs? You could put them in an issue
Avatar
gerdoe 2023-01-03 16:50:10Z
https://bugs.gentoo.org/888888 ?
16:50
404 for me
Avatar
Avatar
deen
Got full logs? You could put them in an issue
murpi 2023-01-03 16:50:28Z
I just got the map and the temp file, that's it
Avatar
Avatar
gerdoe
https://bugs.gentoo.org/888888 ?
deen 2023-01-03 16:50:41Z
Yes, because the issue is deleted or you don't have permissions to see it
Avatar
Avatar
deen
Yes, because the issue is deleted or you don't have permissions to see it
gerdoe 2023-01-03 16:50:54Z
got it
16:50
thanks xd
Avatar
deen 2023-01-03 16:51:09Z
They might have a policy where a crash report is always marked as possibly security relevant initially, and only unmarked when a dev took a look
Avatar
HahahoupasGR 2023-01-03 17:13:12Z
a
17:13
hey
17:13
hi
Avatar
Ryozuki 2023-01-03 17:14:00Z
@heinrich5991 this guy has only been spamming now
17:14
maybe do smth
Avatar
HahahoupasGR 2023-01-03 17:14:39Z
sry it was my littlbe brother
17:15
I'm gonna remove his disc 😄
Avatar
Mr.Gh0s7 2023-01-03 17:19:58Z
@heinrich5991 Can you ban him, it's ok if not? It's my little brother. He won't let me remove his disc rn. I forgot to uninstall it from his windows partition. I have done so from his linux one. The above messages are the proof you need tbh (to know his my lil bro). (edited)
Avatar
gerdoe 2023-01-03 17:28:17Z
i can start spreading misinformation to troll but the situation is already too funny xd
Avatar
Mr.Gh0s7 2023-01-03 17:29:12Z
D: I could take his hardrive or his whole pc but banning him should appear to him as it should. He did smth wrong and was punished for it by a 3rd party.
Avatar
ChillerDragon BOT 2023-01-03 18:30:26Z
@Mr.Gh0s7 omg is that roolpo? is that ur lil brota? can you please unbind his chat key or teach him some english bruu none of his sentences make any sense
Avatar
Mr.Gh0s7 2023-01-03 18:31:05Z
lol sry. Ok will do. Idk if he knows how to binds keys tho
Avatar
GitHub BOT 2023-01-03 18:39:21Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
68625dd Implement exact matches in search and exclude strings - def- 6d3af74 Merge #6180 - bors[bot]
18:39
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6180 Implement exact matches in search and exclude strings
18:42
Author icon
bencie
[ddnet/ddnet] Issue opened: #6224 Moderators timeout upon receiving too many rcon lines
I encountered this issue when I tried to dump_log, dump_antibot and status using 1 bind on a populated server. With some testing, I noticed that every single time i hit the bind, I can only receive 174 lines (6 pages) of rcon before it stops, and doesn't finish printing everything. When I hit this bind on a populated server, it causes me to be unable to read/send messages, emotes, but I can still play and interact with the game for about a minute, after that I get timed out. The bind used: b...
wtf 1
Avatar
GitHub BOT 2023-01-03 18:51:30Z
Author icon
def-
[ddnet/ddnet] Issue closed: #6224 Moderators timeout upon receiving too many rcon lines
Avatar
GitHub BOT 2023-01-03 19:35:12Z
Author icon
def-
[ddnet/ddnet] Pull request opened: #6225 Update translations for upcoming 16.7

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to integration test
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...
Avatar
Robyt3 2023-01-03 20:21:50Z
Should we update this list of releases: https://github.com/ddnet/ddnet/blob/6d3af742dd1aec107cffcd2fe49d80eaea973e19/other/ddnet.appdata.xml#L40-L83 ? Or should we just get rid of the list so we don't have to maintain it?
ddnet/ddnet.appdata.xml at 6d3af742dd1aec107cffcd2fe49d80eaea973e19...
DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.
Thumbnail
Avatar
deen 2023-01-03 21:15:44Z
not sure, what is it good for?
Avatar
Robyt3 2023-01-03 21:20:43Z
It would show a list of releases with their release dates in package managers that use this type of file
21:21
Not really useful to maintain this separately IMO. We can just link to the downloads page that contains all releases.
👍 1
Avatar
GitHub BOT 2023-01-03 22:33:38Z
Author icon
Zwelf
[ddnet/ddnet] Pull request opened: #6226 Remove projectiles on save and load
Restructured CSaveTeam a bit, because I also needed access to CGameWorld. I don't store pointer to IGameController in CSaveTeam anymore, because we pass CSaveTeam to the database thread. If it would be accessed there, it could cause a race conditions.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test (especially base/) or added coverage to in...
22:35
Author icon
def-
[ddnet/ddnet] Issue closed: #2621 Pinyin tab completion
Avatar
GitHub BOT 2023-01-03 23:12:46Z
Author icon
Robyt3
[ddnet/ddnet] Pull request opened: #6227 Fix more issues with the `restart` command
Closes #6168. Not resetting the team when restarting requires too much effort for a feature that would only be active with the non-default sv_rejoin_team_0 0 setting. If the restart command is used for testing a map or for tournaments, it would be easy enough as a workaround to create a bind to join a specific team after restarting, so I don't think this is necessary.

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in...
Avatar
GitHub BOT 2023-01-03 23:40:16Z
Author icon
bors[bot]
[ddnet:master] 4 new commits
dd4e2d6 Send updated teams state to clients after resetting round - Robyt3 dfe0ec3 Restart client race demo when round is restarted - Robyt3 2163691 Refactor team state unpacking - Robyt3 4ca0506 Merge #6227 - bors[bot]
23:40
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #6168 More issues when using `restart`
23:40
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #6227 Fix more issues with the `restart` command
Exported 178 message(s)