DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-12-30 00:00:00Z and 2022-12-31 00:00:00Z

Jupstar ✪

dunno, can u reproduce?

It hasn't worked for me lately either

same^

Bored? irc.twistednet.org Channel Twisted

Jupstar ✪

Click to see attachment 🖼️

172 FPS

nouaa

but I still use windows XP..

Please don't. There have been no security updates for a long time now

10:12

And if you have to, you can keep using an older DDNet version, the current one doesn't work anyway

he's just trolln

You should use ReactOS if you want to use old-school Windows: https://reactos.org/ I'm wondering if DDNet runs, but probably should since they work closely with the Wine devs

11:04

They have a Teeworlds screenshot on their page, so should work

[ddnet/ddnet] Pull request opened: #6207 Run unit tests with sanitizers (fixes #6205)

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

@Patiga bruv @fokkonaut and I were debugging for way too long why the dark design was generated wrong. Seems like twmap 0.3 generates different (hash missmatch) map files than twmap 0.4 oof

could you provide me the different files? I don't see a commit which could cause that

oh woot ur not aware?

do you mean simple map resaving or with editing inbetween?

not resave its editing

13:27

applying this darkmode edit script https://github.com/DDNetPP/maps-scripts/blob/master/BlmapChill/dark.py on this map https://github.com/DDNetPP/maps/blob/master/BlmapChill.map

maps-scripts/dark.py at master · DDNetPP/maps-scripts

Scripts for things like themes. Contribute to DDNetPP/maps-scripts development by creating an account on GitHub.

maps/BlmapChill.map at master · DDNetPP/maps

Official ddnet++ maps. Contribute to DDNetPP/maps development by creating an account on GitHub.

that is curious

13:28

could you send me the two map files?

i think i deleted the old sec

13:28

ye i did :(

13:29

how do u downgrade pip stuff sec

ah right you are talking about twmap python

oh yea

13:29

i py nob

13:31

@Patiga here u go :) https://maps.zillyhuhn.com/

13:31

BlmapChill817.. is the input map both _dark ones are generated using the same dark.py script

13:32

dark_3c3aa is twmap 0.4 and dark_d9ff is twmap 0.3

13:36

I used 0.3.0 and 0.4.1 to be specific

0.3.0 -> 0.4.0 definitely had the breaking change of switching many things to fixed point numbers which are represented as floats in python

13:37

but the things you edited shouldn't fall into this category

13:37

for example things like offsets and positions are now all represented with 1.0 = 1 tile

[ddnet/ddnet] Pull request opened: #6208 Prevent temporary demo file from being deleted multiple times

Each time the client disconnected or stopped a demo, it tried to delete the previous temporary replay file, which causes an error message "could not delete file" to be shown in the console. This is prevented by clearing the current filename of the demo recorder after deleting the file.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (esp...

ChillerDragon: I think I got it

14:13

twmap adapted the thing from 0.7 where upon saving, all air tiles are un-rotated and un-mirrored

14:14

that will probably be the difference

[ddnet-web:pr-2023-funding] 1 new commit

3a8471d Add Taiwan server - def-

15:00

[ddnet:master] 2 new commits

a3e48be Prevent temporary demo file from being deleted multiple times - Robyt3 3be6edc Merge #6208 - bors[bot]

15:00

[ddnet/ddnet] Pull request closed: #6208 Prevent temporary demo file from being deleted multiple times

Ah nice Good catch (@Patiga)

twmap adapted the thing from 0.7 where upon saving, all air tiles are un-rotated and un-mirrored

16:43

Yea I guess I gotta keep versions in sync if I depend on hash matching

[ddnet/ddnet] Pull request opened: #6209 Simplify ninja code

Reasoning this code is correct:

OldPos is set to m_Pos in line 260
m_Pos is not modified in between line 260 and 272 (only m_Core.m_Pos gets modified)
Therefore line 269 Dir = m_Pos - OldPos is always vec2(0.0, 0.0).
And line 271 Center = OldPos + Dir * 0.5 = OldPos.

So we can pass OldPos to FindEntities in line 272. Using OldPos here instead of m_Pos makes it clear, that we use the position before the move, even though m_Pos still holds the old value....

17:15

[ddnet/ddnet] Issue opened: #6210 Certain switch layer tiles cover other tiles

If you have a switch, time switch, or any laser turret tile from the switch layer placed with a game/front tile behind it, they'll be completely invisible both in editor and in game if the switch layer's order is higher than the game/front layers orders are. This could be a bit confusing when mapping if you're trying to add tiles behind these switch tiles. Example 1: Game layer (with freeze tiles) as order 0, switch layer as order 1: https://i.imgur.com/2YMs8YT.png Example 2: Game layer a...

[ddnet:master] 2 new commits

e3147ce Simplify ninja code - Zwelf 9071a4a Merge #6209 - bors[bot]

18:07

[ddnet/ddnet] Pull request closed: #6209 Simplify ninja code

[ddnet/ddnet] Pull request opened: #6211 Fix edge cases where demo tick seeking did not work

Instead of using hardcoded tick offsets, use the current/previous/next tick values from the demo info. This fixes seeking the next tick not working for demos where the difference between the current and the next tick was greater than 3.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration te...

[ddnet:master] 2 new commits

6800bd9 Fix edge cases where demo tick seeking did not work - Robyt3 1ad36b2 Merge #6211 - bors[bot]

20:44

[ddnet/ddnet] Pull request closed: #6211 Fix edge cases where demo tick seeking did not work

[ddnet-web:master] 1 new commit

49d2426 Add back bencie - def-

21:33

[ddnet/ddnet-web] Pull request closed: #221 Update funding for 2023

21:33

[ddnet-web:master] 7 new commits

89a38b3 Update funding for 2023 - def- 5f055be Hetzner price increases for 2023 - def- 8166b1c Remove GER10 - def- 3a5d33b Revert "Remove GER10" - def- b1fe282 Remove NLD - def- 3a8471d Add Taiwan server - def- d32ec4c Merge pull request #221 from ddnet/pr-2023-funding - def-

[ddnet:master] 3 new commits

ed58668 Remove possible overflow in str_comp_filenames (fixes #6204) - Chairn 2847d0f Added some test cases that were failing under new version - Chairn beae6b8 Merge #6206 - bors[bot]

21:45

[ddnet/ddnet] Issue closed: #6204 Buffer overflow in str_comp_filenames

21:45

[ddnet/ddnet] Pull request closed: #6206 Remove possible overflow in str_comp_filenames (fixes #6204)

[ddnet/ddnet] Issue opened: #6212 Rust tests can't be linked with asan+ubsan in different directory

Noticed in https://github.com/ddnet/ddnet/pull/6207, but works fine in source directory. ``` $ mkdir san $ cd san $ CC=clang CXX=clang++ CXXFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer" CFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer" cmake -DCMAKE_BUILD_TYPE=Debug .. $ make -j8 run_rust_tests [...] Compiling ddnet-engine-shared v0.0.1 (/media/ddnet/src/engine/shared) error: linkin...

GitHub

Click to see attachment 🖼️

@deen why bors this one? I hadn't change the condition, was busy failing 10 times a minute on Back in Time 3

Because otherwise my other change stays red

23:14

https://github.com/ddnet/ddnet/pull/6207

Chairn

@deen why bors this one? I hadn't change the condition, was busy failing 10 times a minute on Back in Time 3

you could do a followup PR

23:14

but yea, usually one waits for the comments to be resolved ^^

and now im busy philosophing in #off-topic

deen

Because otherwise my other change stays red

now it's green

[ddnet:master] 3 new commits

6691be1 Run unit tests with sanitizers (fixes #6205) - def- c633905 Address comment from https://github.com/ddnet/ddnet/pull/6206/ - def- 21b3b3b Merge #6207 - bors[bot]

23:46

[ddnet/ddnet] Issue closed: #6205 Also run tests with ASan and UBSan in CI

23:46

[ddnet/ddnet] Pull request closed: #6207 Run C++ unit tests with sanitizers (fixes #6205)

Exported 64 message(s)