DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-12-21 00:00:00Z and 2022-12-22 00:00:00Z

It still should register something then right? And for me the Apache proxy worked wonderfully. I could see a server pop up in the master and in the ddnet server log I got the proper responses from the master. (@deen)

I think the proxy will cause problems, it will try to register the ip of the proxy server, not the actual ip

00:39

On the ddnet Persian master I miss responses in the log and nothing gets registered

It still should register something then right? And for me the Apache proxy worked wonderfully. I could see a server pop up in the master and in the ddnet server log I got the proper responses from the master.

was the server on localhost?

00:40

chillerdragon

Nope

00:40

Ah wait

00:40

Shit

00:40

Hmm

00:40

Oh wow my test was trash haha

00:41

Good catch Heinrich

00:41

Guess next up is run the tw Server on another vps to better reproduce

00:44

Just run a master server on every vps. EzBut the client only asks one master and expects it to have all entries right?

yep

[ddnet:master] 2 new commits

900417b Send laser objects as DDNetLaser with type (fixes #5885) - fokkonaut 327f7de Merge #5886 - bors[bot]

00:59

[ddnet/ddnet] Issue closed: #5885 DDNetLaser should also be used for other laser types

00:59

[ddnet/ddnet] Pull request closed: #5886 Send laser objects as DDNetLaser with type (fixes #5885)

Then just bundle the server.jsons into one. Or edit the client to merge multiple masters.Both weird hacks. But both should work for the Persian empire.

01:00

It would just defeat the purpose of a master server haha

01:00

Heinrich why is localhost so easy and non localhost such a bitch?

if you proxy the stuff with apache

01:01

(which you should)

01:02

then the masterserver needs some way to get the original IP address

01:02

because the request will come from apache (127.0.0.1)

Doesn’t Apache set a header by default?

which header is that?

X- whatever

01:03

Forwarded For

01:03

Or something

01:03

I used it before in nodejs behind Apache

01:05

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For

X-Forwarded-For - HTTP | MDN

The X-Forwarded-For (XFF) request header is a de-facto standard header for identifying the originating IP address of a client connecting to a web server through a proxy server.

this looks like a bad header

01:07

it has security advice right in the mdn

Oof

01:07

Yes about non existent proxy’s

01:08

You said one should use a proxy for the master

yes

01:08

the reverse proxy should set a header to the remote IP address

01:08

I haven't found a simple way to do that with apache in 5 min already

Also what on earth kind of deranged engineer made apple's implementation of smb? Who in their right mind would copy a file sync in a ui routine?

My Apache does it by default

01:12

f any trusted reverse proxies are between the client and server, the final X-Forwarded-For IP addresses (one for each trusted proxy) are trustworthy, as they were added by trusted proxies. (That's true as long as the server is only accessible through those proxies and not also directly).

01:12

I don’t see the problem

01:12

Edit: If any trusted reverse proxies are between the client and server, the final X-Forwarded-For IP addresses (one for each trusted proxy) are trustworthy, as they were added by trusted proxies. (That's true as long as the server is only accessible through those proxies and not also directly).

01:12

Edit: > If any trusted reverse proxies are between the client and server, the final X-Forwarded-For IP addresses (one for each trusted proxy) are trustworthy, as they were added by trusted proxies. (That's true as long as the server is only accessible through those proxies and not also directly).

01:14

If the ip is 127.0.0.1 assume trusted proxy and fallback to the header. Sounds sane to me.

ah, here: https://stackoverflow.com/a/46659932

Apache Server add client IP in a custom header before forwarding re...

Scenario is such that the Apache Http Server will act as a reverse proxy and sit in front of the main application server. In the application server the client IP address needs to be logged. My

01:16

do something like this: RequestHeader set TRUEIP "%{REMOTE_ADDR}s"

01:16

and then start the masterserver with --connecting-ip-header TRUEIP

01:17

chillerdragon: can you try that?

Bruv I’m on ma phony

ok

My header is set anyways

what header?

I don’t know what you mean

x-forwarded-for?

https://httpd.apache.org/docs/current/mod/mod_proxy.html#x-headers

01:19

Yes

01:19

I use this proxy pass

I don't want to implement that, seems like a security vulnerability waiting to happen

01:20

the masterserver currently only supports getting the IP address via a header, not from a comma-separated list in a header (edited)

Yes but is it a security vuln if you only look at the http header if the tcp header is 127.0.0.1 ?

01:22

Im sure it can be but then the admin messed up anyways

01:22

Always take the first entry and you good

yes, because apache will merge the existing X-Forwarded-For header into the one forwarded

01:22

I don't want to get into parsing this obviously badly thought out header

Yea ignore those

01:23

It will prefix the ip from the tcp header

when the secure alternative is so easy

01:23

RequestHeader set TRUEIP "%{REMOTE_ADDR}s"

Okay now I get you

--connecting-ip-header TRUEIP

This modifys the tcp header?

no. this throws away any TRUEIP header the client sends

01:24

and sets the TRUEIP http header to the connecting client IP address

Yea I got it

the advantage is that this either doesn't work (because the admin hasn't configured it) or works securely

Is that your intended way of doing it since you have a cli flag for that in the master?

if I started parsing the x-forwarded-for header, I'm sure some admin will manage to mess it up so it's insecure

01:25

yes

If yes that’s the 2nd sentence your readme could enjoy :p

yep

Also might be the fix for our Persian friend :)

plus the hints for logging

01:26

yes, sounds like it

Yes true

'拏 MAhdiyar

@heinrich5991 The normal port of the master server is 8080, but with apache proxy, the procedure is 443 Our problem is not solved yet We changed to 443 in order to get SSL

add the following to the apache proxy config: RequestHeader set TRUEIP "%{REMOTE_ADDR}s" and then start the masterserver with --connecting-ip-header TRUEIP

01:27

(pinging @'拏 MAhdiyar) (edited)

01:28

good night

Gn8 babe

@heinrich5991 ok ty gn

[ddnet-maps:master] 1 new commit

f932e6d M Adorenarine, A Slippy Slide Up - ddnet-maps

@Jore

Image attachment

brownbear

1

i don't have that :I

11:14

Image attachment

Its not in settings

11:18

Its pop-up when you start the game

11:18

Afaik

justatest

there i only get the 2 options, play and cancel button

This is most likely still a beta feature

11:23

https://help.steampowered.com/en/faqs/view/276C-85A0-C531-AFA3

I had a choice first few starts of the game, then its just opened it how it wants to

good news is that the latest amd driver works again, so the bug is fixed

11:26

so soon the option will be gone anyway

11:28

@murpi if u want u can already drop it now tbh it didnt help for many ppl anyway, and all new players hopefully dont have this driver or use the latest one

Jupstar ✪

good news is that the latest amd driver works again, so the bug is fixed

That's great news brownbear

brownbear

murpi

This is most likely still a beta feature

ah yeah i upgraded to steam beta too, got it now ^^

[ddnet/ddnet] Pull request opened: #6173 Add README.md for the mastersrv, briefly explaining the setup

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssan...

chillerdragon: does https://github.com/ddnet/ddnet/pull/6173 look good to you?

Add README.md for the mastersrv, briefly explaining the setup by he...

Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test (especially base/) or add...

does DDNet now have a required dependency on discord-game-sdk?!

LordMZTE

does DDNet now have a required dependency on discord-game-sdk?!

no

13:09

https://github.com/ddnet/ddnet/blob/327f7de09bd59057b31e185c6645bb87f1a62999/CMakeLists.txt#L126-L127

ddnet/CMakeLists.txt at 327f7de09bd59057b31e185c6645bb87f1a62999 · ...

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

ah good. kinda unfortunate, that the AUR ddnet package has that on :/

i think u can disable game support in discord per app

13:11

and if u dont run discord it shouldnt do anything anyway i guess

thats not the point, the point is that i dont even trust that proprietary lib as far as i can throw it.

mhh, but then arch is maybe not the right distribution, they allow some non free packages

13:12

but i guess u can overload the AUR flags?

13:12

shouldnt be too hard

its not that bad that they allow them, but i prefer not using them.

13:13

yea i guess ill have to redo the PKGBUILD

maybe we can try out https://github.com/EmbarkStudios/discord-sdk

13:14

^^

oh that sounds nice!

13:15

ive seen that theres a cargo config in DDNet now, but how much of it has been RIIR'd?

for the first release we just wanted to make sure to not drop any users by using rust

why would anyone bother?

so there is not really any code inside the client yet except rust_version

13:16

to drop users?

13:16

i mean there are some exotic archicetures out there XD

13:17

and even tho not the case here, some libs also only support newer windows (edited)

so theres arches that DDNet supports but rust doesnt?

i guess so

thats gotta be insanely exotic tho

yes

13:18

however, since our main audience is windows. we also have to make sure to not drop win7 for example

13:18

i am already happy we dont support win xp anymore lmao

lol

13:19

why is win7 endangered tho?

well win7 support ended

13:19

at some point libs will use win8+ API

there's been winapi changes? i thought that stuff didnt change in at least 10 years lol

they dont really change it in a sense of dropping smth

13:20

but they simply add new calls

LordMZTE

thats gotta be insanely exotic tho

See some of the supported archs here https://www.freshports.org/games/DDNet/ and here: https://packages.debian.org/unstable/ddnet

FreshPorts -- games/DDNet: DDraceNetwork, a cooperative racing mod ...

DDraceNetwork (DDNet) is an actively maintained version of DDRace, a Teeworlds modification with a unique cooperative gameplay. Help each other play through custom maps with up to 64 players, compete against the best in international tournaments, design your own maps, or run your own server. The official servers are located in Germany, Poland, R...

@Jupstar ✪ i was thinking about the render multiple demos thing… how would you want to see it done: a) ingame menu with rendering minimized and maybe even progress bar in the demo list b) startup parameter like ddnet —renderdemo demo.demo or c) extract the whole render code and have a pure command line tool. Nice about c) would be, you could put it on a server and render without gui. What‘s most realistic too?

c) with vulkan you can™️ render without any surface attached. but i dunno if u can do it xD a) shouldnt be too hard if i understand correctly. simply add smth like a demo queue to render b) is basically the easiest i'd say for a) if u want it to work minimized u need to create a background framebuffer, since minimizing changes the surfaces -> changes framebuffer (and u need to add it for both opengl and vk, and for OpenGL i think it is only core since 3.0) (edited)

[ddnet/ddnet] Issue opened: #6174 suggesting (sign , filters servers novice >insane)

!4444444 i always looking for map unfinished and i bad in remember maps name so always unpurposely i join this maps i don't like ( will be nice if i can just put sign dislike on it) !555555 and this i think is should be first thing in Filters but still not exist for example i w...

[ddnet:master] 2 new commits

7bacbb0 Add README.md for the mastersrv, briefly explaining the setup - heinrich5991 5831e76 Merge #6173 - bors[bot]

14:34

[ddnet/ddnet] Pull request closed: #6173 Add README.md for the mastersrv, briefly explaining the setup

Jupstar ✪

c) with vulkan you can™️ render without any surface attached. but i dunno if u can do it xD a) shouldnt be too hard if i understand correctly. simply add smth like a demo queue to render b) is basically the easiest i'd say for a) if u want it to work minimized u need to create a background framebuffer, since minimizing changes the surfaces -> changes framebuffer (and u need to add it for both opengl and vk, and for OpenGL i think it is only core since 3.0) (edited)

I‘ll start with trying b, start parameter (edited)

u could simply name it bam_04

15:02

ah u mean from a repo

15:02

i guess u need to compile yourself

15:04

http://ftp.us.debian.org/debian/pool/main/b/bam/bam_0.4.0-5_amd64.deb unpack this

15:04

rename the bam binary, then put it into /usr/bin with sudo

15:05

the package does not do lot more

15:07

in worst case u might need https://packages.debian.org/stretch/liblua5.1-0 too

15:07

i dunno how exactly its linked

15:07

easier is probs to compile urself ^^

heinrich5991

how do you start the masterserver currently?

This is fine for me, but when I put it on another VPS, it has a problem

LordMZTE

thats not the point, the point is that i dont even trust that proprietary lib as far as i can throw it.

are you a true arch user?

17:53

u should know how to use a PKGBUILD without a aur helper

17:53

download the PKGBUILD

17:54

modify it to ur liking

17:54

donne

17:54

thats the way linux is done

i know

i even have my own server that builds PKGBUILDs automatically for me

17:55

i just havent bothered yet.

i would edit the PKGBUILD but i am no longer a arch user

17:55

i upgraded to gentoo

17:55

and i maintain the ebuild

17:55

BASEDDEPT

@Ryozuki planning on keeping as co-maintainer?

not rly sry

19:45

mainly cuz i wiped my arch xD

1

LordMZTE

ah good. kinda unfortunate, that the AUR ddnet package has that on :/

Let me know if you have any other suggestion, preferably that involves still having the feature enabled.

[ddnet/ddnet] Pull request opened: #6175 Render bar below server browser to show loading progression

Render a slim bar below the server browser listbox to show the loading progression, instead of showing a percentage on the Refresh button, as suggested in https://github.com/ddnet/ddnet/pull/5878#issuecomment-1257227947. The margin around the bottom status elements is removed to make more space and improve the alignment of the elements with the rest of the server browser. https://user-images.githubusercontent.com/23437060/209000517-76fea4a1-e2d2-41de-b5af-1d907589e30e.mp4 (I used `br...

[ddnet:master] 2 new commits

1eb600f Render bar below server browser to show loading progression - Robyt3 db08cc0 Merge #6175 - bors[bot]

22:59

[ddnet/ddnet] Pull request closed: #6175 Render bar below server browser to show loading progression

Exported 179 message(s)