DDraceNetwork

sry to ask again but is this gonna get fixed / are u planning to fix it

the issue is being tracked at https://github.com/ddnet/ddnet/issues/5844

Color Picker doesn't keep color when reselected. · Issue #5844 · dd...

Reported by cyberFighter on Discord (This applies to all the color picker buttons): simply clicking some of the laser wall color buttons changes their H/V values by -2/-1/+1/+2 Most notably in the ...

milk dudd

sry to ask again but is this gonna get fixed / are u planning to fix it

it's not actively planned to be fixed, there is no one actively working on it right now

milk dudd

the S and V values in entities background color goes down each time i open the color selection thing

The entities background color selector is kinda buggy meaning you sometimes can't choose the color you want

14:14

There is a workaround I used where I just created a new blank map with the background color I wanted and set the background color to that map

Mh, I wonder if I could get it stable by rounding to closer integer instead of rounding to lower integer

ye, something like that should work

Learath2

Mh, I wonder if I could get it stable by rounding to closer integer instead of rounding to lower integer

just copy code from stackoverflow greenthing

Learath2

Mh, I wonder if I could get it stable by rounding to closer integer instead of rounding to lower integer

Rounding with round_to_int in color4_base::Pack made it more stable, so it doesn't change multiple times when opening and closing the color picker, but it still changes on some values. It doesn't pass the tests cases yet. I wonder if it's even possible to make them pass, i.e. have exactly the same packed values after roundtrip color conversion.

Robyt3

Rounding with round_to_int in color4_base::Pack made it more stable, so it doesn't change multiple times when opening and closing the color picker, but it still changes on some values. It doesn't pass the tests cases yet. I wonder if it's even possible to make them pass, i.e. have exactly the same packed values after roundtrip color conversion.

that would probably be an improvement already

17:52

maybe we should just™ switch to rgb instead ^^

17:52

downsides of that? @Learath2

We break everyones old colors

only by a bit or so, no?

Though rgb 1 byte per component is technically a more dense space, so old colors will change a tiny bit

17:54

Well not more dense I guess. But of uniform density

heinrich5991

downsides of that? @Learath2

By storing rgb in the config? You run new client once, old client once, and then you lose all your color settings

And that ^^

we could make an annoying compatibility hack for that

17:56

e.g. saving both hsl and afterwards the rgb

17:56

and preferring the rgb if both are there

yeah, something like that. can remove that after some time then

Though I'm not sure if it'll help for the color pickers we have that are hsl and hsv

18:01

We'll still have to convert back and forth

eh

18:07

true

18:07

so not a good solution

can we just store hsl with higher precision so we don't care about losing some precison?

ah yea, that might also work