DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-11-29 00:00:00Z and 2022-11-30 00:00:00Z

Anime.pdf

I love reading raw json, thanks feelsbadman

feelsbadman

https://jsonhero.io/

JSON Hero - A beautiful JSON viewer

JSON Hero makes reading and understand JSON files easy by giving you a clean and beautiful UI packed with extra features.

Does anyone know if it is possible to associate ddnet with a url protocol

10:35

In a way that by clicking a url makes it so you join a server

10:36

something like ddnet://{server-ip}:{server-port}

Should be

Sadly only over Firefox

10:50

Chrome sends the port formatted over a parameter instead of raw

10:50

But we could extend the client to accept that too. Most users probably don't use Firefox

Can you maybe give me an example of the url

10:59

Should I register the protocol myself?

Look at ddnet.org status

11:12

The URL is clickable

11:13

The server url bottom right

Perfect.

Alexander

something like ddnet://{server-ip}:{server-port}

It's literally the same format as this too

Alexander

It's literally the same format as this too

Do with slashes it works on chrome? Seems like ddnets page doesn't use them

Actually it doesn't work, I think it's because I don't have the ddnet protocol associated with the ddnet client in my settings

12:19

So I'm looking into it right now

Yeah I've associated protocol ddnet with ddnet.exe but it just opens the client, nothing else

12:34

Why doesn't ddnet do that automatically anyways?

It should work with Firefox

13:00

Last time i tested

13:00

For other brothers we simply need to parse the port from the query

13:00

Browser

do you maybe use the steam version

Alexander

do you maybe use the steam version

I usually try stuff without stream So did you click the one on ddnetorg or your own with slashes?

chrome doesn't pass the port?

13:18

why not?

It does. But as query string

13:19

So i asked if the slashes are maybe essential

13:19

But Alexander doesn't get it to work at all

I'm using brave which is based on chromium

13:20

At first nothing worked

13:20

With or without the slashes

I'll later test when I'm home

When I've added ddnet as ddnet protocol it worked with and without the slashes

13:20

But it didn't join the servers

But it tried?

No it just showed the default screen

For me it tried. But maybe recent changes just cancel the request now

main menu

13:21

Are you on windows maybe

No

Maybe the code that associates the ddnet protocol to ddnet.exe doesn't work on windows

But we had lot of changes recently with allowing domain names etc. Maybe one broke it

Jupstar ✪

It does. But as query string

seems weird, but at least there's a workaround

heinrich5991

seems weird, but at least there's a workaround

Yes also couldn't find out why it didn't allow this

13:23

But maybe custom ports are already non standard even for https. Dunno

13:24

Else full bug xd

13:24

Fill

[ddnet/ddnet] Pull request opened: #6071 Add logs for moderators (fixes #5433)

Moderators can access the last x minutes of the chat activity. Every entry beside server messages will show the player name, player ip and client who wrote the message / who disconnected so moderators can get the players ip after something happened in case he left already. The current implementation has a 4 minute time slot, messages older than 4 minutes are not shown. To limit the memory usage its limited atm to 256 log-entries. In case of more messages than 256 in 4 minutes (unlikely...

@Voxel no way im braindead

Jupstar ✪

But maybe custom ports are already non standard even for https. Dunno

https doesn't matter for this.

Alexander

Why doesn't ddnet do that automatically anyways?

We'd need an installer to do that I guess. Or figure out how to do that in client, I don't know

deen

https doesn't matter for this.

I meant in url Syntax Standstation If such exists xd

16:04

Standard lmao

the URL standard has ports

16:06

https://hostname[:port]/… (edited)

16:07

Embedded image

Maybe create a file that just associates ddnet to the protocol

https://commons.wikimedia.org/wiki/File:URI_syntax_diagram.svg

File:URI syntax diagram.svg

To avoid the installer

I think there should be a cross-platform library which associates ddnet to protocol, I'm trying to find one

Let ryo find one. He knows all rust libraries in existence

C library would be easier

I remember when I was making an electron app it was a simple 1 line to associate the app with whichever protocol you want and then just adding a way for the app to detect if it was run with parameters

For me my browser simply asks me how i want to associate it

But ofc it had an installer

Alexander

I remember when I was making an electron app it was a simple 1 line to associate the app with whichever protocol you want and then just adding a way for the app to detect if it was run with parameters

And then react properly

Jupstar ✪

For me my browser simply asks me how i want to associate it

Firefox on macOS just does nothing when I click on the links

Same for brave on windows 10

I guess a Windows-only solution would be ok-ish first, didn't find a library for this

if done without installer on windows it will probs need ddnet to run or ask for admin perms and modify the registry

16:13

i think its done through the registry

I associated it using cmd and a few reg add commands

https://superuser.com/questions/266268/where-in-the-registry-does-windows-store-with-which-program-to-open-certain-file

Where in the registry does Windows store with which program to open...

After installing Adobe PDF reader, it opens files with the .PDF file extension. Ones' default web browser opens .html files and notepad opens .txt files, etc. Where exactly in the registry are these

Hm, can you try using the windows instructions from here @Alexander https://ddnet.org/news/ddnet-links/

16:14

If that works fine with Brave

Ye sec

oh wait

16:14

its a url not a file xD

16:14

idk

@deen do you want me to remove the file association that I have created

But yeah, seems like registry is the correct way still: https://learn.microsoft.com/en-us/windows/win32/search/-search-3x-wds-ph-install-registration. I was hoping for some api

16:16

yes, file association is wrong

16:16

it has to be a protocol association

deen

But yeah, seems like registry is the correct way still: https://learn.microsoft.com/en-us/windows/win32/search/-search-3x-wds-ph-install-registration. I was hoping for some api

Hm, Windows Search sounds wrong.

hi

hi hzhz

I don't understand the windows instructions

16:19

It doesn't just let me add an app

hm, too bad

16:19

I never tried it on Windows either, maybe you're the first

feelsbadman

16:19

But anyways

16:20

Even if I associate protocol ddnet to DDNet.exe, it still doesn't join the server

[ddnet/ddnet] Issue opened: #6072 Automatically register protocol handler

At least on Windows, see for example https://developer.shotgridsoftware.com/af0c94ce/

It just opens ddnet

Ok, that probably means it passes the arguments in a wrong way

16:21

or a way we don't understasnd

Image attachment

16:22

Btw here is how I added the thing

16:23

For some reason it didn't let me do it from a bat file

16:23

So I had to do it line by line

heinrich5991

Click to see attachment 🖼️

But we don't use slashes i think

You also need to pass the URL to the ddnet executable, by adding something like "%1" after DDNet.exe

So we skip the port stuff

Robyt3

You also need to pass the URL to the ddnet executable, by adding something like "%1" after DDNet.exe

oh right, let me try that

Robyt3

You also need to pass the URL to the ddnet executable, by adding something like "%1" after DDNet.exe

that worked

16:27

Image attachment

16:28

also it worked without slashes in the url

16:29

yeah i also forgot to run the batch file as an administrator, that's why it didn't work

16:30

reg add HKEY_CLASSES_ROOT\ddnet /t REG_SZ /d "DDNet" /f
reg add HKEY_CLASSES_ROOT\ddnet /v "URL Protocol" /t REG_SZ /d "" /f
reg add HKEY_CLASSES_ROOT\ddnet\shell /f
reg add HKEY_CLASSES_ROOT\ddnet\shell\open /f
reg add HKEY_CLASSES_ROOT\ddnet\shell\open\command /t REG_SZ /d "{Path to DDNet.exe} %1" /f

(edited)

rip irc if the bot was still working

Yes, it was working, zhzh just wrote something

i get this btw

Image attachment

17:02

Image attachment

17:03

with slashes its close xd

Image attachment

17:03

at least it doesnt reinterprets the port then

17:03

so i'd say we must add slahes and filter them in client

17:03

that makes more sense from standard

I guess, makes sense. It thinks it's a file without //

and yeah with firefox it works without and with slahes it results in the same as with chrome with slahes

17:05

so with slahes its consistent

ok, let me do that

Edge also seems to add a slash at the end:

Image attachment

[ddnet/ddnet] Pull request opened: #6073 Remove // in ddnet:// url handler

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...

sigh

Isn't like having slashes the standard?

Alexander

Isn't like having slashes the standard?

yes

17:17

but u can also do it without

17:17

but then a : isnt a port

17:18

but since that's what we intend to do, we use slashes ^^

Ah okay

[ddnet:master] 3 new commits

3fcf497 Remove // in ddnet:// url handler - def- 9912e44 Also remove appended / - def- d76755d Merge #6073 - bors[bot]

17:45

[ddnet/ddnet] Pull request closed: #6073 Remove // in ddnet:// url handler

Hey, this bug is pretty annoying imo: https://github.com/ddnet/ddnet/issues/2591

/pause not saving the previous cursor position · Issue #2591 · ddne...

If you paused and move your view pos then unpause, you will have your cursor position moved to an unpredictable position. This causes failure when pause to look out and unpause. A possible fix is t...

Does DDRace have an Api? And what are the servers on, Websocket’ax? @deen @murpi @Jupstar ✪

Deleted User

Does DDRace have an Api? And what are the servers on, Websocket’ax? @deen @murpi @Jupstar ✪

we have multiple protocols it doesnt provide any "real" api except for anti bot server side

Okay, thx

https://github.com/IgorTimofeev/MineOS

GitHub - IgorTimofeev/MineOS: Home of MineOS and it's software for ...

Home of MineOS and it's software for OpenComputers mod - GitHub - IgorTimofeev/MineOS: Home of MineOS and it's software for OpenComputers mod

20:03

Wtf actual OS for minecraft mod

20:03

I mean OS for computers inside minecraft mod

20:03

justatest

[ddnet/ddnet] Pull request opened: #6074 Reset teams when restarting round

The state of teams was not reset when restarting a round with restart, which led to various issues (#5144):

Switchers kept their previous state instead of being reset to the initial state after restarting.
Teams that started racing sometimes could not be joined after restarting.
Sometimes teams cannot finish a race after restarting. I cannot reproduce this issue, so I don't know if it's fixed by these changes.

Checklist

[X] Tested the change ingame
[ ] Provided scre...

[ddnet/ddnet] Pull request opened: #6075 Fix key reader text flashing for one frame, refactoring

The key reader was displaying the old key for a frame. It now shows the new key immediately without flashing the old one after changing a bind. Refactoring:

The if-branches are restructured to be the same as on upstream.
The function GetKeyBindModifiersName can be called without an additional check, because it returns an empty string when no modifier is pressed.
The unused parameter Checked of the DoButton_KeySelect function is removed.

From teeworlds/teeworlds#2877. ...

[ddnet/ddnet] Pull request opened: #6076 Fix stored commands using original callback instead of the chain, fix client crash when launching with `screenshot` command

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...

@Ryozuki damn https://careers.embark-studios.com/jobs/1204728-senior-rendering-engineer-rust-creative-play

Senior Rendering Engineer (Rust) - Creative Play - Embark Studios

Are you interested in new new approaches to visuals and rendering and want to be a part of something no-one has ever made before? As a Senior Rust rendering engineer at Embark you'll be working...

oh nice

Embark good studio

Deleted User

Does DDRace have an Api? And what are the servers on, Websocket’ax? @deen @murpi @Jupstar ✪

Servers themselves are connected to using UDP, websockets can be enabled, but I'd call it experimental. The servers communicate with master server using https. client with master also using https: https://master1.ddnet.tw/ddnet/15/servers.json On the website some information has json versions, check the json logo on pages, for example: https://ddnet.org/maps/?json=Kobra

https://fivethirtyeight.com/features/the-world-cups-new-high-tech-ball-will-change-soccer-forever/

The World Cup’s New High-Tech Ball Will Change Soccer Forever

When the 2022 World Cup made its debut on Sunday, it kicked off one of the most significant in-game uses of technology in sports history. All tournament long, m…

22:55

https://www.reddit.com/r/interestingasfuck/comments/z80b2o/world_cup_balls_getting_charged/

r/interestingasfuck - World Cup balls getting charged

42,287 votes and 1,911 comments so far on Reddit

22:55

lol

ReiTW

@Ryozuki damn https://careers.embark-studios.com/jobs/1204728-senior-rendering-engineer-rust-creative-play

Sounds like a fit for @Jupstar ✪

yeah jupstar go for it

22:55

the most complicated part is vulkan itself

22:55

u already know kek

they don't even require previous rust experience (don't feel afraid to apply for jobs where you don't have the requirements anyway)

i dont think u can rly find senior rust devs

22:57

maybe there are a handful at most xD

22:57

they pick c++ seniors

22:57

well depends what u consider senior

22:57

i usually set a high bar

also, applying for jobs, even if you don't think you want to take them can be fun, good practice, and maybe you actually want the job after talking to some devs from the company

[ddnet:master] 2 new commits

10433e0 Reset teams when restarting round - Robyt3 c2d5d81 Merge #6074 - bors[bot]

23:05

[ddnet/ddnet] Pull request closed: #6074 Reset teams when restarting round

https://godotengine.org/article/release-management-4-0-and-beyond

Release Management: 4.0 and beyond

We are closer to releasing Godot 4.0. No matter the amount of time dedicated to testing and profiling — bugs and issues are inevitable. Still, we intend to follow 4.0 with bug fix releases to ensure a stable experience as soon as possible.

[ddnet:master] 4 new commits

0688355 Fix key reader text flashing for one frame, refactoring - Robyt3 e07bd45 Fix stored commands using original callback instead of the chain - Robyt3 2e2cb47 Fix client crash when launching with screenshot command - Robyt3 3012a42 Merge #6075 #6076 - bors[bot]

23:25

[ddnet/ddnet] Pull request closed: #6075 Fix key reader text flashing for one frame, refactoring

23:25

[ddnet/ddnet] Pull request closed: #6076 Fix stored commands using original callback instead of the chain, fix client crash when launching with `screenshot` command

Exported 171 message(s)