DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-11-01 00:00:00Z and 2022-11-02 00:00:00Z

@Voxel what up with ger3 and 10

ichliebesyrix.

@Voxel what up with ger3 and 10

How should I know? Probably a DDOS

01:37

Oh wait, they're down.

Oh nice I think I have seen it and forgot about it immediately back in the days because I’m C# hater haha. But wow that project is like half a decade old! It’s hard to judge from the missing documentation and examples how useful that is but I will mention that for sure in my list of teeworlds protocol implementations :) (@Matodor)

SIXUP

1

chillerdragon

Oh nice I think I have seen it and forgot about it immediately back in the days because I’m C# hater haha. But wow that project is like half a decade old! It’s hard to judge from the missing documentation and examples how useful that is but I will mention that for sure in my list of teeworlds protocol implementations :) (@Matodor)

In fact, it is quite useless, main branch is not working, in the branch refactoring ready completely clean network part, there is somewhere very old branch, there is a terrible code but you can play, based on it I do city mode plus developments from the refactoring branch. In any case, it's just a hobby through which I've learned to read other people's code and understand it well justatest

justatest

how does it work? Is it 100% C# running the city server?

08:33

Or do you somehow hook in to mod c++ servers with C#?

08:33

if it can run and even be used for city development. Please add some kind of setup/sample/docs im sure someone C# would really appreciate that!

08:34

OMG @heinrich5991 I can not say enough how much I appreciate your dissector!!!!!!!!!! The bit annotation with the ..01010 thingies is so fkin amazing. It really helps a lot to identify where these values spread to. https://zillyhuhn.com/cs/.1667291498.png

Embedded image

08:35

Such a trol protocol having 2 bits sequence number in the middle of the size number!?

how does it work? Is it 100% C# running the city server? yes

awesome!

08:36

and people can join and play?

08:37

You need to document that thats amazing!

08:38

atleast some simple instructions on howto get a server running would be dope i guess

08:38

so gonna ping you too in the future when i got protocol questions :p

08:40

@Matodor also do not be ashamed of your old code. If it works it rocks! Be proud and promote it. If you wanna feel better about your code i can share you some of mine :D

[quakenet] ChillerDragon

and people can join and play?

in the city mod yes, but in TeeSharp no, there is still a lot to do (in refactoring branch), I also want to study the ECS system and implement it for mods But all the time I have now goes to work and to the city mod, so TeeSharp is not updated

i thought city mod is TeeSharp?

[quakenet] ChillerDragon

@Matodor also do not be ashamed of your old code. If it works it rocks! Be proud and promote it. If you wanna feel better about your code i can share you some of mine :D

Yes, I have this problem, to rewrite everything from scratch, made a long time ago the game on the unity, three times rewrote and did not release anywhere

:c

[quakenet] ChillerDragon

i thought city mod is TeeSharp?

no, mLife I think you'll have a look at it by winter)

okeoke

08:42

I mentioned you on my network docs anyways

08:42

so at least my mom reading it will checkout your stuff!

greenthing

2

Matodor

in the city mod yes, but in TeeSharp no, there is still a lot to do (in refactoring branch), I also want to study the ECS system and implement it for mods But all the time I have now goes to work and to the city mod, so TeeSharp is not updated

maybe the good and really modern bevy ECS can inspire you https://bevyengine.org/learn/book/getting-started/ecs/

Bevy is a refreshingly simple data-driven game engine built in Rust. It is free and open-source forever!

08:53

but u will never reach rust speeds with C# BASED

BASED

Ryozuki

maybe the good and really modern bevy ECS can inspire you https://bevyengine.org/learn/book/getting-started/ecs/

Thanks, I'll read it.

https://bevy-cheatbook.github.io/programming/ecs-intro.html

Intro to ECS - Unofficial Bevy Cheat Book

08:55

more here too

08:55

Conceptually, you can think of it by analogy with tables, like in a database or spreadsheet. Your different data types (Components) are like the "columns" of a table, and there can be arbitrarily many "rows" (Entities) containing values / instances of various components.

>

For example, you could create a Health component for your game. You could then have many entities representing different things in your game, such as the player, NPCs, or monsters, all of which can have a Health value (as well as other relevant components).

>

This makes it easy to write game logic (Systems) that can operate on any entity with the necessary components (such as a health/damage system for anything that has Health), regardless of whether that's the player, an NPC, or a monster (or anything else). This makes your game logic very flexible and reusable.

>

The set / combination of components that a given entity has, is called the entity's Archetype.

>

Note that entities aren't limited to just "objects in the game world". The ECS is a general-purpose data structure. You can create entities and components to store any data.

08:55

the tldr

08:55

xd

@Ryozuki when tw client in bevy?

monkalaugh

holy shit i have been starring so long at the hexdump of tw protocol i can almost read it :D

@deen are the map preview images stored in a repo?

no

[ddnet/ddnet] Pull request closed: #5987 Fix physics change by weak hook fix (fixes #5769)

[ddnet:master] 3 new commits

cedc315 Fix physics change by weak hook fix (fixes #5769) - fokkonaut 3b2dd73 Rename config var to no weak only - Jupeyy 571b0b3 Merge #5770 - bors[bot]

10:47

[ddnet/ddnet] Issue closed: #5769 `sv_no_weak_hook_and_bounce 1` causes critical physics changes

10:48

[ddnet/ddnet] Pull request closed: #5770 Fix physics change by weak hook fix (fixes #5769)

[ddnet/ddnet] Pull request opened: #5993 Fix incorrect minimum values for tele, speedup and switch layers

It was possible to select tele number 0, speedup force 0 and switch number 0 in the layer details in the editor, because some of the bounds checks or calculations were not excluding the value 0. As placing those tiles with the value 0 in the editor is not possible and the tiles with this value are ignored by server and client, it also shouldn't be possible to select those values in the first place.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual...

[ddnet/ddnet] Pull request opened: #5994 Change editor hotkey Ctrl+A to Ctrl+T for layer/tile details

The hotkey Ctrl+A is already active universally in the editor to open and append a map to the current one. This collides with the hotkeys for opening the layer/tile details popup for tune, tele, speedup and switch layers, which is only active when a layer of said type is select. Pressing the hotkey in this context opens the popup and the append dialog at the same time, which is undesirable. Therefore the hotkey to open the layer/tile details is changed to Ctrl+T instead. This combination is c...

[ddnet:master] 2 new commits

c6fa29e Fix incorrect minimum values for tele, speedup and switch layers - Robyt3 79ea9d1 Merge #5993 - bors[bot]

12:35

[ddnet/ddnet] Pull request closed: #5993 Fix incorrect minimum values for tele, speedup and switch layers

ChillerDragon: that's amazing

and yeah I also thought that someone didn't look at the actual bytes when "designing" this protocol ^^

not that the C++ code flippin, shuffeling, shifting and dipping those bytes using pBuffer[0]&0xFF<<1 looks any better :D

[ddnet:master] 2 new commits

c916e5d Change editor hotkey Ctrl+A to Ctrl+T for layer/tile details - Robyt3 846b569 Merge #5994 - bors[bot]

12:53

[ddnet/ddnet] Pull request closed: #5994 Change editor hotkey Ctrl+A to Ctrl+T for layer/tile details

12:55

[ddnet/ddnet] Issue opened: #5995 Hide the switch number for tiles that are not affected by it

teini94 mentioned that mappers like to use switch number 0 for jump tiles, because it's confusing when two numbers are shown on them. Technically it shouldn't make a difference, because jump tiles are not affected by the switch number. Selecting switch 0 was disabled by #5993. For example: !screenshot The left tile uses switch number 0 and delay 2, hence setting the number of jump...

ChillerDragon: I got the idea from wireshark's TCP dissector (screenshot attached)

Image attachment

poggers

12:59

it does make so much sense for tw protocol

12:59

btw i finally figured dark mode out on arch too and actually did ditch termshark again after hyping it so much :D

13:00

the highlight in the hexdump is just not as accurate enough as the qt version

13:02

i mean it probably is feature complete but my brain can not grasp that the msg 19 is the byte 27 and it is highlighted https://zillyhuhn.com/cs/.1667307607.png

Embedded image

13:02

this is easier for me :( https://zillyhuhn.com/cs/.1667307664.png

Embedded image

Image attachment

13:10

https://ismypackagereproducibleyet.org/?pkg=ddnet&query=query

Failure is

[ FAILED ] Jobs.LookupHostWebsocket

13:12

So the test server is not connected to a DNS server:

[ RUN      ] Jobs.LookupHostWebsocket
2023-11-13 18:29:23 I host_lookup: host='example.com' port=0 1
./src/test/jobs.cpp:109: Failure
Expected equality of these values:
  pJob->m_Result
    Which is: -1
  0
[  FAILED  ] Jobs.LookupHostWebsocket (1 ms)

13:13

Maybe bad style that our tests require a DNS server

why does the websocket test fail but not the real one?

13:13

are you sure it's the missing internet connection?

13:15

but yea, they do fail without internet ocnnection for me as well. hm

[ddnet/ddnet] Pull request opened: #5996 Allow the test suite to run offline

Allow host resolving to fail, but still check its results if it succeeds.

Checklist

[x] Tested the change ~~ingame~~
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [AS...

Weird, maybe just sporadic internet problem?

[ddnet:master] 2 new commits

b502e67 Allow the test suite to run offline - heinrich5991 333c3ed Merge #5996 - bors[bot]

15:00

[ddnet/ddnet] Pull request closed: #5996 Allow the test suite to run offline

hey i got a question, how can i set the background entities color to a hex or rgb value

18:05

nevermind i figured it out, I had to right click on the hex value in the settings =]

greenthing

1

cl_background_color $808080 also should work

ah thanks

with the hex code after $ instead of the usual #

btw it's not setting it to a correct value though

Maybe it's rounding to the closest value we can store

oof

18:06

#23272A is being replaced with #222629

Yes, so each color's value is off by one

18:07

Is that expected @Learath2 ? ^

and in rgb by 2

It's probably close enough that no one would notice anyway

18:08

The calculation is here: https://github.com/ddnet/ddnet/pull/1678/files#diff-7dc34778e6c28029830864d702a7fadf2a410dcd32033ce83c8ed6a47f145f16R40

Handle colors in console by Learath2 · Pull Request #1678 · ddnet/d...

DEPENDS: #1654 A better way to fix #1581 possibly deprecates #1597

okay no problem, thanks for the help

deen

It's probably close enough that no one would notice anyway

but i think this also ties with #5844

https://github.com/ddnet/ddnet/issues/5844

Color Picker doesn't keep color when reselected. · Issue #5844 · dd...

Reported by cyberFighter on Discord (This applies to all the color picker buttons): simply clicking some of the laser wall color buttons changes their H/V values by -2/-1/+1/+2 Most notably in the ...

Oh yeah, looks like @Robyt3 got it right

deen

Is that expected @Learath2 ? ^

We just can’t represent every 3 byte rgb value with 3 bytes of hsl. It is technically possible that I have an off by 1 somewhere, but it’s more likely that we can’t represent this exact hue

Alright, sounds fine

It could also be that it's rounding the values to a whole value without decimals

19:30

For example i can see that rgb(35, 39, 42) gets converted to hsl(205.7, 9.1%, 15.1%) which is also being converted in teeworlds so it fits as a value from 0 to 255

19:31

So if it's getting rounded to the nearest whole value then that's where the exact color is probably being lost

[ddnet/ddnet] Pull request opened: #5997 Allow selecting switch number 0 in editor again

This reverts part of #5993 to allow switch number 0 to be selected again. Switch number 0 is permanently enabled, so it useful for tiles that should always be switched on. Eventually tiles that don't work with switch 0 (e.g. switch open/close tiles) should be made unplaceable and the switch number should be hidden for tiles where it doesn't have any effect (e.g. jump tiles). See #5995.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ...

@Ryozuki pipewire is pretty cool, I like

nice

21:35

@Learath2 how hard it is to switch

21:35

on gentoo

I tried it on artix, it was painless. Gentoo should be similar given both use openrc

oh u dont use gentoo?

21:36

then im superior right now

21:36

ill take my based pill

21:36

BASED

Testing out artix on an old laptop that can’t build it’s own packages in any reasonable time

I did use this laptop with gentoo for a very long time though. Distcc is great

21:37

@Ryozuki did you use an AUR helper while you were on arch?

21:38

I usually go for aurutils, but just wanted to check if you used something else

@Learath2 i used yay

21:38

but if i wasnt used to yay

21:38

i would use the fork

21:39

made in rust

paru?

yes

21:39

its by one of yay authors

Let me give it a go. I never used pacman wrappers because back when I first installed arch people were all saying they were dangerous things that will break your computer instantly

https://github.com/Morganamilo/paru

GitHub - Morganamilo/paru: Feature packed AUR helper

Feature packed AUR helper. Contribute to Morganamilo/paru development by creating an account on GitHub.

Learath2

Let me give it a go. I never used pacman wrappers because back when I first installed arch people were all saying they were dangerous things that will break your computer instantly

stupid people

sometimes i really feel like a stranger visiting a foreign country here

yay and paru ask if you wanna read the diff for the PKGBUILD

21:40

its ur choice to check it

21:40

xd

Chairn

sometimes i really feel like a stranger visiting a foreign country here

why

i don't understand anything of what's going on with you two

21:41

yay is like deformed yes, not a program to me

I think the issue came from yay -Sy failing. If it failed for whatever reason it could leave your system in a broken half upgraded state

hmm idk

21:41

i jsut run "yay"

21:41

to update

Chairn

yay is like deformed yes, not a program to me

yay is also the name of a program, an AUR helper

@Chairn https://github.com/Jguer/yay

GitHub - Jguer/yay: Yet another Yogurt - An AUR Helper written in Go

Yet another Yogurt - An AUR Helper written in Go. Contribute to Jguer/yay development by creating an account on GitHub.

yogurt?

@Chairn cuz an old aur phelper

Oh and back when I first used arch there was yaourt

called yaogurt

That’s the reference

oh

21:42

yaourt xd

I was once asked where I got the ddnet I use and I said yay. Then the other person said "I am not accusing you for hacking" xD

dammit, there should be laws to name programs

nah

21:42

funny names > serious

21:43

let corpo be the boring ones

21:43

BASED

are there any program name using a copyrighted name like coca cola ?

Chairn

dammit, there should be laws to name programs

the rule is: choose a 2-3 letter name that is not used by another popular cli tool yet

let's rename ddnet to ddn

Am I allowed to do something like this? Or, how do I manage 2 packets at once?

Image attachment

There should be a different NETMSGTYPE_SV_KILLMSG_TEAMS for the KillMsgTeams

[ddnet/ddnet] Pull request opened: #5998 Fix Ctrl+F hotkey not checking for Ctrl key, minor improvement to tile details popup layout

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresss...

It doesn't make sense to me to create two different type objects from the same raw message

[ddnet:master] 2 new commits

d6d88d4 Allow selecting switch number 0 in editor again - Robyt3 c4635a9 Merge #5997 - bors[bot]

22:09

[ddnet/ddnet] Pull request closed: #5997 Allow selecting switch number 0 in editor again

[ddnet:master] 5 new commits

c29d4b9 Remove redundant CUIRects, improve find button height - Robyt3 0db4b5f Refactor border button condition, move button variable - Robyt3 8e9b4dd Refactor tile details popup height, variable names - Robyt3 886ec99 Add missing check for modifier of Ctrl+F hotkey - Robyt3 e71ce8f Merge #5998 - bors[bot]

22:30

[ddnet/ddnet] Pull request closed: #5998 Fix Ctrl+F hotkey not checking for Ctrl key, minor improvement to tile details popup layout

Exported 155 message(s)