DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-10-21 00:00:00Z and 2022-10-22 00:00:00Z

Ryozuki

@ReiTW maybe this helps

Lol yes this is very good and helps to understand and choose

https://news.ycombinator.com/item?id=33281106

cbzbc

SHA-3 Buffer Overflow

07:29

another good day for rust

07:29

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-37454

CVE - CVE-2022-37454

The mission of the CVE® Program is to identify, define, and catalog publicly disclosed cybersecurity vulnerabilities.

07:31

https://nvd.nist.gov/vuln/detail/CVE-2022-37454

07:31

The Keccak XKCP SHA-3 reference implementation before fdc6fef has an integer overflow and resultant buffer overflow that allows attackers to execute arbitrary code or eliminate expected cryptographic properties. This occurs in the sponge function interface.

07:31

guess which lang uses?

07:31

monkalaugh

Java?

bruh-st

07:55

oh wait nvm

[ddnet:master] 3 new commits

26a0836 Don't print max value when there is none (fixes #5953) - def- eb27b26 Also ignore min value - def- 9c6a187 Merge #5965 - bors[bot]

07:57

[ddnet/ddnet] Issue closed: #5953 Better max and min display in the command help

07:57

[ddnet/ddnet] Pull request closed: #5965 Don't print max value when there is none (fixes #5953)

wait idk does java even have buffer overflows?

08:05

I use "WIKI HOW WITH IMAGES" more than I would like to admit :D

the jvm can have, but the code you write can't

ou i see

08:18

omg java seems as unsafe as c++ but also as bloat as python. feels like the worst of both worlds haha

Dude its c

08:56

Not java

08:56

Why u dum

http: https://info.ddnet.org/info failed. libcurl error: getaddrinfo() thread failed to start

10:10

same issue with github idk why its happening

10:13

Image attachment

Github not working either is weird. Maybe check the log on ddnet? It seems curl in general seems to have an issue on your system. Maybe google for the error?

yo @Learath2 why is Msg_SixToSeven(27) -1 and not 27?

11:18

Embedded image

11:18

this one i think

11:19

does -1 mean same in 0.6 and 0.7?

11:20

oh wait no wat

11:21

Nvm it all makes sense

11:21

27 is 0.7 NETMSGTYPE_CL_STARTINFO so passing that into SixToSeven makes no sense so somewhere i f*cked up

Ryozuki

Why u dum

no insulting others

justatest

@Ryozuki pls start drama

no

mmm

BASED

11:36

@Jupstar ✪ rust > vulkan

11:36

greenthing

Ryozuki

@Jupstar ✪ rust > vulkan

How dare you

Can I explicitly opt out of insult protection?

hmm. you can opt out of insult protection in DMs by not reporting it to me

11:38

in public channels however…

Learath2

Can I explicitly opt out of insult protection?

Loser

justatest

Skeith

Loser

I'm so sorry Skeith, apparently I can't opt out. You will be sent to the purgatory

Understood

[ddnet:master] 2 new commits

1020b0a Ignore useless pylint options (fixes #5950) - def- 1c56ca4 Merge #5964 - bors[bot]

11:48

[ddnet/ddnet] Issue closed: #5950 Useless options used for pylint in CI

11:48

[ddnet/ddnet] Pull request closed: #5964 Ignore useless pylint options (fixes #5950)

[ddnet:master] 2 new commits

f7bc58b Fix duplicate description of cl_default_zoom_level - def- 8feba4e Merge #5966 - bors[bot]

12:16

[ddnet/ddnet] Pull request closed: #5966 Fix duplicate description of cl_default_zoom_level

@heinrich5991

13:23

I see people using std::rand

13:23

it is no longer part of std?

in rust?

yes

I'm not aware of that existing

13:26

maybe pre-1.0

https://stackoverflow.com/a/19674981

How can I generate a random number within a range in Rust?

Editor's note: This code example is from a version of Rust prior to 1.0 and is not syntactically valid Rust 1.0 code. Updated versions of this code produce different errors, but the answers still c...

13:26

eg

13:26

they use std::rand

Editor's note: This answer is for a version of Rust prior to 1.0 and is not valid in Rust 1.0.

ah

13:27

well he wasn't the only one to have that, so I was wondering

use that rand crate, I guess

yes that's what i'll do

@Jupstar ✪ do u expect a lot of perf improvement from a 3200mhz to a 4000mhz ram?

I heard Zen architecture of AMD benefits a lot more from faster ram than Intel. So I’d guess that depends a lot on the architecture

Well i use latest ryzen

Ryozuki

@Jupstar ✪ do u expect a lot of perf improvement from a 3200mhz to a 4000mhz ram?

yeah a bit, maybe around 5%

15:05

also depends lot on the program/game

Compiling?

OMG DID RYO CAL ME DUM HEINRICH HALP

Ryozuki

Compiling?

mhh dunno, maybe too cpu bound, just look at phoronix, they probs have benchmarks

@Jupstar ✪ 0.7 skins in ddnet when?

mhhhhhhhhhhhhhhh

THIS SUMMER!?

the skin system defs cool. but 0.7 skins look trash also it makes skins lot more complicated.. e.g. no more database like we have now so i guess just implement the skin system chiller

1

15:29

this spring

15:29

the spring this year

why can't we have a db for 0.7?

who said that

we can not have a db for 0.7 like we have a db for 0.6

15:30

would be a diff db

no more database like now = no finished skins are shown

15:30

see e.g. #📬submit-skins

e.g. no more database like we have now

I interpreted this as such

15:30

but I understand your point now

u dum

15:30

hehehehehehe

i mean ppl probs want the amount of customization anyway

ryo teached me that

and we will have both like 0.7 anyway

15:31

so probs fine

*taught

thanks english sensei

15:31

UwU

chiller: you can only be insulted by dumb, if you aren't dumb, else its no insult

since when

since IQ > 90

so everytime my insult is not true it is not a insult?

yeah then its a fact xD

thats handy

15:32

so heinrich can not prosecute me

whether stuff is true or not has little influence on whether it's an insult

try it out

i have legal high ground due to pro lawyer jupstar being on my side

15:33

wat u gona do

yeah

anyways im sure we can figure something out for the skins

15:34

like we already said somehow crack 0.6 skins into 0.7 format

i can ensure you, you'll get banned without any kind of legal consequences

but what I would need you for is make the cleint skin menu not render 0.7 skins in black but in colors :(

well rip

15:35

i still have 0.6 to 0.7 skin converter btw

im sure you can throw some vulkan at the problem

15:35

ou u already have one nice

15:35

so we done

15:35

so only some pro has to fix this https://zillyhuhn.com/cs/.1666366443.png

Embedded image

https://github.com/Jupeyy/teeworlds_skin_converter_06_to_07 eyes not perfect, but still a beginning, tho its like 5000 years old

GitHub - Jupeyy/teeworlds_skin_converter_06_to_07: Convert skins fr...

Convert skins from 0.6 to 0.7. Contribute to Jupeyy/teeworlds_skin_converter_06_to_07 development by creating an account on GitHub.

15:36

if they black

15:36

give them color

how

black = 0 0 * number = 0

isnt that offensive?

make them white

15:36

i dunno

15:36

isnt it a fact?

15:36

isnt black = 0 banned these days?

15:36

since github switched to main branches and stuff

so u say dark white?

politcal correct code

white = very light grey black = very dark grey?

da

lim light from 0 to inf of grey

eww maffs

15:38

there are only 50 shades of grey not inf -.-

so where is ur skin pr

15:40

i can quickly look why its black

15:41

takes me 5 seconds

https://github.com/ddnet/ddnet/pull/5660

https://github.com/ddnet/ddnet/pull/5660

[DRAFT] Start working on 0.7 skins menu by ChillerDragon · Pull Req...

I started working on this a while ago and it is still far from being finished. Just wanted to share that I am working on this and get some feedback if it even has a chance to be merged when finishe...

15:41

this?

15:41

is the code up to date?

want me to merge da thing w master?

15:42

or rebase i guess

yeah

oke lemme cleanup ma workin tree first

git stash

then it ends up in the long list of forgotton stashes

Yeee

15:42

Image attachment

or git worktree add chiller_skins7 /tmp/chiller_skins7 to check it out to /tmp

okay now that sounds fancy

15:43

worktree add!?

15:43

i should git gud

15:44

im a bit scared i will just run it xd

15:44

how would i get back?

15:44

git worktree remove?

rm -r /tmp/chiller_skins7

a

15:44

hm okay wish me luck

u didnt bind a texture

he alr has it xd

15:45

before i understood git 101

do i need to use 0.7 skins or are they in?

ok fuck it ima stash

(ah, apparently git worktree remove also exists)

make sure to implement the sizing logic for 0.7 skins too

gosh those annoying conflicts

else they aren't perfectly centered in scoreboard in chat like 0.6 skins

feels like this is gonna take some time

and that's a disaster

lzma

ok du model

Reminds me of ligma

15:47

But its just a compression algoritgm

15:48

You got lzma?

15:48

BASED

lzma or lzma2 xd

Idk xd

i think i hacked the conflict

15:50

so wat about that texture now

15:50

how to fix

yeah how do i include them?

15:50

copy from 0.7 client?

ah u miss files or what?

15:51

o

15:51

eh idk its so long ago i either slapped them into ./data or ~/.teeworlds

15:51

omg build issues

15:51

changed apis

15:51

ddnet so unstable

15:52

we should do the wireshark approach api changing prs should ship a fix script :p

ah

looking at you herr müller github.com/ddnet/ddnet/commit/95550fd6a9c608e612343d9079a69de8a91d5c82

u render the front skin first

15:52

then the back

15:52

clever chiller

o

[quakenet] ChillerDragon

we should do the wireshark approach api changing prs should ship a fix script :p

link to that wireshark approach?

i see

15:53

fakof -.-

15:53

you dont know that heinrich!?

15:53

sec

15:56

shit i dont find it anymore but i remember when i looked into dissectors i copied some code from stackoverflow that didnt compile and googling the error message showed the api changing commit that renamed a function. The commit also included a script that you can run on a codebase to rename all method calls

15:58

okay either im blind af or this is far less common than i thought

oke so where is front and back being renderd? c:

16:11

OMG THANKS JOPSTAR U SO SMORT https://zillyhuhn.com/cs/.1666368602.png

Embedded image

also make sure to split all parts into own textures

16:17

else its not pixel perfect anymore like 0.6 skins are

16:18

also ddnet requires the dilate tool to prevent artifacts

16:19

also check image dimensions

ye thanks but 1 character code is enough skins for today

like 0.6 skins

ima give the 0.7 tokens a bit of love now then i rq

@heinrich5991 oh btw did you have time to look at ws dissector?

16:49

the dll issue

ReiTW

@heinrich5991 oh btw did you have time to look at ws dissector?

it should be fixed

ReiTW

the dll issue

https://github.com/heinrich5991/libtw2/issues/61

wireshark-dissector: Fix Windows build · Issue #61 · heinrich5991/l...

Apparently one can't actually load the built binary into Wireshark. From Discord: [8:58 PM] Ravie Senpai: Does someone know how to fix this annoying error? (Followed every step from the &am...

@heinrich5991 amazing ! will test that out

tell me about the results

https://twitter.com/LinaAsahi/status/1583498896847667216

Asahi Lina / 朝日リナ //nullptr::live (@LinaAsahi)

I love how all the odd and error-prone C kernel coding patterns just become beautiful Rust code.

Look, no of_node_put() anywhere! No weird iterator macros! No goto err_put_foo! Error handling is one character!

Likes

141

18:07

https://twitter.com/LinaAsahi/status/1583498900802895879

Asahi Lina / 朝日リナ //nullptr::live (@LinaAsahi)

The kernel codebase is full of OF node leaks because nobody can keep the reference counting straight... Writing OF code in Rust? It does it for you! ✨✨

18:07

gigachad vtuber

18:07

@Jupstar ✪ ^

Ryozuki

@Jupstar ✪ ^

wasnt that person writing drivers?

yeah

18:09

the gpu driver for apple

18:09

m1

how is that related to the kernel?

its a kernel driver?

yeah but its not kernel code, its a driver that uses kernel code

18:09

anyway, its nice that this project exists

i would say this is tighly coupled

up to a certain points probably yes

18:11

but if i think of a kernel i'd think of it like this: you add any kind of bug. u doomed

anyway point still stands

i dunno, i understand that rusts solve lots of problems. but this post sounds like fanboyism a claim without any kind of proof

18:13

but that's probs a general problem with twitter

TIL https://en.wikipedia.org/wiki/Slowloris_(computer_security)

Slowloris (computer security)

Slowloris is a type of denial of service attack tool which allows a single machine to take down another machine's web server with minimal bandwidth and side effects on unrelated services and ports. Slowloris tries to keep many connections to the target web server open and hold them open as long as possible. It accomplishes this by opening connec...

18:21

instead of going fast u go slow xd

and has cool logo xD

xd

@Ryozuki Asahi always streams for 10-12h imagine having such motivation and skill

18:24

would be epic

[ddnet/ddnet] Pull request opened: #5967 Fix crashes in editor when scrolling with up/down keys on empty sounds/images lists

The crashes were already present before #5751.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck...

ye

@Jupstar ✪ https://twitter.com/linaasahi/status/1583444549648543744

Asahi Lina / 朝日リナ //nullptr::live (@LinaAsahi)

My Linux M1 GPU driver passes >99% of the dEQP-GLES2 compliance tests!!!!!

Most of this is thanks to @alyssarzg's prior work on macOS, but now I can replicate it on Linux! ^^

Likes

926

19:08

pog

19:08

https://news.ycombinator.com/item?id=33288706

tpush

Linux M1 GPU driver passes 99% of the dEQP-GLES2 compliance tests

[ddnet:master] 3 new commits

4a683e0 Fix crash in editor when using up/down keys on empty sounds list - Robyt3 f5a16c1 Fix crash in editor when using up/down keys on empty images list - Robyt3 529bbce Merge #5967 - bors[bot]

19:09

[ddnet/ddnet] Pull request closed: #5967 Fix crashes in editor when scrolling with up/down keys on empty sounds/images lists

Ryozuki

@Jupstar ✪ https://twitter.com/linaasahi/status/1583444549648543744

nice godot might already work

[ddnet/ddnet] Pull request opened: #5968 Fix text input not working when entering editor with bind, fix IME not being deactivated when editor is closed

When entering the editor with a custom bind (e.g. bind e "cl_editor 1") or when opening it from the console while also immediately closing the console (e.g. with cl_editor 1; toggle_local_console), the IME state was not properly set to active, so SDL did not report any SDL_TEXTINPUT events, leading to editboxes in the editor not receiving any text. The is fixed by always enabling the IME state when entering the editor, which was previously only done when using the Ctrl+Shift+E hotkey...

I was thinking, while working on dfng, using DDRace teams to have multiple teams instead of 2. By making CTeamsCore::CanCollide always return true (game/teamscore.cpp) it works as expected server-side, but the client makes inaccurate predictions. It could be fixed by using an appropriately modified client. Since already there is a flag for fng predictions, would it be worth introducing something similar for dfng? (I'm not asking about upstream yet)

19:52

If such a flag is introduced, making dfng compatible with ddrace (by using other tile ids for spikes) is worth considering (maybe also adding new types of spikes as well)

you're using ddnet teams for fng teams. you're doing that so that you can have more than 2 teams?

yeah

I wouldn't be opposed to a flag saying that all ddnet teams share the same game world

19:54

not sure if that's hard to do, client-side, though

I think modifying game/teamscore.ccp:CTeamsCore::CanCollide() would suffice

how does it work with super

Mr.Gh0s7

I think modifying game/teamscore.ccp:CTeamsCore::CanCollide() would suffice

After having performed a quick test, it doesn't seem it would suffice though.

Jupstar ✪

how does it work with super

Yeah with super it work as expected :D

i mean how does it work technically

20:01

does the client simply know who is super xd

it seems that the clients knows when someone is super

20:02

let me look at the code (edited)

ah yeah i think it was like team -2

20:02

smth like that

not totally sure but TEAM_SUPER is defined as = MAX_CLIENTS at teamscore.h

[ddnet:master] 3 new commits

75326e8 Fix text input not working when entering editor with bind - Robyt3 c0da3b9 Fix IME not being deactivated when editor is closed - Robyt3 fdc35b4 Merge #5968 - bors[bot]

20:07

[ddnet/ddnet] Issue closed: #5095 Can't type into editor inputs when entering the editor using 'cl_editor 1'

20:07

[ddnet/ddnet] Pull request closed: #5968 Fix text input not working when entering editor with bind, fix IME not being deactivated when editor is closed

@ReiTW did the dissector work?

@heinrich5991 works perfectly

21:57

Image attachment

sql question: If i'm getting it right.. you put PRIMARY KEY as a constraint so you can't do another column with the same name? so "name TEXT PRIMARY KEY" would say "you can't add another column named "name" in the table" ?

no

No, not at all.

it means that two rows in the table can't have the same value for "name"

OH so you can't have "Meekrioz" more than once in the table?

@heinrich5991 that would be unique

22:08

I think it should be name text, primary key (name) and the primary key is the set of columns that identifies a row uniquely

22:09

so if you just have one column as your primary key set, then all rows in that column are unique

PRIMARY KEY columns can be used to uniquely identify the row.

22:09

that is what my note says

Meekrioz

OH so you can't have "Meekrioz" more than once in the table?

correct

22:10

for ddnet's record_race we have (Name, Time, Timestamp) as the primary key. So a rank needs to have unique combination of Name, Time and Timestamp

22:11

If you try to insert a rank twice, you get an error because there already is one with this primary key

aaaah i see

22:11

do you have an example for UNIQUE?

Also indexes are if I remember used to improve query performance if used properly

It just says that each row needs to have a different value in this column

@Meekrioz if u are interested in learning a bit more of the basic theory

22:18

https://en.wikipedia.org/wiki/Third_normal_form

Third normal form

Third normal form (3NF) is a database schema design approach for relational databases which uses normalizing principles to reduce the duplication of data, avoid data anomalies, ensure referential integrity, and simplify data management. It was defined in 1971 by Edgar F. Codd, an English computer scientist who invented the relational model for d...

deen

It just says that each row needs to have a different value in this column

but isn't PRIMARY KEY the same thing then?

@Meekrioz > Primary key will not accept NULL values whereas Unique key can accept NULL values. A table can have only one primary key whereas there can be multiple unique key on a table.

22:21

for example, a user id would be a good candidate for primary key

22:21

and their email a unique key

Ohhh so a PRIMARY KEY has to have an input but UNIQUE doesnt give a fuck what it has? NULL or email (for your example)

it depends on how you define the column

22:24

making a column nullable or not is up to you

22:24

but you can't make a column that is a primary key nullable

22:24

whereas you can specify a column that has the unique contraint nullable

22:25

(email TEXT NULL UNIQUE)

22:25

or (email TEXT NOT NULL UNIQUE)

22:26

@Meekrioz you see, often you want a id that never changes, to referenciate it from other tables

22:26

a unique column that is not a primary key could have its value changed

yea a customer ID for example

losing that ability

AAAAAAA

22:26

I SEE

22:26

you don't wanna change a customer ID but you want to change an email address for example

but this does not mean u cant change a primary key

22:27

yeah

you can probably UPDATE it right?

yea

aaaaah i see! thank you

depends after but you might need to cascade it

22:28

depends of how your db is made

but the norm is to generally not update primary keys

22:28

u rarely need to

well if you have a fk

got it, thanks

Exported 330 message(s)