DDraceNetwork - developer

ddnet-maps

[ddnet-maps:master] 1 new commit

af52782 M Standby - ddnet-maps

def-

[ddnet/ddnet-web] Pull request closed: #219 bencie stepped down

06:36

def-

[ddnet-web:master] 2 new commits

dbfa620 bencie stepped down - murpii 7068e84 Merge pull request #219 from murpii/patch-13 - def-

Ryozuki

Fck im 2 drunk

Wat you kill your good rust brain cells

It’s sober October! Be strong!

xd

wotefek man format features %b and it works as expected but I get a compiler warning: warning: invalid conversion specifier 'b' [clang-diagnostic-format-invalid-specifier]

12:17

for this line printf("%b\n", 255); what am i missing?

std=c++17 maybe?

ah ye thats an idea

12:45

indeed --std=c++17 removed the warning. Weird that it compiles and works either way :D

in e.g. c++11, this does not exist and thus you get the warning

13:11

there's no separate printf for c++17 in the standard library though, so you get the same printf, which supports %b

13:12

(I think GNU libc always supported %b, even before it was standardized)

I see

def-

[ddnet-web:master] 1 new commit

d4e0ded Steinchen99 -> Steinchen - def-

wot is a AltSnap and why is it used here over m_pSnap ? https://github.com/ddnet/ddnet/blob/9e4da2244af63f491039b9ce104f8df7ab8dc4df/src/engine/client/client.cpp#L1012

ddnet/client.cpp at 9e4da2244af63f491039b9ce104f8df7ab8dc4df · ddne...

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

14:10

gameclient chillin in alternative reality UwU

yo @cod3d3v what happend here? https://github.com/ChillerDragon/ddnet/commit/59436b5e6dec43286d85e7948949f86182c7280f#diff-88229ff11d1f6f39e6ba486ab4a7257d675fd7e91026b8fad8e731a54ac70c77L495

Add default values to extended Net Objects · ChillerDragon/ddnet@59...

in vanilla snap and altsnap seem more similar they have the same data somehow my ddnet altsnap ended up in a bad state while the normal snap is just fine ._.

Ah okay I see the altsnap is validated harder using UnpackAndValidateSnapshot while the snap is not. And that bends me over when trying to read 0.7 snaps.

b3z

[ddnet/ddnet] Issue closed: #2995 Adding the event type to server messages so that the client can filter and translate them

16:17

b3z

[ddnet/ddnet] Issue closed: #3151 Server search by multiple keywords

16:17

b3z

[ddnet/ddnet] Issue closed: #3152 Mac: Window shift on resolution change.

Robyt3

[ddnet/ddnet] Pull request opened: #5946 Add tests for too small/large `sha256_str` and `md5_str` buffers, minor refactoring

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[X] Written a unit test (especially base/) or added coverage to integration test
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...

I think the server can crash the client by not sending gameinfo in the snap but some active chracters https://github.com/ddnet/ddnet/blob/9e4da2244af63f491039b9ce104f8df7ab8dc4df/src/game/client/gameclient.cpp#L2445

ddnet/gameclient.cpp at 9e4da2244af63f491039b9ce104f8df7ab8dc4df · ...

DDraceNetwork, a free cooperative platformer game. Contribute to ddnet/ddnet development by creating an account on GitHub.

Robyt3

[ddnet/ddnet] Pull request opened: #5947 Fix client crash when server does not send gameinfo

As reported by @ChillerDragon on Discord.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test (especially base/) or added coverage to integration test
[X] Considered possible null pointers and out of bounds array indexing
[X] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](htt...

Just for experimentation: How can I add more sounds into the game while having it still be detectable? Currently I'm doing a small test for UI sounds for the fun of it (I won't release it as a PR), but the two test sounds I added in aren't being detected/played when they're called. The Enum is generated, but the actual files aren't brought in, despite being in the right place and name. I added the respective files into CMakeList as well, but no luck. (edited)

Voxel

Just for experimentation: How can I add more sounds into the game while having it still be detectable? Currently I'm doing a small test for UI sounds for the fun of it (I won't release it as a PR), but the two test sounds I added in aren't being detected/played when they're called. The Enum is generated, but the actual files aren't brought in, despite being in the right place and name. I added the respective files into CMakeList as well, but no luck. (edited)

https://github.com/Jupeyy/ddnet/tree/client_quake i added custom sound here

GitHub - Jupeyy/ddnet at client_quake

DDraceNetwork, a mod of Teeworlds. Contribute to Jupeyy/ddnet development by creating an account on GitHub.

18:45

maybe u can copy some stuff

18:47

did add them over the python stuff tho

oo

19:07

this looks a bit repetitive tbh LOL

bors[bot]

[ddnet:master] 4 new commits

c0b5e89 Refactor usages of sha256_str - Robyt3 a07c51b Use size_t for indices in digest_str - Robyt3 0a6ad9c Add tests for too small/large sha256_str and md5_str buffers - Robyt3 93b99ef Merge #5946 - bors[bot]

19:20

bors[bot]

[ddnet/ddnet] Pull request closed: #5946 Add tests for too small/large `sha256_str` and `md5_str` buffers, minor refactoring

@Voxel

c++
auto &&GetTrackNamePre = [](int Kills) -> const char * {
    if(Kills >= 5)
        return "is on a ";
    else if(Kills >= 10)
        return "has a ";
    else if(Kills >= 15)
        return "is ";

    return "";
};

19:25

is this good?

i think so

19:27

up to juppey if they wanna change it to that however

Maybe they planned to change other values

i mean it's based off of quake's killing spree thing so i doubt it

bors[bot]

[ddnet:master] 2 new commits

c78f71b Fix client crash when server does not send gameinfo - Robyt3 24207b7 Merge #5947 - bors[bot]

19:38

bors[bot]

[ddnet/ddnet] Pull request closed: #5947 Fix client crash when server does not send gameinfo

Alexander

@Voxel

c++
auto &&GetTrackNamePre = [](int Kills) -> const char * {
    if(Kills >= 5)
        return "is on a ";
    else if(Kills >= 10)
        return "has a ";
    else if(Kills >= 15)
        return "is ";

    return "";
};

this will always go into the first if

19:51

so no

ah yeah i reversed the order

19:51

dumbass

19:52

But yeah you can remove the unnecessary if statements

Voxel

this looks a bit repetitive tbh LOL

its fine, its easier to change it and more clear what modes there are, we planned to have it different, but then again didnt do it

also in theory multilang

Ohh

19:53

makes sense (edited)

Voxel

this looks a bit repetitive tbh LOL

when you cannot use switch case function

20:15

Isn't switch just as repetitive though

I don't know how to debug a fish: './DDNet-Server' terminated by signal SIGBUS: https://gist.github.com/Zwelf/4f3bfacce7badd1da35b55902101e6d9 Any ideas?

To trigger nearly everyone here. Rust is bad, it's not the future, Python is better and faster and Rust is not as safe as C / C++.

Alexander

@Voxel

c++
auto &&GetTrackNamePre = [](int Kills) -> const char * {
    if(Kills >= 5)
        return "is on a ";
    else if(Kills >= 10)
        return "has a ";
    else if(Kills >= 15)
        return "is ";

    return "";
};

This isn't

ReiTW

This isn't

Jupeyy already told me i fucked up

ah

I'm such a bad developer, good thing I'm not developing anything important

Zwelf

I don't know how to debug a fish: './DDNet-Server' terminated by signal SIGBUS: https://gist.github.com/Zwelf/4f3bfacce7badd1da35b55902101e6d9 Any ideas?

Found out what it was: I was passing the wrong class as thread data and therefore interpreting it as the wrong class.

I also guessed wrong pointer

Zwelf

[ddnet/ddnet] Pull request opened: #5948 Pr failsafe mysql

Fixes #4424

Immediately store all ranks/teamranks/saves in separate tabel (suffixed with _backup) in sqlite
remove the rank if mysql succeeds
move the rank to non-_backup table when failed
loading save codes from non-backup-tables is still possible (mostly the reason for the backup table to exist: to prevent double loading)
Immediately tell player how the backup save code will be on save failure

![new_save_text](https://user-images.githubusercontent.com/9964758/19601...