DDraceNetwork

On latest nightly, steam version 16.2.1-20220726, when you shift hold nothing in editor (to delete tiles) game crashes (edited)

DDNet_crash_log_11784_2022-07-26_19-58-06.RTP

4.4 KB

There was a similar bug, let me try if I can reproduce it: https://github.com/ddnet/ddnet/issues/5640

using shift-select as first action crashes editor · Issue #5640 · ...

Restart client, open any map and do a random shift-select. This will crash the 16.2.2 client everytime. If you select a tile with a different id beforehand it won't crash. Doesn't c...

Yep, can reproduce

i thought it was fixed?

Oh, I have a fix for it, but not submitted yet: https://github.com/ddnet/ddnet/pull/5627 Please someone bors r+ it

Fix shift + left click in editor (fixes #5626) by def- · Pull Reque...

Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test (especially base/) or add...

1

the fix doesn't look quite correct, I'm looking into it

it fixes the crash, but not sure if the logic behind is correct

yea

19:08

the whole condition looks wonky, like why does it set the index to 0

Like I didn't mention it before, noooo My theory was that, it loads shortcuts wrong, when it's on startup

19:13

Orrrrr, just cannot register an action related to shift + left click if there was no selection before

19:13

resulting in a null type