DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-07-02 00:00:00Z and 2022-07-03 00:00:00Z

[ddnet/ddnet] Pull request opened: #5544 Replaced float array with appropriate struct (vec or color)

I mostly touched the code in the graphic part for array of 2 floats into vec2. For color, i replaced array of 4 floats with ColorRGBA where it made sense. I had to change the logic order in src/engine/client/graphics_threaded.cpp:1113 due to operator= from vec2 to vec3. I didn't see any visual change.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Writt...

GitHub

Click to see attachment 🖼️

what will this do exactly :o

its just code quality stuff

ye middle mouse is used

06:51

you do not need ctrl to release a tile so in theory ctrl+leftclick should not conflict

on point

06:51

8h since ur last msg

06:52

truly a perfect bot

[ddnet/ddnet] Pull request opened: #5545 Format name accordingly

I think i got almost all the misstyped name. I did let some because they made sense to me. I think, only generated code remains to be formatted (and src/base and websockets, but those seems to have an exception).

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null point...

@Chairn do u ever sleep? xd

no

07:14

im gonna soon

xD

this last pr took me last 2 nights

07:15

im procrastinating too hard maybe

rip

07:15

we need tools for that anyway

i use regex

else contributing gets hard ^^

to find them, and then i use replace all reference

ez

i even put the regex i used in the commit message this time

07:16

clang-tidy freaking slow on my computer

u can run in with multi core, but dont do auto fixes then

07:17

it doesnt "lock" headers

07:17

so it will write to the same header simultanously

im using the same run as CI, so it doesn't fix anything

yeah looks like it also runs single threaded

yeah, but ninja parallelize it

07:18

Load average: 8

07:18

on 4 cores

ok maybe not

07:18

ok

07:19

so its just slow xd

07:19

i mean its defs slower than a normal build, but thats obvious

07:20

maybe you can run it only on files u changed? but no idea how xD

how the hell did ubuntu-latest compile??

louis

@AssassinTee do u know when the material layer will be finished?

No, for it to go into ddnet I need to refactor some things and redo the base PR. My Prototype is closed to be finished, while sounds and some animations are still missing

there's a fucking typo in a variable name

07:26

doesn't ubuntu-latest uses sqlite?

uhm maybe not, maybe it uses mysql directly?

@Chairn can u explain again why the assignment from vec2 to vec3 was required?

07:41

or what exactly required the logic to be reordered?

07:41

i see both code paths as completly independent

the function QuadsDrawTLImpl is a template class

07:41

it is called from 2 places

07:42

one where template was an old struct of yours with an operator= overload from vec2

07:42

i removed that struct as it was just a vec3 copy

07:42

but the assignment from vec2 to vec3 didn't touch last 3rd coordinate

07:43

so to mimic the final behavior, i switched for loop and QuadsDrawTLImpl

ah yeah i see

07:44

if u want a case how to trigger the bad new behavior

07:44

load some huge map into the editor with GL 3.0+ (or vk) and zoom out far

07:44

it will probs render incorrectly then

ok, thx for the feedback, i'll try later

07:49

ok, have a nice day, i'll go sleep ^^

@fokkonaut btw can u also see the FPS drops in demos? if so maybe you can record a ~1min demo and send it to me?

gn8

gn8? its 10

08:23

AM

ez

good night

ChillerDragon, do you have some nice ~1min demos? random team sizes, many particles, many entities whatever. I guess your server also abuses the physics to the limit, perfectly for what i want

[ddnet-scripts:master] 1 new commit

ed544b6 Clean up builds dir first - def-

just join a server and record some? xd

09:38

and omagawd the internet is offline

09:38

gitlab and github are down like watafak

09:39

when git.ddnet.tw for better uptime

09:39

.org *

everytime i read about unicode and text rendering stuff i wonder again and again, why was it made so insanly hard ^^ https://github.com/orling/grapheme-splitter multiple unicode points for one visual

GitHub - orling/grapheme-splitter: A JavaScript library that breaks...

A JavaScript library that breaks strings into their individual user-perceived characters. - GitHub - orling/grapheme-splitter: A JavaScript library that breaks strings into their individual user-pe...

09:44

ChillerDragon pls send, i dont want to join ur server

Jupstar ✪

ChillerDragon, do you have some nice ~1min demos? random team sizes, many particles, many entities whatever. I guess your server also abuses the physics to the limit, perfectly for what i want

I dont think his server does

ok i can try to get something

09:47

but only because i love u jopstar

Z͑ͫ̓A̴ͫ͗LͨͧͩG̑͗̎O͂̌̌!̿̋ͥ" lmao. this string is 145 bytes as c++ char array

fokkonaut

I dont think his server does

then u pls send demos xd

and only browser technology can render it

of what

all other software will fail

yeah bcs nobody understands this xDD

09:47

like wtf

@Jupstar ✪ just join my server

09:49

no idea what u need

just gimme any demo with bad performance as u mentioned

well, its just that the general performance seems to be going down

09:54

nothing specific i can do

you said that performance went down. have you checked whether it also went down in demos? if so, just send a demo you used to test this to Jupstar

then give me general demo xd

like this? @Jupstar ✪ https://zillyhuhn.com/cs/.1656755720.png

Embedded image

yeah

09:55

nice xd

what the fuck? i cant use open gl 3.0.0 it seems. i get massive laggs when zooming out and when i checked it was set to 1.4.0

are you on an intel GPU on windows rn?

ye

well use vulkan, intel drivers shipped with windows are still broken

i always used gl 3.0 without problems

but on nvidia 1060

ah wait

09:56

i didnt select 3.3

09:57

bcs i had set it before, idk why it resetted to 1.4.0

yeah weird

@Jupstar ✪ https://zillyhuhn.com/tmp/GrillBlockShive_2022-07-02_11-54-24.demo enjoy virus maatfaka

I think we blacklist some intel drivers on windows?

yeah but fokko has an nvidia 1060

that seemed to be it

he is just confused

3.3.0 works again, lol. why did it got reset to 1.4.0?! i did not change any setting

09:58

and yesterday when i checked and reported, i verified it was on 3.3

09:58

so i thoiught there was no change on my side

i dunno, 1.4 is hard to trigger, u need to have a bug during your first start with the client and it must fail to render a tilemap with the new rendering method

09:59

else it never falls back, so you probs did it manually

09:59

or u uninstalled your driver or smth xd

neither

i think it rechecks everytime you do driver updates

i guess it will stay a mystery

so that was the problem with ur performance i guess?

10:01

gl 1.x does not batch any particles or whatever

u need more jopstar?

i take everything yes

ok

but not the same if possible, other particles or different entities

yes

i am collecting some weird edge cases

i can give you some shields

10:04

https://zillyhuhn.com/tmp/shields.demo

10:04

Embedded image

i might have a finding for u jopstar

10:12

Embedded image

10:12

Embedded image

10:12

this is smooth af in game but the demo gets very gltichy :/

10:13

https://zillyhuhn.com/tmp/bullets.demo

lol

10:14

looks funny

ikr

10:14

made by timakro the legend

10:16

imagine the possibilitys if servers could send a laser color to the client o.O

would already be nice to get the owner of the laser, does entityex have a field for that?

now that we have extras.png, can we also move the new shields to extras.png? i many ppl use customized game.pngs so would be worth it

[ddnet/ddnet] Pull request opened: #5546 Remove unused `#include ` in engine client

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

[ddnet/ddnet] Pull request opened: #5547 Minor tweaks to keep ODR across translation units

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

12:37

[ddnet:master] 2 new commits

8ee821c Remove unused #include <windows.h> in engine client - Robyt3 d0af85d Merge #5546 - bors[bot]

12:38

[ddnet/ddnet] Pull request closed: #5546 Remove unused `#include ` in engine client

[ddnet/ddnet] Issue opened: #5548 Clang Warnings

So many clang warnings lately:

OpenSSL 3 deprecation warnings
thread-safety-analysis

``` [13/82] Building CXX object CMakeFiles/engine-shared.dir/Unity/unity_5_cxx.cxx.o In file included from build_tmp/CMakeFiles/engine-shared.dir/Unity/unity_5_cxx.cxx:17: src/base/hash_openssl.cpp:6:2: warning: 'SHA256_Init' is deprecated [-Wdeprecated-declarations] SHA256_Init(ctxt); ^ /usr/include/openssl/sha.h:73:1: note: 'SHA256_Init' has been explicitly marked deprecat...

[ddnet:master] 3 new commits

50f8653 Minor tweaks to keep ODR across translation units - Jupeyy 7250be6 Rename typedef - Jupeyy b79bb7e Merge #5547 - bors[bot]

13:25

[ddnet/ddnet] Pull request closed: #5547 Minor tweaks to keep ODR across translation units

Jupstar ✪

ask fokkonaut, he abuses all these flags xd

i abuse everything in this game to all extends

[quakenet] ChillerDragon

Click to see attachment 🖼️

monkaS

fokkonaut

i abuse everything in this game to all extends

that‘s not bad. my main job is abusing databases to find bugs happy

happy

interesting

2

sounds fun indeed

some time i ago i saw this https://www.edgedb.com/

EdgeDB | The post-SQL era has arrived

EdgeDB is an open-source database designed as a spiritual successor to SQL and the relational paradigm.

20:07

looked interesting

20:07

built on top of psql

20:09

Image attachment

[ddnet-scripts:master] 1 new commit

2bc940e rm codebrowser - def-

[ddnet-scripts:master] 1 new commit

9365745 rm - def-

Ryozuki

Click to see attachment 🖼️

That is intriguing, it'd be even cuter if it compiled to SQL98 instead of trying to invent a new db engine

it compiles to psql

23:41

honestly

23:41

sql can do well with a rewrite

Oh so the underlying db is psql?

ye

23:42

the queries are turned into psql queries

That's actually nice. I might give this a go in some small project sometime

23:43

I've always found writing SQL a little too tedious

yeah

Exported 167 message(s)