Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2022-06-30 00:00:00Z and 2022-07-01 00:00:00Z
Avatar
GitHub BOT 2022-06-30 00:05:33Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
756ef3d simplify the snowflake - C0D3D3V 03c5e6a Merge #5537 - bors[bot]
00:05
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5537 simplify the snowflake by Ravie
Avatar
GitHub BOT 2022-06-30 00:26:17Z
Author icon
bors[bot]
[ddnet:master] 3 new commits
f908e4a Updated french language - Chairn 96e9364 Fix more unsafe define - Chairn c345bc6 Merge #5535 #5536 - bors[bot]
00:26
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5535 Updated french language
00:26
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5536 Fix more unsafe define
Avatar
GitHub BOT 2022-06-30 04:30:18Z
Author icon
ddnet-maps
[ddnet-maps:master] 1 new commit
f3bdcad M 1of4, M 3of4, M Delension, M Desert Night, M HDP_OnOff, A Vagrant, M WallJump, M ctf5_solo - ddnet-maps
Avatar
Avatar
deen
@c0d3d3v In general I really appreciate the HUD changes, freeze bar and snow flakes. Starts to feel more like a proper game when we're not just abusing every old graphical element but implement our own 🙂
Matodor 2022-06-30 05:55:10Z
soon at this pace and the account system will appear and api for mods trollet
Avatar
cauldron 2022-06-30 07:19:56Z
hello dumb question. if you fork a repo and want to stay "compatible" with the newest ddnet/master, but you want to have your own master like fork/master. and put all your features into your own master plus change readme and everything. whats the best workflow? i am confused. merge? make my repo as origin/upstream and frequently merge ddnet/master into my fork master? having ddnet master as a second remote named ddnet, but not upstream for any branch? i just want to put some features together but dont want to stay behind ddnet/master. (edited)
07:25
i just have the problem that i have a feature branch where i changed hud specific things but the branch is one month behind and now with the new hud in master i have merge conflicts...
07:25
i guess ill just code it again
07:26
based on current master, easier than understanding all the merge conflicts
Avatar
AssassinTee 2022-06-30 07:27:23Z
it might be easier to do a rebase
07:28
If you do it with a good IDE, you could also use the new hud files and ignore changes from you and reimplement it. The other changes could be merged as usual
Avatar
cauldron 2022-06-30 07:30:39Z
yes ok, i'll just reimplement (edited)
07:31
whats the ide got to do with it? is rebase a manual thing like resolving merge conflicts? i use ms vscode
Avatar
Tater 2022-06-30 08:46:56Z
separating your changes into separate files or functions and making minimal changes to original code makes it a lot easier when possible.
Avatar
Ryozuki 2022-06-30 09:14:59Z
Make ur own branch
Avatar
Simon 2022-06-30 09:32:14Z
can we have a ingame wordfilter? at least for twitch?
Avatar
Lagar 2022-06-30 10:16:52Z
u can hide whole chat or only show msgs from friends already
Avatar
heinrich5991 2022-06-30 10:41:50Z
@Tater have you considered simply sending multiple input packets?
10:42
our game/engine packets are coalesced into UDP packets
Avatar
texnonik 2022-06-30 10:44:14Z
map editor autosaving
Avatar
heinrich5991 2022-06-30 10:44:21Z
@Simon yes, that would probably be good for streamers
Avatar
GitHub BOT 2022-06-30 10:44:26Z
Author icon
heinrich5991
[ddnet/ddnet] Issue reopened: #2304 Client side word filter list
Avatar
Avatar
c0d3d3v
I'm sorry about this.
deen 2022-06-30 10:57:53Z
no worries, as maintainer i should have called that out earlier
Avatar
Avatar
heinrich5991
our game/engine packets are coalesced into UDP packets
Tater 2022-06-30 10:58:45Z
The packets are automatically combined? Are you sure it doesn't add significant overhead sending lots of input packets every tick? it would certainly be easy to do if thats the case
Avatar
heinrich5991 2022-06-30 10:59:59Z
they are automatically combined until you send a packet with NETSENDFLAG_FLUSH
11:00
NETSENDFLAG_FLUSH tells the network to send everything it has out
11:00
(or until the buffer for one packet is full)
Avatar
Tater 2022-06-30 11:00:29Z
oh wow that's very nice
Avatar
heinrich5991 2022-06-30 11:00:38Z
extra overhead per sub-packet: 2 bytes (edited)
11:02
https://github.com/ddnet/ddnet/blob/c345bc6993332fc1969650121d7aab4fa49ce270/src/engine/shared/network.h#L19-L35=
11:02
"chunk header"
Avatar
Tater 2022-06-30 11:02:59Z
I'll look more at that later, it would probably be better if trml implemented this system but I'll give it a try if he is busy
Avatar
heinrich5991 2022-06-30 11:04:43Z
you don't need to implement anything server-side, right?
Avatar
Tater 2022-06-30 11:06:00Z
well in my testing the server is currently not very good at handling duplicate packets, I was able to fix it but the code path for inputs on the server seems very complex
Avatar
heinrich5991 2022-06-30 11:06:59Z
ah 😦
Avatar
Tater 2022-06-30 11:11:41Z
I don't really know why it's so complex but its rather scary code to touch especially with the lack of any tests
Avatar
Avatar
GitHub
Click to see attachment 🖼️
Simon 2022-06-30 11:12:43Z
that is very appreciated
Avatar
Simon 2022-06-30 11:22:46Z
"Don't think that helps much personally. There can always be creative wordings that are not blocked." what about not blocking names but ip adresses, so u cant just rejoin with another name?
Avatar
GitHub BOT 2022-06-30 11:28:04Z
Author icon
bors[bot]
[ddnet:master] 16 new commits
939c51b Add IsPlaying to engine sound - Robyt3 3db3f0a Code style: remove unnecessary indentation - Robyt3 4bc8871 Refactoring: move variable declarations in engine sound - Robyt3 1fb46b7 Code style: rename variable id to NextID - Robyt3 d3e4ebf Simplify loop body and reduce duplicate code - Robyt3 a8949cb Fix log message context - Robyt3 82425f2 Handle WavpackUnpackSamples failure - Robyt3 757d7d0 Change m_SoundEnabled from int to bool - Robyt3 b4a82b1 Reduce visibility of engine sound members and methods - Robyt3 525527f Add IsPlaying to sounds client component - Robyt3 9932bd7 Update menu music state when the config variables change via console - Robyt3 9390ae9 Fix OOB access when stopping a sound that has invalid samples - Robyt3 2e200c8 Use consistent sizeof expression for Mix calls - Robyt3 d8e72ad Handle op_read errors and EOF - Robyt3 b8d6298 Rename OpusFile to pOpusFile - Robyt3 2bd1273 Merge #5514 - bors[bot]
11:28
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #2911 if you have use sounds enabled, then do snd_enable 0, the menu music still plays but use sounds becomes disabled
11:28
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5514 Update menu music state when the config variables change via console, various refactoring
Avatar
cauldron 2022-06-30 11:46:34Z
various refactoring
Avatar
Avatar
Simon
"Don't think that helps much personally. There can always be creative wordings that are not blocked." what about not blocking names but ip adresses, so u cant just rejoin with another name?
heinrich5991 2022-06-30 11:57:50Z
people are actually really motivated to spam and use proxies to circumvent IP bans
Avatar
GitHub BOT 2022-06-30 12:59:27Z
Author icon
def-
[ddnet-web:master] 1 new commit
4b1b5bf Add 22.22 € donation by ReD - def-
Avatar
GitHub BOT 2022-06-30 13:23:49Z
Author icon
bors[bot]
[ddnet:master] 4 new commits
281c766 Add APPEARANCE Settings page - C0D3D3V a26285c Add cl_nameplates_strong to settings page - C0D3D3V cee071e The appearance settings page has been revised to look more like the general and DDNet settings page - C0D3D3V 5e0eada Merge #5517 - bors[bot]
13:23
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5517 Add APPEARANCE Settings page
Avatar
Avatar
AssassinTee
If you do it with a good IDE, you could also use the new hud files and ignore changes from you and reimplement it. The other changes could be merged as usual
cauldron 2022-06-30 13:48:28Z
ah... i'll just try to merge with resolving conflicts, not want to reimplement xd
Avatar
Avatar
Ryozuki
Make ur own branch
cauldron 2022-06-30 13:49:53Z
yes, that's the best way, but can i somehow say github that they sould show my branch as default branch on my fork. because i want a "fork readme" and not the master branch that's identical to the ddnet master
Avatar
Robyt3 2022-06-30 13:51:32Z
you can name the upstream branch upstream and have your own master branch be the main
13:52
or change the default branch https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/changing-the-default-branch
Avatar
cauldron 2022-06-30 13:54:16Z
i never forked something before, i guess it's obvious how to do it... xd i'll just change the default branch i think, name it "cauldron" and push it to my own repo. merge all my other branches into the cauldron branch and merge ddnet/master into the cauldron branch. in my theory it's cool.
13:54
but maybe not xd
Avatar
Avatar
Matodor
soon at this pace and the account system will appear and api for mods trollet
Kurosio 2022-06-30 14:20:44Z
lol, So it will be, there are more and more people, therefore, the community is growing nouis
Avatar
GitHub BOT 2022-06-30 14:56:14Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
b62894d Switch to loading screen, when map creation takes too long - Jupeyy 5e7ec64 Merge #5486 - bors[bot]
14:56
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5486 Switch to loading screen, when map creation takes too long
Avatar
GitHub BOT 2022-06-30 15:10:06Z
Author icon
luk51
[ddnet/ddnet] Pull request opened: #5538 fix typo and comment
just found a variable lasterOutlineColor instead of laserOutlineColor + double comment

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+U...
Avatar
GitHub BOT 2022-06-30 16:04:06Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
1c340da fix typo and comment - luk 21178e2 Merge #5538 - bors[bot]
16:04
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5538 fix typo and comment
Avatar
GitHub BOT 2022-06-30 17:32:35Z
Author icon
C0D3D3V
[ddnet/ddnet] Pull request opened: #5539 Remove even more redundant variables to avoid inconsistent states. Fix another swap bug.
See https://youtu.be/jghPB-Y2BsQ Please review it carefully. I made all the changes manually and was careful. I don't think I made a mistake, but it can happen.

Checklist

  • [x] Tested the change ingame
  • [x] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [x] Considered possible null pointers and out of bounds array indexing
  • [x] Chang...
Avatar
GitHub BOT 2022-06-30 17:48:03Z
Author icon
Robyt3
[ddnet/ddnet] Pull request opened: #5540 Minor refactoring: Fix variable names and use sizeof in CMapImages

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--und...
Avatar
GitHub BOT 2022-06-30 18:28:09Z
Author icon
bors[bot]
[ddnet:master] 4 new commits
3c7847a Fix variable name WasUnknwon -> WasUnknown - Robyt3 d5594d8 Fix variable name EntitesAreMasked -> EntitiesAreMasked - Robyt3 d9b0304 Use sizeof instead of constant - Robyt3 747fe93 Merge #5540 - bors[bot]
18:28
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5540 Minor refactoring: Fix variable names and use sizeof in CMapImages
Avatar
Ryozuki 2022-06-30 20:05:29Z
https://blog.rust-lang.org/2022/06/30/Rust-1.62.0.html
Announcing Rust 1.62.0 | Rust Blog
Empowering everyone to build reliable and efficient software.
Thumbnail
20:05
@ReiTW hehe
20:05
@Jupstar ✪ this update makes it even easier to write kernels
20:05
before u had to do some config to disable the red zone
20:05
with the new compile target u dont need to
20:06
also now rust uses its on mutexes instead of using pthread
20:06
from 40 byte overhead to 5 bytes
20:06
Image attachment
20:06
BASED
Avatar
Jupstar ✪ 2022-06-30 20:07:42Z
epic
Avatar
Ryozuki 2022-06-30 20:08:13Z
https://news.ycombinator.com/item?id=31935116
caution
Rust 1.62.0
Footer icon Hacker News • 2022-06-30 16:42:20Z
20:08
discussion
Avatar
Jupstar ✪ 2022-06-30 20:15:50Z
now only godot 4 is missing
Avatar
Avatar
Ryozuki
Click to see attachment 🖼️
Learath2 2022-06-30 20:25:29Z
I wonder what they did with mutexes on windows, they also have something similar to futexes but they also have critical sections that are part of the winapi. The two have very different performance characteristics obv
20:27
Also futex based locks can't really be moved either, I wonder what they were talking about there
20:29
heck, it's also the reason pthread based mutexes can't be moved because glibc and most other libcs use futexes under the hood 😄
Avatar
Ryozuki 2022-06-30 20:29:27Z
it rly improved perf tho
20:29
idk
20:30
but i guess the key part is this
20:30
The pthreads locks support more features than the Rust APIs themselves do, including runtime configuration, and are designed to be used in languages with fewer static guarantees than Rust provides.
20:30
and are designed to be used in languages with fewer static guarantees than Rust provide
20:30
https://github.com/rust-lang/rust/issues/93740
Tracking issue for improving std::sync::{Mutex, RwLock, Condvar} · ...
A few weeks ago, on January 12th, the @rust-lang/libs team discussed a plan to improve std::sync::Mutex, std::sync::Condvar, and std::sync::RwLock. On most platforms, these structures are currently...
Thumbnail
Avatar
Learath2 2022-06-30 20:30:57Z
I don't doubt that it improved performance, why would they lie about that. I was just wondering what they were talking about with movability and what they did on windows for parity
Avatar
Avatar
Learath2
I don't doubt that it improved performance, why would they lie about that. I was just wondering what they were talking about with movability and what they did on windows for parity
Ryozuki 2022-06-30 20:31:09Z
no
20:31
they said that pthread cannot be moved
20:31
and so to make that guarantee on rust
20:31
they have to be boxed
20:31
and thats an allocation
20:31
which is now removed
20:31
by using their own impl
Avatar
Learath2 2022-06-30 20:31:39Z
Ah, so the new implementation might not be movable either, it just doesn't need a box
Avatar
Ryozuki 2022-06-30 20:31:41Z
as far as i udnerstand
20:33
@Learath2 i think before it did 2 allocations
20:33
if u used arc mutex
20:33
so now its 12
20:34
1
20:34
in the future when they stabilize scoped threads without a needed a library as is now, you can avoid the arc (edited)
20:34
Image attachment
Avatar
Learath2 2022-06-30 20:37:57Z
Huh, bizarre, how does this thread scope thing even work? Seems you can spawn 2 threads in the same scope and both can borrow the same thing at the same time
Avatar
Avatar
Learath2
Huh, bizarre, how does this thread scope thing even work? Seems you can spawn 2 threads in the same scope and both can borrow the same thing at the same time
Ryozuki 2022-06-30 20:38:55Z
because with the scope rust can know the value lives as long as needed (aka as long as the scope lives)
20:39
the std says it better
20:39
Unlike non-scoped threads, scoped threads can borrow non-'static data, as the scope guarantees all threads will be joined at the end of the scope.
>
All threads spawned within the scope that haven’t been manually joined will be automatically joined before this function returns.
20:39
https://doc.rust-lang.org/nightly/std/thread/fn.scope.html
scope in std::thread - Rust
Create a scope for spawning scoped threads.
Avatar
Learath2 2022-06-30 20:40:24Z
Oh, so when thread::scope returns the threads spawned within it will have joined already
Avatar
Ryozuki 2022-06-30 20:40:26Z
Image attachment
20:40
yeah
20:40
and u can handle errors by joining them explicitly
20:40
otherwise if one panics it will panic too
Avatar
Learath2 2022-06-30 20:41:06Z
I see, that does sound useful indeed
Avatar
Ryozuki 2022-06-30 20:41:15Z
it allows to avoid Arc on most cases
Avatar
Learath2 2022-06-30 20:41:16Z
A lot of Arcs can be avoided that way
Avatar
Ryozuki 2022-06-30 20:41:19Z
ye
20:41
Arc is the multithreaded way to make a value live for 'static more or less
20:41
xd
20:43
@Learath2 have u used lazy_static?
Avatar
Learath2 2022-06-30 20:43:52Z
yes, with a regex
Avatar
Ryozuki 2022-06-30 20:44:02Z
i hate tweets but she tweets a lot of good stuff about rust
20:44
https://twitter.com/m_ou_se/status/1538209506085244929
Author icon
Mara Bos (@m_ou_se)
🦀 Starting in @rustlang 1.63, Mutex::new, RwLock::new, and Condvar::new are all const functions! That means you can now finally use these types as static variables, without needing lazy_static or once_cell or other workarounds. 🎉
Likes
1460
Retweets
182
Image
Footer icon Twitter • 2022-06-18 17:18:19Z
20:44
tldr u can avoid it in 1.63
20:44
due to mutex new being const
Avatar
Learath2 2022-06-30 20:44:38Z
Oh that's nice too
Avatar
Ryozuki 2022-06-30 20:45:01Z
"On Linux and *BSD these use futex() syscalls directly. On Windows, they're wrappers around SRW locks. On macOS, these (still) use pthread's locks, but now lazily allocated and initialized."
20:45
macos always there to be funny
Avatar
Learath2 2022-06-30 20:45:47Z
This is the new mutex implementation?
Avatar
Ryozuki 2022-06-30 20:45:58Z
nah thats for the future const new mutex
20:46
well yeah
Avatar
Learath2 2022-06-30 20:46:11Z
SRW locks are nice
Avatar
Ryozuki 2022-06-30 20:46:16Z
but maybe it uses that on 1.62
20:50
Image attachment
20:50
found it
Avatar
Learath2 2022-06-30 20:58:16Z
Huh, surprising they didn't match parking_lot in the no contention case given how similar their implementation looks
20:58
but that's a massive improvement indeed, very nice to see things moving forward in a language
20:58
C++ is permastuck with pthread ones
Avatar
Ryozuki 2022-06-30 21:13:32Z
xD
Avatar
Ryozuki 2022-06-30 21:24:32Z
https://sfconservancy.org/blog/2022/jun/30/give-up-github-launch/
Give Up GitHub: The Time Has Come!
Those who forget history often inadvertently repeat it. Some of us recall that twenty-one years ago, the most popular code hosting site, a fully Free and Open Source (FOSS) site called SourceForge, proprietarized all their code — never to make it FOSS again. Major FOSS projects slowly left SourceForge since it was now, itself, a proprietary s...
21:24
https://news.ycombinator.com/item?id=31932250
jrepinc
Give up GitHub: The time has come
Footer icon Hacker News • 2022-06-30 13:44:02Z
21:25
If it is, as you claim, permissible to train the model (and allow users to generate code based on that model) on any code whatsoever and not be bound by any licensing terms, why did you choose to only train Copilot's model on FOSS? For example, why are your Microsoft Windows and Office codebases not in your training set?
Avatar
Learath2 2022-06-30 21:48:04Z
Difference between github and sourceforge is that github isn't a shit product. It's very convenient and pretty, furthermore new generation of open source developers aren't as ideological as the ones we had back in the day. Good luck convincing hipsters that fetishize UI/UX to switch
21:48
The only way I see github ever dying like sourceforge is if massive projects decide to move away from it, which is unlikely given most seem to be moving to github rather than away from github
Avatar
GitHub BOT 2022-06-30 22:10:08Z
Author icon
Robyt3
[ddnet/ddnet] Pull request opened: #5541 Fix player input player flags translation with sixup, fix player flags output of `status` command
Closes #5220.

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...
Avatar
Learath2 2022-06-30 22:26:13Z
@c0d3d3v so what are the gameinfo flags controlling the hud?
Avatar
fokkonaut 2022-06-30 22:26:33Z
i implemented them
22:26
the gameinfoEx can send up to 3 flags
22:26
one for armor/heartzs
22:26
one for ammo
22:26
and one for ddrace hud
22:27
if multiple ones get sent, they get adjusted donwwards
22:27
u can try that on my server, i can show you
22:27
i have implemented all versions already, depending on what u do
Avatar
Learath2 2022-06-30 22:27:49Z
how do I check them out?
Avatar
fokkonaut 2022-06-30 22:28:02Z
come visit me, i will show you
Avatar
Learath2 2022-06-30 22:28:08Z
I'm on your server
Avatar
Avatar
Learath2
@c0d3d3v so what are the gameinfo flags controlling the hud?
c0d3d3v 2022-06-30 22:29:46Z
I just debugged KOG, they do not even send a single flag O.o
22:31
ah xDD I guess I know what goes wrong
22:33
yep @fokkonaut removed the check that the server is sending extended character data. So the client does not fall back to the vanilla hud
22:33
I will add it back in
Avatar
GitHub BOT 2022-06-30 22:33:55Z
Author icon
bors[bot]
[ddnet:master] 3 new commits
6d0806f Fix engine client flags not being updated under some conditions - Robyt3 f3fbe89 Fix player input player flags translation with sixup - Robyt3 2cba4dd Merge #5541 - bors[bot]
22:33
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #5220 Vanilla 0.7 Scoreboard Ping display not working correctly on DDNet servers
22:33
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5541 Fix player input player flags translation with sixup, fix player flags output of `status` command
Avatar
Avatar
c0d3d3v
I will add it back in
c0d3d3v 2022-06-30 22:35:53Z
I will do that tomorrow... I'm tired...
Avatar
fokkonaut 2022-06-30 22:36:08Z
https://github.com/ddnet/ddnet/pull/5427
22:36
@Learath2 check the screens
Avatar
Avatar
fokkonaut
https://github.com/ddnet/ddnet/pull/5427
c0d3d3v 2022-06-30 22:38:36Z
that check... As I copied your delete I forgot why I added it... but now it makes sense xD (edited)
Image attachment
22:42
Actually we could also just only display the weapon display and the jumps...
Avatar
Learath2 2022-06-30 22:42:20Z
So if the server isn't sending extended character data we shouldn't render the new hud, that makes sense to me given we don't try to predict it by default
Avatar
Avatar
c0d3d3v
Actually we could also just only display the weapon display and the jumps...
Learath2 2022-06-30 22:43:20Z
Let's not change it for servers that don't want to change it, @Avolicious can start sending HUD_DDRACE if he wants the new hud on kog
Avatar
c0d3d3v 2022-06-30 22:43:25Z
Some data would be predicted... but not perfectly
Avatar
fokkonaut 2022-06-30 22:44:14Z
i'll print that
Image attachment
Avatar
Avatar
Learath2
Let's not change it for servers that don't want to change it, @Avolicious can start sending HUD_DDRACE if he wants the new hud on kog
c0d3d3v 2022-06-30 22:46:45Z
at least as I debuged it, ... at least the servers I tested do not send any gameinfo... we use the pFallbackServerInfo infos... thats why it is categorised as a DDRace server, but it is not sending DDNetCharacters
Avatar
fokkonaut 2022-06-30 22:47:15Z
@Learath2 ahhh i know why jumps didnt work. because i havent merged displayinfo into ddnetchar
Avatar
Learath2 2022-06-30 22:47:28Z
Oh wait, so KoG doesn't send gameinfo at all?
Avatar
c0d3d3v 2022-06-30 22:47:54Z
Image attachment
Avatar
Avatar
Learath2
Oh wait, so KoG doesn't send gameinfo at all?
fokkonaut 2022-06-30 22:48:07Z
theyre old af
Avatar
c0d3d3v 2022-06-30 22:48:18Z
at least 3 updates are made... But when I debug it the version is always -1
Avatar
Learath2 2022-06-30 22:48:36Z
I guess then the fallback info should be upgraded to include HUD_HEALTH_ARMOR and HUD_AMMO
Avatar
c0d3d3v 2022-06-30 22:48:39Z
but it does not send any extended net objects
Avatar
Avatar
c0d3d3v
at least 3 updates are made... But when I debug it the version is always -1
Learath2 2022-06-30 22:48:48Z
That is the old gameinfo, not extended ddnet gameinfo
Avatar
Avatar
Learath2
I guess then the fallback info should be upgraded to include HUD_HEALTH_ARMOR and HUD_AMMO
fokkonaut 2022-06-30 22:48:52Z
it should
22:48
ah
22:49
i see why it didnt work
Avatar
Avatar
Learath2
That is the old gameinfo, not extended ddnet gameinfo
c0d3d3v 2022-06-30 22:49:18Z
ah
22:49
true
Avatar
fokkonaut 2022-06-30 22:49:36Z
https://github.com/ddnet/ddnet/blob/2cba4dd768a6523a6cba76fe17019e6e4315c301/src/game/client/gameclient.cpp#L1065-L1068
Avatar
Learath2 2022-06-30 22:49:38Z
Info.m_HudHealthArmor = !DDNet; this doesn't look very correct, right? I guess this is it?
Avatar
c0d3d3v 2022-06-30 22:49:43Z
this is ddnet server:
Image attachment
Avatar
fokkonaut 2022-06-30 22:49:47Z
yes, this is it @Learath2
Avatar
Learath2 2022-06-30 22:50:03Z
Yeah, so just a small fix to the fallback info is needed and we are fine
Avatar
Avatar
Learath2
Info.m_HudHealthArmor = !DDNet; this doesn't look very correct, right? I guess this is it?
c0d3d3v 2022-06-30 22:50:08Z
no it is ok
Avatar
fokkonaut 2022-06-30 22:50:10Z
yeah, and which?
22:50
its not easy to predict everythign correctly xd
22:50
like, for all types
Avatar
Avatar
Learath2
Info.m_HudHealthArmor = !DDNet; this doesn't look very correct, right? I guess this is it?
c0d3d3v 2022-06-30 22:50:53Z
it should just fallback to Info.m_HudHealthArmor if we do not get extended game info
Avatar
fokkonaut 2022-06-30 22:50:57Z
yea
22:51
+ ammo
22:51
the default way
Avatar
Learath2 2022-06-30 22:51:10Z
It should already
Avatar
fokkonaut 2022-06-30 22:51:20Z
no, bcs kog is ddnet
22:51
so it falls back to nothing
22:51
but the ddrace hud
22:51
which is not shown
22:51
due to the other case
22:51
they just gotta update. its unbelievable :D
Avatar
Learath2 2022-06-30 22:52:11Z
It falls back correctly, the values you chose are wrong afaics
Avatar
fokkonaut 2022-06-30 22:52:24Z
why?
Avatar
Learath2 2022-06-30 22:52:42Z
It should be true, true, false. That was the old behaviour we want to preserve
Avatar
fokkonaut 2022-06-30 22:53:20Z
ah
22:53
yes
22:53
i did it the other way around
Avatar
Learath2 2022-06-30 22:53:36Z
Even if a server is deemed to be IsDDNet unless it's sending the new gameinfo and the character with the new values, we should just render the old hud. Atleast that's how I have it in my head
Avatar
c0d3d3v 2022-06-30 22:53:40Z
ta-da KOG server ... just by adding this:
Image attachment
Image attachment
Avatar
fokkonaut 2022-06-30 22:53:49Z
no
Avatar
Learath2 2022-06-30 22:53:50Z
Now that looks very wrong
Avatar
fokkonaut 2022-06-30 22:53:50Z
pls no
Avatar
c0d3d3v 2022-06-30 22:53:54Z
need to check if this is fine... tomorrow... I will make a fix
Avatar
fokkonaut 2022-06-30 22:54:03Z
do what learath and me just said
Avatar
Learath2 2022-06-30 22:54:06Z
But yes, true true fals 😄
Avatar
fokkonaut 2022-06-30 22:54:13Z
just at the top xd
22:54
in the initial place
Avatar
Learath2 2022-06-30 22:54:45Z
Anyway, I need to sleep too. Good thing we caught it before release, I guess kog people just don't play with rcs ever
Avatar
fokkonaut 2022-06-30 22:54:55Z
ye (edited)
Avatar
c0d3d3v 2022-06-30 22:55:40Z
you mean like this
Image attachment
Avatar
fokkonaut 2022-06-30 22:56:46Z
yes
22:57
it should stay like this no matter teh gametype.
22:57
because this is the main teeworlds setting
22:57
defualt
22:57
and once the server sends the right flags and version > x + the extended info = show ddrace hud
Avatar
Avatar
c0d3d3v
you mean like this
heinrich5991 2022-06-30 23:52:10Z
yes, like that
Avatar
Avatar
Learath2
Also futex based locks can't really be moved either, I wonder what they were talking about there
heinrich5991 2022-06-30 23:52:58Z
you can only move stuff in rust when you have the sole reference to it
23:53
in that case, you can obviously move the futex-based mutex because no one can have it locked at the time (because no one else has a reference to it)
23:53
but apparently you're not allowed to move pthread mutexes in that case
Avatar
Avatar
heinrich5991
in that case, you can obviously move the futex-based mutex because no one can have it locked at the time (because no one else has a reference to it)
Learath2 2022-06-30 23:53:46Z
Oh that's very clever
23:54
I wonder why that's not the case with pthread mutexes, the same idea should apply, no
23:54
?
Avatar
heinrich5991 2022-06-30 23:59:58Z
it looks like they might have an internally linked list
Exported 238 message(s)