Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories β€” IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2022-06-25 00:00:00Z and 2022-06-26 00:00:00Z
Avatar
a6fa123 Mention code browser in readme - def- 0081e99 integration test: print log diff for easier result check - def- a0cdefa Merge #5492 #5493 - bors[bot]
00:23

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undef...
Avatar
Avatar
Skeith
But speedrunning in the past didn't make use of them, is what I'm saying. Sure it exists now and you could view it as a mechanic, but I don't think a majority of speedrunners enjoy that you need to do it
But speedrunning in the past didn't make use of them, is what I'm saying.
You're stating this as a fact. Can you provide any reasoning or evidence?
Avatar
Nope, just experience
05:16
Doesn't mean much I guess
Avatar
Avatar
Jupstar βœͺ
what do u need the apk for
oh i thought it was updated version
Avatar
im pretty sure the android build is broken anyway
07:04
Does anyone have tried to build for android recently?
Avatar
Jupstar βœͺ 2022-06-25 07:07:33Z
yes works for me
Avatar
oh then fine πŸ™‚
07:09
did/can you upload the apk on ddnet.tw/download ?
Avatar
Jupstar βœͺ 2022-06-25 07:11:00Z
but why, u cannot relly use it, no controls
07:11
u can use it with keyboard and mouse xD
07:12
ah but compiling SDL is currently broken sdl/src/audio/openslES/SDL_openslES.c:163:25: error: mixing declarations and code is incompatible with standards before C99 [-Werror,-Wdeclaration-after-statement] const SLInterfaceID ids[1] = { SL_IID_VOLUME }; lmao, i kinda feel like Sdl is alwys broken for me
Avatar
what the hell is that error?
Avatar
Jupstar βœͺ 2022-06-25 07:15:44Z
they use local variables but dont delcare them at the start of the function i guess
07:15
in c99 u put your locals at the start
Avatar
lol, but why c99 anyway? can't you change standard?
Avatar
Jupstar βœͺ 2022-06-25 07:17:09Z
yes i'll add it i guess. maybe cmake is doing this, i read that arch also had problems with that πŸ˜„
Avatar
-std=c11 i think
Avatar
hmm, maybe indeed cmake adds its own set of flags
Avatar
Jupstar βœͺ 2022-06-25 07:28:26Z
Yesterday I posted benchmarks of six Linux distributions on the HP Dev One, the exciting new Linux laptop launched by HP in collaboration with System76 that is using their Pop!_OS distribution
07:28
btw this was not a performance hit actually
07:28
it was just that c99 has no timespec structure or smth like that
Avatar
already posted by ryozuki i think
07:31
but yeah flags can have weird interaction with optimization pass order as well
07:32
ah no, posted by you last week πŸ˜„
Avatar
Jupstar βœͺ 2022-06-25 07:32:54Z
yes but its funny that its kinda related
Avatar
Jupstar βœͺ 2022-06-25 07:49:26Z
sdl/src/render/opengles/SDL_render_gles.c:26:10: fatal error: 'SDL_opengles.h' file not found #include "SDL_opengles.h" I dunno, smth is really broken in SDL repo xd
Avatar
how big is the android studio dependency?
Avatar
Jupstar βœͺ 2022-06-25 07:52:03Z
1-2gb
Avatar
i remember for a school project having to download like 20GB of their ide+compiler
Avatar
Jupstar βœͺ 2022-06-25 07:52:17Z
maybe if u compile urself xD
Avatar
it was on windows though
07:53
maybe i choosed default installation which came with simulator/emulator as well
Avatar
Jupstar βœͺ 2022-06-25 07:55:42Z
even then it should not be 20gb xD
Avatar
d29b22a Be upfront about completeness of the autogenerated code documentation - heinrich5991 fda0ecc Merge #5494 - bors[bot]
Avatar
Jupstar βœͺ 2022-06-25 07:55:47Z
maybe the emulator img is that huge
Avatar
Avatar
Jupstar βœͺ
even then it should not be 20gb xD
well, i ended up deleting it as soon as the project was over
07:58
android studio was struggling to run on my poor pc with 4gb ram
07:59
i had to buy another stick
07:59
which was actually the only good thing to come out of that project πŸ˜„
Avatar
Jupstar βœͺ 2022-06-25 08:12:22Z
@Chairn gradle only support java 17 yet
08:12
maybe thats a problem for u
08:12
Expected Behavior Java 19 compilation target is supported. Current Behavior [INFO] --- exec-maven-plugin:3.0.0:exec (gradle) @ quarkus-gradle-model --- FAILURE: Build failed with an exception. * Wh...
Avatar
  • Video recorder off
  • small fix in logger.cpp
Tested on Java-17

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's...
Avatar
why DEV=ON ?
Avatar
Jupstar βœͺ 2022-06-25 08:17:15Z
what
Avatar
in the cmake call in cmake_android.sh
Avatar
Jupstar βœͺ 2022-06-25 08:18:51Z
i dunno
08:19
back then it probs was not related to checksum
08:20
and then its easier to use debug & release client
08:20
does it overwrite other stuff too?
08:20
i kinda dislike all this complexity anyway
Avatar
it keeps debug symbol, i don't think we need them for android
Avatar
Jupstar βœͺ 2022-06-25 08:23:45Z
they are stripped by gradle on release
Avatar
if you use add_path $DATADIR add_path $DATADIR add_path $CURRENTDIR as storage.cfg or for example have custom menuimages in your config directory it duplicates everything. It should merge directories and only show the file with higher priority (e.g. config dir has higher prio)
Avatar
a22a8dc Fix Android build - Jupeyy 937a9cc Merge #5495 - bors[bot]
Avatar
8933ae8 Try to fix dump_local_console (fixes #5488) - def- 5dd2e50 Update src/game/client/components/console.cpp - def- 83267ed Update src/game/client/components/console.cpp - def- a622507 Merge #5490 - bors[bot]
Avatar
Avatar
Jupstar βœͺ
in c99 u put your locals at the start
that's c89, c99 is the one that allowed mixing
Avatar
Avatar
Chairn
doesn't for me
Jupstar βœͺ 2022-06-25 09:47:10Z
more annoying is that it uses a border instead of an outline and changes the line breaks all the time when i hover over one element πŸ˜„
Avatar
Avatar
Learath2
that's c89, c99 is the one that allowed mixing
Jupstar βœͺ 2022-06-25 09:47:21Z
yeah true misread it
09:47
before c99 πŸ˜„
Avatar
I noticed that we have Getters for some private and some public member variables in different classes. And in the same classes we use the direct access to these variables as well as the getter access. Would be nice if could decide what we should use. Only direct access in the same class or only indirect access. Mixing both up does not feel right (sometimes the access types switch between the next line in the same function). An Example: GetPlayer() and m_pPlayer in server/entities/chara...
Avatar
@heinrich5991 do you still scrape for new maps?
Avatar
``` ./DDNet-Server "sv_port 8305" [2022-06-25 15:13:34][engine]: running on unix-linux-amd64 [2022-06-25 15:13:34][engine]: arch is little endian [2022-06-25 15:13:34][storage]: couldn't open storage.cfg [2022-06-25 15:13:34][storage]: using standard paths [2022-06-25 15:13:34][storage]: added path '$USERDIR' ('/home/daniel/.teeworlds') [2022-06-25 15:13:34][storage]: added path '$DATADIR' ('data') [2022-06-25 15:13:34][storage]: added path '$CURRENTDIR' ('/home/daniel/Desktop/other_r...
Avatar
We could even add implicit fallthrough warning, but it is triggered in external json.c

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+U...
13:30
I first thought that is not a big problem for me, because I can just use [CTR+C] again to force close it. But it turns out, this can corrupts sometimes the database if I force close the server. It happened to me twice. If I start than the server again, I get: ``` [2022-06-25 15:24:52][assert]: /home/daniel/Desktop/other_repos/ddnet_latest/src/engine/server/databases/sqlite.cpp(117): Tried connecting while the connection is in use [2022-06-25 15:24:52][ddnet]: cid=0 version=16010 [1] ...
Avatar
[2022-06-25 16:43:24][opengl]: Version string: OpenGL ES 3.2 Mesa 22.1.1 /home/arda/ddnet/src/engine/client/backend_sdl.h:234:60: runtime error: load of value 190, which is not a valid value for type 'bool' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/arda/ddnet/src/engine/client/backend_sdl.h:234:60 in @Jupstar βœͺ i get this when i use gles backend
Avatar
uninitialized data
13:50
what's funny with uninitialized bool is that they can be both true and false πŸ˜„
Avatar
schrödinger's boolean?
Avatar
[quakenet] ChillerDragon BOT 2022-06-25 13:51:51Z
xd
Avatar
While working on the new HUD, I noticed that DISABLE_HIT_GRENADE also disables the hit of teleport gun on other players. Should we change this behaviour?
Avatar
Avatar
nori
[2022-06-25 16:43:24][opengl]: Version string: OpenGL ES 3.2 Mesa 22.1.1 /home/arda/ddnet/src/engine/client/backend_sdl.h:234:60: runtime error: load of value 190, which is not a valid value for type 'bool' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/arda/ddnet/src/engine/client/backend_sdl.h:234:60 in @Jupstar βœͺ i get this when i use gles backend
Jupstar βœͺ 2022-06-25 14:09:25Z
ty
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
bruh you are fast :D
Avatar
@ChillerDragon why you didn't use timeout utility rather than wait_for_fifo in integration_test.sh ?
15:02
currently, script lives forever if server crash
Avatar
I wonder how @ ChillerDragon is displayed in IRC
Avatar
he's using matricks
Avatar
Avatar
Chairn
he's using matricks
he uses both matrix and IRC
Avatar
@deen shouldn't this assert rather than message report ?
Avatar
Jupstar βœͺ 2022-06-25 15:36:28Z
shouldnt it be compile time instead
15:36
ok dunno if we ship sqlite ourself
Avatar
well, it does pass integration test with my outdated version
Avatar
I first tried adapting and using CMenus::DoButton_Icon like DoIcon on upstream to reduce duplicate code in the menus. Later I moved/renamed this method to CRenderTools::RenderIcon, to also use it in the editor. Changes to demo list:
  • Show the icons as part of the name column
  • Improve spacing/centering of icons in columns
  • Grey out icon if demo is not loaded or not valid
  • Clamp the number of demo markers to valid range (I have an old version 3 demo that incorrectly shows more ...
Avatar
[quakenet] ChillerDragon BOT 2022-06-25 16:28:01Z
@Chairn you mean expect or what? No particular reason i tend to just crack down stuff my self instead of working with other tools. It just easier for me to understand
16:28
and it just works :D i have horrible expirience with expect and see no reason to add another dependency if bashs native fifo check works so well
16:29
16:29
^ this is how the ping looks like on irc @c0d3d3v
Avatar
chillerdragon BOT 2022-06-25 16:30:14Z
and this is how it looks like in matrix https://zillyhuhn.com/cs/.1656174581.png
Avatar
Avatar
[quakenet] ChillerDragon
@Chairn you mean expect or what? No particular reason i tend to just crack down stuff my self instead of working with other tools. It just easier for me to understand
16:35
how do i use valgrind.supp file?
Avatar
a530ce8 Rename DoButton_Icon to DoIcon and remove unused return value - Robyt3 97e36fa Add optional color parameter to DoIcon - Robyt3 f727199 Render demo file icon in name column, remove DoIcon centering - Robyt3 5184cf5 Add greyed out demo icon for invalid or not loaded demos - Robyt3 87cb948 Clamp number of demo timeline markers to valid range - Robyt3 25ad47b Use DoIcon for ingame player GUI icons - Robyt3 fb91881 Move CMenus::DoIcon to CRenderTools::RenderIcon - Robyt3 42532f3 Use CRenderTools::RenderIcon in editor file dialog - Robyt3 fbfd938 Merge #5503 - bors[bot]
Avatar
i cant see my mouse cursor when teeworlds is open unless i hide the application (osx 10.15.4, ddnet 16.1)
17:35
it wasnt like this in ddnet 15.5
Avatar
did u try changing display mode or renderer
17:55
in graphics tab
Avatar
Jupstar βœͺ 2022-06-25 17:56:27Z
update OS
Avatar
When noby has tech issues
Avatar
oh changing gl version fixed it also giving 3-4k fps ty
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undef...
Avatar
@Jupstar βœͺ can you cancel #5504 ?
18:40
thx
Avatar
[quakenet] ChillerDragon BOT 2022-06-25 19:15:57Z
@Chairn ah nice im def gonna use that in some of my projects but dont see how its useful in the CI
Avatar
script can lives forever if server crashes
19:19
with timeout 20 it will last 20 seconds max
19:22
oO
Avatar
Jupstar βœͺ 2022-06-25 19:25:09Z
no wtf
19:25
guess he wanted to write if
19:25
ah
19:25
no
19:25
no just no xd
19:26
but maybe the remove entity makes problems
19:26
maybe its safer to copy all objects to a temporary list first
19:26
this code is such a mess xD
19:27
im still trying to attach gdb to one of the client
19:27
both crash
19:27
i cant fucking have interactivity with gdb through the script...
Avatar
I always get MemoryLeak messages from UBSan whenever i close the client or crash :d
Avatar
i got them too, you can ignore them
19:29
best part is that these leaks are not from the client but from other libs
Avatar
This is why source is not visible like others?
19:30
Or says Direct/Indirect leaks
19:31
just really unintuitive code
Avatar
@Chairn yeah i'm also able to reproduce on integration test, but this time not wayland related
19:40
7.62 KB
Avatar
this fucking bash is creating a subprocess of itself and i get pid of bash and not ddnet...
Avatar
Avatar
Chairn
how do i use valgrind.supp file?
check the integration test script
Avatar
i solved that part πŸ˜„
19:43
im trying to attach debugger to running instance of ddnet in the script
19:43
but i got only bash subprocess' pid with $!
Avatar
thatβ€˜s weird, sounds like it should work
19:44
if we invoke the process with & and no nohup or other stuff
Avatar
nah, it uses || and i realised i modified the wrong line
19:45
and obviously it doesnt crash anymore
19:45
looks like its very timing dependent
19:49
nice heisenbug we got here
19:51
where should i set the breakpoint?
19:51
destructors aren't called when it doesn't crash...
Avatar
i think i get libpng related messages this time :d
20:13
[2022-06-25 23:12:38][libpng]: warning for file "downloadedskins/Shadow.21178.tmp": iCCP: known incorrect sRGB profile this when i use Shadow skin
Avatar
Jupstar βœͺ 2022-06-25 20:15:15Z
if libpng says so, then it is so
Avatar
when i close the client: (edited)
20:15
Avatar
Avatar
Jupstar βœͺ
if libpng says so, then it is so
nah this one
Avatar
Jupstar βœͺ 2022-06-25 20:16:39Z
i guess graphics is deallocated already
20:19
why does that code even run in a different thread?
20:19
when was this added
20:19
our storage is not thread safe
Avatar
Avatar
nori
when i close the client: (edited)
Jupstar βœͺ 2022-06-25 20:35:04Z
create an issue on github pls and ping heinrich or smth that the jobs should be cleaned before any kind of destruction happens I dunno if storage is save for saving but since the code exists for ever i guess its fine^^
20:35
ah no its actually loading data
20:36
then it probs not fine, dunno, maybe for just opening files it is
20:36
guess aslong readfile from storage isnt used or snmth like that
Avatar
i give up
20:44
its beyond my capacities
Avatar
``` ================================================================= ==21178==ERROR: AddressSanitizer: heap-use-after-free on address 0x7fe60e3ed390 at pc 0x000000dd5e5e bp 0x7fe60f456290 sp 0x7fe60f456288 READ of size 8 at 0x7fe60e3ed390 thread T2 #0 0xdd5e5d in CComponent::Graphics() const /home/arda/ddnet/src/game/client/component.cpp:7:56 #1 0x14979eb in CSkins::LoadSkinPNG(CImageInfo&, char const, char const, int) /home/arda/ddnet/src/game/client/components/skins.cpp:129:...
21:49
eb3406c Add missing capability for GLES backend - Jupeyy c5bf246 Merge #5502 - bors[bot]
Avatar
5f5b80a Use [[fallthrough]] attribute rather than comment - Chairn a50ddb7 clang-format - Chairn 0179dfd Merge #5499 - bors[bot]
Exported 177 message(s)