DDraceNetwork - developer

Siraxa

[ddnet/ddnet] Pull request closed: #5449 Skins.tw skins download option

kaitlynia

[ddnet/ddnet] Issue closed: #5458 Ability to sort by recently edited in editor map list

i just got this window after i closed ddnet, what is this?

Iza

i just got this window after i closed ddnet, what is this?

Nightly? RC? Current release? Sounds to me like it wants to create a crash dump and searches the missing symbols ^^

i have nightly

07:13

i just closed that window lol

@Iza happens each time you quit ddnet?

08:22

@Jupstar ✪ if it only fails on crashdump then I guess I broke drmingw by building it myself

deen

@Iza happens each time you quit ddnet?

no, just this one time

and you closed it normally or it crashed?

alt f4

do we have a known crash to test if it still works @?

08:26

@Jupstar ✪

bors got stuck on #5453

https://github.com/ddnet/ddnet/pull/5453

Fix segfault in SDL_JoystickClose on client quit by Robyt3 · Pull...

Instead of closing the joysticks manually, use SDL_QuitSubSystem(SDL_INIT_JOYSTICK) to quit the entire subsystem, which will also close all joysticks correctly. The engine input destructor is repla...

@deen open this map in the editor for a crash ^^

timeout.map

48 bytes

I'm wondering if there are nowadays better ways to compress our snapshots, than based on zeros in ints. https://github.com/ddnet/ddnet/blob/master/src/engine/shared/compression.cpp#L9-L39

ddnet/compression.cpp at master · ddnet/ddnet

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/compression.cpp at master · ddnet/ddnet

Mh, they compress pretty well. Why mess with it?

11:58

This + huffman coding + delta gives us pretty small snapshots

Do we use huffman coding? I did not find it in the code path

12:00

I only found it for demos

Learath2

Mh, they compress pretty well. Why mess with it?

I do not want to mess with it... simply philosophize about it (edited)

c0d3d3v

Do we use huffman coding? I did not find it in the code path

every packet gets huffman coded if it results in a smaller packet

Learath2

every packet gets huffman coded if it results in a smaller packet

mh, I have not seen it somehow... now I have found it in the data path... https://github.com/ddnet/ddnet/blob/master/src/engine/shared/network.cpp#L145-L146 yes should be pretty good compression

ddnet/network.cpp at master · ddnet/ddnet

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/network.cpp at master · ddnet/ddnet

heinrich5991

[ddnet/ddnet] Issue opened: #5460 Swap penalty isn't actually added to teams using swap

It's apparently only added to the actual tees swapping, but that gets reset on finish. It should be added to the whole team.

1

BloodWod-513

[ddnet/ddnet] Pull request opened: #5461 add penatly to the whole team

this should fix it #5460

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#u...

BloodWod-513

[ddnet/ddnet] Issue opened: #5462 The problem with the automatic installation of the command in the chat

For example: try /sw + tab Next steps 1. Try tab for name (false); 2. Write space or word; 3. try tab (false); 4. backspace; 5. try tab name (true); 6. Enter (send); 7. Open the chat and press UP arrow (whitespaces).

GitHub

Click to see attachment 🖼️

need to replace for(int i = 0; i < MAX_CLIENTS; i++) to (auto & m_apPlayer : GameServer()->m_apPlayers)?

@σℓí♡ to for(const auto &pPlayer : GameServer()->m_apPlayers)

1

Is this a new code style or why is it necessary?

its C++14

ok

code style, basically

15:57

the other thing works just as well, but someone activated a check that we always use the foreach loop where possible

Personally, I think the loops are easier to understand this way, quicker to keep track of.

the only downside of this check that I can see is that it requires more round trips with the PR author in some cases

^^ PR authors want to learn new stuff too

16:00

I guess, or what do you say @σℓí♡ (edited)

I rarely program in C++ and first of all I look at how people designed it so that everything was in the same style, so at first I was confused

16:02

is pListedPlayer fine name?

We have a lot of old code, that could use for each loops if we would refactor it. But it is not always possible to use for each loops (edited)

pListedPlayer is fine, but I don't understand what Listed is supposed to mean

16:03

@c0d3d3v so it's not a simple replacement in this case ^^

The variable is iterated through in a loop. I can't use pPlayer

c0d3d3v

We have a lot of old code, that could use for each loops if we would refactor it. But it is not always possible to use for each loops (edited)

I don't think so, the clang-tidy check forbids use of for loops that can be translated into a foreach loop

16:04

@σℓí♡ yea, whatever, pListedPlayer is fine. I can't come up with a better name

heinrich5991

I don't think so, the clang-tidy check forbids use of for loops that can be translated into a foreach loop

for example this loop for time bonus if we would use GameServer()->m_apPlayers[i]->GetCharacter()->Team() instead of Teams()->m_Core.Team(i) it could be replaced with a for each... that is possible in many places (edited)

heinrich5991

@σℓí♡ yea, whatever, pListedPlayer is fine. I can't come up with a better name

xD I think your probosed pPlayer is better

but ...

pPlayer is already used in the function

16:07

(and we forbid name shadowing, also the outer pPlayer is also used inside the loop)

Could refactor pPlayer to pOriginPlayer but I'm also ok with pListedPlayer

my rebase accidentally caused 5 extra commits

16:14

lmao

16:17

how can i fix it?

somehow you added https://github.com/ddnet/ddnet/pull/5445 to your PR. maybe reset to only your commits and then rebase to latest master. (edited)

@σℓí♡ did you mark the first commit as fixup or squash in the interactive git-rebase?

16:51

try git rebase -i upstream/master

16:51

and then mark all committs that are not yours as drop

rebase head~5 p p p p s

16:52

ok i try

idk how but i fix it, fetch to master and rebase fetch_head (edited)

you could squash the latest commit

17:04

(only annotate the commits you don't want to see with squash or fixup) (edited)

17:04

the very first commit should never be squash or fixup

I think the problem was that I used rebase HEAD~2 -> rebase HEAD~5 instead and it turned out like this pick not my commit pick not my commit pick not my commit pick my commit squash my commit

ah, I don't know what happens when you do that with merge commits

bors[bot]

[ddnet:master] 13 new commits

da5ec5a Include <iterator> instead of <array> for std::size - Robyt3 0a4b1b9 Organize generated protocol includes - Robyt3 4048bbb Organize engine-shared includes - Robyt3 557ee84 Organize base includes - Robyt3 0813fbb Move android log include to correct file - Robyt3 4949645 Organize game-shared includes - Robyt3 2c9696c Use existing typedef instead of duplicating arguments - Robyt3 32707f6 Remove unused CVideo constructor argument, organize includes - Robyt3 23cce54 Organize engine-client includes - Robyt3 a1851ed Organize engine-server includes - Robyt3 2add5d5 Organize game-client and editor includes - Robyt3 352734d Organize game-server includes - Robyt3 1bb9641 Merge #5450 - bors[bot]

17:15

bors[bot]

[ddnet/ddnet] Pull request closed: #5450 Further organize includes and use forward declarations where appropriate

deen

@Jupstar ✪ if it only fails on crashdump then I guess I broke drmingw by building it myself

tbh i've never seen this ever, maybe he simply has visual studio installed, and that catches such things globally?

soon ill have 4 days off maybe i can code some pr

18:03

web or server/client?

whats new on the web?

the skin database needs pages

honestly the way the web is built makes me wanna stay away

or some kind of lazy loading (edited)

18:04

yeah xD

https://github.com/edg-l/ddnet-web-modern

GitHub - edg-l/ddnet-web-modern: A rework of the ddnet.tw website w...

A rework of the ddnet.tw website with the objective to make it more maintainable by others and modernize it. - GitHub - edg-l/ddnet-web-modern: A rework of the ddnet.tw website with the objective t...

18:05

i started this 2 months ago

18:05

xd

when do we get some epic site like kog or skins.tw

i want to do that but first i need a good organized project

18:05

not some python prints spread over 2 repos

18:05

its hell

xD

btw

18:07

if u wanna remove the php dependency on the index.php page

18:07

u can use this

18:07

// This script detects the host os and shows the correct download.
window.addEventListener('DOMContentLoaded', (event) => {
    const downloadButton = document.querySelector("#download-link");

    function getDownloadLinkEnd() {
        const userAgent = navigator.userAgent;
        var osPlatform = "unk";

        if (userAgent.match(/android/i))
            osPlatform = 'and';
        else if (userAgent.match(/wow64/i))
            osPlatform = 'win64';
        else if (userAgent.match(/win64/i))
            osPlatform = 'win64';
        else if (userAgent.match(/windows/i))
            osPlatform = 'win32';
        else if (userAgent.match(/linux.*x86_64/i))
            osPlatform = 'lin64';
        else if (userAgent.match(/linux.*i686/i))
            osPlatform = 'lin32';
        else if (userAgent.match(/macintosh|mac os/i))
            osPlatform = 'mac';
        
        const linkEnds = {
            "win64": ["win64.zip", "Windows (64bit)"],
            "win32": ["win32.zip", "Windows (32bit)"],
            "lin64": ["linux_x86_64.tar.xz", "Linux x86"],
            "lin32": ["linux_x86.tar.xz", "Linux x86_64"],
            "mac": ["macos.dmg", "macOs"],
            "unk": false,
        };

        return linkEnds[osPlatform];
    }

    const linkEnd = getDownloadLinkEnd();

    if(linkEnd) {
        downloadButton.href = `/downloads/DDNet-{{DDNET_VERSION}}-${linkEnd[0]}`;
        downloadButton.textContent = `Download DDraceNetwork Client & Server {{DDNET_VERSION}} for ${linkEnd[1]}`
    }
});

it doesnt require php anymore

oh

18:07

ok

i just didnt rename it, bcs i dont want to fix the links xD

xD

but the script behind the database still uses php