DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-06-16 00:00:00Z and 2022-06-17 00:00:00Z

[ddnet/ddnet] Pull request opened: #5434 Add separate log levels for each output

stdout_output_level for printing to stdout, console_output_level for printing to local console and remote console and loglevel for the log file. Keep the old log level filters 0 for info and more severe, 1 for debug and more severe and 2 for trace and more severe, introducing -1 for warn, and -2 for error. -3 will show no log messages at all.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with po...

[ddnet/ddnet] Pull request opened: #5435 Update traditional_chinese.txt

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

05:31

[ddnet/ddnet] Pull request opened: #5436 Update simplified_chinese.txt

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

why are clannames sometimes chop off in scoreboard and suffied with "..." ?

bcs the scoreboard is too small

06:23

or the font size is too big

but it used to fit in there? same resolution and font size

:/

06:24

i called it XD

ofc u did

06:25

u also called my 15% amd gain o.O

i just knew someone would be affected by it

06:25

ez amd

Embedded image

06:26

those two bois were cut off a sec ago. Probably some dudes joined and it switched to the two sided scorevoard with smaller font then it fully displayed their clans again

ez

not very long clans imo

06:27

i assume this "fix" was made for our friend the "WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW" xD

and clan is most important too

well this poor ad bridge cant spread the virus when the last characters are visible so its business critical

06:28

anrent'

i have to say, i dont even find a bigger scoreboard that ugly

Image attachment

06:32

(text not fixed)

i think it looks fine too

06:34

no reason to have it so tiny since it already obstructs the screen

Jupstar ✪

i have to say, i dont even find a bigger scoreboard that ugly

If the clan is empty, you may can render a bigger name

but that's just me being crazy, Keep it simple stupid

Can anyone review https://github.com/ddnet/ddnet/pull/5412 ? Otherwise it will conflict with every translation PR

Add translations for 16.2 by def- · Pull Request #5412 · ddnet/ddnet

Translated German while at it Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a uni...

[ddnet/ddnet] Pull request opened: #5437 Update Brazilian Portuguese translation (supersedes #5304)

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

08:27

[ddnet/ddnet] Pull request closed: #5304 Update Brazilian Portuguese translation

[ddnet:master] 2 new commits

0f21f9a Update traditional_chinese.txt - Cheeser0613 e442798 Merge #5435 - bors[bot]

08:39

[ddnet/ddnet] Pull request closed: #5435 Update traditional_chinese.txt

08:39

[ddnet/ddnet] Issue closed: #3428 Open News tab automatically, if you press the green news icon

Jupstar ✪

i just knew someone would be affected by it

In a community that loves their weird UB, I expect no less than 3 people getting affected badly by any change

xD tru story

I think the only change I never got any complaints with was the http map downloader

[ddnet/ddnet] Pull request opened: #5438 Draft reply tests

08:52

[ddnet/ddnet] Pull request closed: #5438 Draft reply tests

lmao, chillerdragon on attention seeking again

more like daydrinking again

08:57

did it ping u 10 times again and sent u 10 mails? xd

sadly u forgot to ping me

[ddnet:master] 2 new commits

2bc2232 Update simplified_chinese.txt - Cheeser0613 36a624c Merge #5436 - bors[bot]

09:01

[ddnet/ddnet] Pull request closed: #5436 Update simplified_chinese.txt

[ddnet:master] 2 new commits

1ec6912 Add translations for 16.2 - def- edab7c0 Merge #5412 - bors[bot]

09:36

[ddnet/ddnet] Pull request closed: #5412 Add translations for 16.2

09:41

[ddnet/ddnet] Pull request opened: #5439 Improve some german translations

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

@louis do you want me to write something for #📬submit-skins ? nothing fancy though

Jupstar ✪

i have to say, i dont even find a bigger scoreboard that ugly

does it work in legacy display resolutions? (edited)

its smaller than 2 scoreboards

Jupstar ✪

its smaller than 2 scoreboards

there was also one suggestion to just display the clan below the player name ^^ would also work

<.<

09:55

most ppl only read clans in scoreboard

09:55

it should be special

Jupstar ✪

most ppl only read clans in scoreboard

xDDD

09:55

I normally never read clan ^^ (edited)

i always read them

09:56

but not in the nameplate

09:56

only in scoreboard

09:56

and in vanilla mods when round is over

09:56

and u are first place

09:56

u see, ah nice he's from that clan

^^

09:56

yes probably some use it ... At least all players that use clans seriously

yeah

@Chairn Is it ok to address your refactoring requests in another PR. Because they are not specific to my PR, but the problem was there already before

Or do you want me that I scan somhow the code for all wrong array prefixes. And the refactoring of the asset menu should also be done in a more serious PR.

you could change the array prefixes only in the structs you added

10:02

@c0d3d3v why do you think passing the version to a function SendChatTarget is cleaner than doing the version check at the call site?

10:02

it seems to me that it's better to do the check locally, you immediately see what it does

10:03

you don't get that from a random parameter of a function

heinrich5991

you don't get that from a random parameter of a function

But I do get it from the parameter. My IDE tells me the name of the parameter, and that is very verbose written.

heinrich5991

you could change the array prefixes only in the structs you added

... ok

I don't get that in my coding environment, and it's also not visible on github, etc.

10:07

in git diffs

Also the version we add as parameter is verbose. We all know it is a Enum for version number...

10:08

Do you not think it is code duplication?

10:08

To add everywhere the same condition

and even if we had explicit parameter passing like SendChatTarget(1, OnlyForVersionGreaterThan=5), it seems weird to not just check it locally

deen

Can anyone review https://github.com/ddnet/ddnet/pull/5412 ? Otherwise it will conflict with every translation PR

Asks for review, merges anyway lol

I mean you can add a function for specifically this if you absolutely want to, but it's just one if everywhere, no?

AssassinTee

Asks for review, merges anyway lol

murpi reviewed it

yeah and I found at least 3 issues

to me, a single if is clearer than a parameter to some function, where I have to read some non-local code

heinrich5991

I mean you can add a function for specifically this if you absolutely want to, but it's just one if everywhere, no?

25 conditions around the same function, only difrent message to send

I'd prefer if(x < 5) DoFunction() over DoFunctionIfLessThan(5)

10:11

the left is a programming language native construct that is easy to understand

But why

the right thing is a function that could do anything

You should not do checks for something 25 times that should be done by the worker that needs to carry out the operation

(if you absolutely want to, you could add a function that does what you want, but I think overloading the SendChatTarget function isn't really nice)

c0d3d3v

You should not do checks for something 25 times that should be done by the worker that needs to carry out the operation

but what does "send chat target" have to do with version checks?

Why we then added the flag field to that function

10:12

to send some messages to version 6 cleints and some to version 7

10:13

thats the same thing

10:13

should I also remove the flags?

10:14

I could also add only one flag to that flag field

10:14

xD do not send to that specific version

I guess a flag there for OLDHUD would be fine-ish

10:15

the CHAT_SIX stuff at least uses the -1 thing, i.e. it can't simply be lifted out of the function

@Jupstar ✪ I reviewed on the old branch, I posted the veiew in the new one ^.^

if you want, you can also use my pr and fix more stuff

10:16

i only skipped through them and fixed some obvious stuff

10:17

havent looked deeper into it, i kinda also dont really like some "forced" translations Like "Karte" instead of "Map"

10:17

nobody uses that in german

Your code style is really strange xD why would I write everything 20times, if I could do the same thing with only one argument more. Its the same in the asset menu. Every second line is duplication, If I would refactoring it, I would not like to have any duplication at all.

its not always so easy

10:18

it already uses templates to minimize some code

10:18

time vs effort

@c0d3d3v I don't like to put unrelated concerns into functions, especially if they can easily be factored out

10:19

I prefer DoX and DoY over DoXAndY

alternatively you could use lambdas :p

@AssassinTee can you elaborate where you want to use lambdas here?

Jupstar ✪

it already uses templates to minimize some code

I would like OOP more then templates, but seems like I'm an other generation :/

AssassinTee

alternatively you could use lambdas :p

in assets it makes sense

That was a bad joke

sorry

c0d3d3v

I would like OOP more then templates, but seems like I'm an other generation :/

but what do u want to OOP?

10:21

lambdas can do some magic here

10:21

at least to minimize code

Jupstar ✪

but what do u want to OOP?

every tab uses the same method...

dunno about readability

c0d3d3v

every tab uses the same method...

doesnt that sound good? xd

10:23

e.g. would you refactor this code:

c++
char aBuff[IO_MAX_PATH_LENGTH];

    if(str_comp(pAssetItem->m_aName, "default") == 0)
    {
        str_format(aBuff, sizeof(aBuff), "%s.png", pAssetName);
        CImageInfo ImgInfo;
        if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL))
        {
            pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0);
            pGraphics->FreePNG(&ImgInfo);
        }
    }
    else
    {
        str_format(aBuff, sizeof(aBuff), "assets/%s/%s.png", pAssetName, pAssetItem->m_aName);
        CImageInfo ImgInfo;
        if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL))
        {
            pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0);
            pGraphics->FreePNG(&ImgInfo);
        }
        else
        {
            str_format(aBuff, sizeof(aBuff), "assets/%s/%s/%s.png", pAssetName, pAssetItem->m_aName, pAssetName);
            if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL))
            {
                pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0);
                pGraphics->FreePNG(&ImgInfo);
            }
        }
    }

I would think so. If I have one class that I init with specif parameters, asset name, title ... path.. And init for example 5 objects that belong to the asset menu tab, then I have only one class with only one set of functions

might look like its lot of same code

10:23

but in the end its still a bit ddifnfernt (edited)

10:23

but for example entities allow dirs or PNGs

10:23

while other assets only allow PNGs

10:23

but go ahead and refactor it

all use the same function... could be one function of a asset_tab_class

Image attachment

10:24

(except for enteties)

thats a spot where i nowadays would use lambdas

10:24

or templates

10:25

but why classes?

Jupstar ✪

doesnt that sound good? xd

yes thats whhy I would use OOP instead of templates

well anyway, just do it

Jupstar ✪

e.g. would you refactor this code:

c++
char aBuff[IO_MAX_PATH_LENGTH];

    if(str_comp(pAssetItem->m_aName, "default") == 0)
    {
        str_format(aBuff, sizeof(aBuff), "%s.png", pAssetName);
        CImageInfo ImgInfo;
        if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL))
        {
            pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0);
            pGraphics->FreePNG(&ImgInfo);
        }
    }
    else
    {
        str_format(aBuff, sizeof(aBuff), "assets/%s/%s.png", pAssetName, pAssetItem->m_aName);
        CImageInfo ImgInfo;
        if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL))
        {
            pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0);
            pGraphics->FreePNG(&ImgInfo);
        }
        else
        {
            str_format(aBuff, sizeof(aBuff), "assets/%s/%s/%s.png", pAssetName, pAssetItem->m_aName, pAssetName);
            if(pGraphics->LoadPNG(&ImgInfo, aBuff, IStorage::TYPE_ALL))
            {
                pAssetItem->m_RenderTexture = pGraphics->LoadTextureRaw(ImgInfo.m_Width, ImgInfo.m_Height, ImgInfo.m_Format, ImgInfo.m_pData, ImgInfo.m_Format, 0);
                pGraphics->FreePNG(&ImgInfo);
            }
        }
    }

void LoadPNGFromPath(char* aBuf, idkthetype* RenderTexture)

not now

the reason is simple: its not worth the effort

10:26

in the past at least

10:26

now we have extras and HUD

I only want to finish the HUD stuff. Refactoring can be done later xD

see

10:26

thats my point

10:27

its always a question of time

But there would be no reason to refactor it, if it would have been oop in first place...

10:27

but ye everything is historicly groun

10:27

grown*

until u need smth the other stuff doesnt need

10:27

not like u never refactor OOP

first there was only a entities tab... so ye would not have made sense

just to be clear i'd use OOP in many places always depends if its worth it

c0d3d3v

all use the same function... could be one function of a asset_tab_class

btw this is actually a good case where i'd bind parameters

10:29

but e.g. ListDirectory doesnt allow this

10:29

it only allows C functions

10:30

so also refactor this ;P

10:31

but it allows a user

10:31

so i guess u can hack in an object

heinrich5991

I prefer DoX and DoY over DoXAndY

So should I remove the flags too? Or better just tell me what I should do. I do not fight anymore ^^ I will do it.

IMO, you can move it to flags, you can create another function, or check it locally

@c0d3d3v I didnt know what exactly you meant yesterday I think, but I think a flag for the freezebar from the server aswell as a flag for the stars to be rendered clientside with the ninja skin will be the way to go. Either you can add it to your pr, or I would add it for you to copy

11:12

Then we could simply add a chat command to toggle and a client option that sends this option ?

11:12

Idk:(

11:13

@heinrich5991 lets make a vote :(

11:13

Democracy

perhaps we could get an actual freeze animation

11:14

but I don't have a good idea for it

11:14

how to do it with arbitrarily shaped skins

heinrich5991

perhaps we could get an actual freeze animation

there were thoughts of an "ice" block above the skin, also you could simply color the player different and add particles (just some thoughts)

AssassinTee

there were thoughts of an "ice" block above the skin, also you could simply color the player different and add particles (just some thoughts)

yes, but where do we get an ice block that fits arbitrary skins? ^^

this one should do: https://static.wikia.nocookie.net/enfuturama/images/7/74/GiantIceCube.jpg/revision/latest?cb=20090629004813

Embedded image

@heinrich5991 I might have a very valid argument

11:18

Look

jokes aside, aren't skins limited in their size?

I personally always played with show ninja 0. Is that now also impossible for freeze?

11:19

i really liked the combination of ninja weapon, normal skin, and the stars

11:20

That way I could always see who is who in freeze

11:20

and I could better decide, so its part of my gameplay.

that would also be served by putting an ice block around people, no?

No, i am colorblind and cant see colors on first frame

11:21

I need to inspect colors a bit in order to see them or to differntiatw

11:21

thats why it always helped me

the ice block would probably change the color a bit. that would make it harder to distinguish?

At least during fast gameplay, yes.

11:23

And when names are cramped together tee by tee, i can also not view them

11:23

I imagine a freezebar in such situations as very ugly and uncomforting aswell

I think the freeze bar can be disabled when the tee is still in freeze

thats good

11:25

But yeah, the ninja + real skin was epic for me

11:25

+ helped

I would find it great if we could get away from ninja and move to something freezy

sure, but its such a good way of seeing the tee in freezepits

11:27

as the skin is rendered without any extra layers

11:27

just the ninja weapon behind it, which could be "removed"

11:27

maybe that would be a toggleable option @c0d3d3v ? rendering normal skin in freeze, with new freeze particles and so on, and maybe the stars?

please don't add more options

11:29

why do you want to have the stars, specifically?

11:29

they don't seem to add anything

mostly design, but yea, i think i can live without them

11:30

but

11:30

rendering normal skin as frozen is important gameplay!!

if we do decide to add it, the burden shouldn't be on @c0d3d3v to add it

11:31

(because this is precisely why options are bad, they put burden on people changing things)

i sed

11:31

tw just died today

imagine again ddnet with moving tiles, so much more new map designs

11:32

@fokkonaut tw never dies

The cleanest most work intense solution might be a frozen skin for each skin. And if you don't possess the frozen version, it defaults back to the default skin frozen version. But I think you'd gain to little for all the work

but

2054 i'll host my v0.14 server

ye same but

11:32

like

11:32

:/

11:33

i want to update my client always, but those things make it hard for me to update i am honest

11:34

@heinrich5991 we even have a config for the old chat system? why? because some people might prefer it. And why wouldnt we allow it in this case?

11:34

when there is even a real reason, because it heavily affects gameplay

11:34

and especially in teeworlds single gameplay changes can affect your whole play style :/

fokkonaut

tw just died today

I think you're overstating this design change a lot. it'd probably be "just normal" in a month

i know what you mean, but i really need skin visibility

We have a config for the old chat because I didn't want to get shot by konsti on my way to the supermarket

now be scared of me !

11:36

pepeH

the CTuneParams class is so ugly, as soon as you add a virtual function, its size is different and some other related code breaks (edited)

add a function for the size and use that in the breaking parts

doesn't work, because it gets interpreted into an int array and the sequence might be compiler/os depended, idk

what approach did you take?

to fix it? Inherit from it and add the virtual functions in the derived class

can i see it?

?

12:03

class CMatDefault : public CTuneParams  //CTuneParams is not allowed to contain virtual functions
{
public:
    CMatDefault() = default;
    virtual int GetSkidSound();
    virtual float GetSkidThreshold() { return 500.0f; }
    virtual float GetDynamicAcceleration(float Velocity) { return m_GroundControlAccel; }
};

12:04

tbh that's less of a fix and more of a workaround

i dont know what exactly the problem is, i believe

this is a very evil function (which is actually wrong, too): https://github.com/ddnet/ddnet/blob/edab7c0e8c25ea52384801674f05dcd3b12aaca8/src/game/gamecore.h#L56

ddnet/gamecore.h at edab7c0e8c25ea52384801674f05dcd3b12aaca8 · ddne...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/gamecore.h at edab7c0e8c25ea52384801674f05dcd3b12aaca8 · ddnet/ddnet

12:08

also this part, it's equally bad (and also wrong) https://github.com/ddnet/ddnet/blob/edab7c0e8c25ea52384801674f05dcd3b12aaca8/src/game/client/gameclient.cpp#L690

ddnet/gameclient.cpp at edab7c0e8c25ea52384801674f05dcd3b12aaca8 · ...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/gameclient.cpp at edab7c0e8c25ea52384801674f05dcd3b12aaca8 · ddnet/ddnet

ah!

12:08

i see

adding a virtual function to CTuneParams makes the class bigger and in turn breaks this code parts, also in both cases it should be sizeof(CTuneParams) instead of sizeof(int) (edited)

yep

my connection via Ethernet cable keeps breaking whenever i connect my phone on mobile hotspot of my pc since 1-2 days

12:23

https://answers.microsoft.com/en-us/windows/forum/all/internet-connection-stops-when-mobile-hotspot-is/f778a986-919b-4d4e-b40a-71b58964a5ab

12:23

ive found this

12:23

Image attachment

12:23

and here it says when he uninstalled that specific windows update it fixed it for him

12:23

i tried it but now i cant connect anymore with mobile hotspot at all

12:23

does anyone have any ideas what i could try?

12:24

i dont have wifi in my room so i kinda use my pc as a 2nd router now it doesnt work anymore

AssassinTee

this is a very evil function (which is actually wrong, too): https://github.com/ddnet/ddnet/blob/edab7c0e8c25ea52384801674f05dcd3b12aaca8/src/game/gamecore.h#L56

you could use a macro that expands each tune parameter declaration to +1 to statically calculate the number of parameters without relying on the size of any classes

12:30

(put the macro in the cpp file so it's not expanded each time the header is included)

getting the count of the tuning parameters was never a problem, because adding m_NumTuningParamters++; to the macro is easy, but the class needs to be readable as an int*, WAIT can't I write an operator for that

you could wrap the values in a separate POD class

12:31

and put all method in the real tuning class that internally has a wrapper for the values

AHHH

12:31

nice idea

12:37

genius

AssassinTee

the CTuneParams class is so ugly, as soon as you add a virtual function, its size is different and some other related code breaks (edited)

Yes, that thing is absolutely awful

Smh c++

Not C++'s fault matricks decided he didnt care what the standard has to say

PES3_SusAlt

when it's nearly 15 o'clock, you programm all day and notice, that you may need something to breakfast (edited)

@heinrich5991 is there an easy way for me to implement the reliable server registering without applying the whole register refactor?

AssassinTee

when it's nearly 15 o'clock, you programm all day and notice, that you may need something to breakfast (edited)

I usually notice when I get a massive hunger headache :D

exactly

fokkonaut

@heinrich5991 is there an easy way for me to implement the reliable server registering without applying the whole register refactor?

you only need to do regular post requests, see the description of this PR how they look like: https://github.com/ddnet/ddnet/pull/5064

murpi

@louis do you want me to write something for #📬submit-skins ? nothing fancy though

if youre willing to, it would be nice

heinrich5991

you only need to do regular post requests, see the description of this PR how they look like: https://github.com/ddnet/ddnet/pull/5064

thanks, uhm :D

12:51

xd

12:52

i'll see if i can get it to work

@murpi mvp

12:58

when learn python programming @louis?

import discord
if messageIsValid()
    addReactions()

13:07

i think that should work

missing colon in line 2

13:08

but otherwise great, let's ship it

i tried to write a python script to automatically generate gores maps that wouldnt be too distinguishable from a human-made map

13:10

it got pretty disgusting quickly though

@louis I did something similar, but in C++ and for dungeons, if you want the repo tell me ^^

I want to take a look at it

oh god (edited)

GitHub

Click to see attachment 🖼️

i force pushed to this

13:37

https://github.com/ddnet/ddnet/pull/5424 (edited)

no-goalshud by luk51 · Pull Request #5424 · ddnet/ddnet

do it using getgameinfo from gameclient introducting a new flag for ddrace. Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly...

@cauldron I let the CI run. if there's style checker problems, can I add them to your PR so you don't have to deal with it?

sure, but this time i let the python script run ;D

ah nice

13:41

the if looked a bit weird, I hadn't guessed that this is what clang-format wants

well, maybe check again, and maybe it's not the best way, but in the range of the python script. i put it on newline but the script put it back on one line.

[ddnet:master] 11 new commits

c7fb013 Add io_read_all, io_read_all_str and mem_has_null: - Robyt3 c1c8797 Add IStorage::ReadFile and ReadFileStr: - Robyt3 93536b8 Use io_read_all to load font files - Robyt3 7050022 Use ReadFile in CServerBrowser::LoadDDNetInfoJson - Robyt3 74d7d4f Use ReadFile to load wv/opus sound files - Robyt3 ceca44e Use io_read_all to load icon font - Robyt3 5d49ee3 Use ReadFile to load updater index json - Robyt3 0a46332 Use ReadFile to load server maps - Robyt3 de2744c Use ReadFile to read opus sounds in editor - Robyt3 dc52377 Use ReadFile to read shader - Robyt3 992723d Merge #5430 - bors[bot]

14:02

[ddnet/ddnet] Pull request closed: #5430 Add `io_read_all` and `io_read_all_str` to system, add `IStorage::ReadFile` and `ReadFileStr`

14:05

[ddnet/ddnet] Issue closed: #5367 Should we put stuff into namespaces?

how to add the clang-format or the python fix styling script to vscode, so that is formats everytime you save?

Is it possible that there is no code for movin a directory in the storage code? :(

idk, maybe https://marketplace.visualstudio.com/items?itemName=xaver.clang-format @cauldron

Clang-Format - Visual Studio Marketplace

Extension for Visual Studio Code - Use Clang-Format in Visual Studio Code

14:08

ChillerDragon: does RenameFile not work?

it sounds like file i didnt test it

14:09

also in the rename manpage it talks about files

rename isn't limited to files in linux

but yea isnt everything a file in linux?

14:09

even folders?

yes

xd

14:09

ok maybe renamefile works then

idk about windows though

force pushed again

but I guess it's fine there, as well

yikers

14:10

MoveFileExW

14:10

windows .-.

it's backward compatible

14:10

I mean, on linux the syscall is called renameat2

yea should work

14:11

fingers crossed

heinrich is if checking from left to right or right to left?

@louis done

14:13

the bot should auto-react and auto-yeet all messages not following the format

陪我

@louis done

its not "sheep" by unknown? xdd

@cauldron left to right

14:14

also get rid of the newline in the condition, please @cauldron

Cøke

its not "sheep" by unknown? xdd

did you make it? I can't remember

i found it but idk who made it

I spent like an hour to figure out how to restrict certain reactions for specific roles, just to learn we can restrict reactions from discord directly

14:17

emotional damage

heinrich5991

@cauldron left to right

and also what comes first || or && because i did ( cond1 || (cond2 && cond3))

(edited)

this evaluates left to right

14:18

it first checks cond1, if it's true, it stops evaluating

14:18

otherwise it checks cond2, if it's false, it stops evaluating

14:19

otherwise it checks cond3 (edited)

yes, but if i do (cond1 || cond2 && cond3) what then?

14:19

i guess && comes first because its 'stronger'? (edited)

(cond1 || cond2 && cond3) is the same as (cond1 || (cond2 && cond3))

14:20

but write parentheses, it makes the intent clearer ^^

but that would be different just for the record ((cond1 || cond2) && cond3)

yes

ok

陪我

@louis done

thank u ^^

[ddnet:master] 3 new commits

fe51c73 Added new translations + fixed current one - crqch e53107b Fix Leak IP not visible - crqch 2dac492 Merge #5432 - bors[bot]

14:30

[ddnet/ddnet] Pull request closed: #5432 Added new translations + fixed current one

[ddnet/ddnet] Issue opened: #5440 Add save server info to clipboard button

This may help people trying to report others for not following the server rules on discord, and moderators a quick way to connect to the server. Perhaps under Game Tab or maybe next to the "Favorite" tickbox under ESC > Server Info?

[ddnet:master] 2 new commits

379d93a no goals hud when empty - Lukas Kitsche 79de540 Merge #5424 - bors[bot]

1

14:57

[ddnet/ddnet] Pull request closed: #5424 no-goalshud

is it possible that clang tidy has false positives?

please be more specific

15:00

probably yes

woot how

15:00

i thought its da best of the best

its a static analyzer

15:01

it sometimes assumes stuff

the only one I know is about object slicing (if you want it)

CCharacter *pChar = ChatHelper()->GameClient()->m_GameWorld.GetCharacterByID(ChatHelper()->GameClient()->m_LocalIDs[g_Config.m_ClDummy]);
			if(pChar)
				continue;
			vec2 Self = pChar->m_Pos;

yeah

15:02

thats just wrong

15:02

if(pchar) continue

15:02

looks really wrong

ah lol

15:02

i want !

15:02

xd

xd

yea i knew it

15:02

never clang gets something so simple wrong

if the pChar comes from other libs for example it might actually do this

15:03

but the compiler should see it too actually

you can overwrite the pointer operator and make the code above work

dunno if that works, but best idea 2022

15:04

just invert all logic

jupstar u got some free music for me?

let me google CC0 music

omagawd

15:04

not CC0

15:04

free to listen to

https://en.wikipedia.org/wiki/File:Anthem_of_Europe_(US_Navy_instrumental_short_version).ogg here

File:Anthem of Europe (US Navy instrumental short version).ogg

15:05

public domain

lmao my pipeline was actually catching the issue as well but my tests are not that ellaborate xd

15:05

omagawd

15:05

something thats nice to listen to

u dont like bethooven?

bitsh wat u would listen to

15:06

niet

suka

15:06

its the best german musican

all nazis

back them the world was smth else

send me ur fav playlist or riot

ok let me see

15:07

i like anime soundtracks alot, bcs im weeb

15:07

game music also nice often

15:08

i am more instrumental guy u know

try me

u hear 2 songs at the same time

15:09

and call it a new song

ping

pong

matrix is so broken time to kill it again

why is it broken?

its super slow. It cant be killed without running pkill -f electron it loses messages. It messes up message order.

15:15

maybe its an element issue and i should try getting matrix into my weechat which is use for irc

the only annoying thing is, that the bridge has such huge delay sometimes

15:15

makes it unusable when talkn to smbdy

[ddnet/ddnet] Issue closed: #3702 scoreboard blank box

i never notice that from irc

@heinrich5991 does the server require now ipv6 btw?

15:29

or can I set it up for only ipv4 somehow

jopstar where dj

i dunno where u are

15:46

probs in some holidays xd

AssassinTee

or can I set it up for only ipv4 somehow

yes, with sv_ipv4only 1, feedback is missing, like sending heartbeats oO

i mean u

15:49

when send songs

i said i mostly hear instrumental music lmao

i said try me

no idea what to pick, sometimes i hear this, then that u know

15:51

its not like i have a playlist

hrmpf

Is anyone interested in testing materials with me? I merged all I have together and maybe need some feedback now

c0d3d3v

@Chairn Is it ok to address your refactoring requests in another PR. Because they are not specific to my PR, but the problem was there already before

Or do you want me that I scan somhow the code for all wrong array prefixes. And the refactoring of the asset menu should also be done in a more serious PR.

Sure, it's not that important

u got some server to connect to?

yes, a home server, but you need a custom client

is it public?

15:57

by customclient u mean #5313 ?

can you see this workflow? https://github.com/AssassinTee/ddnet/runs/6921876190?check_suite_focus=true

implement all materials experimental · AssassinTee/ddnet@1b96d4e

DDraceNetwork, a cooperative racing mod of Teeworlds - implement all materials experimental · AssassinTee/ddnet@1b96d4e

ye

I am just waiting for the artifacts

gh atrifacts is M$ maleware axaxax

You think my at home compiled client is more secure?

yes

not if u use MSVC xd

dont u?

16:02

axaxax MSVC

no, CLion

does CLion have its own compiler?

probably gcc

poggies

but github actions is widely used, makes it less likely to contain weird software

@AssassinTee yea i think im too lazy to build the pr rn i thought u wanted to test something on current master and i could quickly join a pub server

you don't need to build the PR, i am just stupid atm

what a statement @Jupstar ✪ xd

16:03

@Jupstar ✪ windows is also widley used

i mean in open source community

16:04

would damage their image

im even less likley to run a binary you send me xd

16:04

which image?

16:04

we all think that m$ is stealing our closed src code and feeding it into code pilot

for being more open source friendly lately

gh it self is still closed src

16:04

ms open src is just meme

depends

but yea i get what you mean vscode etc

typescript

da

how about hating m$ but still respect their open source projects

im in

16:06

but i dont trust their pipeline xd

16:06

the binarys probably install a windows bootloader on my system

i doubt they care tooo much about the artifacts

16:06

remember, company does only things where it can get much money

16:06

and artifacts are probs not too hugely used in industry xd

artifacts are behind account wall

16:07

so next summer when github accounts cosz 10$ artifacts are literally e-gold

lmao

16:07

where did u get that from

xd

16:07

i made it up

that would instant kill github xxD

i would still buy

Watch this ad in order to start your github actions workflow

but no student would

xxxxxxxxxxxxxxxxxxxD

16:10

since im uploading these logs to gh they will parse that shit and only make me pay to keep my account

16:10

@microsoft I WONT!

16:11

spawns are deterministic right? Always closest spawn to 0/0 is used first on empty server

y

ur pipeline failed nob

I mean technically everything is deterministic, because it's running on a computer, but I know what you mean

omg cringe CS

ye ik, already updated

this boi? https://github.com/AssassinTee/ddnet/tree/feature/all-materials-experimental

GitHub - AssassinTee/ddnet at feature/all-materials-experimental

DDraceNetwork, a cooperative racing mod of Teeworlds - GitHub - AssassinTee/ddnet at feature/all-materials-experimental

?

i still dont know which branch u work on

yes that's the branch, the current pipeline is still running since 10 minutes

ah yea but style alr failed

look again at your link

[quakenet] ChillerDragon

ah yea but style alr failed

and therefore software can't compile?

YES

I hope you don't have macos

16:17

https://github.com/AssassinTee/ddnet/actions/runs/2510253176 (edited)

16:17

artifacts below

i just started cloning

16:18

but ill only swope in for a quick moment

16:20

so wat server i join?

Assa's material server, but are master servers down?

send ip

I can't even find them in serverbrowser

leak ip

16:21

https://duckduckgo.com/?t=ffab&q=what+is+my+ip&ia=answer

what is my ip at DuckDuckGo

DuckDuckGo. Privacy, Simplified.

172.28.224.1:8303

enjoy ddos mf

leaked duh

axaxax

16:22

"No asnwers from server yet"

16:22

u got em firewall up?

16:22

NAT

I even got other players on it rn

watfaka

16:23

does one need custom client to join?

16:23

or only to see materials?

to see materials and to have valid predictions

i cant join wetefek

and if you only have ipv6 then I can't help you

lol

16:24

ye rip cant join

@heinrich5991 can u setup master2 rn xd

I don't know why ipv6 is not working here

omagaw di have ipv4

16:25

its not that

16:25

sure u sent the correct ip?

Jupstar ✪

@heinrich5991 can u setup master2 rn xd

like 3rd time ddnet.tw was down this week

16:26

:/

yes

how come i can not join then=

no

16:27

93.245.170.253:8303

xd

16:27

trol

16:27

accidentally leaked moms ip

idk, seems to be a lokal one oO

16:28

Image attachment

wot

16:29

why does it look like ass for me?

16:29

i got ur sus client

16:29

Embedded image

what is in data/editor/entities_clear/ddnet-materials ? (edited)

16:30

wtf

there is no data/entities

16:30

is ur cmake working?

16:30

lemme check

[quakenet] ChillerDragon

there is no data/entities

/editor

Embedded image

16:31

hmmm

16:36

https://github.com/AssassinTee/ddnet/blob/41a960117b3deff5c9075cdbe7ab29a6554d8b3c/src/game/client/components/maplayers.cpp#L2047

ddnet/maplayers.cpp at 41a960117b3deff5c9075cdbe7ab29a6554d8b3c · A...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/maplayers.cpp at 41a960117b3deff5c9075cdbe7ab29a6554d8b3c · AssassinTee/ddnet

16:36

i think i could end up in this branc

every layer does that and I don't know why xD

16:38

ah I see, it's copy pasta probably maybe

unitinilaized variable nob

16:39

m_MaterialIsLoaded should be set to false

16:39

in constructuror

16:44

Embedded image

yes, you are probably right (edited)

16:50

16:50

yea if u get the wrong compiler/setting this might not work. But i think modern c++ should init bools to false. Probably not the only place ddnet depends on that

i barley map these days so idk but did editor sense get slower?

17:11

oh yea WAYYY SLOWER

17:11

hrmpf

17:11

@robyt i guess this is a feature? -.-

am i the only one to have segfault on latest master?

server or client?

17:11

i get none in client

client

17:12

on windows

17:13

it's in vulkan backend, but nothing has changed there recently?

17:15

hmm, i blame robyt, still have to check, looks like new readfile function might fail weirdly

[ddnet/ddnet] Issue opened: #5441 Slow editor navigation

https://github.com/ddnet/ddnet/pull/5428 eb7e210fc1ec76192dcb62f7ef9cad7b7c5ee6b6 Slowed navigation down

why is murpii better in german than rest of us? isnt he like hungerian or smth (edited)

troll

2

my german is horrendous, alot of people would disagree but I think growing up in a multilingual household is a huge nerf

[ddnet/ddnet] Issue opened: #5442 SegFault on master with vulkan backend

git bisect:

dc52377fc59f41f8687ca4176ba73196d7790e69 is the first bad commit
commit dc52377fc59f41f8687ca4176ba73196d7790e69
Author: Robert Müller 
Date:   Tue Jun 14 21:27:10 2022 +0200

    Use `ReadFile` to read shader

 src/engine/client/backend/vulkan/backend_vulkan.cpp | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

``` bt #0 0x0000000007cfc5c5 in vkGetInstanceProcAddr () from C:\Windows\system32\nvoglv64.dll #1 0x0000000000661007 ...

where do i download artifacts on github?

17:35

i wanna try windows build from robyt's pr

klick on the gh action and then choose a build

17:36

and they are groupped

17:36

click on the group

17:37

Image attachment

lol, it just didnt scroll with my mpousewheel...

17:38

ok, the github page is bugged i think: https://github.com/ddnet/ddnet/actions/runs/2507725847 can you scroll ?

why

17:38

i dunno what u mean with scroll up

17:39

it desotn even fill my whole mintor

17:39

monitor

i couldn't scroll down, hence i didnt see it

why the fuck do u even need to scroll xD

17:42

the page is pretty small xD

i got small screen

[ddnet/ddnet] Pull request opened: #5443 Additional binds for control over copy moves

These simple changes give you complete control over what the dummy should or not copy when using "cl_dummy_copy_moves". This will be helpful for copy fly with dummy for example. Added on line 272 m_MousePos[!g_Config.m_ClDummy] = m_MousePos[g_Config.m_ClDummy]; This places the mouse in the same direction as it was when copying moves. To prevent jerking of the weapon when switching to a dummy

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a vis...

1366x768

xd

laptop is from 2014

potato

not really

17:42

i7 still running fine

potato²

i need to change thermal paste though, it's starting to get quite hot again with this weather

kaby lake gen exists since 2014? thonk

thonk

probs ivy bridge

17:48

but his laptop supports vulkan, thats quite nice xd

i7 was first introduced in 2008

17:48

god I feel old now

how old r u

17:49

leak

I turn 26 this year

ez

soonTM

then i feel even older xd

leak

i am 26 already xd

17:51

my first ever bought PC was an intel core duo

17:51

xD

my first ever bought PC from money that wasnt from my parents was i7 ivy bridge xd

17:52

so yeah old af xD

17:53

and then comes my dad with his stories about first commodore 64 and how they bought it, bcs it was the first cool computer xd

tell your dad we now have rgb

17:55

everywhere -, that's the new cool

(edited)

[ddnet/ddnet] Pull request opened: #5444 Fix shader code vector size not being updated after copy

Oops, I tried to be smart with reserve instead of resize but of course that wouldn't set the actual size of the vector after I copy in the data. Closes #5442.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Ch...

Chairn

hmm, i blame robyt, still have to check, looks like new readfile function might fail weirdly

it's because I misused std::vector, I reserve the size and then copy but this doesn't set the actual size of the vector

murpi

everywhere -, that's the new cool

(edited)

no joke, he buys all these LED lights and puts them fcking everywhere xD he's like RGB but not limited to computers xD

Jupstar ✪

no joke, he buys all these LED lights and puts them fcking everywhere xD he's like RGB but not limited to computers xD

RBG man cave? poggers

poggers

18:04

I'd go in debt just to have a rbg man cave

we dont have that, but our living room looks sexy af

[ddnet:master] 2 new commits

82e8ab5 Fix shader code vector size not being updated after copy - Robyt3 29e8ec4 Merge #5444 - bors[bot]

18:17

[ddnet/ddnet] Issue closed: #5442 SegFault on master with vulkan backend

18:17

[ddnet/ddnet] Pull request closed: #5444 Fix shader code vector size not being updated after copy

Robyt3

it's because I misused std::vector, I reserve the size and then copy but this doesn't set the actual size of the vector

worst thing is that i almost made a comment on this, and after checking the reference, it seemed to be safe

murpi

I turn 26 this year

only 334° more and you will make a full turn

happy

1

[ddnet/ddnet] Pull request opened: #5445 Fix editor value scrollers not working and panning being slow

Accumulate the mouse deltas and reset them at the end of the frame to fix editor panning being slowed down and value scrollers (layer width etc.) not working anymore. Closes #5441.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array i...

use ctrl+f to search in F1 and F2 would be fire

19:36

is it planned already? i got this idea for so long

https://www.nvidia.com/en-us/studio/canvas/ (edited)

19:54

amazing

thats old

20:02

hows this old? beta launch was 1 year ago

20:06

thonk

well news fly

20:06

for me 1y is old news

20:06

xd

oh so this doesn't apply to me, cool

Image attachment

22:11

i already fixed all of the "he/him/his" in the codebase kek

22:11

last things is the announcements.txt

[ddnet/ddnet] Pull request opened: #5446 Gender-neutral language

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

bop

22:16

this does not even affect compilation it's just comments

girls dont exist

wtf

lynn

last things is the announcements.txt

this should be the file https://github.com/ddnet/ddnet-scripts/blob/master/servers/announcement.txt

ddnet-scripts/announcement.txt at master · ddnet/ddnet-scripts

The magic scripts that make DDNet run. Contribute to ddnet/ddnet-scripts development by creating an account on GitHub.

ah got it

22:42

well im busy now but maybe i get to this at some point xd

22:42

thank you

22:42

nvm ill just do it

1

22:43

can i also fix grammar?

22:43

there are some mistakes

22:43

...blocking players. And only some of them do it on purpose. this is a fragment

22:43

should be

22:43

...blocking players, and only some of them do it on purpose

yes

perfect thank you

22:44

Check out the DDNet Wiki by Patiga & Zwelf on wiki.ddnet.tw
Check out DDNet's Discord server on ddnet.tw/discord
Check out DDNet's TeamSpeak server hosted by laxa on ts.ddnet.tw

22:44

recommend making these uniform

22:45

Check out the DDNet Wiki by Patiga & Zwelf on wiki.ddnet.tw
Check out the DDNet Discord server on ddnet.tw/discord
Check out the DDNet TeamSpeak server hosted by laxa on ts.ddnet.tw

22:45

unnecessary change though

22:45

"Join our community and register on forum.ddnet.tw" should probably be revised. we are not actively talking here so it seems wrong to say "join our community" (edited)

22:45

or we can remove this announcement

22:46

i thought /rankteam was a typo, had no idea it works (edited)

22:46

dont people normally say /teamrank ?

22:47

this could be revised as well, a bit dated: "Mappers looking to map using our new features can get our server and client on our website: ddnet.tw" (edited)

22:48

...giving you access to /r and /tp to easily traverse the map... should we point out /tp works based on spec?

22:49

i suppose it's intuitive but maybe not something a newer player realizes

22:49

"Keep up to date with new map releases on ddnet.tw/releases" maybe also mention the channel on Discord

[ddnet/ddnet-scripts] Pull request opened: #40 Grammar, gender neutrality

done

[ddnet:master] 2 new commits

6691d71 Gender-neutral language - kaitlynia d44b11d Merge #5446 - bors[bot]

23:02

[ddnet/ddnet] Pull request closed: #5446 Gender-neutral language

make some new announcements

23:39

would be nice if some announcements were more heavily weighed on novice servers kek

23:39

like the /practice, wiki links, etc

Exported 670 message(s)