DDraceNetwork - developer

[ddnet/ddnet] Issue opened: #5402 Frequently unresponsive on Windows 11

The version of Windows 11 is 22000.xxx ddnet.exe downloaded from both ddnet.tw/downloads and Steam is frequently unresponsive. And also to load Assets directory in Setting would report an unknown error but can still open it.

hus3h

[ddnet/ddnet-web] Pull request opened: #195 Player hours graph improvements

Make monday the first day of the week and change "0 hour" to "0 hours". Made the day letters on the side just for the first and last day to avoid adding "Th" which didn't look good. !image

Player hours graph doesn't look too nice on mobile. Don't know if that is worth a bug just wanted to share.

1

Jupstar ✪

i think i never had non responsive computer since i have my 8 cores

You never crashed your PC with a rogue C++ app? xD

louis

for the slime thing yeah we'd probably need a sound for bouncing + hooking it if it got added i offered to make it in one of the github issues, but shouldnt be too complicated so either of us could do it

I made a bouncy sound, but please ask pipou xD

07:24

Can I post it here?

07:25

P.J.

Player hours graph doesn't look too nice on mobile. Don't know if that is worth a bug just wanted to share.

thanks, will check later

AssassinTee

I made a bouncy sound, but please ask pipou xD

hes in here @Pipou

07:42

but i can give feedback too

07:42

i think its a bit too high frequency for smth bouncy

07:42

maybe try to get more low end to give it the 'smush' sound effect

07:44

oh and dampen the reverb a bit

deen

thanks, will check later

added a fix for it in my pr

def-

[ddnet/ddnet-web] Pull request closed: #195 Player hours graph improvements

08:29

def-

[ddnet-web:master] 4 new commits

2fabe53 Make monday the first day of the week - hus3h 0d40c07 Change "0 hour" to "0 hours" - hus3h dd73287 Make the hours graph scrollable for smaller screens - hus3h d3e5c83 Merge pull request #195 from hus3h/pr-hours-graph-improvements - def-

AssassinTee

You never crashed your PC with a rogue C++ app? xD

I think i only had GPU driver crashes yet

I tried to compile ddnet and I got an error that it cannot find avcodec-59.dll, swscale-6.dll, avformat-59.dll

how did you get the source code?

09:31

have you downloaded the ddnet-libs submodule?

yes

how do you compile ddnet?

With this commands: mkdir build cd build cmake ..

can you post the exact error message?

Jupstar ✪

I think i only had GPU driver crashes yet

it's very simple: make a thread start a synchronous and asynchronous version of itself (and forget the end condition

)

heinrich5991

can you post the exact error message?

so you have successfully compiled it, just running doesn't work?

luk51

[ddnet/ddnet] Pull request closed: #5401 Only show the scorelimit box in other mods than ddrace.

heinrich5991

so you have successfully compiled it, just running doesn't work?

I launched it 1 time and the hereditary day does not start

you could try copying over these libraries from ddnet-libs/ffmpeg/windows/lib64/

when you include the wrong protocol.h and nothing compiles anymore xD

I always find development bugs funny, so here is one for you: I used the wrong image and now my skid marks are emojis

heinrich5991

you could try copying over these libraries from ddnet-libs/ffmpeg/windows/lib64/

@и чо ^

и чо

Click to see attachment 🖼️

why does it look so photoshoped? xD

12:31

tbh it looks like tippex on the monitor

@nouaa probably an app that recognizes text and makes it more readable

was thinking 'bout that, but the font also seems weird xd

12:34

u're probably right

Patiga

@nouaa probably an app that recognizes text and makes it more readable

Hm, I was thinking it looked a lot like google translate

def-

[ddnet/ddnet-web] Pull request closed: #194 Fix skinpack download link

12:43

def-

[ddnet-web:master] 2 new commits

54b95b6 Fix skinpack download link - Jupeyy 5c03ae8 Merge pull request #194 from Jupeyy/pr_fix_skinpack_download_link - def-

nouaa

why does it look so photoshoped? xD

no it is translate

Learath2

Hm, I was thinking it looked a lot like google translate

@Learath2 huh didn't notice that the text might be odd, might be it I guess :)

bors[bot]

[ddnet:master] 2 new commits

2710fe8 Add community skin option to client - Jupeyy 5f6e532 Merge #5397 - bors[bot]

13:02

bors[bot]

[ddnet/ddnet] Pull request closed: #5397 Add community skin option to client

и чо

no it is translate

oh ^^

Learath2

@deen https://ddnet.tw/maps/?json=Stronghold the json thing seems broken, haven't investigated though

thanks, fixed

bors[bot]

[ddnet:master] 2 new commits

ffff443 Remove ui_scale: - Robyt3 5a7fa10 Merge #5393 - bors[bot]

13:19

bors[bot]

[ddnet/ddnet] Issue closed: #5062 UI scale breaks start menu

13:19

bors[bot]

[ddnet/ddnet] Issue closed: #5358 ui_scale

13:19

bors[bot]

[ddnet/ddnet] Pull request closed: #5390 Change ui_scale range from 50-150 to 90-110

13:19

bors[bot]

[ddnet/ddnet] Pull request closed: #5393 Remove `ui_scale`:

cauldron

haha i could fix it with a linux tool called dos2unix. i think i even found some windows line endings in some files xd

do you want that I run fix style for you?

AssassinTee

[ddnet/ddnet] Pull request opened: #5403 Draft: Implement Ice Material

Implement Ice based on #5313 Ice skids: !screenshot_2022-06-13_16-01-26 !screenshot_2022-06-13_16-01-29 Should be visually equal to my video: https://www.youtube.com/watch?v=WixRWjyqm1o

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a...

@c0d3d3v Is it possible to give me a branch on ddnet? My Latest PR is based on another one and the code looks inflated. This could make reviewing easier

heinrich5991

[ddnet/ddnet] Pull request opened: #5404 Always send all tunings

It doesn't hurt since tunings after the last one are simply ignored. This also stops future coders from introducing more and more cases in this if chain.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no ...

AssassinTee

@c0d3d3v Is it possible to give me a branch on ddnet? My Latest PR is based on another one and the code looks inflated. This could make reviewing easier

you can just make a branch on your fork. git checkout -b your_branch_name

heinrich5991

[ddnet/ddnet] Pull request opened: #5405 mastersrv: Small convenience function

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undef...

where can I find the skin db code?

@heinrich5991 how about this https://github.com/ddnet/ddnet-web/pull/193/files

thanks

lets just allow indexed rgb

15:08

nobody cares about old clients

I kinda do

nobody - you

15:09

or +

15:09

indexed rgbs are smaller, so why prevent useful stuff

I wanted to explore that

15:10

how much smaller are indexed rgbs, does it justify the skin db no longer working for older clients

it still works

15:10

just not the indexed RGB skins

does it justify the skin db no longer working for the indexed rgb skins for old clients

How I can add custom sprite for my client?

heinrich5991

[ddnet/ddnet] Issue reopened: #3691 flooding the rcon console can timeout authed players

https://github.com/ddnet/ddnet/pull/5404 @heinrich5991 this would leed to overflow in old clients. Do you want this? Do we want to drop support for old clients? becuase of https://github.com/ddnet/ddnet/blob/master/src/game/client/gameclient.cpp#L700

Always send all tunings by heinrich5991 · Pull Request #5404 · ddne...

It doesn't hurt since tunings after the last one are simply ignored. This also stops future coders from introducing more and more cases in this if chain. Checklist Tested the change ingame P...

ddnet/gameclient.cpp at master · ddnet/ddnet

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/gameclient.cpp at master · ddnet/ddnet

left non indexed right indexed

15:16

on Ablush NeoN.png

thanks, you were way faster than me on that one

if u want to reproduce: changed type in gimp ran zopfli on both

c0d3d3v

https://github.com/ddnet/ddnet/pull/5404 @heinrich5991 this would leed to overflow in old clients. Do you want this? Do we want to drop support for old clients? becuase of https://github.com/ddnet/ddnet/blob/master/src/game/client/gameclient.cpp#L700

as far as I can tell, this doesn't lead to any overflow, clients only read as many tune params as they know: https://github.com/ddnet/ddnet/blob/5a7fa108a6ab735f6c7a9fe061245297ca6367c4/src/game/client/gameclient.cpp#L692-L701

ddnet/gameclient.cpp at 5a7fa108a6ab735f6c7a9fe061245297ca6367c4 · ...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/gameclient.cpp at 5a7fa108a6ab735f6c7a9fe061245297ca6367c4 · ddnet/ddnet

c0d3d3v

you can just make a branch on your fork. git checkout -b your_branch_name

This is not what I meant, I just wanted reviews for you easier (edited)

if you still see an overflow, please point me to it

AssassinTee

This is not what I meant, I just wanted reviews for you easier (edited)

I think it's fine to just base your PRs on top of others. we can look at just the new commits

heinrich5991

if you still see an overflow, please point me to it

mh I see

It might get messy at some point when I modify the base PR more and start merging it back in

try rebasing instead ^^

All of this is a bit of trial and error unfortunatly

15:19

hmm okay

(instead of merging back)

1

that's the first time I see why rebasing is useful

15:21

now it clicked on me why it's named rebasing (edited)

also, not a large issue, but for future pull requests, you could consider squashing commits like https://github.com/ddnet/ddnet/pull/5313/commits/0c5f98a41e10e7863c5336173fd803bcfe4460dc

AssassinTee

This is not what I meant, I just wanted reviews for you easier (edited)

ah sorry

I forgot that you are AssassinTee ... Now I understand

not much information is added by having that as a separate commit. if we only have commits that correspond to semantic changes, it eases git-blaming

c0d3d3v

ah sorry

I forgot that you are AssassinTee ... Now I understand

can you rename me here? I would do it myself but the server doesn't allow it <.<

@AssassinTee since the last two commits became superfluous, you could practice rebasing by doing a git rebase -i upstream/master keeping the first commit, squashing the second one into the first one and deleting the other two of this pull request: https://github.com/ddnet/ddnet/pull/5398

15:27

superfluous: https://github.com/ddnet/ddnet/pull/5404

Jupeyy

[ddnet/ddnet-web] Pull request opened: #196 Load current skin values on change

Makes it easier to only change a single value when changing skin properties

15:28

def-

[ddnet-web:master] 1 new commit

8a31a4d Remove ddnet.tw stats - def-

@Jupstar ✪ I guess the question boils down to: do we want to support old clients for the skin db

15:30

if we want to do that, we need to ensure compatibility

then i vote no xd

15:31

idc about outdated software

heinrich5991

@AssassinTee since the last two commits became superfluous, you could practice rebasing by doing a git rebase -i upstream/master keeping the first commit, squashing the second one into the first one and deleting the other two of this pull request: https://github.com/ddnet/ddnet/pull/5398

What does deleting do?

if we don't, sooner or later indexed rgb skins will get added, or people might get the idea that indexed rgba skins are smaller and can thus be replaced

sounds like a good step to me

AssassinTee

What does deleting do?

I think the delete command is called "drop" in git rebase -i

15:32

it just removes the commit and its changes

next drop vanilla support and add map images as PNG instead of zlib

15:32

ok its more about old clients actually

15:32

since 0.7 have own map files

Jupstar ✪

sounds like a good step to me

with that in mind, I can see why my comments are seen as unnecssary burden ^^

cant we add a warning in next release to update the client and trigger it in exactly 1 year

15:33

then we have some spearroom

I wouldn't intentionally make old software not work, but I guess one could say that adding a warning doesn't make the software not work

Jupstar ✪

https://github.com/ddnet/ddnet/blob/ae1876d1414cb013554db3ed839425a9647a4fc2/src/game/client/components/mapimages.cpp#L166-L183 smth like this

is this a good way to get mod type in the hud or whats the best source?

mhh depends

bcs i didnt see it how to get the ggametype out of this at the first glance

are entities always related to the hud

15:36

could probs argue yes, but maybe also no

15:36

dunno

15:36

ask fokkonaut, he abuses all these flags xd

if you have another idea pls tell me

15:37

ok, yeah sounds like abuse or hacky way

i am also not the right person to ask network questions xd

cause entities rely on gametype so why not go to the "root source"

15:37

ok

and deleting the other two of this pull request

15:37

this was requested by codedev

yes, I think he was mistaken

off

c0d3d3v

mh I see

see here

15:38

@cauldron you can add another flag if you want

15:38

alternatively, why not hide that part of the score board if it's empty? @cauldron

@Learath2 if it makes u happy, the skin database runs better on firefox than chrome, firefox seems to struggle less creating the 600 skins table

can anyone here write something for the discord bot? just to autoadd reactions in the new skin submission channel

I have no experience with the discord bot, I don't know anyone who does

15:41

maybe Learath2

yeah i asked learath as well

cauldron

i don't get it, it asks which entities are there and then decides it's the corresponding gametype?

I already linked you to the gameinfo in your PR... just add a flag there

Jupstar ✪

@Learath2 if it makes u happy, the skin database runs better on firefox than chrome, firefox seems to struggle less creating the 600 skins table

Can we maybe just render the ones on screen? 600 is a lot

15:43

or paginate it

yeah could do lots of stuff xd lets see if the performance hit comes from the tee.js

@heinrich5991 dev just added a commit 2 minutes ago and now I overwrote history

is he here?

Jupstar ✪

@Learath2 if it makes u happy, the skin database runs better on firefox than chrome, firefox seems to struggle less creating the 600 skins table

Firefox supremacy

AssassinTee

@heinrich5991 dev just added a commit 2 minutes ago and now I overwrote history

is he here?

If you mean def-, that's me

louis

can anyone here write something for the discord bot? just to autoadd reactions in the new skin submission channel

mh I really don't feel like it, what does it need to do?

deen

If you mean def-, that's me

then I mean you, I didn't know your github name

Learath2

mh I really don't feel like it, what does it need to do?

can you see #📬submit-skins

off

it needs to add 2 reactions to any messages in there with a skin file and the correct name

15:46

i think you should be able to copy/paste a lot from map_submissions.py

deen

or paginate it

do we have plugins for that on the website alraedy? there is a javascript library: datatables, but it requires jquery, dunno if that bloats stuff too much

@Jupstar ✪ hm, it's too fast for me to detect any slowdown, how did you figure chrome fared worse than firefox?

no plugins

15:49

maybe jquery supports it, we use some jquery stuff

15:49

for me it doesn'T even load all skins

cauldron

off

https://github.com/ddnet/ddnet/blob/ae1876d1414cb013554db3ed839425a9647a4fc2/src/game/client/gameclient.cpp#L1012 like this, "Info.m_ShowGameGoals = Vanilla FNG ..." guessing it from the mod flags https://github.com/ddnet/ddnet/blob/ae1876d1414cb013554db3ed839425a9647a4fc2/src/game/client/gameclient.cpp#L989-L998 should be fine

ddnet/gameclient.cpp at ae1876d1414cb013554db3ed839425a9647a4fc2 · ...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/gameclient.cpp at ae1876d1414cb013554db3ed839425a9647a4fc2 · ddnet/ddnet

louis

can you see #📬submit-skins

i don't see it

every time I refresh a different subset of skins is shown

Hm, if I clear the cache while reloading I do get some missing too

15:52

but if I refresh again since the skin images are cached it renders all just fine

15:52

I haven't taken a look at the code btw, so dunno why the GET request for the image ending late causes this

heinrich5991

[ddnet/ddnet] Pull request opened: #5406 Remove namespace tw

It didn't have a clear role, it just acted as a distinguisher between two functions with the same name. Rename tw::time_get to time_get_nanoseconds and delete the old time_get_nanoseconds. Move CCmdlineFix and the typed net_socket_read_wait function to the global namespace.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if ...

ah yeah the tee.js thing is weird it should trigger only when the image is actually shown

heinrich5991

[ddnet/ddnet] Issue opened: #5407 Should we continue to support old clients to load from the skin DB?

Doing so adds some complexity with #5385, as skins with indexed RGBA might get added to the skin DB accidentally or on purpose for size reduction. Possible solutions: 1. Move to a new skin DB URL to allow indexed RGBA skins, retaining the older one for compatibility. 2. Disallow using indexed RGBA skins so everyone sees the same skins, new and old clients. 3. Display a warning when an indexed RGBA file is loaded. 2 and 3 might come with a feature flag from info.json so that we can add...

15:59

heinrich5991

[ddnet/ddnet] Issue closed: #5364 Discussion: Only mark "accepted feature requests" as "enhancement"

off

murpii

[ddnet/ddnet] Issue closed: #3742 Steam Workshop integration / Streamline user submissions for skins

Jupstar ✪

ah yeah the tee.js thing is weird it should trigger only when the image is actually shown

The intersection observer api could probably be used there, or maybe lazy loading combined with the onload event? I might take a look in a couple hours

@AssassinTee now you combined the two later commits into the first one, instead of dropping them. do you want me to fix it or do you want to try yourself?

16:06

(in https://github.com/ddnet/ddnet/pull/5398)

Learath2

The intersection observer api could probably be used there, or maybe lazy loading combined with the onload event? I might take a look in a couple hours

ah good to know, i dunno all dom events

16:07

else i gonna just create a image map

16:07

might be faster anyway

please fix it, I also clashed with @deen there

and doesnt create this weird flashing

@AssassinTee done. it seems your git identity isn't connected to github btw

16:12

you might want to add your git email address to your profile

My account is really really old, this might be the reason why. I fixed it. And thank you ofc ❤️ (edited)

Github also provides a noreply forwarding email if you'd rather not have your email public

I connected my spam email address, which is 13 years old and already got hacked twice

Actually calling it "noreply" is very wrong. It's just a forwarding email :D

now that I modified the PR, can someone else merge it? https://github.com/ddnet/ddnet/pull/5398

16:18

ah, maybe hold off of it for a moment, there might be identity issues ^^

Uff, new physics, I don't feel comfortable merging it without reviewing it myself anyway

hehe

16:21

@Learath2 identity issues solved

1

I'm busy for atleast an hour. I've been putting off studying since the morning, I'll feel bad if I don't atleast study some italian

ti amo @Learath2 (and that's all the Italian I learned)

I can say "ciao"

Buonissimo

16:24

I'm learning the wonderful world of italian prepositions and how they lack all rhyme and reason

16:25

You just memorize what preposition is supposed to be used with what noun

sounds like most languages

16:26

to be operated on something

16:26

to think of

How do I dilate images again?

Jupstar ✪

drag it into dilate tool

hm

drag the file into dilate.exe

16:34

(same directory as ddnet.exe is in)

1

(yeah had to build it first)

def-

[ddnet-web:master] 1 new commit

9999a6b Server funding update - def-

off

@heinrich5991 did you test the bouncyness ingame or do you just trust me?

I trust you

16:39

the changes looked sane and I think I've experimented with the already built-in bounciness before

you can break it with values > 1.0 and < -1.0, that's why I am asking (edited)

hmmm ^^

16:40

break with >1.0 because you get faster and faster?

16:40

what happens with <-1.0?

yes, make a 1 tile gab with bouncy walls and see how your acceleration clips you through walls with elasticity_x > 1.0 (edited)

btw i squashes @heinrich

heinrich5991

what happens with <-1.0?

with exactly -1.0 walls get sticky, it's actually a funny effect, because walls try to pull you into them. If you make this value higher, you get more and more accelerated into the wall clipping through it in the process

hmmm

16:42

ChillerDragon ?

da

wdym?

u asked me to squash the nullptr pr

16:43

i just did

ah

road to -Weverything :D

-Weverything isn't useful

16:45

except maybe learning more warnings to enable

yea iv seen u write tha

16:46

but i think it would be cool to pass Weverything

some warnings aren't applicable to our code

if you like a -Wall of text, sure :p

fixing them for the sake of passing -Weverything doesn't sound beneficial

hrmpf

-Wall actually means "activate a conservative, always useful set of warnings"

16:47

-Wextra means "activate a usually useful set of warnings" ^^

that's -Wonderful :p

lul

e.g. -Wpadded "Warn if padding is included in a structure"

and wats Weverything? activate as much as u can no matter the usefulness

doesn't sound useful to forbid entirely

16:48

-Weverything is "enable literally all warnings, even those that aren't actually useful for anyone"

well ill try to fix the nullptr thing and then if im still motivate ill check if others are cool or not

@AssassinTee should I stop the merge or should it be fixed in a followup PR?

how can we fix that, aren't all tuning values broken at some point? Do we have limits somewhere or do I need to clamp that every time I use it?

could theoretically clamp it in MoveBox I guess

I once made a PR to put sane limits on all tuning values, but it wasn’t accepted iirc

stop the merge, I'll clamp them

done

how can I pull your changes of this branch?

do you have your own branch currently checked out?

yes

git fetch origin

16:56

and no local changes?

16:56

git reset --hard origin/features/elasticity-tuning

$ git reset --hard origin/feature/elasticity-tuning
fatal: ambiguous argument 'origin/feature/elasticity-tuning': unknown revision or path not in the working tree.

can you show me the output of git remote -v (or tell me how you call your github.com/AssassinTee/ddnet remote)?

ah, this remote is named upstream (to add to my own confusion). I just fetched the branch with git fetch origin pull/5398/head:BRANCHNAME and see, that the commit hashes are identical now

great

17:04

(upstream is usually the thing not controlled by you btw ^^)

17:04

it's "further up the stream"

I know, but swapping them was too much effort

git remote rename origin temp; git remote rename upstream origin; git remote rename temp upstream

1

[quakenet] ChillerDragon

well ill try to fix the nullptr thing and then if im still motivate ill check if others are cool or not

i was going to do it if you don't want to use regex to fasten it

@heinrich5991 when I pull the PR I get hash 2435c72, which is right according to https://github.com/ddnet/ddnet/pull/5398/commits, however if I take a look at collision.cpp the changes are gone (edited)

what's the output of git rev-parse HEAD?

Okay I searched for elasticity and was in MovePoint and not in MoveBox

‍♂️

great

bors[bot]

[ddnet:master] 2 new commits

3667061 Use nullptr in generated and editor - ChillerDragon 5729cfe Merge #5399 - bors[bot]

17:21

bors[bot]

[ddnet/ddnet] Pull request closed: #5399 Use nullptr in generated and editor

is this a bug? xD

17:24

185.11.142.197:8314 if someone want to try

17:24

wrong channel btw, sorry

heinrich5991

[ddnet/ddnet] Issue opened: #5408 Tees can spawn near spawn points

https://cdn.discordapp.com/attachments/293493549758939136/985957700963815465/Ddnet_2022.06.13_-_19.21.54.01.mp4 Should probably instead spawn on the spawn point, even if it's occupied.

@heinrich5991 done

@nouaa good old sp someone trick

yeah xD

Today I learned that my IDE has a "Resolve Simple Conflicts" button when rebasing. Best feature ever.

is the hours played based on actual hours or just finishes?

def-

[ddnet-web:master] 1 new commit

a0a0c53 Frontpage video - def-

hours played in any teeworlds server

oh

18:03

u get that with teehistorian or a new thing?

18:03

missed a lot of stuff poggers

apparently from master stats

so its accurate down to 5 seconds of error

yes

i wonder what would be the math way to calculate the min and max possible hours