DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-06-12 00:00:00Z and 2022-06-13 00:00:00Z

[ddnet:master] 4 new commits

01edaec Format vector variables names (fixes #5209) - Chairn e265a9f Remove useless float vector in vulkan backend - Chairn 14f7f2e Remaining formatting and fix github code scanning - Chairn 47b9bcc Merge #5391 - bors[bot]

05:40

[ddnet/ddnet] Pull request closed: #5391 Format vector variables names (fixes #5209)

convert it to string do a string slince and then back to int :troll: :D

learaths dream, one firefox tab uses 4gb ram xd

Image attachment

yo jupstar how u activitina da -Weverything flag in ddnet? do you edit the cmakelists.txt or can one pass an env var?

-DCMAKE_CXX_FLAGS="-Weverything" should work

CXXFLAGS='-Weverything' cmake .. -DCMAKE_BUILD_TYPE=Debug yea this alr worked for me but thanks

08:01

and oh boiiii those warnings are not stopping

08:01

and i am not even using clang

i told ya what i used.. using all is insane

08:02

"Weverything is best just disable the few warnings u dont need" here for u to find my message

08:03

quite possible i dont even allow implicit conversations

08:03

i prefer to cast variables if really needed so i can quickly refind them

08:03

(on refactor)

[ddnet-scripts:master] 1 new commit

bcee5cd Add zstd dependency - def-

https://store.steampowered.com/app/1885690/Virtual_Circuit_Board/

Virtual Circuit Board

Virtual Circuit Board, or VCB, is a sandbox-only drawing-based logic simulator featuring an assembler and a powerful simulation engine. All of it designed to give you the freedom to build and experiment with logic circuits to your heart’s content.Set your own goalsIn VCB you will set your own goals of what and how you want to build, it does not ...

Price

$14.99

08:50

this looks so clean

08:50

im gonna try it

[ddnet/ddnet] Pull request opened: #5393 Remove `ui_scale`:

remove config variable ui_scale
remove CUI::Scale
remove CUI::SetScale
remove CUI::DoLabelScaled
remove CUIRect::Scale
use CUI::DoLabel instead of CUI::DoLabelScaled
remove usages of CUI::Scale() and CUIRect::Scale(), or use 1.0f instead

Closes #5062. Closes #5358. Closes #5390.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options ...

[ddnet/ddnet-web] Pull request opened: #193 New skin database

Small overview:

Community skin type
template skin type
HD skins for all types
json for skinlist(so it can in future be parsed by the client)
skin database uses more javascript now
skin downloads are onfly => less scripting on server side & search string can be used to download only searched files

We should defs make a backup of the old one. To convert the old to the new few steps are required: (small note, make sure the permissions are correct, old skin database used ...

[ddnet:master] 2 new commits

6725c36 Some qol changes for practice - kiw-q 40dfc06 Merge #5387 - bors[bot]

09:39

[ddnet/ddnet] Pull request closed: #5387 Some qol changes for practice

heyo, I am still getting a styling error: Wrong header guard in src/game/material.h I don't see what's wrong with my header guard?

lets se

09:49

e

09:49

DDNET_MATERIAL_H

09:50

but if you look at other header guards, it the path to the file

ah it's the name

so it should be GAME_MATERIAL_H

GAME_CLIENT_MATERIAL_H

09:51

if its in client

09:51

the github file structure confuses my brain

09:51

ah its not

it's in both

then u are right

09:51

oh ok

thank you ❤️

^^

Jupstar ✪

the github file structure confuses my brain

it bugs for me, too, it's bigger then it's scrollbar

it could just make this gab a bit bigger, but when u just search material.h its fine

Image attachment

09:55

still one of the most useful features added to github recently

1

09:59

@deen maybe this is related, apparently on https://ddnet.tw/css-halloween.css redirects

Image attachment

09:59

for me this link isnt created

[ddnet/ddnet] Pull request opened: #5394 Tell what has to be changed in check_header_guards.py

Example: Wrong header guard in src/game/bezier.h, is: #ifndef GAAME_BEZIER_H, should be: #ifndef GAME_BEZIER_H

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ]...

header guards are for the slaves, #pragma once for kings xd

10:38

modules for gods

[ddnet:master] 2 new commits

23af9ef Tell what has to be changed in check_header_guards.py - def- e961030 Merge #5394 - bors[bot]

10:53

[ddnet/ddnet] Pull request closed: #5394 Tell what has to be changed in check_header_guards.py

[ddnet/ddnet] Pull request opened: #5395 [WIP] Require Python 3.6 (f-strings) and fix pylints

So far only done scripts directory, will do the rest if this is considered good

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBS...

[ddnet/ddnet-web] Pull request closed: #193 New skin database

11:28

[ddnet-web:master] 2 new commits

4cc9b10 New skin database - Jupeyy 173417c Merge pull request #193 from Jupeyy/pr_new_skin_db - def-

11:34

[ddnet/ddnet] Issue opened: #5396 Skin names can break in 5:4 resolution

probs vertical alignment or smth like that !image

how long does it take until caches are cleaned?

11:36

is that all from cloudflare?

11:37

for me its still on the old page even with dev console open, really weird

11:38

well atleast partially on the old site, tee.js is old for example

[ddnet/ddnet] Pull request opened: #5397 Add community skin option to client

I think this was requested in the client too, rn I dont get any skins, maybe cloudflare caching or smth. Will test the days or if someone can test it go ahead

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed n...

Ah I see the actions are only displayed but if you press click them the http authentication pops up

Image attachment

yeah, not the best solution i know

11:43

but normally users should not even click it

11:44

for me it doesnt even work yet <.<

11:44

stupid caching xD

ctr+shift+r ?

yes i also have devtools open

11:44

and disabled cache there

11:44

i really assume its cloudflare

11:44

bcs it also doesnt work in my other browser

[ddnet-web:master] 1 new commit

4e7550d css halloween for graph - def-

11:48

[ddnet:master] 3 new commits

18ab88d Remove obsolete AfkTimer function - ardadem c4492c2 Move/rename AfkVoteTimer to AfkTimer - ardadem ae1876d Merge #5388 - bors[bot]

11:48

[ddnet/ddnet] Pull request closed: #5388 Remove obsolete AfkTimer function

Jupstar ✪

yeah, not the best solution i know

I can also not uplaod a skin

11:50

to community

11:50

so you could also just make the whole edit button authenticated as it was before?

11:50

I thought the skin gets moderated if someone uploads it

it mirrored the whole site before

11:51

i dont like this amount of code duplication (edited)

mh k

@deen are the skins mirrored? https://ddnet.tw/skins/skin/uhd/2005tfo.png

11:52

discord also cant load it

I can not load it

(edited)

its important tho

11:53

normal skins must be mirrored in community directory too

11:53

anyway im off now, @deen see pr if not mirrored, but maybe its just cloudflare again

@Jupstar ✪ let me clear that

11:54

mirrored how?

uhd community

11:54

and community/uhd also contain the normal skins

11:55

bcs else the skindownload wont download those

ok, done

perfect thanks

[ddnet/ddnet] Pull request opened: #5398 implement tuning values for elasticity

Similar to https://github.com/teeworlds/teeworlds/pull/3136 closes #5124 can be followed up by #5313 with a "slimey block", see here

Checklist

[x] Tested the change ingame
[ ] ~Provided screenshots if it is a visual change~ NO VISUALS
[x] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[x] Considered possib...

@deen pls make release_date=DESC as default in skin database

@Jupstar ✪ ^

i leave this decision to database crew, i think as its now was default before

[ddnet/ddnet] Pull request opened: #5399 Use nullptr in generated and editor

There is currently 0, 0x0, NULL and nullptr mixed in the code. The flag -Wzero-as-null-pointer-constant suggests to use nullptr. It is in a zillion places so I started with the editor.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out...

how to know in the code which gamemode you're in?

16:07

preferably in a hud component

https://github.com/ddnet/ddnet/blob/ae1876d1414cb013554db3ed839425a9647a4fc2/src/game/client/components/mapimages.cpp#L166-L183 smth like this

ddnet/mapimages.cpp at ae1876d1414cb013554db3ed839425a9647a4fc2 · d...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/mapimages.cpp at ae1876d1414cb013554db3ed839425a9647a4fc2 · ddnet/ddnet

16:08

i think gameinfo contains all stuff u need

i don't get it, it asks which entities are there and then decides it's the corresponding gametype?

forget the entities

16:12

it also contains booleans i think

16:12

IsFNG or smth like that

xd

there's also information when you go to server info. on the right it tells you gametype. is it json from the server or is it from the gamecode?

16:14

maybe i can reuse this

16:19

Localize("Game type"), CurrentServerInfo.m_aGameType, is that accessible anywhere in the huds?

i imagine the fng HUD would be something like this

Image attachment

16:23

having less needed DDNET entities, it would be rather minimal and would use numbers in its place. though that would involve a lot more calculation so

yeah i also thought about kill counter

16:24

and combo nice too

you mean numbers for counting down freeze instead of shields?

i mean i was thinking it would be a bar but that would have to include a bit of a rehaul? of the code

Does ddnet have a person for graphic-design and game-sounds? I could do that myself but my results are most of the time only functional

voxel and mind added graphics for the svg repo ravie did the new hud iirc louis did his entities for sound, not that i am aware of

16:42

a new background theme would be nice, so it doesnt sound so cheap xD

16:42

(l like that theme, but realisticly its not really "awesome" xD)

I want to start creating the first material drafts and one issue is the bouncy slime material. I thought that I maybe want to add a sound for it

i know pipou does sounds, i do sounds also but we've never had a need for it

Jupstar ✪

voxel and mind added graphics for the svg repo ravie did the new hud iirc louis did his entities for sound, not that i am aware of

teetow (an og tw dev) did explain how the sounds were made

go ahead

16:46

im interested

theres an image of it lurking around the wiki

16:46

let me get it

16:47

Image attachment

poggers

1

1

ok, the PET bottle was OG

16:48

how the fuck xD

no idea, that's all i got XD

16:49

and tbh it seems like teetow is completely distanced from tw dev so i don't want to force too much out

can you record sounds with audacity? Creating the sounds from a technical POV is not the problem

AssassinTee

can you record sounds with audacity? Creating the sounds from a technical POV is not the problem

if you have a microphone? yes

if u have a good microphone

16:50

good sound design is probs hard

16:50

so much real world factors that annoys u

AssassinTee

I want to start creating the first material drafts and one issue is the bouncy slime material. I thought that I maybe want to add a sound for it

for the slime thing yeah we'd probably need a sound for bouncing + hooking it if it got added i offered to make it in one of the github issues, but shouldnt be too complicated so either of us could do it

hooking it

So i slap some spaghetti?

what about add feature that u can see which CP u have? sometimes is very usefull

AssassinTee

hooking it

So i slap some spaghetti?

basically or scrunch a wet shirt

eww sounds good

Jupstar ✪

a new background theme would be nice, so it doesnt sound so cheap xD

i do have a friend who makes some really good music! i could ask him if wants to think up of something

idk if we need new menu music

16:55

tw does'nt really have a central theme or central game

16:55

map unique music is the way to go imo

16:56

lol imagine if tw had random mellow music like minecraft

LOL

but every good game has this one menu theme

16:56

u know

lets add random cave sounds to tw

vote insane map boss music starts playing

https://www.youtube.com/watch?v=fI5AcN6eOSw

Video Games Music

Menu 1 - Super Smash Bros. Melee

16:56

this in tw

16:56

and gg

16:57

we just need few nintendo music designers around here

16:57

make ddnet great in japan

16:59

lmao, hearing any smash bros theme before playing fng would be insane instant competitive

ok lets form a band and record a theme

thats the spirit

17:00

teeworlds band

Jupstar ✪

https://www.youtube.com/watch?v=fI5AcN6eOSw

https://www.youtube.com/watch?v=azbvol2FdMA

One Winged Angel (super smash bros ultimate: Sephiroth Theme)

17:00

greenthing

xD hear complete killer music, and then see these cute rainbow skins

tw starts with the most banger music ever and then you join a map and ddnet_lgbt

ddnet_lgbt

is the first player you see

heartw

giftee_green

soundtrack would be dope tho, imagine maps get categorized into how difficult they are/how their design looks and random tracks play based on that

[ddnet/ddnet-web] Pull request opened: #194 Fix skinpack download link

louis

soundtrack would be dope tho, imagine maps get categorized into how difficult they are/how their design looks and random tracks play based on that

we would have to exclude maps that HAVE a track tho

yeah

@Ryozuki do you use the stable kernel on arch?

18:01

hm, though I remember you using a modern cpu, you might suffer less from it, but I've been noticing lately that electron apps absolutely wreck havoc with scheduling in the kernel

ye stable

18:03

im on a 5600x xD

How do electron apps feel for you?

what electron apps do u even use? XD

discord and spotify

discord always sucked for me, but i guess thats nothing suprising xd

electron apps the real stress test

Voxel

i mean i was thinking it would be a bar but that would have to include a bit of a rehaul? of the code

rehaul, idk i don't think so. a number counting down or shields or bar is not so different, i mean it's modular i think. but actually a number counting down would involve a lot of design i think. there are no number assets (edited)

If the CPU is busy e.g. compiling sth, and I have an electron app open it'll absolutely destroy the scheduler

if u dont clear the discord cache at least once in a month, its getting slower and slower xD

Jupstar ✪

if u dont clear the discord cache at least once in a month, its getting slower and slower xD

how to do that

i use it in browser

NT Kernel seems to handle this sort of stress much better, even it struggles with electron apps, but the rest of the system atleast keeps running even if the electron apps can freeze up

18:08

I was going to ask if any of you tried the pf or zen patchset, supposed to be better at providing responsiveness

nintendo sounds https://www.8bitpeoples.com/

i think i never had non responsive computer since i have my 8 cores

18:10

r u sure its not the GPU that struggles xd

How does renaming existing maps filename affects DDNet Server? I'm packaging ddnet maps, and some of them contain special characters which causes warning messages to be output. For example, Spüli.map from novice. Changing Spüli.map to Spuli.map changes nothing in the file's checksum. (edited)

18:33

Can't translate pathname
'usr/share/ddnet/data/types/novice/maps/Spüli.map' to UTF-8

is the output

@deen https://ddnet.tw/maps/?json=Stronghold the json thing seems broken, haven't investigated though

wat is is supposed to show?

Ranks and mapinfo in json form

ou dats nice

19:15

but its not used for the discord bot or frontend is it?

c0d3d3v

this also looks kind of easy https://github.com/ddnet/ddnet/issues/3702

https://github.com/ddnet/ddnet/issues/3702#issuecomment-1153273344

19:47

i tried to solve this, but i think i have some linting issues or something. is there a script or a tool to fix the linting? so that it's the same with ddnet

@Jupstar ✪ thanks for improving the skindb :D

nvm i have found this: scripts/fix_style.py

cauldron

nvm i have found this: scripts/fix_style.py

I think you changed every newline, ending. You have to use LF instead of CRLF

okay, because fix_style.py didn't change anything

20:24

i think

you have to tell it visual studio or git

and then?

idealy both

how to relint

it is not linting

20:26

you changed every lineending

20:27

https://www.cylindric.net/git/force-lf

Force Git to use LF everywhere | Grav

My Grav Site

git config --global core.autocrlf false

20:27

i got this, but i'm checking for visual studio

I think git will be enough

20:31

It was probably git that changed it to crlf

okay, i hope

20:34

when i now type git status should all files be changed? because they are not

20:34

after i did git checkout-index --force --all

[ddnet/ddnet] Issue opened: #5400 Shortcuts for adjusting tile data in editor

It's incredibly hard to make the types of fun maps I want to create in DDrace with the current editor. I need to frequently use around half of the available switch/tele numbers and always placing them one by one, even with the F shortcut is a pain. I think the editor would benefit greatly by some sort of shift-scroll to bulk adjust numbers. So if you're holding 2,3,4 from tele, scrolling up would cause the brush to become 3,4,5.

1

This is also just a huge QOL feature for normal map making. Either I'm unaware of a shortcut for "focusing" the Tele button or the best current way is to move your mouse, click, and then press F (which is also not always what you want if a destination already exists)

20:43

Pressing F also does not collapse the Tele popup which is a bit annoying, but it wouldn't exactly be expected behavior either. I think it's just my preference for F to collapse it, but I think esc works anyway

20:44

We could also discuss other shortcuts, like "Populate all game layers" which adds every type of Game layer to a group (which could arguably exclude the sound layer since many maps don't make use of it)

1

20:45

Skips the need to run through them all if you expect to use every single layer

20:45

There is still the cascading issue with highlighting multiple layers and making adjustments to the group, but it's already an issue in GitHub

20:46

Tile/quad layer should probably not be populated as well. I suppose a better name for this then would be "Populate entity layers"

20:46

available from the group context menu

20:48

found another issue with ui_scale 105 lol

20:48

the list continues

Image attachment

@Yoydex please be constructive

ya i also mentioned it's good for normal map making, not sure that it's crying_wah.gif worthy

ok next time

heinrich5991

@Yoydex please be constructive

if you want to remove ui_scale it's fine. I just think it makes the UI a bit more clickable at 1080

20:50

that's why i use it

20:50

none of the issues really bother me with 105, since i can still make use of the UI that way, but no doubt i would be using something higher if i could

so have fun @heinrich5991

c0d3d3v

I think you changed every newline, ending. You have to use LF instead of CRLF

haha i could fix it with a linux tool called dos2unix. i think i even found some windows line endings in some files xd

21:04

that were there before like in data/languages/hungarian.txt

21:07

but the build failed on github, idk why. i don't think it was because of the lineendings

[ddnet/ddnet] Pull request opened: #5401 Only show the scorelimit box in other mods than ddrace.

#3702 this issue. sorry for lots of commits, i don't know how to rebase.

Checklist

[x ] Tested the change ingame
[x ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or v...

[ddnet-web:master] 1 new commit

137c09e New features - def-

22:39

[ddnet-web:master] 1 new commit

612d160 formatting - def-

cauldron

git config --global core.autocrlf false

I still use autocrlf true on windows, I don't trust windows not to put their nasty CR everywhere

Learath2

I still use autocrlf true on windows, I don't trust windows not to put their nasty CR everywhere

i think i'll just try to stay on wsl as often as possible

22:59

i thought autocrlf false would prevent crlf line endings? or auto overwrite to lf

autocrlf to true and safecrlf to false

okay

Exported 241 message(s)