DDraceNetwork - developer

[ddnet/ddnet] Issue opened: #5294 Undetermined crash in nightly server build

Reported by @l-ouis on discord. It happens with a gore map when approaching some area in the map. Here's the crash report DDNet-Server_crash_log_101744_2022-05-31_18-09-30.txt I couldn't get anything from it, even with the parse_drmingw.shscript (only outputs ??:0)...

Theres something wrong with the shotgun pull prediction I think

04:56

after like the 3rd shot, the prediction is pretty messed up

04:57

(with high ping)

Because in the server there was a physic change in shotgun @deen

3

Hey sup

08:15

Do you guys have female friends?

def-

[ddnet/ddnet] Pull request closed: #5193 Optimize ellipsis calculation a bit

09:03

bors[bot]

[ddnet:master] 2 new commits

8c781f6 Add back compiler warnings on macOS (oops) - def- 45fbc62 Merge #5248 - bors[bot]

09:03

bors[bot]

[ddnet/ddnet] Pull request closed: #5248 Add back compiler warnings on macOS (oops)

heinrich5991

[ddnet/ddnet] Issue opened: #5295 Integration test script doesn't work for me

It doesn't launch the second client before the first one is closed or made windowed. Making it windowed from the start also fixes it. It's also a bit fishy that it relies on sleeps to make sure the client2 has started, the sleeps are barely enough for my computer. Arch Linux Linux 5.17.9-arch1-1 X11, window manager i3 4.20.1

heinrich5991

[ddnet/ddnet] Issue opened: #5296 Integration test script leaks memory

``` ================================================================= ==240823==ERROR: LeakSanitizer: detected memory leaks Direct leak of 419600 byte(s) in 11 object(s) allocated from: #0 0x55f071eb4bf9 (/home/u/git/ddnet/integration_test/DDNet+0x73cbf9) #1 0x55f072095462 (/home/u/git/ddnet/integration_test/DDNet+0x91d462) #2 0x55f0720837e5 (/home/u/git/ddnet/integration_test/DDNet+0x90b7e5) #3 0x55f07221e719 (/home/u/git/ddnet/integration_test/DDNet+0xaa6719) ...

cl_show_others what does this affect? doesnt seem to work for me

should have the same effect as /showothers, I think

heinrich5991

[ddnet/ddnet] Issue opened: #5297 Should we use forward-declarations in header files?

From https://github.com/ddnet/ddnet/pull/5276#discussion_r885413694:

Yeah, this change was not necessary if we want to optimize for compile time. All the changes were applied manually, but I initially configured the tool to not use forward declarations because it would have caused too many changes at once. Around 90% of the tool's implementation code seems to be for considering where forward declarations are better than includes. We could probably save quite a bit of compile time if we use...

heinrich5991

[ddnet/ddnet] Pull request opened: #5298 Fix integration test waiting for client to close

As described in #5295, the integration test script waits for the client to close before launching the next one. I don't know what causes this, but disabling full-screen mode works around the issue. I don't know if this is okay. @ChillerDragon? Fixes #5295.

Checklist

[x] Tested the change ~~ingame~~
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, s...

bors[bot]

[ddnet:master] 2 new commits

0914c12 add ellipsis again - C0D3D3V b623c3c Merge #5284 - bors[bot]

10:25

bors[bot]

[ddnet/ddnet] Pull request closed: #5284 add ellipsis again

bors[bot]

[ddnet:master] 5 new commits

2c04c00 Use color constants in color_hsv_to_windows_console_color - Robyt3 95f2449 Remove duplicate conditional expressions - Robyt3 2d7f67d Use current console background color, restore original color on exit - Robyt3 2a8b2ad Add locks to windows loggers - Robyt3 eab87e0 Merge #5291 - bors[bot]

10:43

bors[bot]

[ddnet/ddnet] Pull request closed: #5291 Windows: Use current console background color, restore original color on exit, refactoring

bors[bot]

[ddnet:master] 2 new commits

b3d8e05 Add valgrind to integration test - def- adcae2a Merge #5242 - bors[bot]

11:01

bors[bot]

[ddnet/ddnet] Pull request closed: #5242 Add valgrind to integration test

hello, i am setting up vscode for ddnet. what extensions do you use?

maybe @Learath2 or @Ryozuki use vscode?

I do, I'm about to move to vim tho

11:17

I only have the C/C++ extension pack from microsoft when working with ddnet

heinrich5991

[ddnet/ddnet] Issue closed: #4001 Use GithHub discussions for feature requests, ideas and improvements

11:20

heinrich5991

[ddnet/ddnet] Issue opened: #5299 Find some way to recover discussions, or at least the issues that were moved

See https://github.com/ddnet/ddnet/issues/4001#issuecomment-1143475281.

bors[bot]

[ddnet:master] 3 new commits

f9a05eb Add back compiler warnings on macOS (oops) - def- 174b855 Enable -Wthread-safety-negative (as suggested by Chairn) - def- 9dd46eb Merge #5260 - bors[bot]

11:34

bors[bot]

[ddnet/ddnet] Pull request closed: #5260 Pr thread safety negative

Robyt3

[ddnet/ddnet] Pull request opened: #5300 Refactoring: Replace CGameClient::CStack with std::vector

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--und...

vim with language server protocol? i want to use the "go to declaration" feature to jump to the implementation of a function. in particular i wanted to hack on the draw hookcoll function. but vscode only gives me hints when i hover code like the type of a variable. normally i use vim for small code snippets. but i fail at setting it up as an ide

i use vscodium

vscodium not an ide hollande

i used archlinux version of vscode now vscodium. when i ctlr click on a function nothing happens. or when i right click and then "go to implementation"

weird

learath im also interested in a working vim setup for ddnet

14:46

i use this and have 0 problems

i used clangd and "c/c++ themes" i think

14:48

i'll try the other stuff when i'm home

cauldron

learath im also interested in a working vim setup for ddnet

I haven't gotten one yet, so you'll have to wait on that, but @Ryozuki has a setup, you could ask him

cauldron

i used archlinux version of vscode now vscodium. when i ctlr click on a function nothing happens. or when i right click and then "go to implementation"

I only have the c++ pack my microsoft as I said and go to definition works fine for me

14:53

s/my/by/

^^

14:55

ok, do you use vscode by microsoft or vscodium?

cauldron

vim with language server protocol? i want to use the "go to declaration" feature to jump to the implementation of a function. in particular i wanted to hack on the draw hookcoll function. but vscode only gives me hints when i hover code like the type of a variable. normally i use vim for small code snippets. but i fail at setting it up as an ide

you need to use ctag to fasten search

def-

[ddnet/ddnet] Pull request closed: #5234 Enable cppcoreguidelines-pro-type-member-init

I use chad neovim that has native LSP support

15:38

I press gd over a function and i go to its definition

15:39

Check out nvim-lspconfig

Hey! I got segfault when touching the startline on Back in the days. Happened on latest master 9dd46eb. Here's a backtrace from the coredump. Don't know if it says anything, but I can send more if needed.

Core was generated by `./DDNet'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000563224f92cea in std::_Rb_tree_node<int>* std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy<std::_Rb_tree<int, int, std::_Identity<int>, st>
[Current thread is 1 (Thread 0x7f6cd717d980 (LWP 14588))]
(gdb) bt full
#0  0x0000563224f92cea in std::_Rb_tree_node<int>* std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy<std::_Rb_tree<int, int, std::_Identity<int>, st>
No symbol table info available.
#1  0x0000563224f9eb1b in CGameClient::IntersectCharacter(vector2_base<float>, vector2_base<float>, vector2_base<float>&, int) ()
No symbol table info available.
#2  0x0000563224f7c93f in CPlayers::RenderHookCollLine(CNetObj_Character const*, CNetObj_Character const*, int, float) ()
No symbol table info available.
#3  0x0000563224f0af98 in CGhost::OnRender() [clone .part.0] ()
No symbol table info available.
#4  0x0000563224f99192 in CGameClient::OnRender() ()
No symbol table info available.
#5  0x0000563224ea461c in CClient::Render() ()
No symbol table info available.
#6  0x0000563224ead4c8 in CClient::Run() ()
No symbol table info available.
#7  0x0000563224e3e60a in main ()
No symbol table info available.
(gdb)

Do any of you use any note taking software? I’m looking for something open source, cross platform(iOS) and with support for handwritten notes

furo

Hey! I got segfault when touching the startline on Back in the days. Happened on latest master 9dd46eb. Here's a backtrace from the coredump. Don't know if it says anything, but I can send more if needed.

Core was generated by `./DDNet'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000563224f92cea in std::_Rb_tree_node<int>* std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy<std::_Rb_tree<int, int, std::_Identity<int>, st>
[Current thread is 1 (Thread 0x7f6cd717d980 (LWP 14588))]
(gdb) bt full
#0  0x0000563224f92cea in std::_Rb_tree_node<int>* std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy<std::_Rb_tree<int, int, std::_Identity<int>, st>
No symbol table info available.
#1  0x0000563224f9eb1b in CGameClient::IntersectCharacter(vector2_base<float>, vector2_base<float>, vector2_base<float>&, int) ()
No symbol table info available.
#2  0x0000563224f7c93f in CPlayers::RenderHookCollLine(CNetObj_Character const*, CNetObj_Character const*, int, float) ()
No symbol table info available.
#3  0x0000563224f0af98 in CGhost::OnRender() [clone .part.0] ()
No symbol table info available.
#4  0x0000563224f99192 in CGameClient::OnRender() ()
No symbol table info available.
#5  0x0000563224ea461c in CClient::Render() ()
No symbol table info available.
#6  0x0000563224ead4c8 in CClient::Run() ()
No symbol table info available.
#7  0x0000563224e3e60a in main ()
No symbol table info available.
(gdb)

This backtrace smells a little fishy, I can't see how anything in IntersectCharacter can lead to a std::_Rb_tree::_M_copy happening

Learath2

Do any of you use any note taking software? I’m looking for something open source, cross platform(iOS) and with support for handwritten notes

Idk about handwrriten but i use obsidian

16:25

https://obsidian.md/

Obsidian

Obsidian: A knowledge base that works on local Markdown files.

Though, there aren't many things in the code that'd even be using an underlying std::_Rb_tree. It's almost definitely one of the std::sets

Ryozuki

https://obsidian.md/

This looks very nice and it seems to support handwritten notes too

Its the best

16:27

Hn recomnends it too

16:27

Well apparently it doesn't directly support them, but it can embed images, hm that is a little jank but I'm sure I can write a plugin to work around it

does obsidian also handle images?

@cauldron vscodium by default does not have all the extensions probably due to some libre filtering i use th aur package "code-marketplace" together with community/code to get the juicy ms c++ extensions

16:42

@Learath2 did you try paper?

Like actual paper? I'd like to browse and filter notes easily, very annoying with physical paper

yea

16:43

idk works for me. Guess you write much more

I don't write much, because I find it's annoying to manage paper notes. That's why I'm looking for something different

iOS lol

16:44

if you are fully sucked into the apple universe they probably have something

I only use an ipad because the competitors are several light years behind in tablets

or do you also need it to run on non apple systems?

I need it to run on my desktop which is linux

im sure ipads can run some nice apple pen supporting note apps

16:45

oh yikers

16:45

then u fked

16:45

vnc into your ipad from linux then hrhrhrhr

Obsidian seems to have a nice plugin for excalidraw and excalidraw supports apple pen, so all is good

@Jupstar ✪ got more hot stocks for me?

Zwelf

[ddnet/ddnet-web] Pull request opened: #191 Update teehistorian doc

With recent extension additions + document the update process a bit more.

I tried to build DDNet for android but I am getting this error cp: cannot stat 'build/outputs/bundle/release/DDNet-release.aab': No such file or directory

17:05

I tried to build it with ./scripts/android/cmake_android.sh arm64 DDNet Release

17:05

and I generated libs with ./scripts/compile_libs/gen_libs.sh ../tmp android and copied them to ddnet-libs in root dir

17:08

also when generating the libs I got cp: cannot stat 'compile_libs/png/build_android_arm/libpng16.a': No such file or directory cp: cannot stat 'compile_libs/png/build_android_arm64/libpng16.a': No such file or directory

Ryozuki

Idk about handwrriten but i use obsidian

Seems it’s not open source, how could you

Learath2

This backtrace smells a little fishy, I can't see how anything in IntersectCharacter can lead to a std::_Rb_tree::_M_copy happening

Hmm, do you want any other info? I have had it happen around 10 times now. All in the same spot.

furo

Hmm, do you want any other info? I have had it happen around 10 times now. All in the same spot.

If you can reproduce it, can you try with a full debug build?

Learath2

If you can reproduce it, can you try with a full debug build?

I had it compiled with -DCMAKE_BUILD_TYPE=Debug what else am I supposed to change/add?

Uh, why is the symbol table info missing then? :/

17:19

Hm, can you do readelf -S ./DDNet | grep -i debug

  [30] .debug_aranges    PROGBITS         0000000000000000  00387860
  [31] .debug_info       PROGBITS         0000000000000000  00387950
  [32] .debug_abbrev     PROGBITS         0000000000000000  00387ed3
  [33] .debug_line       PROGBITS         0000000000000000  0038804a
  [34] .debug_str        PROGBITS         0000000000000000  00388264
  [35] .debug_ranges     PROGBITS         0000000000000000  00388690

Okay, I’m confused. gdb ./DDNet does that load the symbol table properly?

Seems like it

Reading symbols from DDNet...
(gdb)

Maybe try getting it to crash within gdb, see if we get a better backtrace

Learath2

Maybe try getting it to crash within gdb, see if we get a better backtrace

gdb.log

55.39 KB

Aha, I see the issue now, there is a useless copy there. It probably reveals an underlying bug though

17:33

@c0d3d3v ^^ your new std::set is the culprit

17:34

@furo since you can reproduce, can you try a quick fix?

i think we should instantiate some std::set everywhere to detect more bugs

Ok, this copy is a very old bug, the trying to copy std::set is just revealing the issue

Learath2

@furo since you can reproduce, can you try a quick fix?

Don't think so, I don't even know where to begin. Sorry :/

Learath2

Seems it’s not open source, how could you

oh lol true, sadge

@furo nono I'll give the fix, I just want you to try it

https://github.com/obsidianmd/obsidian-releases i tought it was it xd

17:39

check this out https://github.com/zadam/trilium

GitHub - zadam/trilium: Build your personal knowledge base with Tri...

Build your personal knowledge base with Trilium Notes - GitHub - zadam/trilium: Build your personal knowledge base with Trilium Notes

Learath2

@furo nono I'll give the fix, I just want you to try it

Ah perfect, go ahead send whatever :D

https://logseq.com/

A privacy-first, open-source knowledge base

A privacy-first, open-source platform for knowledge management and collaboration.

@furo Try this please

test.patch

633 bytes

17:45

In the root folder where you are compiling from, you can just do patch -p1 < test.patch

Ryozuki

check this out https://github.com/zadam/trilium

unsupported macOS build, no iOS build, but the second one you sent looks exactly like what I need

Learath2

@furo Try this please

Seems to have worked, thanks :)

Yay

def-

[ddnet/ddnet-web] Pull request closed: #191 Update teehistorian doc

17:57

def-

[ddnet-web:master] 2 new commits

7ba8d2b Update teehistorian doc - Zwelf 35171f3 Merge pull request #191 from Zwelf/pr-update-th-doc - def-

17:58

Learath2

[ddnet/ddnet] Pull request opened: #5301 Avoid unnecessary copy leading to crash

Reported by kiwq#4737 on Discord. This issue was revealed by the addition of a std::set into CCharacterCore, I'm unsure why the copy constructor of std::set didn't work. It might be a good idea to check and see if there is a further underlying issue @C0D3D3V. Backtrace ```c++ #0 gnu_cxx::new_allocator<std::_Rb_tree_node >::construct (this=0x7fffffff95e8, p=0x555558935fd0) at /usr/include/c++/10.2/ext/new_allocator.h:150 No locals. #1 0x0000555555831100 in std::...

furo

Hey! I got segfault when touching the startline on Back in the days. Happened on latest master 9dd46eb. Here's a backtrace from the coredump. Don't know if it says anything, but I can send more if needed.

Core was generated by `./DDNet'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000563224f92cea in std::_Rb_tree_node<int>* std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy<std::_Rb_tree<int, int, std::_Identity<int>, st>
[Current thread is 1 (Thread 0x7f6cd717d980 (LWP 14588))]
(gdb) bt full
#0  0x0000563224f92cea in std::_Rb_tree_node<int>* std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy<std::_Rb_tree<int, int, std::_Identity<int>, st>
No symbol table info available.
#1  0x0000563224f9eb1b in CGameClient::IntersectCharacter(vector2_base<float>, vector2_base<float>, vector2_base<float>&, int) ()
No symbol table info available.
#2  0x0000563224f7c93f in CPlayers::RenderHookCollLine(CNetObj_Character const*, CNetObj_Character const*, int, float) ()
No symbol table info available.
#3  0x0000563224f0af98 in CGhost::OnRender() [clone .part.0] ()
No symbol table info available.
#4  0x0000563224f99192 in CGameClient::OnRender() ()
No symbol table info available.
#5  0x0000563224ea461c in CClient::Render() ()
No symbol table info available.
#6  0x0000563224ead4c8 in CClient::Run() ()
No symbol table info available.
#7  0x0000563224e3e60a in main ()
No symbol table info available.
(gdb)

o.O touching the startline is fine for me. Can you reproduce it multiple times?

Learath2

Ok, this copy is a very old bug, the trying to copy std::set is just revealing the issue

why can you not copy a set in C++?

copy shouldnt cause crash if there is no destructor

c0d3d3v

o.O touching the startline is fine for me. Can you reproduce it multiple times?

I think you need some players, I got it quite consistently on the crowded Back in the days server.

tho copying a std::set if not needed is reall ynot nice code style

18:11

its a heap object after all

The copy shouldn't be there either way. I didn't investigate what's actually broken

Learath2

The copy shouldn't be there either way. I didn't investigate what's actually broken

yes I also agree that it should not be there... xD but I'm curious whats the reason for a crash. I'm not so familiar with this kind of C++ concepts

probably a completly unrelated memory corruption somewhere else

18:15

use asan

18:15

and u will know

Jupstar ✪

probably a completly unrelated memory corruption somewhere else

I think so too

@furo if you have a minute can you try asan without the patch?

furo

I think you need some players, I got it quite consistently on the crowded Back in the days server.

maybe its a config? but if u can reproduce it, try to build with asan (ddnet github page tells you how)

You basicly have to run this in an empty build dir:

CC=clang CXX=clang++ CXXFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer" CFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer" cmake -DCMAKE_BUILD_TYPE=Debug .. && make -j$(nproc)

then you can start DDnet like this:

UBSAN_OPTIONS=log_path=./SAN:print_stacktrace=1:halt_on_errors=0 ASAN_OPTIONS=log_path=./SAN:print_stacktrace=1:check_initialization_order=1:detect_leaks=1:halt_on_errors=0 ./DDNet

Thats at least how I build and run with Asan @furo (edited)

@heinrich5991 why do chat messages no longer show up in server log?

ChillerDragon

[ddnet/ddnet] Issue opened: #5302 Chat messages not showing in server log

stalkerdragon is angry

yes

i think rn is no good time for new stock, wait 2 weeks

ok

nvidia will soon have new GPU reveal

i just bought some oil stonk warren buffet bought too

could buy now and sell directly after that reveal

reveal is priced in

as soon as AMD will show their GPUs at the end of the year it will probs drop again

xd

yeah AMD's 6950 is faster or around as fast as rtx 3090 so i assume nvidia pushes so fast bcs AMD can deliver smth similar

18:27

i mean nvidia wants to release a 600 watt GPU as customer GPU XD

18:27

that clearly says smth

i think they belive electricity will be free

its pretty free in summer

but in the summer i do not need an heater

around 3cents / kwh if u got a roof and some skill to install solar panels

pf

18:28

u wanna do some flips on my roof mr skill?

yes

nice