DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-05-31 00:00:00Z and 2022-06-01 00:00:00Z

kek

[ddnet/ddnet] Issue opened: #5282 16.1 Client crash in `std::clamp` call

From Discord:

[10:28 PM] Reteah: I have got quite a few crashes after updating to 16.1 client version. It aborts after complaining about an assertion error on a std::clamp call:

/usr/include/c++/12.1.0/bits/stl_algo.h:3623: constexpr const _Tp& std::clamp(const _Tp&, const _Tp&, const _Tp&) [with _Tp = int]: Assertion '!(hi < lo)' failed.

08:18

[ddnet/ddnet] Issue opened: #5283 Jump tile's switch number is ignored

From Discord:

2:25 AM] Skystrife: For a map if you use the tile to change the number of jumps a tee can have, that block cannot be toggled with a switch despite being in the switch layer, changing the switch number for it is useless [3:11 AM] Chairn: that's not a bug, that's by design [3:11 AM] Chairn: switch number is used to select number of jump [5:09 AM] Skystrife: the delay is used for th...

08:20

[ddnet:master] 2 new commits

3e60cd8 Time out for POST requests too (hopefully fixes #5198) - def- 760cb99 Merge #5271 - bors[bot]

08:20

[ddnet/ddnet] Issue closed: #5198 HTTP master registration post hangs on server shutdown

08:20

[ddnet/ddnet] Pull request closed: #5271 Time out for POST requests too (hopefully fixes #5198)

08:27

[ddnet/ddnet] Pull request closed: #5275 Remove info trace logging (fills up RUS server disk)

08:34

[ddnet/ddnet] Issue closed: #5278 Server keep reporting that they can't register

08:39

[ddnet:master] 2 new commits

38b2a8d Add loglevel config (fixes #5178, fixes #5174) - def- 4183ad6 Merge #5179 - bors[bot]

08:39

[ddnet/ddnet] Issue closed: #5178 Set log_level?

08:39

[ddnet/ddnet] Issue closed: #5174 Register output even when sv_register 0 is set

08:39

[ddnet/ddnet] Pull request closed: #5179 Add loglevel config (fixes #5178, fixes #5174)

[ddnet/ddnet] Pull request opened: #5284 add ellipsis again

!grafik !grafik @Jupeyy can you please test if this also decreases the fps significant more than without this PR?

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration ...

@Jupstar ✪ please try out my new PR for the ellipsis later

thanks

[ddnet/ddnet] Pull request opened: #5285 Fix clamp in CStun::Update (fixes #5282)

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

[ddnet/ddnet] Pull request closed: #5206 Do not use ELLIPSIS if the text fits anyway

12:26

[ddnet:master] 2 new commits

e31fa70 Fix clamp in CStun::Update (fixes #5282) - def- 369c217 Merge #5285 - bors[bot]

12:26

[ddnet/ddnet] Issue closed: #5282 16.1 Client crash in `std::clamp` call

12:26

[ddnet/ddnet] Pull request closed: #5285 Fix clamp in CStun::Update (fixes #5282)

If you need a cheap root server in germany for one month you can get this one https://www.netcup.de/bestellen/produkt.php?produkt=2885 for 0,49€ only today https://www.netcup.de/bestellen/gutschein_einloesen.php?gutschein=20EuroRabatt2022

netcup.de - Produktdetails

Webhosting, Server, Domains, Managementdienste, einfach alles fuer einen erfolgreichen Internetauftritt

netcup.de - Warenkorb

Webhosting, Server, Domains, Managementdienste, einfach alles fuer einen erfolgreichen Internetauftritt

thanks, I ordered one. maybe it'll be useful in some way

c0d3d3v

If you need a cheap root server in germany for one month you can get this one https://www.netcup.de/bestellen/produkt.php?produkt=2885 for 0,49€ only today https://www.netcup.de/bestellen/gutschein_einloesen.php?gutschein=20EuroRabatt2022

I cannot confirm that this works, you only seem to be able to cancel after two months

13:00

Produkt erstellt am: 31.05.2022 Kündigungsfrist: mindestens 31 Tage vor Ablauf der Mindestvertragslaufzeit Möglicher Kündigungstermin: (Wenn Kündigung heute zugestellt wird .) 30.07.2022

13:01

english: Product created on: 31.05.2022 Cancellation possible 31 days before end of the minimum contract length Possible cancellation (if cancelled today: 30.07.2022)

heinrich5991

english: Product created on: 31.05.2022 Cancellation possible 31 days before end of the minimum contract length Possible cancellation (if cancelled today: 30.07.2022)

I also fear this xD I just rented it...

c0d3d3v

I also fear this xD I just rented it...

I will try to cancel it via mail

you can cancel via your widerrufsrecht

13:11

in the customer control panel

heinrich5991

you can cancel via your widerrufsrecht

I just called them... they told that the system always adds one day so it does not think you would cancel the contract at the same day as you buy it. If you cancel at the same day via mail and tell them that you want to cancel for the 30.06.2022 it works, additionaly you could use the "Satisfaction guarantee" and get full price back after 30 days

[ddnet/ddnet] Pull request opened: #5286 Only show port forward message if there's a problem

Previously, it was always shown. Fixes #5203.

Checklist

[x] Tested the change ~~ingame~~
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https...

[ddnet/ddnet] Issue closed: #3666 HTTPS masters

[ddnet/ddnet] Pull request opened: #5287 Work around Windows's definition of `min`/`max`

This allows us to use std::min/std::max.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://g...

15:33

[ddnet/ddnet] Pull request opened: #5288 Remove outdated comment

The string comparison isn't actually done anymore, it's now done via a boolean flag.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UB...

15:37

[ddnet:master] 2 new commits

9da3f5c Only show port forward message if there's a problem - heinrich5991 dd9e0b0 Merge #5286 - bors[bot]

15:37

[ddnet/ddnet] Issue closed: #5203 HTTP master: Wrong portforward message

15:37

[ddnet/ddnet] Pull request closed: #5286 Only show port forward message if there's a problem

[ddnet/ddnet] Pull request opened: #5289 Add *.csv and *.json to .gitignore

Both file types are used in conjunction with the HTTPS master.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memch...

15:56

[ddnet/ddnet] Pull request opened: #5290 Don't output as much in normal STUN behavior

Log send errors with debug instead of error severity. They're normal in case a protocol stack isn't initialized supported by the host or if there's no route. Don't periodically retry STUN if successful. Trying again for each connection establishment is enough. Previously, it was re-requested every 10 minutes. Fixes #5273.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuratio...

16:01

[ddnet:master] 3 new commits

eb28232 Work around Windows's definition of min/max - heinrich5991 d0ff811 Remove outdated comment - heinrich5991 d32b223 Merge #5287 #5288 - bors[bot]

16:01

[ddnet/ddnet] Pull request closed: #5288 Remove outdated comment

16:01

[ddnet/ddnet] Pull request closed: #5287 Work around Windows's definition of `min`/`max`

16:04

[ddnet/ddnet] Pull request opened: #5291 Windows: Use current console background color, restore original color on exit, refactoring

Remember initial console foreground and background color.
Use the original background color with the message specific foreground color, so it looks better when the console background color isn't black.
Restore the initial console foreground and background color on exit instead of leaving the color be whatever was last used.
Refactoring: Replace numbers with color constants defined in wincon.h (https://github.com/wine-mirror/wine/blob/4312d209232c701b0b78d9f8b463917c989005c5/inclu...

I think the mess I made of the windows logger should be looked at again sometime

what mess did you make out of the windows logger?

Windows really wanted utf16 for some reason and I implemented it but it's not very correct, you might be running in mintty under windows which wants utf8 instead

16:11

The ad-hoc implementation of utf8 -> utf16 I made should probably be replaced with a winapi call too

16:13

I also doubt that it works well with output redirection

I see

[ddnet/ddnet] Issue opened: #5292 Use of Rust inside DDNet client/server

While implementing past pull requests like #5064 I've been thinking about implementing them using Rust instead of C++. Rust is a language targeting a similar audience as C++. It tries to completely rule out any memory unsafety and thread unsafety. I've used the language in the past for university assignments, hobby projects, projects related to DDNet such as https://github.com/heinrich5991/libtw2 and most recently also the DDNet HTTP masterserver ([src/mastersrv](https://github.com/ddnet/d...

Sticker

chillerdragon: can I recommend set -o errexit; set -o nounset; set -o pipefail to you?

16:41

also maybe mktemp -d

https://youtu.be/2XLZ4Z8LpEE?t=661

Using a 1930 Teletype as a Linux Terminal

16:50

lul

16:51

apt upgrade -y sue

sue

ReiTW

https://youtu.be/2XLZ4Z8LpEE?t=661

your computer is slow? No way, I think it is your monitor! My monitor? I have never heard that a monitor can be slow.... (edited)

[ddnet/ddnet] Pull request opened: #5293 Cleanup: Remove dead code, don't print datafile debug per default, remove misused static CUIRect

Remove dead (commented out) code.
Don't print detailed datafile log messages, unless the datafile specific DEBUG flag is set.
Use static int instead of static CUIRect as UI element ID.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of...

For what? (@heinrich5991)

heinrich5991#9827

also maybe mktemp -d

18:07

Also do you still need something regarding the integration test? I’m mobile -.-Check the integration_test/ directory there is logs of client and server.

[ddnet:master] 2 new commits

2c89008 Add *.csv and *.json to .gitignore - heinrich5991 22f4225 Merge #5289 - bors[bot]

18:54

[ddnet/ddnet] Pull request closed: #5289 Add *.csv and *.json to .gitignore

[ddnet:master] 6 new commits

71d47c3 Log send errors with debug instead of error severity - heinrich5991 92f27bd Don't periodically retry STUN if successful - heinrich5991 7f24922 Print auxiliary datafile log messages only when DEBUG flag set - Robyt3 7474ca2 Remove dead code - Robyt3 019c2fa Remove static CUIRect used as UI element ID - Robyt3 27ebe08 Merge #5290 #5293 - bors[bot]

19:13

[ddnet/ddnet] Pull request closed: #5293 Cleanup: Remove dead code, don't print datafile debug per default, remove misused static CUIRect

19:13

[ddnet/ddnet] Pull request closed: #5290 Don't output as much in normal STUN behavior

19:13

[ddnet/ddnet] Issue closed: #5273 Lot of STUN log

c0d3d3v

I just called them... they told that the system always adds one day so it does not think you would cancel the contract at the same day as you buy it. If you cancel at the same day via mail and tell them that you want to cancel for the 30.06.2022 it works, additionaly you could use the "Satisfaction guarantee" and get full price back after 30 days

bargain hunters...

just kidding, i think i pay way to much for my uberspace, while not using it so much

Exported 67 message(s)