DDraceNetwork - developer

Ryozuki 2022-05-27 06:47:56Z

06:47

06:49

wait is that your local machine? xd

nah xd

06:49

i just found this https://www.reddit.com/r/uptimeporn/

r/uptimeporn

omg

06:49

look at this

06:49

lmao

too much internet for you today

06:49

UPTIMEPORN

06:50

srsly xd

ye xd

lel

06:50

must be a old linux kernel then hrhrhr

06:50

uptimeporn is literally ppl saying "hey my system is outdated, hack me pls"

wasnt it possible to update the kernel without restarting

06:51

in some modern kernels

i mean arch does it doesnt it? but its no fun

06:51

if you do not reboot stuff breaks

idk if arch does iti

06:51

ah

06:51

you can do it

well everything the linux kernel shows up in my update and i do not reboot shit breaks

but you have to restart your programs

casual programs like systemd?

Other OSes probably combine the upgrade/restart into a single step. With Arch you can do the upgrade while continuing to use your computer and then restart things at your discretion.

06:52

You do actually have to restart programs on Arch after updating. Update your video drivers/Xorg, probably should restart your DE/WM. Update your kernel, have to restart the whole computer. It generally doesn't cause huge problems to not restart, but it's a good idea to do so ASAP to avoid weirdness.

I always end up in big trouble if i dont

6:53:35 up 2 min, 1 user, load average: 0.53, 0.34, 0.13

06:53

rebooted my server

@Jupstar ✪ are there docs on using ur android scripts? howto create and apk? If not pls add some :) https://github.com/chillerbot/chillerbot-ux/issues/107

CREATE CHILLERBOT APK???! · Issue #107 · chillerbot/chillerbot-ux

scripts/android

ah wow there is a readme!

07:24

good style

07:24

anyone elses github also loading forever?

07:25

new low

07:25

even the 500 page does not load xd

Robyt3

[ddnet/ddnet] Pull request closed: #5208 Use std::vector instead of sorted_array, remove base/tl/sorted_array.h

bors[bot]

[ddnet:master] 20 new commits

9b2f0fe Remove unused includes of base/tl/array.h and sorted_array.h - Robyt3 9dece94 Use std::vector<CMapNameItem> instead of sorted_array - Robyt3 97dd810 Use std::vector<CLanguage> instead of sorted_array - Robyt3 295c395 Use std::vector<CUISkin> instead of sorted_array - Robyt3 0032f6f Use std::vector<CCountryFlag> instead of sorted_array - Robyt3 662cb58 Use std::vector<CFilelistItem> instead of sorted_array - Robyt3 2ea0c49 Use std::vector<CCommand> instead of sorted_array - Robyt3 96c97d5 Use std::vector for assets menu list items instead of sorted_array - Robyt3 359093c Use std::vector<CDemoItem> instead of sorted_array - Robyt3 de23bf9 Use std::vector<CString> instead of sorted_array, improve string search - Robyt3 b24f318 Use std::vector<CFriendItem> instead of sorted_array - Robyt3 5cc76d2 Use std::vector<CGhostItem> instead of sorted_array - Robyt3 ae8f5e8 Use std::vector<CNameIndexed> instead of sorted_array - Robyt3 0859da7 Use std::vector<CSkin> instead of sorted_array - Robyt3 a76cdb2 Use std::vector<CDownloadSkin> instead of sorted_array - Robyt3 bea74f3 Remove base/tl/sorted_array.h - Robyt3 d0b5d09 Use emplace_back for CString - Robyt3 476af12 Use emplace_back for CCommand, fix member variable names - Robyt3 de1de5e Use emplace_back for CFriendItem - Robyt3 7348bf4 Merge #5246 - bors[bot]

09:18

bors[bot]

[ddnet/ddnet] Pull request closed: #5246 Use std::vector instead of sorted_array, remove base/tl/sorted_array.h

cauldron

i tested a 28 second demo. but will try the 1 hour demo tonight when i sleep

gles demo is in sync (with software render) (edited)

Robyt3

[ddnet/ddnet] Pull request opened: #5250 Add `CUI::CheckActiveItem`, preventing the UI from locking up

Port e98921593bf23886de32ffb2fce9b166a89d6c05 from upstream. Closes #1884. I can consistently reproduce the locked up UI according to @Jupeyy's description and can confirm that this PR fixes this behavior: >I think i found a way to reproduce it

press left & right mouse click (hold them) press F5 (refresh) now you cannot click anything anymore

Minor refactoring: use nullptr instead of 0 for UI active item.

Checklist

[X] Tested the change ingame
[ ] Provided ...

bors[bot]

[ddnet:master] 3 new commits

2b02bd4 Prevent lock of UI - Robyt3 b9c52f7 Use SetActiveItem(nullptr) instead of SetActiveItem(0) - Robyt3 309d18a Merge #5250 - bors[bot]

11:04

bors[bot]

[ddnet/ddnet] Issue closed: #1884 Unable to click any menu item

11:04

bors[bot]

[ddnet/ddnet] Pull request closed: #5250 Add `CUI::CheckActiveItem`, preventing the UI from locking up

AssassinTee created really cool features xD we need to win him for DDNet https://github.com/teeworlds/teeworlds/pulls/AssassinTee (edited)

Pull requests · teeworlds/teeworlds

A retro multiplayer shooter. Contribute to teeworlds/teeworlds development by creating an account on GitHub.

This guy is really into EMOTES

def-

[ddnet/ddnet] Issue opened: #5251 vulkan error: The device surface capabilities could not be fetched.

Reported by Jeremy on Discord:

[2022-05-26 17:30:19][vulkan]: vulkan error: The device surface capabilities could not be fetched.
[2022-05-26 17:30:19][assert]: /ddnet-source/src/engine/client/backend/vulkan/backend_vulkan.cpp(1127): The device surface capabilities could not be fetched.

TIL gdb script is the worst programming language

Jupeyy

[ddnet/ddnet] Issue closed: #5251 vulkan error: The device surface capabilities could not be fetched.

c0d3d3v

AssassinTee created really cool features xD we need to win him for DDNet https://github.com/teeworlds/teeworlds/pulls/AssassinTee (edited)

i sometimes see him around on ddnet

13:52

he always uses emojis in the issues xd

13:52

what do you think about, rendering the own team always last xD so that other team players do not cover the own team players? would add an extra loop in the players and nameplate renderer

idc tbh xD nothing speaks against it

14:02

there will be this one single guy somewhere, who uses otheralpha = 1 and be mad that this doesnt render as before xdd but if u dont talk about it this person does not exists xd

c0d3d3v

what do you think about, rendering the own team always last xD so that other team players do not cover the own team players? would add an extra loop in the players and nameplate renderer

thats completely dumb

14:04

ahj sorry

14:04

by last i thought u meant behind

14:04

ye then nvm shouldb egood

does someone know what the idea was for this code https://github.com/ddnet/ddnet/blob/309d18a3bf28110e8e4dc9ce574f8e60479186be/src/game/server/entities/dragger.cpp#L233-L238 I tracked it back all the way to the inital DDRace-Beta trunk merge https://github.com/ddnet/ddnet/commit/434b4aad86013871d072450506efc0d88a006f25 But I see no reason for it, at the time I refactored the draggers, I just left it in, because I had no Idea what it does

The Porting of DDRace-Beta to trunk by [BlackTee] den Maps with one...

…nd two layer works properly. Laser works. Fix second game layer Re-added logs Readded the rcon commands addvote and scoring system and time Fixed Weapons Signed-off-by: btd <bardadymchik@g...

ddnet/dragger.cpp at 309d18a3bf28110e8e4dc9ce574f8e60479186be · ddn...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/dragger.cpp at 309d18a3bf28110e8e4dc9ce574f8e60479186be · ddnet/ddnet

@cauldron btw its the video that is out of sync not the audio gonna think what could cause it, maybe frame drops are the reason or smth, maybe minfps would be needed, i'll try out some stuff

Robyt3

[ddnet/ddnet] Pull request opened: #5252 Use std::vector instead of array, remove base/tl/array.h, algorithm.h, allocator.h, range.h

Replaces all usages of array with std::vector. I adjusted variable names of variables I changed to use the v prefix. Not so in the editor however, as there are already many changes due to clang-tidy enforcing the use of for-each loops. This allows us to remove all remaining base/tl headers except threading.h. Clang-tidy now finds clang-analyzer-cplusplus.NewDelete (Use of memory after it is freed), which is also fixed here, though it appears to be a false-positive. Thi...

c0d3d3v

I'll just try that tomorrow and see where the server despairs xD

I tried to do the tests I announced yesterday xD ... But the server crashes on windows if a client connects even without anything else, @Tater could you test it pls

15:25

with the visual studio build

Jupstar ✪

@cauldron btw its the video that is out of sync not the audio gonna think what could cause it, maybe frame drops are the reason or smth, maybe minfps would be needed, i'll try out some stuff

for me it's solved. because gles, cpu works i just gave up trusting my gpu with mesa. but if you try out something i can render again. one more thought: could the delay be already saved in the demo? (edited)

no

15:40

i might have found smth

15:40

its also not related to your drivers

15:44

@heinrich5991

[2022-05-27 17:04:10][stun/6]: couldn't send stun request
[2022-05-27 17:04:42][stun/6]: couldn't send stun request
[2022-05-27 17:05:46][stun/6]: couldn't send stun request
[2022-05-27 17:07:54][stun/6]: couldn't send stun request
[2022-05-27 17:12:10][stun/6]: couldn't send stun request
[2022-05-27 17:13:39][stun/4]: got address: myip:36742
[2022-05-27 17:20:42][stun/6]: couldn't send stun request
[2022-05-27 17:23:39][stun/4]: got address: myip:36742
[2022-05-27 17:29:14][stun/6]: couldn't send stun request
[2022-05-27 17:33:39][stun/4]: got address: myip:36742
[2022-05-27 17:37:46][stun/6]: couldn't send stun request

why does this happen in demo player? does it also happen for http requests or what

O M G

15:44

WHY DOES CLAMG TIDY NOT ALLOW GOTO!?

1

15:44

goto is top10 underrated programming features

oh yeah

15:44

goto is best

PLS FIX

error: avoid using 'goto' for flow control [cppcoreguidelines-avoid-goto,-warnings-as-errors]

15:45

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

15:46

is there any programming language that can do "goto" and "eval" ?

c0d3d3v

I tried to do the tests I announced yesterday xD ... But the server crashes on windows if a client connects even without anything else, @Tater could you test it pls

what is it you wanted me to test?

15:49

running the game with cheat engine?

Jupeyy

[ddnet/ddnet] Pull request opened: #5253 Don't ever skip any frame

Fixes #5051 With the video recorder rework, start and ending video rendering waits for the graphics threads anyway, additionally we never skip a frame while videos are rendering, so these checks are not needed anymore. Basically like this !image Update (sets true) => frame starts(but is not finished) => next update (sets to true again, but video frame still not finished) => frame s...

@bencie test video rendering with please (as soon as the build is finished) https://github.com/ddnet/ddnet/actions/runs/2397541170

Don't ever skip any frame · ddnet/ddnet@d7cdc14

DDraceNetwork, a cooperative racing mod of Teeworlds - Don't ever skip any frame · ddnet/ddnet@d7cdc14

16:07

@cauldron u can also test ^, but for you it was less easy to reproduce

ChillerDragon: it allows gotos that jump strictly forward. In case your questino is serious: https://homepages.cwi.nl/~storm/teaching/reader/Dijkstra68.pdf

Jupstar ✪

@bencie test video rendering with please (as soon as the build is finished) https://github.com/ddnet/ddnet/actions/runs/2397541170

this version fixed the bug

bencie

this version fixed the bug

nice thanks for test

np

https://web.archive.org/web/20170717042242/https://www.cs.sjsu.edu/~mak/CS185C/KnuthStructuredProgrammingGoTo.pdf there are still good uses for goto, even beyond this column by knuth

error exists are a forward jump, so the cppcoreguidelines check allows them

16:27

exits*

I'm always okay with them when breaking out of nested loops and error handling. C/C++ just has no better way to do these imho

exceptions or functions with returns

I've already stated my distaste with exceptions before, and creating weird one-off functions just so you can use return and pretend it's not a goto is just a bad pattern imo

bors[bot]

[ddnet:master] 2 new commits

d7cdc14 Don't ever skip any frame - Jupeyy 6cae22f Merge #5253 - bors[bot]

16:43

bors[bot]

[ddnet/ddnet] Issue closed: #5051 Video rendering can be too fast

16:43

bors[bot]

[ddnet/ddnet] Pull request closed: #5253 Don't ever skip any frame

Tater

what is it you wanted me to test?

running the server and join

16:47

on windows

ok

Tater

ok

and debug the crash xD send the trace .... and so on xD

is it still crashing?

I tested the last CI build in my VM the server crashs if I join with a Client

I only have like 15 minutes right now but I can look at it more tomorrow if you still need

maybe I find another windows dev xD

16:53

or I setup a windows PC

Client doesn't seem to crash but the server does

yep

16:58

btw. I tested, speedhack on client. It does desync prediction, but the game seems to work quite good, probably because we have limits how far the client gametick evolves. at speed up by >= x100 the client starts dropping packes or thinks it looses conection, but if you reset it to ~x20 it starts syncing again

My desktop discord crashed and won't load ;-;

when add mouse cl_mouse_max_distance in control settings? a whee like inp_mousesens 1-400 (edited)

Naist

when add mouse cl_mouse_max_distance in control settings? a whee like inp_mousesens 1-400 (edited)

you could try implementing it

it is not that hard

ok

Tater

ok

latest master?

yes

there was a crash yesterday

17:00

ok

it looks like a similar crash to before?

yes

this time it's on the server though

crash yesterday too

oh ok

17:01

did we fix the std::set crash issue? (edited)

xD is it 82 or 83

c0d3d3v

you could try implementing it

it is not that hard

i cant

i am in my first year of study i only know open visual studio/idle

Naist

i cant

i am in my first year of study i only know open visual studio/idle

you could try to get into it... could be your first experience... it is really simple to add it but you will gain knowledge (edited)

numbering is probably wrong

17:04

but I guess 83 (edited)

last time I had to remove parts of the commit in order to get the crash to be useful

17:05

but it might be two seperate issues

we fixed part of it yesterday

17:05

on part in server, the other in client

hmm

but seems to be more

17:06

but thanks for the trace

yeah sure, I can't look at it anymore rn but hopefully you'll figure it out (edited)

yes thanks

have a nice evening

17:08

ah in the trace the clear function is listed xD so it is definitely 83

Jupstar ✪

@cauldron u can also test ^, but for you it was less easy to reproduce

ok, maybe

found it, it m_ReckoningCore and m_SendCore are mem_zeroed on character spwan

now, that i know i can render with cpu and it works i don't care anymore

cauldron

now, that i know i can render with cpu and it works i don't care anymore

but gpu is faster (I guess) (edited)

true

Robyt3

[ddnet/ddnet] Pull request opened: #5254 Fix ingame menu button behavior when holding mouse button

Fixes the following behavior: 1. Player is ingame and the ingame menu is opened with Esc 2. A mouse button is held down on one of the ingame menu buttons (e.g. the spectate button) 3. The ingame menu is closed without moving the mouse away from the button 4. The mouse button is released while ingame 5. The menu is opened again

Current behavior: The hovered button is immediately activated, as soon as the menu opens, due to the released mouse state being handled as a click.

-...

17:27

C0D3D3V

[ddnet/ddnet] Pull request opened: #5255 fix windows server crash on client spawn

The continuation to remove mem_zero over CCharacterCore.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](...

17:32

C0D3D3V

[ddnet/ddnet] Issue closed: #5230 .desktop file preview has no icon

Jupeyy

[ddnet/ddnet] Pull request opened: #5256 Use double for traffic calculations

fixes #5207 Not going to rewrite rn since it relies on normilization of the time. Hope this is enough, floats probs struggle with time_freq and time differences being so huge

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexi...

was it always the case, that if you open with Ctr+Shift+D the debug hud, that the traffic numbers getting really huge, before the next calculation. Just as if they would sum up all traffic till you open up the debug hud again (edited)

git bisect

Robyt3

[ddnet/ddnet] Pull request opened: #5257 Refactoring: Move CMenus::UseMouseButtons to CUI::SetEnabled, extract CRenderTools::RenderCursor

Adopt changes from upstream.

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddne...

bors[bot]

[ddnet:master] 2 new commits

d4b1bec Use double for traffic calculations - Jupeyy 862faa2 Merge #5256 - bors[bot]

18:37

bors[bot]

[ddnet/ddnet] Issue closed: #5207 sv_netlimit keeps causing "Stressing network" bans

18:37

bors[bot]

[ddnet/ddnet] Pull request closed: #5256 Use double for traffic calculations

bors[bot]

[ddnet:master] 6 new commits

a0a0fa1 Fix ingame menu buttons when mouse is held and released ingame - Robyt3 910f01c Fix ingame menu buttons when mouse is held ingame and released in menu - Robyt3 3193095 Only allow buttons to be become hot while the mouse is not pressed - Robyt3 caa23bc Move CMenus::UseMouseButtons to CUI::SetEnabled - Robyt3 fccfbd5 Extract CRenderTools::RenderCursor - Robyt3 59acac2 Merge #5254 #5257 - bors[bot]

18:51

bors[bot]

[ddnet/ddnet] Issue closed: #3560 Releasing a mouse button when entering the UI immediately results in a mouse click.

18:51

bors[bot]

[ddnet/ddnet] Issue closed: #5229 Disconnect "trap" when closing menu while disconnect button is clicked down.

18:51

bors[bot]

[ddnet/ddnet] Pull request closed: #5257 Refactoring: Move CMenus::UseMouseButtons to CUI::SetEnabled, extract CRenderTools::RenderCursor

C0D3D3V

[ddnet/ddnet] Issue opened: #5258 We somehow fixed the shotgun bug -> reintroduce it?

probably introduced by https://github.com/ddnet/ddnet/commit/6b497afba497c4e61d7d6d9940d63c97533917a3

@c0d3d3v are you bisecting sg bug?

you can try to

I just started

i have to water flowers, then eat, then i can do it. I don't feel like i wanna move on on my personal work tonight

okok

never bisected before, so i need to train this anyway

19:59

i believe 15.9.1 is the last stable version

xD "stable"

19:59

the last release is 16.1

i know, but we do not know since when sg bug is broken

and it worked in 16.0.3

oh

As I build my new HUD it worked

can it be the CCharacterCore mod

?

... we will see

When automation in fiscal administration goes wrong https://autoriteitpersoonsgegevens.nl/nl/nieuws/boete-belastingdienst-voor-zwarte-lijst-fsv

Boete Belastingdienst voor zwarte lijst FSV

C0D3D3V

[ddnet/ddnet] Issue closed: #3533 after 14 hours some bullets stopped moving and my grenades don't rotate

what's a map i can use to test sg bug?

21:01

well Stacked looks nice

xD just make a map with no collision and a shotgun

im too lazy

21:03

and im bad mapper

I send you mine one moment

pfff, i got potato pc, compiling so slow

21:03

nah, i'll use stacked with cheats

21:03

its fine

I already tested 344eeaf8aa988bdc030254c7d6e5477bfb646e81 there it still works

21:05

stack.map

688 bytes

21:06

I now test 03f95108b4c39446b209d29114d2982875ab7732 from before 3 days

lol, rcon console looks completely buggy when using a dummy

works too

i didn't rebuild everything, maybe that's why

yes

21:10

now testing 3b81157013b2c2e8b67ef2fffab755912cb29f5f https://github.com/ddnet/ddnet/commit/3b81157013b2c2e8b67ef2fffab755912cb29f5f

Merge #5231 · ddnet/ddnet@3b81157

5231: Fix windows crash r=def- a=C0D3D3V Fixes #5226 I tested it in a Windows VM. @sjrc6 is it correct that TempCore is this way zero initialized, can you check that maybe in the debugger?...

21:10

so last before 2 days

for me class() calls default constructor which does nothing in our case

21:11

so data is NOT zero initialized

21:11

note that behavior changed in c++11

Chairn

When automation in fiscal administration goes wrong https://autoriteitpersoonsgegevens.nl/nl/nieuws/boete-belastingdienst-voor-zwarte-lijst-fsv

You read dutch news gigachad

nah, i found something in frnech with this as source

21:13

story is fucked up

Yeah it is

c0d3d3v

now testing 3b81157013b2c2e8b67ef2fffab755912cb29f5f https://github.com/ddnet/ddnet/commit/3b81157013b2c2e8b67ef2fffab755912cb29f5f

xD bad commit xD crashs the game

what's dummy fly bind?

Funfact the dutch government never apologied or acknowledge that they were wrong until the story was so big that they had no other option to say that misstakes were made. Still no apologies tho

Chairn

what's dummy fly bind?

normal dummy fly?

nah, i'd like to trigger dummy to shoot once, whatever weapon he has

+toggle cl_dummy_hammer 1 0 this will shot once at you but only if you do not hold to long the mouse button

i tried, ddin't work

21:19

okay, i inverted 1 and 0

in 4ec67b84f5865c500a99013f6dd50582dd342fdb the sg bug still works

Chairn

nah, i'd like to trigger dummy to shoot once, whatever weapon he has

Cl_dummy_fire?

works too but then it will not aim on you

21:23

in aa5471f98d5fa76c91ff41e14e3bf02d2e6ca5c6 it does no longer work

21:25

so introduced by one of these

uh? it only changes prediction code, not real physic

the commits in between are basicly untestable because all of them leed to crashes xD

21:32

ah I have a guess

21:32

the math change https://github.com/ddnet/ddnet/commit/68bcd21eff9fbace8605eec8122f860499e03c21

asan+ubsan clean · ddnet/ddnet@68bcd21

21:34

xD yes looks like potential for UB before

21:35

I vote for keeping the correct math ^^ and do not divide by 0 ^^

division by 0 is not UB...

21:36

only for integer, not for floating points

it is converted ... to nan

it should not

and then to int

21:36

that was known before

oh

deen just forgot it

okay, that's probably UB

I tested the commit one before that, and it the bug worked... I now revert the math in latest and test it

okay, its defintely UB

21:39

https://stackoverflow.com/a/10366541

Problems casting NAN floats to int

Ignoring why I would want to do this, the 754 IEEE fp standard doesn't define the behavior for the following: float h = NAN; printf("%x %d\n", (int)h, (int)h); Gives: 80000000 -2147483648 Basic...

21:39

now, we gotta see what value is inserted if we wanna keep the bug

21:39

and we should keep it obviously

21:39

because it's not a bug, it's a feature

mh yes I will debug and add it to the sg logic

Bisecting: 29 revisions left to test after this (roughly 5 steps) my pc so slow

xD what is that

21:41

feature form git?

yeha, git bisect

21:41

you didn't use that

? (edited)

I send you the hashs of the commits I tested... first picked the last before 3 days... then the last before 2 then 1 and it was inbetween the last 2 xD

21:43

ah one extra because I wanted to know if it was one of my change ^^ that was not neccessery

21:44

git checkout 05efc25f328ff7c652449f5180b9c8727e51c294 && cd .. && rm build -rf && mkdir build && cd build && CC=clang CXX=clang++ CXXFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer" CFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer" cmake -DCMAKE_BUILD_TYPE=Debug .. && make -j$(nproc) I used something like that to build xD

uh, i dont redo cmake, it's handled by make

21:45

or ninja

21:45

but i do clean and rebuild all

21:46

the answer below in stackoverflow says that intel processor returns 0x80000000 when converting floats to integer

that was probably a merge error before xD

oh lol

21:49

what git blame says?

https://github.com/ddnet/ddnet/commit/5d0bb4cf3c9fede8247f37da31e45d291dac9f7e

Backport vector functions cleanup from the upstream · ddnet/ddnet@5...

Keep closest_point_on_line() as-is. (commit 6b69f94dc8601050d727feaeb6aac7d999e9f19c)

UB = unintentional behaviour?

yes

21:50

no

21:50

undefined*

Ah

it is not specified by the c++ spec what should happen

Undefined Behabior

so something happens, and most of the time you also do not want to let that happen

it means the compiler is free to do whatever it wants

21:51

so it could as well try to make a coffee while you try to debug

I see

Can confirm with broken math, sg bug works

Bisecting: 0 revisions left to test after this (roughly 0 steps)final build

xD you can not run that commit anyway... it introduced a crash

you don't even know what commit im building

21:54

i had no crash for now

true

looks like git bisect tries merge commit first (edited)

21:55

then it delves into the remaining commits to find the guilty one, using dichotomy

21:56

68bcd21eff9fbace8605eec8122f860499e03c21 is the first bad commit
commit 68bcd21eff9fbace8605eec8122f860499e03c21
Author: Dennis Felsing <dennis@felsin9.de>
Date:   Thu May 26 01:22:14 2022 +0200

    asan+ubsan clean

:040000 040000 c2a05ed35a2813cf52fb342fec10feccff5c2f4c 777420887b27ed36ba256603dc2b8736563e4c00 M      scripts
:040000 040000 9b4332345d8861463c081da7bb45c552e3baddf4 ce94f0ab3e0d532ce47c86263c5f4a093e6d5a13 M      src

so normalize returns nan, ClampVel just keeps it because it can not compare with ints, so pHit->Core()->m_Vel just gets nan

22:01

this will then probably go through the complete core, till the charactercore is quantiziesed using ints

what is scary is that normalize_pre_length has been wrong for more than a year now

not wrong, just unneccery lines

22:04

but division by 0 is wrong xD

ah no

22:05

the guy just swapped function order which confuses git

22:06

just as I guessed

22:07

so min_int is our magic number I would guess (edited)

this probably yield 0

22:07

m_vel is -max_int so *256 is 0

22:08

ah never mind

22:09

easiest fix is either round_to_int or fix vmath.h

I just add our magix number to laser logic

22:10

@Jupstar ✪ also agreed on this before

22:10

remove UB and add magic number

ok

22:12

CLaser::HitCharacter i think

yes

im tyring to get familiar with server side code

I think a simple From == At is enough

C0D3D3V

[ddnet/ddnet] Pull request opened: #5259 reintroduce shotgun bug

fixes #5258 bug got fixed by the math changes in https://github.com/ddnet/ddnet/commit/68bcd21eff9fbace8605eec8122f860499e03c21 This fix introduces a hard coded velocity that the player would get like before. We could now make this bug optional, by adding it to our mapbugs, or adding a server setting for it.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[...

bors[bot]

[ddnet:master] 2 new commits

55671e4 fix windows server crash on client spawn - C0D3D3V 4b3b093 Merge #5255 - bors[bot]

23:23

bors[bot]

[ddnet/ddnet] Pull request closed: #5255 fix windows server crash on client spawn

bors[bot]

[ddnet/ddnet] Issue closed: #5258 We somehow fixed the shotgun bug -> reintroduce it?

23:41

bors[bot]

[ddnet:master] 2 new commits

04f1bbf reintroduce shotgun bug - C0D3D3V ce9b16d Merge #5259 - bors[bot]

23:41

bors[bot]

[ddnet/ddnet] Pull request closed: #5259 reintroduce shotgun bug

@heinrich5991 i was playing with compiler flags once again and it got me this (using clang)

../src/base/tl/threading.h:48:32: warning: acquiring mutex 'm_Lock' requires negative capability '!m_Lock' [-Wthread-safety-negative]
../src/engine/client/serverbrowser_http.cpp:136:2: warning: acquiring mutex 'm_Lock' requires negative capability '!m_Lock' [-Wthread-safety-negative]
../src/engine/client/serverbrowser_http.cpp:178:3: warning: acquiring mutex 'm_Lock' requires negative capability '!m_Lock' [-Wthread-safety-negative]
../src/engine/client/updater.cpp:115:2: warning: acquiring mutex 'm_Lock' requires negative capability '!m_Lock' [-Wthread-safety-negative]
../src/engine/client/updater.cpp:122:2: warning: acquiring mutex 'm_Lock' requires negative capability '!m_Lock' [-Wthread-safety-negative]
../src/engine/client/updater.cpp:130:2: warning: acquiring mutex 'm_Lock' requires negative capability '!m_Lock' [-Wthread-safety-negative]
../src/engine/client/updater.cpp:137:2: warning: acquiring mutex 'm_Lock' requires negative capability '!m_Lock' [-Wthread-safety-negative]
../src/engine/client/video.cpp:465:5: warning: acquiring mutex 'g_WriteLock' requires negative capability '!g_WriteLock' [-Wthread-safety-negative]
../src/engine/client/video.cpp:545:5: warning: acquiring mutex 'g_WriteLock' requires negative capability '!g_WriteLock' [-Wthread-safety-negative]
../src/engine/shared/jobs.cpp:57:3: warning: acquiring mutex 'pPool->m_Lock' requires negative capability '!pPool->m_Lock' [-Wthread-safety-negative]
../src/engine/shared/jobs.cpp:99:2: warning: acquiring mutex 'm_Lock' requires negative capability '!m_Lock' [-Wthread-safety-negative]

is this a false positive? (edited)

Link for context: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#negative

23:56

We'll most likely need to add some REQUIRES(!m_Lock)