Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2022-05-23 00:00:00Z and 2022-05-24 00:00:00Z
Avatar
lynn 2022-05-23 02:09:08Z
hey is there an API for ddnet.tw?
02:09
i think someone said there was one at one point but it was either never fully working/shut down
Avatar
chillerdragon BOT 2022-05-23 05:34:53Z
API for what
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 06:08:48Z
Wasn't there some CPU optimization for idle ddnet servers? Like skip some thing when the server is empty. What was it? And where in da code
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 06:26:03Z
i think i found it https://github.com/ddnet/ddnet/commit/948197b598bab07d111abc62e74dce980f68b1c9
Only wake up server once every second if noone is connected anyway ...
Thumbnail
Avatar
GitHub BOT 2022-05-23 06:33:09Z
Author icon
ChillerDragon
[ddnet/ddnet] Pull request opened: #5196 Break early out of loop
Avatar
GitHub BOT 2022-05-23 07:31:31Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
76efcc6 Fix 0 byte malloc in register.cpp (fixes #5187) - def- 847454f Merge #5189 - bors[bot]
07:31
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #5187 Clang-tidy: malloc 0 bytes in register.cpp
07:31
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5189 Fix 0 byte malloc in register.cpp (fixes #5187)
Avatar
GitHub BOT 2022-05-23 07:45:38Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
e54f0ee Break early out of loop - ChillerDragon 064dc2c Merge #5196 - bors[bot]
07:45
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5196 Break early out of loop
Avatar
GitHub BOT 2022-05-23 08:34:59Z
Author icon
def-
[ddnet/ddnet] Issue closed: #4344 in-game menu buttons can be activated if you hold mouse1 before pressing ESC
Avatar
c0d3d3v 2022-05-23 08:42:21Z
The rule for net objects if you set validate_size=False: "Can't use members that need validation in a struct whose size isn't validated" seems a bit unnecessary, because NetIntRange is the only member type that emits a validation function, and that is only "ClampInt". :/ @fokkonaut you wished that I move the display data in DDNetCharacter, ... so should I change NetIntRange of m_Jumps and m_StrongWeakID to NetIntAny?
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 09:52:53Z
@Jupstar ✪ im procrastinating merge since days now due to ur fakin c++ overlord MÜKROSECONDOS code
09:53
constexpr auto = &std::time::using::chrono::seconds::in_micro::Microseconds(std::chrono::OneSecond() * std::numbers::Number(1));
🤣 1
09:54
watafaka
09:55
whats even the benefit of that? thread_sleep(int seconds) was so simple and readable
Avatar
Avatar
[quakenet] ChillerDragon
i think i found it https://github.com/ddnet/ddnet/commit/948197b598bab07d111abc62e74dce980f68b1c9
AssassinTee 2022-05-23 09:56:30Z
I am pretty sure the compiler optimizes this, but there is a break missing :p
Avatar
GitHub BOT 2022-05-23 10:18:36Z
Author icon
C0D3D3V
[ddnet/ddnet] Pull request opened: #5197 do not render freezebar if you are not freezed
Improves the freezebar a little bit, because this way it is not unnecessarily displayed empty. https://youtu.be/IybuY5QYUDg

Checklist

  • [x] Tested the change ingame
  • [x] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [x] Considered possible null pointers and out of bounds array indexing
  • [x] Changed no physics that affect existing maps
...
Avatar
Avatar
[quakenet] ChillerDragon
constexpr auto = &std::time::using::chrono::seconds::in_micro::Microseconds(std::chrono::OneSecond() * std::numbers::Number(1));
c0d3d3v 2022-05-23 10:23:59Z
way to verbose
Avatar
Avatar
lynn
hey is there an API for ddnet.tw?
c0d3d3v 2022-05-23 10:27:27Z
what api do you need?
Avatar
lynn 2022-05-23 10:30:06Z
im asking for a friend, but they need access to profile + map data
Avatar
Avatar
c0d3d3v
what api do you need?
lynn 2022-05-23 10:30:18Z
oops forgot ping
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 10:31:32Z
just dl the database and write sql queries then
Avatar
Avatar
lynn
oops forgot ping
c0d3d3v 2022-05-23 10:34:03Z
maybe this https://ddnet.tw/stats/sql.js/ or download it from here https://ddnet.tw/stats/
Avatar
Avatar
lynn
im asking for a friend, but they need access to profile + map data
deen 2022-05-23 10:35:39Z
https://ddnet.tw/players/?json2=deen and https://ddnet.tw/maps/?json=Adrenaline%203
lynnyaLove 1
Avatar
lynn 2022-05-23 10:36:06Z
perfect, thank you
10:36
im assuming there are no limits enforced here? other than whatever can be provided by the website load time
10:37
this would be used by a Discord bot fyi
Avatar
deen 2022-05-23 10:37:02Z
if you want to scrape all, be nice and wait a bit inbetween
10:37
otherwise fine
Avatar
lynn 2022-05-23 10:37:12Z
gotcha, thought so
10:37
thanks for your help both
Avatar
GitHub BOT 2022-05-23 10:39:39Z
Author icon
def-
[ddnet-web:master] 1 new commit
d33325b Add json svg - def-
Avatar
Avatar
c0d3d3v
The rule for net objects if you set validate_size=False: "Can't use members that need validation in a struct whose size isn't validated" seems a bit unnecessary, because NetIntRange is the only member type that emits a validation function, and that is only "ClampInt". :/ @fokkonaut you wished that I move the display data in DDNetCharacter, ... so should I change NetIntRange of m_Jumps and m_StrongWeakID to NetIntAny?
fokkonaut 2022-05-23 10:44:23Z
Well, I really thought u can just add a variable? That definitely happened earlier
10:48
@heinrich5991 ?
Avatar
Avatar
fokkonaut
Well, I really thought u can just add a variable? That definitely happened earlier
c0d3d3v 2022-05-23 10:50:51Z
we probably can... but not with NetIntRange currently
Avatar
fokkonaut 2022-05-23 10:52:00Z
So what would be your approach?
10:52
changing them to Any?
Avatar
c0d3d3v 2022-05-23 10:56:25Z
that would be an option, and just do not use clamp at all for these 3 variables, or we remove the rule (edited)
Avatar
GitHub BOT 2022-05-23 11:00:18Z
Author icon
def-
[ddnet/ddnet] Issue opened: #5198 MySQL connection stayed stuck for hours
[2022-05-22 23:31:02][mysql]: can't deinitialize, connections remaining: 2 @Zwelf Can we get more info about why it's hanging? There were no further errors printed relating to sql
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 11:06:02Z
i implemented python in bash just for trols :D
😄 1
11:06
Embedded image
Avatar
c0d3d3v 2022-05-23 11:06:52Z
rofl
11:07
not real python syntax, but nice
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 11:08:56Z
ah fak
11:08
wat i miss?
11:09
my python is rusty
11:09
ah damn parenthesis. iv been writing to much ruby latley
11:12
Embedded image
11:12
better?
11:12
oops now i leaked my internals xd
11:12
im def not using eval
Avatar
k2d222 2022-05-23 11:13:50Z
we don't talk about the forbidden function
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 11:14:01Z
hrhrhr
11:14
evil is top10 underrated programming features
11:14
eval*
11:14
xd
11:15
ok so nextup is inline c
11:18
ok that was too easy xd
11:18
i might actually use that :D
Avatar
arch1t3cht 2022-05-23 11:25:43Z
https://xon.sh/
The Xonsh Shell — Python-powered shell
The xonsh shell is a Python-powered, cross-platform, Unix-gazing shell language and command prompt.
Thumbnail
11:26
This is actually a thing
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 11:35:55Z
ou i would use that if i were a python fan
11:35
but im bash fan so...
11:36
why would one do a while(0) loop? xd
11:36
https://github.com/bminor/bash/blob/9439ce094c9aa7557a9d53ac7b412a23aa66e36b/variables.c#L1188-L1194
bash/variables.c at 9439ce094c9aa7557a9d53ac7b412a23aa66e36b · bmin...
Unofficial mirror of bash repository. Updated daily. - bash/variables.c at 9439ce094c9aa7557a9d53ac7b412a23aa66e36b · bminor/bash
Thumbnail
11:37
does c not have unnamed scopes?
11:37
yea no i dont get it xd
11:38
@Jupstar ✪ btw i sold amd again thanks for a 15% gain
Avatar
Avatar
[quakenet] ChillerDragon
does c not have unnamed scopes?
k2d222 2022-05-23 11:39:24Z
to write your macro like a function MY_MACRO(x, y); with a semi at the end
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 11:39:46Z
ou
11:39
smort bash devs
Avatar
k2d222 2022-05-23 11:40:31Z
c macros suck it forces you to do magic tricks like that
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 11:41:22Z
@Jupstar ✪ when are we creating our own language? Lets call it ++c and write some cool standard for it. Then we let @Ryozuki write a compiler for it
Avatar
@unexploredtest:kde.org BOT 2022-05-23 11:53:49Z
Then write PPDDNet?
Avatar
GitHub BOT 2022-05-23 13:01:35Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
bf2d3d5 do not render freezebar if you are not freezed - C0D3D3V 59c79fa Merge #5197 - bors[bot]
13:01
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5197 do not render freezebar if you are not freezed
Avatar
chillerdragon BOT 2022-05-23 13:51:18Z
Lmao yea
Avatar
Avatar
c0d3d3v
The rule for net objects if you set validate_size=False: "Can't use members that need validation in a struct whose size isn't validated" seems a bit unnecessary, because NetIntRange is the only member type that emits a validation function, and that is only "ClampInt". :/ @fokkonaut you wished that I move the display data in DDNetCharacter, ... so should I change NetIntRange of m_Jumps and m_StrongWeakID to NetIntAny?
heinrich5991 2022-05-23 14:52:38Z
if you want to go around that rule, you have to consider how to handle backward compatibility and so on yourself
14:52
the only reason why I added it was probably because my code didn't account for these checks
Avatar
GitHub BOT 2022-05-23 14:55:54Z
Author icon
heinrich5991
[ddnet/ddnet] Issue closed: #2706 Token handshake for serverinfo requests
14:56
Author icon
heinrich5991
[ddnet/ddnet] Issue closed: #3944 HTTP master invalid serverinfo
Avatar
heinrich5991 2022-05-23 15:00:03Z
perhaps you could figure out a general way to extend net objects @c0d3d3v, probably by adding default values for fields not included in the object
Avatar
GitHub BOT 2022-05-23 15:01:14Z
Author icon
heinrich5991
[ddnet/ddnet] Issue opened: #5199 Add a way to extend snapshot objects
Probably by adding default values for fields not included in the snapshot. CC #2484
Avatar
Jupstar ✪ 2022-05-23 15:08:08Z
chillerdragon: std::this_thread::sleep_for(100ms) not that hard
15:08
and if too hard, u have full cppreference explaining it in detail for u
15:08
but i'd say cant be more intuitive
15:08
this thread, sleep for
15:08
this is litteraly english
Avatar
GitHub BOT 2022-05-23 15:10:30Z
Author icon
def-
[ddnet/ddnet] Pull request opened: #5200 Don't assume script name/path

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
Avatar
Jupstar ✪
chillerdragon: std::this_thread::sleep_for(100ms) not that hard
heinrich5991 2022-05-23 15:15:17Z
you have to using namespace something for that to work IIRC
Avatar
GitHub BOT 2022-05-23 15:17:53Z
Author icon
def-
[ddnet/ddnet] Issue opened: #5201 Crash when starting client
Reported by JimmyJazzThe1st DDNet_crash_log.zip Not sure if I'm using drmingw parser correctly: ``` $ scripts/parse_drmingw.sh ~/DDNet.exe ~/DDNet_crash_log_11960_2022-05-23_13-42-02.RTP Parsing address: 5C9EFB (img base: 400000) /home/deen/isos/ddnet/ddnet-source/src/engine/client/text.cpp:186 Parsing address: 46E0D4 (img base: 400000) /home/deen/isos/ddnet/ddnet-source/src/game/client/components/maplayers.cpp:1103 ...
Avatar
Avatar
heinrich5991
perhaps you could figure out a general way to extend net objects @c0d3d3v, probably by adding default values for fields not included in the object
c0d3d3v 2022-05-23 15:23:57Z
:/ would probably be the best ... so much work
Avatar
GitHub BOT 2022-05-23 15:24:49Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #5202 Call HttpInit in server
Otherwise curl_global_init would be called from the first curl_easy_init, but curl_global_init isn't threadsafe. Fixes #5195.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect ex...
Avatar
Jupstar ✪ 2022-05-23 15:26:05Z
chillerdragon: and then write ++DDNet in ++C? 😄
Avatar
GitHub BOT 2022-05-23 15:31:58Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
1158bbf Don't assume script name/path - def- f03a659 Merge #5200 - bors[bot]
15:31
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5200 Don't assume script name/path
Avatar
[quakenet] ChillerDragon BOT 2022-05-23 15:43:15Z
yes!
15:43
aka PPDDNet thats what unexploredtest alr said
15:44
@Jupstar ✪ yea but i need this -.- https://github.com/ddnet/ddnet/blob/f03a6599081d3fd3ba567309670c6728a85fc399/src/engine/client/client.cpp#L3307-L3317
ddnet/client.cpp at f03a6599081d3fd3ba567309670c6728a85fc399 · ddne...
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/client.cpp at f03a6599081d3fd3ba567309670c6728a85fc399 · ddnet/ddnet
Thumbnail
15:45
its bit more weird with decltype and shit
Avatar
GitHub BOT 2022-05-23 15:48:13Z
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #5195 Crash in curl_easy_init
15:48
Author icon
bors[bot]
[ddnet:master] 4 new commits
7778afd Update Dutch translations by Ronan - def- 76ed324 Call HttpInit in server - heinrich5991 c93658f Make sure we don't accidentally initialize libcurl in a thread - heinrich5991 50de8d2 Merge #5175 #5202 - bors[bot]
15:48
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5175 Update Dutch translations by Ronan
15:48
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5202 Call `HttpInit` in server
Avatar
heinrich5991 2022-05-23 15:50:14Z
ah, we don't distinguish between timestamps and durations? that's a bit sad
Avatar
Avatar
[quakenet] ChillerDragon
its bit more weird with decltype and shit
Jupstar ✪ 2022-05-23 16:00:04Z
its amazing bcs in 1000000000 years when we switch to picoseconds we dont have to change that line
16:00
isnt that truly amazing
16:00
i saved some future alien 1 second of his life
Avatar
heinrich5991 2022-05-23 16:01:01Z
the variable could probably be renamed to not include 'nanoseconds' for clarity
Avatar
Jupstar ✪ 2022-05-23 16:01:25Z
true, then i'd have saved him 2 seconds of his life
16:01
damn me
Avatar
Ravie 2022-05-23 16:13:01Z
I've made new racist shields because I'm not a fan of the current ones and also the new ones are in vector so they can be part of the same svg file as hud
Image attachment
Avatar
Learath2 2022-05-23 16:13:51Z
I’m still a little skeptical of the new shields usefulness in mapping 😛
Avatar
Ravie 2022-05-23 16:14:09Z
yeah me too but if they're gonna exist, they can at least look good
16:14
imo they don't encourage the cleanest level design
Avatar
deen 2022-05-23 16:15:07Z
We have no maps with them yet, so we can also remove them again I guess
Avatar
Iza 2022-05-23 16:17:55Z
i find the weapon shields are a little too specific as a map mechanic but maybe its good idk
Avatar
Jupstar ✪ 2022-05-23 16:21:22Z
yes please put them outside of game.png, its probably nicer with the amount of custom pngs out already dont want to judge about usefulness tho^^
Avatar
Avatar
Jupstar ✪
yes please put them outside of game.png, its probably nicer with the amount of custom pngs out already dont want to judge about usefulness tho^^
c0d3d3v 2022-05-23 16:23:08Z
I thought about a ddnet_game.png for ddnet entities
Avatar
heinrich5991 2022-05-23 16:23:45Z
idk about placing it outside game.png
16:24
maybe it could be replaced by a known-good image if the game.png doesn't contain something for it
Avatar
Jupstar ✪ 2022-05-23 16:24:52Z
game.png is bloated anyway what is game.png even it contains effects, shields, flags, hud cursors
16:24
completly random
Avatar
heinrich5991 2022-05-23 16:25:09Z
okay, that's a different argument
Avatar
Pipou 2022-05-23 16:25:21Z
You can do the same by removing all the weapons and giving some back in a column so you can't see it. Another way would be to use à transitional teleport with speedups so it's too fast for players to see.
Avatar
Avatar
Pipou
You can do the same by removing all the weapons and giving some back in a column so you can't see it. Another way would be to use à transitional teleport with speedups so it's too fast for players to see.
heinrich5991 2022-05-23 16:25:39Z
that argument was also brought forward in the PR
16:25
perhaps we should discuss the usefulness there, not here
16:26
@Jupstar ✪ but placing it outside of game.png for backward compatibility concerns doesn't sound very useful to me, it creates the same backward compatibility problem for the new image. am I missing something?
Avatar
Jupstar ✪ 2022-05-23 16:27:29Z
but we dont really use the new image yet
Avatar
Pipou 2022-05-23 16:27:40Z
Sorry Heinrich, I had no idea. I never use or look at github
Avatar
Ravie 2022-05-23 16:27:55Z
the only use case I can think of is if you have some map where you pass the same area multiple times with different weapon setups and you only wanna take away 1 specific weapon every time
16:28
so an oddly specific use case
Avatar
Avatar
Ravie
the only use case I can think of is if you have some map where you pass the same area multiple times with different weapon setups and you only wanna take away 1 specific weapon every time
heinrich5991 2022-05-23 16:28:11Z
that's basically what was said in the PR
Avatar
Ravie 2022-05-23 16:28:24Z
ah I didn't read the whole pr either
Avatar
heinrich5991 2022-05-23 16:28:51Z
https://github.com/ddnet/ddnet/pull/4728#issuecomment-1126740688=
Avatar
GitHub BOT 2022-05-23 16:31:42Z
Author icon
heinrich5991
[ddnet/ddnet] Issue opened: #5203 HTTP master: Wrong portforward message
It's currently always displayed.
Avatar
Ravie 2022-05-23 16:32:21Z
of course it's about a Konsti map twinbop
Avatar
ᶰ°Konͧsti 2022-05-23 16:47:17Z
justatest
16:47
I dont understand why people argue about a tile that wont harm them tho
Avatar
heinrich5991 2022-05-23 16:49:33Z
adding a tile isn't free, there's more stuff a player has to learn
Avatar
Jupstar ✪ 2022-05-23 16:59:18Z
why does POS1 key on keyboard not scroll up the whole F1 console anymore? was there a change lately in f1 console?
Avatar
heinrich5991 2022-05-23 17:00:17Z
perhaps it's being eaten by the line input?
17:00
perhaps it could be mapped to shift-pos1 if that's the case
Avatar
Robyt3 2022-05-23 17:00:52Z
doesn't help, shift+pos1 is for selecting text
17:01
at least if completely implemented
Avatar
heinrich5991 2022-05-23 17:01:18Z
hm. ctrl-pos1?
Avatar
Robyt3 2022-05-23 17:01:29Z
would work I guess, ctrl+left/right is for word skipping
17:01
but ctrl+pos1 is unused
Avatar
murpi 2022-05-23 17:01:54Z
end key scrolls to the latest line, so that one works 😛
Avatar
Avatar
Jupstar ✪
why does POS1 key on keyboard not scroll up the whole F1 console anymore? was there a change lately in f1 console?
c0d3d3v 2022-05-23 17:02:30Z
what do you mean with whole? there was a fix by Robyt so the last page is not renderd again...
Avatar
Jupstar ✪ 2022-05-23 17:02:57Z
pos1 = first page end = last
17:03
or other way around
Avatar
c0d3d3v 2022-05-23 17:03:05Z
ah I was lost
Avatar
Jupstar ✪ 2022-05-23 17:03:07Z
😄
Avatar
Learath2 2022-05-23 17:03:50Z
Do any of you use something like docker locally?
Avatar
heinrich5991 2022-05-23 17:04:11Z
podman might be more to your liking if you like chasing weird bugs
17:04
I tried that for a bit
Avatar
Learath2 2022-05-23 17:04:27Z
I've been thinking about whether I want to have a local LEMP stack running or if I should catch up with the times and have it running in a container
Avatar
heinrich5991 2022-05-23 17:05:08Z
I liked the opinion that containers hide complexity, instead of removing the complexity in the software itself
Avatar
ReiTW 2022-05-23 17:05:51Z
docker kinda annoying when you host a tw server
Avatar
Avatar
c0d3d3v
what do you mean with whole? there was a fix by Robyt so the last page is not renderd again...
Robyt3 2022-05-23 17:06:20Z
it was probably that which broke it, cause I didn't realise this was a thing (edited)
Avatar
Learath2 2022-05-23 17:06:38Z
docker is annoying 100% of the time, from their weird enterprise bootlicking to their odd approach to having a demon running all the time
17:06
daemon*
Avatar
heinrich5991 2022-05-23 17:07:05Z
podman is running containers without a daemon
Avatar
ReiTW 2022-05-23 17:07:06Z
have to flush conntrack entries on tw ports when the server restarts (bridge mode) (edited)
Avatar
Robyt3 2022-05-23 17:07:19Z
pos1/end are only supposed to work in the console when the input is empty
Avatar
ReiTW 2022-05-23 17:07:22Z
overwise people who were online can't join anymore
17:07
only way to fix that is to set the ct in host mode
Avatar
Avatar
Robyt3
pos1/end are only supposed to work in the console when the input is empty
c0d3d3v 2022-05-23 17:09:05Z
make sense, but pos1/home only scolls up one page, instead of jumping to the beginning. Do you want to fix it?
Avatar
Avatar
c0d3d3v
make sense, but pos1/home only scolls up one page, instead of jumping to the beginning. Do you want to fix it?
Robyt3 2022-05-23 17:09:28Z
yeah, I'll fix it
👍 1
Avatar
Avatar
Learath2
docker is annoying 100% of the time, from their weird enterprise bootlicking to their odd approach to having a demon running all the time
ReiTW 2022-05-23 17:10:02Z
well yeah, after you can still restart the daemon without stopping the containers
17:10
(upgrade ig works also)
17:10
ah Live restore allows you to keep containers running across Docker daemon updates, but is only supported when installing patch releases (YY.MM.x), not for major (YY.MM) daemon upgrades.
Avatar
c0d3d3v 2022-05-23 17:15:36Z
@trml in what units is SnapItemSize messured? I think the original NETOBJTYPE_SWITCHSTATE has 72 bytes
Avatar
Avatar
c0d3d3v
@trml in what units is SnapItemSize messured? I think the original NETOBJTYPE_SWITCHSTATE has 72 bytes
c0d3d3v 2022-05-23 17:16:50Z
also you can use Item.m_DataSize instead of const int SnapItemSize = Client()->SnapItemSize(IClient::SNAP_CURRENT, i);
Avatar
heinrich5991 2022-05-23 17:20:11Z
I think it's in bytes
Avatar
trml 2022-05-23 17:20:12Z
@c0d3d3v I mostly just copied the approach used for GameInfoEx there. I will probably try to look a little more into the snapshot code though
17:21
the number I used is just from a "dbg_msg" print (I didnt check how it is calculated yet)
Avatar
c0d3d3v 2022-05-23 17:21:34Z
@heinrich5991 if I would implement, the default value mechanic, for some usecases it would be enough, but using a version value like trml just used, would probably be enough and better than default values
Avatar
heinrich5991 2022-05-23 17:22:24Z
I don't think using a version is better tbh
17:22
what use is the version?
Avatar
trml 2022-05-23 17:22:41Z
since you would only need the default values when the snapshot is shorter than expected (most typically newer client and older server), perhaps it's ok to just do it in the parsing?
17:23
or, hmm, maybe someting along the lines of seting all values to a default while parsing, then to a memcpy from the snapshot
Avatar
Avatar
Learath2
Do any of you use something like docker locally?
AssassinTee 2022-05-23 17:23:48Z
yes I do, whats the matter?
17:24
I highly recommend using a custom image if you host Teeworlds in docker
Avatar
Learath2 2022-05-23 17:25:22Z
I'm only looking to use it as a local web dev environment, was wondering if anyone else was using it and if it was a smooth experience
Avatar
Avatar
Learath2
docker is annoying 100% of the time, from their weird enterprise bootlicking to their odd approach to having a demon running all the time
AssassinTee 2022-05-23 17:25:37Z
you don't need to run it all the time? Ofc if you want to host a container tho
Avatar
Learath2 2022-05-23 17:26:54Z
I'm happy to run a LEMP stack directly on my machine so if there are any annoyances with it I'd rather not spend time messing around with docker. I'm wondering about things like mounting the local files, connecting to stuff in the container e.g.
Avatar
AssassinTee 2022-05-23 17:27:14Z
if you have put some work in your docker compose files, you can incredibly easy host your infrastructure, even frontend and backend with hot-coding
Avatar
Avatar
heinrich5991
what use is the version?
c0d3d3v 2022-05-23 17:27:56Z
like for example if you would use default values for freeze start tick, set it to 0, how would I know if it is set by the server to 0 or by parser
Avatar
heinrich5991 2022-05-23 17:28:40Z
set it to a sentinel value, probably -1?
Avatar
c0d3d3v 2022-05-23 17:30:11Z
I could also just use the size of the snap to determine the version. But does not work if we only add new flags to a flag field
Avatar
Avatar
heinrich5991
set it to a sentinel value, probably -1?
c0d3d3v 2022-05-23 17:31:04Z
and then checking everywhere where its used for -1 or would I set m_HasExtendedDisplayData to false xD
Avatar
GitHub BOT 2022-05-23 17:31:56Z
Author icon
Robyt3
[ddnet/ddnet] Pull request opened: #5204 Fix pos1 only scrolling up one page in console
Holding down the pos1 key will still make the console text flash though. Fixing that would require to first calculate the total number of pages in a separate pass before rendering the current page.

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out ...
Avatar
c0d3d3v 2022-05-23 17:32:40Z
how about using two flag bit in DDNetCharacter for versioning xD so it could be changed 2 more times
17:33
🙈
Avatar
heinrich5991 2022-05-23 17:34:00Z
ah yea, for adding flags we need a version
Avatar
c0d3d3v 2022-05-23 17:35:23Z
alternativ would be a version field in a snap that is not send as often as character, but that gives info about the versions of other snaps
17:36
like GameInfoEx (I think its not send often)
17:37
mh I'm wrong, It is sended all the time
17:37
or use the GameInfoEx version also for other snaps
Avatar
trml 2022-05-23 17:38:08Z
snapshot objects are only sent every time they change though (so gameinfoex is most likely only sent once)
17:40
otoh, parsing a netobject will be slightly easier if it doesnt depend on other netobjects
Avatar
c0d3d3v 2022-05-23 17:42:54Z
mh true, but we could define GAMEINFO_CURVERSION, also as protocol version, save it in the client, and use it to parse other snaps. :/ -.- Do not know, Honestly I would just add a version to ddnetcharacter, but the optimization heart says that goes better xD (edited)
17:48
@heinrich5991 what do you think about using GAMEINFO_CURVERSION as protocol version? Or should every snap use its own version? its a bit strange to use 32 bit for version, But I do not know how good that it is compressed, So it might not be to bad. (edited)
Avatar
Learath2 2022-05-23 17:51:14Z
Does a user with the privilege GRANT OPTION also have the ability to GRANT GRANT OPTION to other users? 😄
17:51
Hard to find documentation for something so specific
Avatar
heinrich5991 2022-05-23 17:56:11Z
@c0d3d3v hmmm. that would still need default fields though, no?
17:56
because some objects might be shorter in older versions
Avatar
Avatar
heinrich5991
because some objects might be shorter in older versions
c0d3d3v 2022-05-23 18:06:17Z
yes just do the handeling of that in parsing like in gameclient, based on the protocol or snap version
Avatar
heinrich5991 2022-05-23 18:07:19Z
but that would lose the automated handling of the correct snapshot length and verification of snapshot data
18:07
likely leading to bugs :/
Avatar
GitHub BOT 2022-05-23 18:18:07Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #5205 Allow multiple addresses per server in the serverbrowser
Support is incomplete for leak_ip_address_to_all_servers (will only ping the first address of each server) and for the leak_ip setting (which will also only ping the first address of each server).

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and ou...
Avatar
GitHub BOT 2022-05-23 18:30:37Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
0c518ba Fix pos1 only scrolling up one page in console - Robyt3 c929ef4 Merge #5204 - bors[bot]
18:30
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #5204 Fix pos1 only scrolling up one page in console
Avatar
Avatar
heinrich5991
but that would lose the automated handling of the correct snapshot length and verification of snapshot data
c0d3d3v 2022-05-23 18:31:39Z
I dont get the point, It I set it to default -1 I also have to catch that in the parsing, or way later if I want to access the data. In my opinion is the check for a version (or the size) in parsing best, because it allows to set a value like "hasExtendedDisplayData" to true, and if its false, the display data will be random "or default so useless anyway.
Avatar
heinrich5991 2022-05-23 18:32:23Z
well, to take a step back: why do we have the generated protocol?
18:32
so that we don't parse it in our own code, so that we are less likely to introduce out of bounds accesses, etc.
18:33
if we completely turn this off, we lose these benefits
Avatar
Avatar
deen
if you want to scrape all, be nice and wait a bit inbetween
Broso56 2022-05-23 19:11:47Z
how long should people wait inbetween scrapes? just testing (first time messing with json/json api) and dont want to spam too much if people generally wait a good bit
19:12
just a few seconds?
Avatar
Avatar
heinrich5991
well, to take a step back: why do we have the generated protocol?
c0d3d3v 2022-05-23 19:35:59Z
How about this: I just move the new display data into DDnetCharacter for now, and do the check if the data is there just based on the size of the snap ( @trml can do that too). So that this finally gets done quickly (And I do not have to worry about it). And later I or someone who has time, can deliver the mechanism for default values and then replace the check for the size with checks for default values.
Avatar
Avatar
Broso56
just a few seconds?
deen 2022-05-23 19:46:49Z
ok
Avatar
heinrich5991 2022-05-23 20:00:57Z
@c0d3d3v sounds okay
👍 1
Avatar
GitHub BOT 2022-05-23 21:00:24Z
Author icon
C0D3D3V
[ddnet/ddnet] Pull request opened: #5206 Do not use ELLIPSIS if the text fits anyway
Alternative to #5193 for me, this generates about the same fps as not using ELLIPSIS. my idea was to simply render the text without further conditions if it fits in anyway. Since most names fit anyway, rendering ELLIPSIS is usually the exception. maybe @Jupeyy can test this with his awesome gpu

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a ...
Avatar
c0d3d3v 2022-05-23 21:48:40Z
@heinrich5991 not clear if this is still relevant, because I was on a slightly older nightly, but I get random crashes because of Stun while beeing like 20min ingame Also did not have debug symbols on... I will report again if this also happens on latest nightly xD (edited)
Image attachment
Image attachment
Avatar
heinrich5991 2022-05-23 21:51:32Z
@c0d3d3v sounds bad. I don't see a way for an assert to happen in that function :/
Avatar
deen 2022-05-23 21:59:10Z
secure_random_data not initialized?
Avatar
heinrich5991 2022-05-23 22:10:45Z
client initializes it early
22:10
also unlikely 20min in
Exported 232 message(s)