5947755
Fix unread variable clang-tidy warning on macOS - def-
8d5693d
Enable clang-tidy's modernize-use-override (fixes #5139) - def-
583d6e6
Mark virtual function as override using a script: - Chairn
3a659ad
Added -Wsuggest-override flag - Chairn
402cccf
Add override in code behind CONF_DISCORD, disable clang-tidy check - def-
bae4324
Merge #5140 - bors[bot]6977bdc
Make NETADDR
forward-declarable - heinrich5991
407644d
Change IClient::ServerAddress
to give the actual server address - heinrich5991
ec45a73
Add bare-bones STUN protocol support - heinrich5991
4fb050c
Use STUN to determine UDP connectivity and show diagnostics - heinrich5991
53d77e8
Merge #5119 - bors[bot]je/jouw
except line 1121 which uses u
, not a big deal I guess tho [2022-05-17 20:06:28][datafile]: loading done. datafile='downloadedmaps/RedCastle2_de71ee62.map'
[2022-05-17 20:06:28][client]: loaded map 'downloadedmaps/RedCastle2_de71ee62.map'
[2022-05-17 20:06:28][client/network]: loading done
[2022-05-17 20:06:28][textrender]: Found non empty text container with index 992
[2022-05-17 20:06:28][assert]: /home/deen/isos/ddnet/ddnet-source/src/engine/client/text.cpp(1912): text container was not empty
Doesn't happen with OpenGL 3.0, reported.../home/runner/work/ddnet/ddnet/src/engine/shared/http.cpp:307:77: error: both sides of operator are equivalent [misc-redundant-expression,-warnings-as-errors]
static_assert(std::numeric_limits<std::underlying_type_t<CURLcode>>::min() >= std::numeric_limits<unsigned int>::min() &&
How is this redundant? Does clang-tidy have some arcane knowledge here?CURLcode
is unsigned
?CURLcode
and sees that it's actually unsigned
, so you have static_assert(a >= a)
for some a
clang-tidy
doesn't take into account that it might not be unsigned in some build configurationunsigned int
(since we can't have the include in http.h) can represent all the values of CURLcode
I'm not really interested in anything elseCURLcode
is a typedef that will never change