DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-05-17 00:00:00Z and 2022-05-18 00:00:00Z

[ddnet-maps:master] 1 new commit

46694e0 M oco - ddnet-maps

this IPO linking is rly noticeable even with my cpu lol

[ddnet/ddnet] Issue opened: #5135 Warnings when building + long link time

``` [90/251] Linking CXX executable config_store lto-wrapper: warning: using serial compilation of 7 LTRANS jobs lto-wrapper: note: see the ‘-flto’ option documentation for more information [91/251] Linking CXX executable config_retrieve lto-wrapper: warning: using serial compilation of 7 LTRANS jobs lto-wrapper: note: see the ‘-flto’ option documentation for more information [92/251] Linking CXX executable fake_server lto-wrapper: warning: using serial compilation of 8 LTRANS jobs l...

CHN5 is missing some entities on some of the servers

06:58

any idea why?

06:59

guns and shields don't spawn

07:00

looks like it started today

GitHub

Click to see attachment 🖼️

also why does it have to use the gnu gold linker?

07:02

Use GNU gold linker if available (to speedup the build)

07:02

fake

07:03

Image attachment

[ddnet/ddnet] Issue opened: #5136 Don't enable the GNU Gold Linker by default

!image It was way better before this was a thing.

disabling ipo is so much faster its insane

07:10

"cmake.configureArgs": [
        "-DDEV=ON",
        "-DMYSQL=ON",
        "-DUPNP=ON",
        "-DVIDEORECORDER=ON",
        "-DUSE_GOLD=OFF",
        "-DIPO=OFF"
    ],

07:10

sane dev options as of today

07:10

fuckyousnail

@Ryozuki when leak how :fuckyousnail: emote looks like o.O

07:54

and who devs with mysql bra

[ddnet/ddnet] Issue opened: #5137 Shields and weapons sometimes move away / don't appear

This started yesterday after switching to new server version (@heinrich5991's rebased pr_ddnet_serverbrowse_http_server branch) !weirdstuff I'm not sure what change is causing this, I can't reproduce it. Old change: c5230110 New change: c082a842 Suspicious looking changes: https://github.com/ddnet/ddnet/pull/4959 https://github.com/ddnet/ddnet/pull/5125 https://github.com/ddnet/ddnet...

Ryozuki

sane dev options as of today

I have a change that auto-disabled IPO in DEV=ON

[quakenet] ChillerDragon

and who devs with mysql bra

i like having most options enabled so my editor properly shows stuff

Who made the map_diff tool in the install dir?

so servers can have multiple addresses now

10:22

I'm thinking about how to handle favorites

heinrich5991

so servers can have multiple addresses now

ipv4 and 6?

yes, or in the future also different protocols

does it support domain names?

think tw-0.6, tw-0.7, etc.

10:25

not at the moment, no

10:25

I thought that maybe we could still just store favorites by IP address

10:25

adding a server adds all the addresses to favorites, removing a server removes all the addresses

10:26

if only some addresses of a server are favorited, then clicking the favorite button adds the rest

10:26

problems I see: a server has some IP addresses I favorite it. but it removes some of them later, I unfavorite it. then there's still some favorite addresses lingering around

10:27

perhaps one could group the favorites based on how you favorited them first

10:28

then when you remove a favorite, you actually remove the whole group

10:28

or actually remove all the groups of all the addresses of the current server

how about only favorite the server ip that you are currently on? Or we could generally group servers with multiple ips together.

what would we do if the user favorites the server in the serverbrowser?

11:57

add a random IP address from the list?

[ddnet/ddnet] Pull request opened: #5138 No gold preference (fixes #5136)

@Kaffeine lld is used on some systems, we also have instructions for mold in readme, both are faster than gold.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Teste...

heinrich5991

add a random IP address from the list?

if we do not group a server with multiple ips, you would add the ip that is selected in the list.

ah, but I'm grouping them

12:26

the masterserver already groups them

how do you even know if it is the same server?

otherwise it would look confusing in the server list

12:27

{"addresses":["tw-0.7+udp://1.15.247.109:8303"],"location":"as:cn","info":{…}}

does it send some unique ID

no

does it register all ips at once?

no, individually

12:29

it registers them with a secret to identify the server

is this secret a secret or could it be made public xD?

it's a secret

12:30

if it were made public, anyone could register as being part of that server

12:31

it's also kinda short lived and tied to the specific execution of the server

I see. How about you store server side a unique ID for each server secret and send this so clients can know what ips are from what server, even if the ip is no longer connected to the server

12:31

ah ok

12:32

then nevermind

yes, in the future™ we could make it work with asymmetric cryptography, once we have secured our game server connection

heinrich5991

problems I see: a server has some IP addresses I favorite it. but it removes some of them later, I unfavorite it. then there's still some favorite addresses lingering around

probably acceptable xD I do not even think favourites are used that often

12:40

Would be nice if someone looks at #5063 and tell me what he thinks about the physics changes.

https://github.com/ddnet/ddnet/pull/5063

Reworked Draggers and Turrets AND show always hooks if they are in ...

Fixes #3622, #4723 #4798 and #5054 Here you can find a comparison video with 16.0.3: https://youtu.be/bYwLB1cEMI8 This now also includes the changes from #4980 So please also see my monologue here:...

murpi

Who made the map_diff tool in the install dir?

i think deen made it

yes, thanks

[ddnet/ddnet] Issue opened: #5139 Mark all overridden functions with `override`

Gives some better diagnostics in case you fail to override a function due to a typo.

18:26

[ddnet/ddnet] Pull request opened: #5140 Enable clang-tidy's modernize-use-override (fixes #5139)

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

am i supposed to drop my contributions to the translation of some strings in here?

if you want to, post the whole yourlanguage.txt here

19.98 KB

[ddnet/ddnet] Pull request opened: #5141 Updated dutch language by Ronan

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

1

[ddnet/ddnet] Pull request opened: #5142 Handle file/pipe stdout and add fallback on Windows

The CWindowsConsoleLogger uses WriteConsoleW which only works when the standard output handle is a console (GetFileType returns FILE_TYPE_CHAR). When redirecting output into a file, GetFileType returns FILE_TYPE_DISK. For this case a CWindowsFileLogger is added that uses WriteFile instead. This works on raw bytes, so the UTF-8 encoded lines are written directly. When pipeing output or when using custom terminals like Git Bash, GetFileType returns FILE_TYPE_PIPE. I ca...

Ronan

Click to see attachment 🖼️

Was looking for a troll message. Couldn't find 1 feelsbadman

feelsbadman

21:24

feelsamazingman

feelsamazingman

21:26

i din troll

do you speak dutch, @n000b?

I am dutch feelsamazingman

feelsamazingman

can you check whether all these changes look sane? https://github.com/ddnet/ddnet/pull/5141/files

i was gon say

21:27

how do you rate the changed ive made

Looks good

21:30

I already checked the file up here. But like this it is easier to check

feelsamazingman

Didn't read if everything is correctly translated. But there is no wrong stuff written

21:31

Maybe i would translate hookline to hooklijn, but that is because hook is such a basic term and in dutch it sounds weird

i did consider that too

21:32

but the fellas who have come before me

21:32

have translated hook as haak

21:32

hence why i opted for haaklijn

21:32

and a hook is a haak after all so i figured that itd work (edited)

Hmm i guess you are right

21:35

feelsamazingman

have you spotted some other debatable translations

21:38

we might just be bang on if we work together

Hmm didn't read the English stuff most of the time. So actually not

heinrich5991

can you check whether all these changes look sane? https://github.com/ddnet/ddnet/pull/5141/files

i suppose ya can deem 'm sane then

21:39

feelsamazingman

I was only checking for bad language or memes or something like that

oi i spotted a mistake.

21:41

Server executable not found, can't run server == == Server executable niet gevoNden, de server kan niet gestart worden

21:41

i forgot an n lmao

21:41

lil slip up yo

@Chairn ^

19.98 KB

21:42

fixed it

Ah lol

done

Ronan

but the fellas who have come before me

Entiteiten is ook zo een vaag woord xD

ja ik heb er heel lang over nagedacht om het entities te laten

21:45

wat zeg jij

21:45

terug veranderen?

please only english here

21:47

#off-topic for other languages

Oopz

sorry mens

[ddnet/ddnet] Pull request closed: #5141 Updated dutch language by Ronan

[ddnet/ddnet] Issue closed: #4422 Console output does not work with Git Bash

22:24

[ddnet/ddnet] Pull request closed: #5142 Handle file/pipe stdout and add fallback on Windows

@Ronan throughout the translation is used je/jouw except line 1121 which uses u, not a big deal I guess tho

anyone have that flowchart that explains the ddnet cpp files?

22:57

@Ryozuki i think u posted it before

This? https://codedoc.ddnet.tw/inherits.html

i was looking for the info that explains what each file "controls" in the game, but this helps a lot too, thanks

if you're looking for client modification, it's mostly stuff in game/client/components

Exported 124 message(s)