2
CNetObj_GameInfo *pGameInfoObj = (CNetObj_GameInfo *)Server()->SnapNewItem(NETOBJTYPE_GAMEINFO, 0, sizeof(CNetObj_GameInfo));
But it makes no sense to repeat CNetObj_GameInfo three times and use the only correct NETOBJTYPE.
With one line for codegen and for lines for engine/server.h:
--- datasrc/datatypes.py
+++ datasrc/datatypes.py
@@ -218,6 +218,7 @@ class NetObject:
. . . lines = ["struct %s : public %s"%(self.struct_name,self.base_struct_name), "{"]
. . else:
. . . lines = ["struct %s"%self.struct_name, "{"]
+. . lines += ["\tstatic const int ObjectType = %s;" % self.enum_name]
. . for v in self.variables:
. . . lines += ["\t"+line for line in v.emit_declaration()]
. . lines += ["};"]
--- src/engine/server.h
+++ src/engine/server.h
@@ -279,6 +279,13 @@ public:
. virtual void SnapFreeID(int ID) = 0;
. virtual void *SnapNewItem(int Type, int ID, int Size) = 0;
+. template <typename T>
+. T *SnapNewItem(int ID)
+. {
+. . int Type = T::ObjectType;
+. . (T *)SnapNewItem(Type, ID, sizeof(T));
+. }
we can turn messes into a nice and clear code:
CNetObj_Character *pCharacter = static_cast<CNetObj_Character *>(Server()->SnapNewItem(NETOBJTYPE_CHARACTER, ID, sizeof(CNetObj_Character)));
CNetObj_Character *pCharacter = Server()->SnapNewItem<CNetObj_Character>(ID);
// or even
auto *pCharacter = Server()->SnapNewItem<CNetObj_Character>(ID);
Deal? If yes, then I'll try to come up with a PR when I'll have time. static const int maybe a constexpr just to make sure ? protocol7 but it's not a big deal. . I'll do PR eventually. And I'm fine with any name for that method (maybe SnapNewObject() or something like that; it will be easy to rename during CR).
Also you're messing up ID and Type.
Type is a value from NETOBJTYPE_ anonymous enum.
ID is an integer with this_type instance number.
E.g. for CNetObj_Laser valid IDs in the mod I'm maintaining can reach hundreds.
CNetObj_GameInfo *pGameInfoObj = (CNetObj_GameInfo *)Server()->SnapNewItem(NETOBJTYPE_GAMEINFO, 0, sizeof(CNetObj_GameInfo));
But it makes no sense to repeat CNetObj_GameInfo three times and use the only correct NETOBJTYPE.
With one line for codegen and for lines for engine/server.h:
--- datasrc/datatypes.py
+++ datasrc/datatypes.py
@@ -218,6 +218,7 @@ class NetObject:
. . . lines = ["struct %s : public %s"%(self.struct_name,self.base_struct_name), "{"]
. . else:
. . . lines = ["struct %s"%self.struct_name, "{"]
+. . lines += ["\tstatic const int ObjectType = %s;" % self.enum_name]
. . for v in self.variables:
. . . lines += ["\t"+line for line in v.emit_declaration()]
. . lines += ["};"]
--- src/engine/server.h
+++ src/engine/server.h
@@ -279,6 +279,13 @@ public:
. virtual void SnapFreeID(int ID) = 0;
. virtual void *SnapNewItem(int Type, int ID, int Size) = 0;
+. template <typename T>
+. T *SnapNewItem(int ID)
+. {
+. . int Type = T::ObjectType;
+. . (T *)SnapNewItem(Type, ID, sizeof(T));
+. }
we can turn messes into a nice and clear code:
CNetObj_Character *pCharacter = static_cast<CNetObj_Character *>(Server()->SnapNewItem(NETOBJTYPE_CHARACTER, ID, sizeof(CNetObj_Character)));
CNetObj_Character *pCharacter = Server()->SnapNewItem<CNetObj_Character>(ID);
// or even
auto *pCharacter = Server()->SnapNewItem<CNetObj_Character>(ID);
Deal? If yes, then I'll try to come up with a PR when I'll have time. 
protocol is a part of the game or engine?
Engine message.h includes protocol.h which includes mapitems_ex.h which makes the engine depending on mapitems_ex.cpp which is a part of game.
This ruined my attempt to clearly split engine and game libraries. 
1
1
I will check it out, i always was busy finding those white spaces
files.trimTrailingWhitespace
1
