DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-04-24 00:00:00Z and 2022-04-25 00:00:00Z

[ddnet-maps:master] 1 new commit

46c6455 A Rotate - ddnet-maps

Hi, just wanted to say sending this query: https://ddnet.tw/maps/?query=%27 crashes the website.

bobby tables entered the game ...

07:07

@Ryozuki mr web dev go fix sql injection ^

Aaaa who wants to explain rust lifetimes to me :D I love how the compiler suggests to remove the scope .. duh https://paste.zillyhuhn.com/2m

@Discord Mod

1

thanks

@irc mod

08:03

there isnt even message deletion on irc is there?

08:03

omg im about to rq rust again

xd

yq: Thanks, let me take a look

08:17

xq*

08:23

Fixed

[ddnet/ddnet] Pull request opened: #5015 Adopt random_int() from upstream

Inspired by https://github.com/teeworlds/teeworlds/commit/b84b8ddfdabba3d2b77d62bdab7d7548e739380f

:)

[quakenet] ChillerDragon

Aaaa who wants to explain rust lifetimes to me :D I love how the compiler suggests to remove the scope .. duh https://paste.zillyhuhn.com/2m

bruh nowhere does it talk about "removing" a scope

08:54

u create a player

08:54

and then put a reference to it on ur vector

08:54

but then the player gets out of scope so its destroyed

08:54

thats why

08:55

you should just pass the player to the vector without a reference

08:55

and why do you put it in a Box?

08:55

instead of a vec of mutable references let mut players: Vec<&mut Player> = Vec::new(); , create a vec of owned players let mut players: Vec<Player> = Vec::new();

08:55

and put them

08:56

fn add_player(players: &mut Vec<Player>) {
    let player = Player { x: 0, y: 0 };
    players.push(player);
}

08:56

one tip in rust

08:56

only use mut when u really need it

08:56

dont start typing stuff with mut

08:56

only put it when u rly require it

i use my gaming mouse macro to type mut

08:57

thanks a lot babe i love u

also

08:57

a Box is like a smart pointer

it does say remove the scope in rustc --explain E0597 :D

for values on the heap

yea that i understood

08:57

i thought i need that

08:57

to heap alloc it and then pass the ownership into the vector

i think the error is pretty clear

-.-

borrowed value does not live long enough

ok i guess i tis

08:58

but the fix wasnt for me

why did you use Box?

ok lemme try

08:58

because without Box it didnt work :D

wow chillerdragon has his personal rust trainer

no?

ikr

u lucky one

with box it doesnt work

@Jupstar ✪ as you can see i really need it :D

because ur vector is not a vec of boxed players

08:59

ye

08:59

idk if u trollin

XD

im not

i rly hate ur low effort learning

:D

u always rely on askin here

08:59

instead of googling

im just stupid

and ye ur smiley face makes me even more upset

i was googling all morning

xDDD

08:59

mad af

sorri senpai

08:59

UwU

just one thing

09:00

just because u have a Vec<Player> and it doesnt say mut in the player

09:00

if u have a mut Vec<Player>

09:00

u can still change the players

oh wow thats weird

because the vector is mutable and the vector owns the players

so thats mutable by default!?

09:00

i mean what about a mutable vector that holds immutable players?

thats what i just said to you?

i thought mutable vector only means i can push into the vector not the entrys are mutable

ifi the vector is mutable and it contains owned data

09:01

it can mutate the owned data

09:01

owned data = not a reference

awesome that compiles :3

09:02

i love u ryo <3

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=a85a9b736ed55e0adbc8c847bbfb3542

Rust Playground

A browser interface to the Rust compiler to experiment with the language

09:02

check it

09:03

the rust playground is awesome to share stuff btw

09:03

if its simple

neat

you made me stop mining in ff14

09:03

pay for it

ff14?

09:04

final fantasy?

a mmo xd

09:04

ye

cringe

no u

[ddnet/ddnet] Pull request opened: #5016 Remove cl_show_quads

Leads to confusion why parts of map are not shown, no good reason to use it on hardware of the last 15 years. If someone has a use case for it please say so now.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] C...

[ddnet-scripts:master] 1 new commit

5343519 git config - def-

Just upgraded to 16,0,3 (from 15) and FPS is spiking like crazy (edited)

Image attachment

10:48

1k+ FPS to 100 FPS spikes too often

10:49

Before, I had stable 1k FPS

what does gfx_gl_major say? and what is ur OS and GPU

Windows 10 AME, Nvidia P1000

10:51

gfx_gl_major = 3

mh, the config vars were resetted for the GFX stuff, you could try vulkan in settings -> graphics -> renderer on CPU side: what i heard is that discord(the app) causes laggs and anti virus does weird stuff

Ok I will try without Discord, will report back soon I will see if changing OpenCL does anything also

10:53

brb

10:56

All same behaviour, unfortunately

latest drivers from nvidia directly?

10:59

nvidia.com

Pathos

All same behaviour, unfortunately

also vulkan should at least push ur fps higher really weird

Don't get me wrong, I love Vulkan

11:00

I will try latest drivers

11:00

brb

yeah but i wonder if there is at least no difference

11:00

but yeah frame drops can have many reasons

Looks like I have the latest version

do u run anti virus software?

Nope

11:01

Windows Defender is disabled also

11:01

Or removed, not disabled but yeah

mhh, can you PM me your config? also did you try again on DDNet 15, after the upgrade

11:02

to make sure its really DDNet

My config? DDNet config? Computer config?

DDNet config

jupstar is after your rcon binds!

11:03

also good to know ur windows defnder is off :p

yeah i want to hack chinese community

11:03

or japanese

11:03

cant remember

isnt pathos europe?

isnt he pathoslego smth on github

ye think so

11:04

imagine talking like he is not here

i connect him with scoreboard laggs on japanese font

o

#809

https://github.com/ddnet/ddnet/issues/809

More lag than ever when viewing scoreboard for the first time when ...

How to reproduce: Open DDNet client Set to Japanese Join server Press the key bound to show scoreboard There was already delay before, but with the latest patches, the lag is absolutely horrendous....

such an oldie goldy

wow >1000

11:06

how do u even remember that

i dunno xd

did u restart ur client after changing renderer

11:06

xd

xd

always expect the worst

true

11:07

vulkan must give 5k fps with any nvidia card or RQ

Ryo pro techsupporter

11:07

have you tried turning it on and off again?

no for real

[quakenet] ChillerDragon

also good to know ur windows defnder is off :p

Yeah I'm using Windows AME :D

whats AME

@Pathos can u try real fullscreen just to see if that fixes it, i know IME is broken then, but worth a try

African Methodist Episcopal Church

Ryozuki

did u restart ur client after changing renderer

Yes, every time

ah neat unbloated windows

just use linux

ah lol

11:09

@Pathos u have cl_refresh_rate 288

11:09

set that to 0

[quakenet] ChillerDragon

whats AME

Ameliorated

Jupstar ✪

@Pathos u have cl_refresh_rate 288

No it was 0 before, I set it to 288 to see if it was due to auto throttling

ok

11:10

so if cl_refresh_rate is 0 and gfx_refresh_rate is 0 it still laggs?

11:10

in "real" fullscreen

Jupstar ✪

@Pathos can u try real fullscreen just to see if that fixes it, i know IME is broken then, but worth a try

Tried fullscreen, no change -- interestingly, usual FPS didn't go up, even though it should... hmm

Jupstar ✪

in "real" fullscreen

Ok I will try this combination

Lmao AME is illegal? :D

Jupstar ✪

in "real" fullscreen

Hmm stranger FPS behaviour now -- I can't really take a screenshot of the graph

11:13

Well, let me try multiple, one sex

sex

11:13

looks like AME is deprecated

Image attachment

Image attachment

11:14

It does this every few seconds, interestingly enough

can u try ddnet 15

lmao Cylox

11:15

@Pathos could you ping Cylox in chat and say "raaaaaaaawr dinosaur" for me? :D

Jupstar ✪

can u try ddnet 15

I will have to try this another time

ok

Thanks

[quakenet] ChillerDragon

@Pathos could you ping Cylox in chat and say "raaaaaaaawr dinosaur" for me? :D

No Cylox in here

11:15

I will come back with this issue probably another time, thanks

meh he was on screenshot

11:15

blue team on fng

restarting win10 also solved alot of problems xd

11:16

else remeber, usually good config vars are: gfx_backend "Vulkan";gfx_refresh_rate 1000;cl_refresh_rate 0;gfx_fullscreen 1;quit for good stable fps xd

Should we try setting Vulkan as default at some point? After it's been tested a bit more

could try it out yeah, only non solvable issue is one amd gen yet other issues were issues in the code

deen

Should we try setting Vulkan as default at some point? After it's been tested a bit more

why not open gl 3.3.0=

bcs intel opengl driver on windows suck

Vulkan is a good way to avoid these various driver issues since it's lower level

11:33

At least that was my understanding

most people i talked to disliked vulkan since it had multiple bugs

what bugs does it have?

and opengl support is kind of not ideal everywhere, since only few games use it

for example stuff like weirdness when two clients were opened or so

11:33

idk

They should report those bugs...

i never heard any complain from anyone tbh

11:34

actually it was the opposite

11:34

ppl with older AMD cards could finally run the game without laggs (rx 480)

i'll stick to 3.3.0

i mean do what u want

11:35

but if there is a problem for you pls tell

11:35

remember vulkan is just next gen opengl

maybe we can update PTS some day and check if lower end/older hardware profits from it or if it hurts or whatever

11:49

when i see that they name their benchmarks as "low end gpus" and then list rx vega 56 or rx 590 xDD

[ddnet:master] 2 new commits

394b2a0 Remove cl_show_quads bind - def- 0be35fb Merge #5016 - bors[bot]

15:57

[ddnet/ddnet] Pull request closed: #5016 Remove cl_show_quads standard bind

deen

Should we try setting Vulkan as default at some point? After it's been tested a bit more

Works fine for me

16:07

Dont know if related but sometimes when i open the minimized client its bad resolution and i have to minimize again then reopen

You can check if it only happens with Vulkan

i bet its an sdl issue xdddd just tested the latest sdl2 code

17:27

everything broken xD

17:27

2.0.22 gonna be fun

17:27

they want to release in 1 week Xd

17:27

https://github.com/libsdl-org/SDL/issues/5572

Restoring from minimized fullscreen broken · Issue #5572 · libsdl-o...

apparently (git bisected) 8bae343 (1) and 0249df9 (2) (i hope i did the bisect correct, bcs the (1) issue i only discovered while bisecting but not sure if i can reproduce it on the main code) brea...

17:28

but i linked ddnet, so we get some views from linux enthusiasts xd

Regarding vulkan as default: Idk why, i am playing tw since many years like that, but i cant play with vsync off. Everything feels so shaky and "too much responsive" when i turn vsync off. When i change the renderer to vulkan, its the same feeling. I dont know what vsync does and i am too lazy to google it, my fps are capped at 60fps when its turned on. But thats the reason i dont like to switch to vulkan.

vulkan also supports vsync

never could play with vsync

17:41

gameplay becomes sooo smooth and soo unresponsive

its the other way around for me :D

Vy0x2

Regarding vulkan as default: Idk why, i am playing tw since many years like that, but i cant play with vsync off. Everything feels so shaky and "too much responsive" when i turn vsync off. When i change the renderer to vulkan, its the same feeling. I dont know what vsync does and i am too lazy to google it, my fps are capped at 60fps when its turned on. But thats the reason i dont like to switch to vulkan.

what about your card?

graphic? Radeon RX 570 Series (edited)

if u turn on vulkan and vsync is your FPS set to 60fps or unlimited?

Its set to 60fps

then vsync is on

17:43

also with amd cards make sure to use drivers from march 2022 or newer

17:43

so newest drivers from amd directly

17:48

but anyway not like we drop opengl, if u need it for some weird reason to have more input delay xD i guess most ppl prefer lower input delay tho, so you are kinda an edge case

Yea i guess vulkan is too good and fast for me, it changes my timing a bit and i cant adapt after 10 years of playing

^^

u probs can adapt

19:27

u just dont give it enough time

19:27

usually 1 week is enough

19:27

human brain

yes i guess, havent tried longer than 30min

when yoc(a gores player) switched from vsync to non vsync he suddenly got insane player xD

19:55

true story

dont give me hope monkaS

monkaS

[quakenet] ChillerDragon

This code is run https://github.com/chidraqul/chidraqul5/blob/bd4bb4d506459b343e8c1689ba9877b9317e0dd0/src/client.rs#L153

still an issue? channel not receiving data, ChillerDragon?

hello, i'm coming here because i have a request (if it's possible ) about a ban. My friend have 100 hours on the game and yesterday (or somethings likes that) he got banned because he blocked a player. the problem is we spend so much time to play together and wee want to replay together but i'ts not possible. he knows what he have done and i want to know if it's possible to deban or minimalize his ban (oh and he is banned only on the map multiplayer, for the map solo he's not banned, it's weird ?)

1

[ddnet/ddnet] Issue opened: #5017 Generated files are out of sync with generating scripts

Should probably be tested in CI. scripts/generate_unicode_confusables_data.py scripts/generate_unicode_tolower.py CC @Chairn CC #4854

@heinrich5991 what's the problem exactly?

22:54

i noticed that some files are indeed useless

src/base/unicode/confusables_data.h and src/base/unicode/tolower_data.h were generated files

oh

now they were manually edited/moved without changing the generating scripts

i thought all generated files were in builddir/CMakeFiles/generated

we have some generated files that are checked into source control

22:58

a CI job verifying that they're up-to-date would probably be useful, as noted in the issue ^^

ill try to fix that within the week, im on my windows right now

oh, cool

im trying to find the file that i know is not included anywhere

22:59

yet, it's object file is used, i think it was about checksum

23:06

can't find it

[ddnet:master] 2 new commits

e428f6a Ignore F5 key press when ingame menu is open - def- 9be59a9 Merge #4678 - bors[bot]

23:25

[ddnet/ddnet] Pull request closed: #4678 Ignore F5 key press when ingame menu is open

Exported 261 message(s)