Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2022-04-20 00:00:00Z and 2022-04-21 00:00:00Z
06:51
i write that for compile the client from windows (edited)
06:51
change the path in the file
Avatar
[quakenet] ChillerDragon BOT 2022-04-20 07:37:44Z
@c0d3d3v it is probably other para groups messing it up. I can reproduce.
Avatar
[quakenet] ChillerDragon BOT 2022-04-20 09:05:29Z
Ok i rq debugging that fakin mouse world positions are no fun
🤣 1
Avatar
[quakenet] ChillerDragon BOT 2022-04-20 09:11:49Z
09:12
@danielkempf u here? -.- please do not starr my valueless fork. But starr the upstream project instead -.-
Avatar
ChillerDragon I think you're adding group offset to mouse world position for no reason
Avatar
Avatar
lynn
@heinrich5991 how the hell did you even notice this https://github.com/ddnet/ddnet/issues/4656
I noticed it on the tutorial map, during initial testing
Avatar
[quakenet] ChillerDragon BOT 2022-04-20 14:06:16Z
@Ravie that adds support for group offsets its tested to be useful. It is just missing parallax
14:06
@heinrich5991 what did you notice?
Avatar
ChillerDragon you don't need to care about offset or parallax, I think those get handled by rendering and don't affect positions in editor
14:15
int x = (int)UI()->MouseWorldX() / 32; int y = (int)UI()->MouseWorldY() / 32;this selects the layer correctly for me even if the group has offset and parallax
Avatar
or no it doesn't work when you're in another group :/
Avatar
[quakenet] ChillerDragon BOT 2022-04-20 14:32:30Z
Yea this works fine in the Update() method. But I feel like you said the issue arrises when you are switching groups. Or like checking tiles from a different group.
14:33
So you probably have to revert the current groups offset/para/clipping and add the other one
Avatar
i just made a interview with a german company that offered a rust job
14:46
PES2_Pray lets pray i get it
14:46
having german pay on spain also sounds good BASED
Avatar
remote job?
Avatar
Avatar
Ryozuki
having german pay on spain also sounds good BASED
catalan mafia remembers u
monkalaugh 1
Avatar
Avatar
deen
remote job?
ye
14:54
i dont think im prepared to move outside where i live
14:54
and lose all my friends
14:54
monkaS
Avatar
same, else i'd move to USA
14:54
make AMD GPUs great again
14:54
hehe
14:55
go work for amd
Avatar
and fix their drivers for ddnet
PepeA 1
Avatar
mesa drivers are the best already
14:56
i add compability layer for windows xd
14:57
@Ryozuki what kind of job is it
14:57
something econemy related, some startup?
Avatar
its like a startup
14:58
about security for companies
Avatar
nais
Avatar
"behaviour based security"
14:58
xddd
14:58
they have some machine learning in the stack or smth
Avatar
where i live, there are no startups xD
15:01
15:01
netflix said it lost users for first time in 10 years
15:01
i mean nothing holds forever xd
Avatar
yeah disney is too big player
Avatar
except herpes, this shit sticks to you
Avatar
no chance for netflix xd
Avatar
bittorrent is a big player
15:02
no chance for netflix xd
15:02
PES2_Pirate
Avatar
with the annoyance of having to buy 10 subs for movies again, it will defs rise again
Avatar
even if i have netflix, i still download them, the quality is just better
15:03
when ur not conditioned by a stupid algorithm that checks ur current resolution
15:03
to set the display quality
Avatar
bluekitty (edited)
Avatar
i dunno if that exists in spain but we have videobuster, they send u 4k blurays per post
15:04
even if u only get like 4-5 movies per month, i think its worth it more, bsc u can take the good ones xd
Avatar
Netflix has lost 200,000 subscribers in Q1 and expects to lose another 2 million in Q2.
15:04
monkaS
15:05
thats like 2.4 million monthly revenue
15:05
iirc
15:05
200k
Avatar
penauts
Avatar
american dollars
15:05
$$$
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
16.0.4
Avatar
DDNet 17
Avatar
ddnet 17 needs something big
Avatar
vanilla breakage xd
15:23
poggers
15:23
fast math in rust
Avatar
nice
Avatar
@Jupstar ✪ have u ever written a language?
15:25
i want to learn to make one with llvm
15:25
ryolang
15:25
ryo-os + ryolang = boom
Avatar
i tried to make a integer forced logic module with c++ templates that automatically forces you to range check all integer based math
15:26
but was too much work to write stuff in xd
Avatar
even tho i have some ideas for languages, e.g. better type safety by not allowing stuff like int generally but requiring to explicitly cast (nice to prevent logic errors like Function(i, i) instead of Function(i, n) i am not really motivated to think about all the edge cases u can fall into xD
15:28
when i look how insanly huge rust and c++ are
Avatar
@Ryozuki there is a tutorial for that in case you didn't know: https://llvm.org/docs/tutorial/MyFirstLanguageFrontend/index.html
15:29
i have it bookmarted
15:29
bookmarked*
Avatar
hear me out a ddnet os would be called DummyDrag OS purposefully shortened to DDOS since thats what ddnet has basically come to now
Avatar
finish #4791 and i setup a proxy for ppl i trust
Avatar
The proxy server is supposed to prepend the client IP address and port in the first 18 bytes of a packet. IPv4 addresses are represented using IPv4-mapped IPv6 addresses with the prefix ::ffff:, e....
Avatar
and i invite u ^^
Avatar
isnt heinrich back
Avatar
dont stress him out
Avatar
i dunno why he left xd
15:31
hopefully not bcs stress
Avatar
he takes his vacations i think
15:31
honestly idk how he does it
15:31
i find it hard to not look at discord
15:31
i guess im addicted
Avatar
yes
15:32
social media
Avatar
meet with more friends and discord gets less interesting xd
Avatar
i do meet with friends xd
15:32
but i mean
15:32
idk
Avatar
play football every day and u forget u are coder
Avatar
i usually have this phase in summer xd
15:33
and u sweat crazy
15:33
here it gets hot af
Avatar
in germany u can finally go outside without your winter jacket
Avatar
the interviewer mentioned the sun in spain
Avatar
886b651 Update Korean translations by CHaBek - cwh7435 3cf8048 Merge #5011 - bors[bot]
Avatar
i guess spain is just that
Avatar
the sun
15:36
the climatei s a bit weird tho
15:36
cuz its not usually cold in april
15:36
and here it is rn
15:36
the world is fucked
Avatar
april macht was er will xd
Avatar
A project more than one year in the making by Emma Anholt is about to mark its completion with GLSL-to-TGSI set to be removed from Mesa whereby Gallium3D will always go through the NIR intermediate representation while older drivers still dependent upon TGSI will make use of the NIR-To-TGSI pass
16:03
Those with older GPUs can also celebrate since this effort to go through NIR means the possibility of better performance, fixes, and better tested code in general.
Avatar
-23k lines
16:25
ez
Avatar
@deen https://github.com/ddnet/ddnet/pull/4980#issuecomment-1104137791 I collected the maps that are affected by PR 4980
this should not be directly merged as it changes the physics of maps When a player was solo, plasma turrets always fired whether they were on or off. This changes the physics of all maps that use P...
Avatar
oh noes physic changes
cammo 1
Avatar
@c0d3d3v can this be fixed by making the affected maps always be on?
16:35
or is something more complicated
16:35
by fixed i mean implementing this fix and modifying the maps
Avatar
xD you want the maps to stay broken? (edited)
Avatar
ye there is no other solution
16:37
we can actually use
16:37
our bug interface
16:37
that allows a bug on certain maps
16:38
xd
16:38
{{"Binary", 2022597, s("65b410e197fd2298ec270e89a84b762f6739d1d18089529f8ef6cf2104d3d600")}, BugToFlag(BUG_GRENADE_DOUBLEEXPLOSION)}};
16:38
we already do this for the double grenade
Avatar
Increase Your Speed and Fall into the Future got released before the bug
Avatar
but maybe there are ranks
16:39
after the bug appeared
Avatar
TurboSeks was allways borken
16:39
I think in Time Shop noone used the bug because you would have to do the team map solo
16:40
just delete or keep the ranks xD on oco there are also a lot of cheated ranks... noone seems to care (edited)
Avatar
we cant delete ranks
16:41
its hard to know
16:41
and we keep the ranks but it has to be fair for future runners
16:41
thats why mapbugs.cpp exists
16:41
xd
Avatar
just move the start and finish tiles closer to each other xd
16:42
some skips may be to big for that
Avatar
I would definitely re-release "Increase Your Speed" because this map makes no fun with the bug. It is a complete diffrent map with the bug (edited)
16:44
And in "Fall into the Future" we could just always activate the turret... its just a troll part, everyone who knows can skip it
16:46
"TurboSeks" can just stay as it is, pro players do the part first try anyway
Avatar
how does it affect solo again
16:47
and the turrent part in turbosecks is random
Avatar
currently in solo turrets are always active
Avatar
oh not the turrent
Avatar
with the patch they get swtiched correctly
Avatar
but the puller is random
Avatar
Avatar
heinrich5991
I noticed it on the tutorial map, during initial testing
ohh makes sense actually xd
17:12
actually now that you mention it it's the same for 0 jumps
17:13
er no
17:13
not particles, but you see the jump key above their head
17:13
maybe intended
Avatar
Avatar
lynn
not particles, but you see the jump key above their head
xD definitely not intended I also saw this... its annoying. You do not press the key so it should not display it in my opinion
Avatar
ya i agree 100%
17:41
maybe show it if they truly are pressing it when they have no jumps but what's the use anyway
17:49
there are some pretty easy issues to fix here, if anyone has the time
17:50
I'm not great at C++ but I don't have time today to look into them regardless
17:50
ive added labels to all the new issues and modified the others to be more accurate
17:51
and further, is this an acceptable place to talk about xpanic dev? i assume if there were any other modes we were maintaining the discussion would happen here instead of somewhere less topical, like #off-topic (edited)
Avatar
Avatar
lynn
maybe show it if they truly are pressing it when they have no jumps but what's the use anyway
mh good idea, could be added in the new HUD xD
Avatar
definitely (edited)
17:54
is it planned to have no hit shown as well as if you have the weapon? imo it would be like, show the sprite if u have it, use the same sprite for no hit, with a line through it
17:54
but dont put like two of the same sprite
17:54
seems weird
Avatar
what xd
17:55
yes no hit is shown
17:55
you can customise it
Avatar
ye i mean to say, if you have grenade and its disabled, it would not show a clean sprite and a line through another one, just one with a line through it
17:56
and back to a clean one if hit is enabled
Avatar
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/hud.png at New_HUD · C0D3D3V/ddnet
Avatar
ohhh it doesnt show what weps you have?
17:56
might be useful
Avatar
it does
17:57
it uses game.png
Avatar
in addition to this
Avatar
ravie did not like the idea
Avatar
i guess that's something
17:57
just my idea was to use the nade sprite as a clean version
17:57
if you have nade
17:57
line through if it's disabled
17:57
dont show two separate icons, takes up space
17:58
and i think the asset should not be grabbed from game.png... we already have tons of shit like this
17:58
x_ninja
17:58
default tee
17:58
stuff that you just have to know about instead of a setting to change it
Avatar
I can send you a the latest video I made with the hud, then you can tell me if its ok, wait I look it up
Avatar
make a new file with the wep states and let people make them with their game.png if they really want it
Avatar
You can change hud.png in assets settings
Avatar
imo it would be easier to read even if someone is used to their game.png
17:59
it's easily recognizable
17:59
sure yea
17:59
send it over :D
18:01
well, since xpanic does not compile on Windows, i guess ill just try to make a change and someone can test it
Avatar
https://streamable.com/1el5z1 is a bit old but most of it is still the same
Avatar
as this is my repo im just making a lynn branch, you cant tell me not to :D
18:02
timer for ninja is pretty cool
Avatar
Avatar
c0d3d3v
https://streamable.com/1el5z1 is a bit old but most of it is still the same
do u actually have this weird flickering ingame?
18:03
or is your recording software just broken xD
Avatar
oh you already have this in-game
18:04
with the line through it
Avatar
obs can not record teeworlds at all, it has big laggs. SimpleScreenRecorder can record in 1080p without problem but creates this flickering
Avatar
but im not sure what all the greyed out weapons are for
18:04
what you're currently using
18:04
?
Avatar
Avatar
c0d3d3v
obs can not record teeworlds at all, it has big laggs. SimpleScreenRecorder can record in 1080p without problem but creates this flickering
mhh are u on wayland?
Avatar
obs runs smooth af for me xd
Avatar
I have intel cpu
18:05
xD without gpu
Avatar
ah
Avatar
this doesnt seem like a hardware issue xd
Avatar
my notebook laggs also with more than 1 teeowrlds open
Avatar
i was gonna say its software
Avatar
intel gpus are my favorite
18:06
they never have bugs
Avatar
and the recording was also with opengl, I rebased last week 😄 maybe next recording with vulkan gets better
Avatar
lets hope so^^
Avatar
Avatar
Jupstar ✪
mhh are u on wayland?
I should be on X11, but I check it, one moment...
18:08
yes its X11
18:09
i5-6200U CPU @ 2.30GHz
Avatar
nice so smth like intel hd graphics 630
18:10
deen also has it
18:10
and also always 0 problems xd
Avatar
Avatar
lynn
but im not sure what all the greyed out weapons are for
the transparent weapons are the weapons you can select
Avatar
yea makes sense
Avatar
Avatar
Jupstar ✪
and also always 0 problems xd
I currently have flickering with Vulkan on that CPU though
Avatar
xd
Avatar
but what do you use for recording?
18:14
It is btw Intel® HD-Grafik 520
Avatar
but u are on arch right=?
Avatar
actually the one thing intel is actually good at is VAAPI
18:15
which intel itself developped
18:15
weird it runs so bad
18:15
Avatar
@deenhi dude pleas accept my friend request ❤️
Avatar
sorry for german, but this is the only encoder I can select. But I just install obs-hevc-vaapi-git maybe that helps
18:21
Avatar
Avatar
c0d3d3v
sorry for german, but this is the only encoder I can select. But I just install obs-hevc-vaapi-git maybe that helps
i dunno
18:22
but u also need vaapi from your driver package
Avatar
@murpi
Avatar
smth like i965-va-driver
Avatar
its iHD
18:24
and I already have intel-media-driver installed
Avatar
@murpidude accept my friend request
Avatar
Why? You can just dm me without sending a friend request
Avatar
great.... now Github changed their Ubuntu runner again
Avatar
@murpiI have something to do with the game
Avatar
how to select the right version with apt?
18:25
ill share the config
18:25
name: Compile server on: push: branches: [ main ] pull_request: branches: [ main ] jobs: build: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: Install bam run: sudo apt install bam=0.4.0-5 - name: Compile binary server file run: bam server_release
18:25
this is possibly an out of date way to write the command now
Avatar
Avatar
murpi
Why? You can just dm me without sending a friend request
No I can not
Avatar
most mods do not have messages restricted to friends
Avatar
@murpisorry for tag pleas open dm
Avatar
my dm's are open
Shyggers 3
Avatar
im not even murpi's friend and i have a long history with them
Avatar
Avatar
murpi
my dm's are open
dude ! No I can not pm
18:27
18:27
@murpi
Avatar
possibly your own user settings prevent this? i dont think that's it though
18:30
shrug
Avatar
hm, @murpi seems there's just one place that the message is rendered, in CHud::OnRender()
18:46
ill make a simple PR
18:46
oops deen requested this not you
18:46
damn i keep pinging you for no reason troll
18:51
i will never ping again today
18:51
u-unless you like it baka
Avatar
Avatar
Learath2
uwu
would you sub if i had jiggle physics
Avatar
no, I stopped simping, it's unhealthy
18:53
doubt
18:53
once a simp always a simp
Avatar
you guys saw hetzner has a USA location now? poggers
19:01
Cloud servers starting at € 3.49. A little money gets you lots of cloud. Our flexible billing model and clever interface make it easy to use our cloud servers for all your IT needs.
Avatar
here is my referral hetzner link https://hetzner.cloud/?ref=c5CYKx0H7EoL
19:10
BASED
19:10
it gives u free 20€ if u register
19:10
BASED
Avatar
someone tell me im not an idiot and this is all i have to remove
19:11
for a simple C++ method
19:12
header file, declaration, calls to it (edited)
19:12
the runner is broken so i cant test
Avatar
doesn't that just remove it from the client? does xpanic require a custom client for the gamemode? idk
Avatar
no, this removes it from the server
19:21
it's entirely server-side
19:22
i did my best to look for instances of it
Avatar
am I stupid? it says game/client/components
Avatar
ctrl-shift-F for the main method
19:22
im not sure, you dont need another client
Avatar
but you're changing the client render code? how would that affect the server
Avatar
hmm good point maybe there's more code that i havent found yet
Avatar
@lynn bruh this is the client ur modifying
Avatar
i think there's more i need to change
19:24
im not sure why the client was even edited like this then xd
19:24
maybe there used to be an xpanic client
19:25
ill keep digging
Avatar
@lynn put this in config
19:25
"sv_teambalance_time 999999"
19:25
no code changes
Avatar
ah well regardless
Avatar
maybe 0 disables it
Avatar
MACRO_CONFIG_INT(ClWarningTeambalance, cl_warning_teambalance, 1, 0, 1, CFGFLAG_CLIENT|CFGFLAG_SAVE, "Warn about team balance")
Avatar
but idk
Avatar
there's just a flag
19:25
for it
19:25
use it
Avatar
i am not an admin
19:25
thats for the client
19:25
thats useles
19:26
wait yea, cl
19:26
FUCK
19:26
who wrote this
Avatar
it should disable it but people need to do it manually
Avatar
curse kurosio
19:26
yeah
Avatar
u cant disable team balance warning
19:26
it depends on the client
Avatar
so this is not something they added to the client
19:27
this is just a teeworlds client thing
Avatar
this is from vanilla
Avatar
yea i see
Avatar
you could miss report the team sizes to client xD
Avatar
well, can't be avoided then
19:27
yeah true
19:27
but
Avatar
actually the best way would be
Avatar
doesn't that affect server stats
Avatar
if the ddnet client adds a server cabality flag for unbalanced teams or smth
19:27
but thats just for ddnet client
Avatar
is "sv_teambalance_time" something the server will recognize?
19:28
im not finding it anywhere
Avatar
if it's a part of vanilla then this mode really needs to be rebased
Avatar
its in vanilal settings
19:29
vanilla*
Avatar
yea this thing is ancient then, it's not in the code
19:29
or maybe
Avatar
what is this gamemode about?
Avatar
it was specifically removed
19:29
it's a zombie infection mode
19:29
with level up skills
Avatar
ah level up
19:30
its not the one i played
Avatar
it's a panic mode
19:30
they were very very popular
Avatar
old infection on the mario map was epic
19:30
the hammer wall skillz
19:30
i had
Avatar
there was the plague mode
Avatar
anyway, i think we need to close this issue or mark it as part of the rebase issue
19:31
for now i wont touch it xd
Avatar
u should rewrite the mod
19:31
Contribute to teeframe/ddnet-skeleton-readme development by creating an account on GitHub.
19:31
it is a stripped down ddnet
19:32
used as a base for modding
19:32
this is gods work
19:32
u will get 64p + all the fixes in ddnet
19:32
ur xpanic mod probs cant handle utf8 names
19:32
xd
19:33
to be clear its not my mode, i just made like 1-2 fixes for it
19:33
i think this is a rewrite kurosio did
19:33
based on what i could find online
Avatar
do u know if it is big
19:33
code wise
19:33
maybe il ltake a look someday
Avatar
it doesn't seem that bad
Avatar
but its a bit useless, since nobody plays mods
Avatar
it's just not super well coded i guess
Avatar
my teesmash sits there
Avatar
people really like xpanic though
19:34
literally GER is always full
19:34
i havent been able to play once there
Avatar
is it possible to rebase without the original commits?
Avatar
Avatar
Tater
is it possible to rebase without the original commits?
reset or what
Avatar
talking about this code https://github.com/kaitlynia/xpanic
don't xpanic, it's game. Contribute to kaitlynia/xpanic development by creating an account on GitHub.
Avatar
yeah we need to use the skeleton as posted above
Avatar
is the databse shared across ger and usa for accounts
Avatar
that's already an issue in github, i can add it as a comment (edited)
19:40
I just noticed that there are different account lists on the German and the American xpanic server. I propose a crossover of both servers. This means that if you level up an account on the German s...
19:41
not commit wtf, comment
Avatar
but how can you distinguish ddnet code from xpanic code if it was added at the same time?
Avatar
it's pretty easy to tell
19:42
just take the stuff that's absolutely required like the new doors, stationary nades, level up related mechanics
19:42
turrets
19:42
mines (edited)
19:42
i think that's it
Avatar
I mean for the purposes of doing a rebase automatically
Avatar
any localized strings not in vanilla
19:42
i dont know about automatic, probably shouldnt
Avatar
yeah maybe so
Avatar
@lynn maybe ill do it
19:45
i can also add database support for stats
19:45
always fun
19:45
well the ddnet skeleton probs has it
Avatar
i think imma fix some other stuff right now in the meantime
19:47
not allowing new map votes for zombies
Avatar
oh xpanic 🥺 thanks to him, I started learning programming in 2011, I remember then for 30 rubles I bought the Xpanic source code from Spok and ReDFoX43Rus and started poking around in it just changing the numbers)
Avatar
you had to pay for it? lol
Avatar
Avatar
Matodor
oh xpanic 🥺 thanks to him, I started learning programming in 2011, I remember then for 30 rubles I bought the Xpanic source code from Spok and ReDFoX43Rus and started poking around in it just changing the numbers)
can we compare? maybe your version is better
Avatar
Avatar
Tater
you had to pay for it? lol
yes, the sources were private, but they were sold to me by a friend who betrayed them 🤣
Avatar
i want to find the most "complete" version people remember
19:49
whatever is nostalgic for people
19:49
im adding an issue for removing all the pay2win strings
19:49
there used to be ranks, there are commands for this and logic even
Avatar
original mod is wPanic (without accounts system)
Avatar
yea i know wPanic
19:50
but xPanic apparently has more
19:50
there is also zPanic
19:50
which supposedly had more features but is somewhat broken (?) (edited)
19:50
never got to test it properly
Avatar
history of *Panic mods: wPanic -> xPanic (by ReDFoX43Rus & $pokXXL) -> mPanic (m just Matodor xD) -> oPanic (new version byReDFoX43Rus ) -> xPanic (remake by kurisio) (edited)
Avatar
thank you so much for this
19:51
what features specific did m/o add?
19:51
and are they still contained in this remake?
19:52
@Matodor ping sry
Avatar
Avatar
lynn
what features specific did m/o add?
🤣 They just worked steadily, the main advantage was that they did not shutdown)
20:01
so no real features, just support
20:02
i would guess xPanic is still the most stable version
20:02
what is xPanic based off of? if i can ask
20:02
0.6?
20:02
forgot ping again @Matodor
Avatar
Avatar
lynn
0.6?
by kurosio? 0.6.3?
20:03
thank you
20:03
didnt change
20:04
wait to make sure that's the right repo
20:04
show the latest commit
20:04
name
20:04
fuck i keep forgetting ping @Matodor
Avatar
ehh yea i think this is what i forked
20:04
thanks again
Avatar
this is why I started programming
Avatar
is it normal for teeworlds codebase to be riddled with all these php-equivalent commands monkaS @Ryozuki
20:54
or does kurosio just really like php methods (edited)
Avatar
show example
20:54
php copied c and bash
20:54
not the other way around
20:54
xd
20:54
its php who copied tho
20:55
-> is used when the type ur dealing with is a pointer
Avatar
instead of ur usual .
20:55
dot
Avatar
ok i see now
Avatar
if u hover
20:55
gamserver()
20:55
and u have a good ide
20:55
u will see the type has *
20:55
it means its a pointer
Avatar
if it says "__cdecl" ?
20:56
what part of this should suggest it
Avatar
but i meant gameserver()
20:56
not scanff
20:56
xd
20:56
20:56
Msg too
20:56
also if the variable name has m_
20:56
and then a p
20:56
m_p
Avatar
so the result from -> is the object
Avatar
its a pointer
Avatar
but initially it's a pointer
Avatar
Normally TW code doesn't use C standard lib much directly, mostly through system.c
heartw 1
Avatar
just treat -> as a dot
20:57
its the same
20:57
so like pointer dot
20:57
xd
20:57
theorically it means like "access the method this pointer points to"
20:57
or smth like that
20:57
it makes sense to me
20:57
i think
Avatar
its normal to not get pointers
20:58
they are an abstract thing
20:58
that take time to learn
Avatar
huh, kind of clever way
20:58
if(!strncmp(Msg->m_pMessage, "/", 1)) { LastChat(); GameServer()->SendChatTarget(m_pPlayer->GetCID(), "Wrong command. Use /cmdlist"); }
20:58
makes sense though
20:58
at the end of chain
20:58
actually why is this not else if xd
20:58
SMH THEY AHVE return IN EVERY ELSE IF
20:59
im changing this for sure
Avatar
strncmp is special
20:59
it returns 0
20:59
if it matches iirc
20:59
so by doing !0
20:59
it means 1
20:59
which is true
21:00
so it evalutes that branch
21:00
its more readable to do strncmp == 0
Avatar
Avatar
lynn
SMH THEY AHVE return IN EVERY ELSE IF
its not wrong to have returns inside if or else if
21:00
also, to have an else if you first need an if
21:00
thats why u just use a negated if
Avatar
no they have explicit return; in every else if when it's only because the last if is not else if
21:01
if the return doesn't have a value
Avatar
sometimes it does
Avatar
read DeMorgan's Law
21:01
doing the else if in ifs
21:01
xd
21:01
for*
21:02
eh
21:02
show code
Avatar
yea i dont think u get what i mean
21:02
don't xpanic, it's game. Contribute to kaitlynia/xpanic development by creating an account on GitHub.
21:02
Ctrl-F "return;"
21:02
then check the last if
Avatar
u can click on the line number btw
21:02
and it links thee
Avatar
there's tons of places to look xd
21:03
its the chat command handling
Avatar
yes they can just write else if there and reduce the return; usage everywhere
21:04
if it's it's at the very end of the else if
21:04
if it's a short-circuit, fine
21:04
but 99% are not
Avatar
well i dont think it matters the return
Avatar
and why is it half if half else if here xd
21:05
code is wacky
Avatar
i find it funny the commands is under the entities folder
21:06
no idea why (edited)
21:06
but anyway this stuff bothers me personally so im fixing it xd
Avatar
the correct way is to remove all those commands there
Avatar
if you're really going to use an else if chain at least write it in a sane way
21:06
oh
Avatar
yea i know, but i dont wanna touch too much, im noob
Avatar
ill leave that to someone else
Avatar
it doesnt look like it supports it anyway
Avatar
where are these checked anyway?
21:07
for ddrace
21:07
here
Avatar
the actual string comps
21:07
got it
Avatar
in ddnet we use this macro
21:07
it handles it
21:08
ya i like it
21:08
not the coolest way but not sure if there are things like dicts in C greenthing
Avatar
a dict is a hashmap kinda
Avatar
we can also remove all these LastChat() calls into a call at the top
21:27
or remove the call and put the code there
21:28
no idea why it exists
21:28
im fixing stuff that doesnt need fixing, as expected
Avatar
@Ryozuki u think this is the only place new votes are considered? https://github.com/kaitlynia/xpanic/blob/main/src/game/server/gamecontext.cpp#L226
21:36
i wanna prevent zombies from making their own votes
21:36
or at least prevent |map| ones
21:37
the only thing i have available in the method it's called in is int ClientID
21:37
maybe i can get to the zombie flag from that
21:39
oh it's just m_Team
Avatar
Avatar
ReiTW
where is https master code located btw?
Some Teeworlds stuff in Rust. Contribute to heinrich5991/libtw2 development by creating an account on GitHub.
Avatar
oh we're actually using the Rust stuff in prod? that's cool
21:41
at least some
Avatar
@heinrich5991 ah lolthen someone sent me the wrong git repo, was on twmaster-collect
21:45
would be great for you to have such a "ban" feature aswell on https master
Avatar
ok i think i got it
21:56
Avatar
Avatar
[quakenet] ChillerDragon
Click to see attachment 🖼️
can you send that cmake php missing error as not a screenshot? ChillerDragon
Avatar
Avatar
lynn
@Ryozuki u think this is the only place new votes are considered? https://github.com/kaitlynia/xpanic/blob/main/src/game/server/gamecontext.cpp#L226
nvm unpreventable because it's determined in the client, if it receives NETOBJTYPE_CLIENTINFO
22:25
if we just don't send this i assume other stuff breaks
22:27
if we put TEAM_SPECTATORS in m_Team when the netobj is sent, im sure that messes with xPanic logic and UI
22:31
my suggestion is to just not show the message in the client if CServerInfo::m_aGameType is not equal to any vanilla mode or any ddrace mode
22:31
i guess we can check for fng too
22:32
only problem is that people use this for other stuff, like showing additional server info
22:32
many different strings here. substring for "fng" i think is also a lazy solution
22:35
race modes ive seen: DDrace, TestDDrace, Race, +DDRace, iDDRace, XXLDDRace, and PPRace
22:35
so i guess if the substring method is viable we can also check for "race"
22:36
I'm not sure how DDrace has done away with teams, whether that's based on CServerInfo::m_aGameType or not
22:37
but maybe there's some logic there to modularize and create a similar thing for *Panic modes
22:38
ive spent way too long on this, gonna give it a rest
Avatar
ah, finally finished the #developer chat for the last 1.5 months
22:48
only took like 3 hours 😛
Avatar
yay now you can help me determine the best way to hide team balance messages from modes that are asymmetric
22:50
we could just build a list of "infect" modes in the client, is this an appropriate solution?
Avatar
no. add a flag to game info I guess
Avatar
if CServerInfo::m_aGameType is an exact match, we could include a flag not to show this message
22:51
hmm for servers? and if they support the flag and have a value for it, ignore message
22:51
since right now there is a flag for teambalance but it's on the client
Avatar
for servers to send to the client
22:52
if the client sees the flag, it won't show the message
Avatar
yea good idea
22:53
well, either way it requires a change on ddnet client, so ill deprioritize it for now
22:53
having this kind of open-ended client-server relationship leads to some interesting solutions xd
Avatar
that change is probably quite easy and could be added
Avatar
yea it seems like it is
22:54
i could prep so the commit would be in tandem with it, but i would stick it in a new PR
22:54
im making one for the rest of the issues
22:55
and i need to ACTUALLY fix my github runner
22:55
they changed apt or ubuntu or something
Exported 649 message(s)