Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2022-03-23 00:00:00Z and 2022-03-24 00:00:00Z
Avatar
and obviously, without complaining...
Avatar
Avatar
Patiga
@Ryozuki yo have you touched platform-dependent dependencies before? I'm making twmap wasm-compatible rn, so I switched from zlib-sys to flate 2 with the zlib backend, and for wasm flate 2 with the rust-native backend https://doc.rust-lang.org/reference/conditional-compilation.html ^ this leads me to believe my dependencies should look smth like this: [target.'cfg(target_family = "wasm")'.dependencies] flate2 = { version = "1.0.17", features = ["rust_backend"] } [target.'cfg(not(target_family = "wasm"))'.dependencies] flate2 = { version = "1.0.17", features = ["zlib"] } However, this apparently isn't it yet. However my observations while fiddling around a bit seem so damn contradictive that I wanted to see if you might have an idea: with the configuration above, both the wasm and non-wasm build use the zlib backend if I remove the first two lines, the wasm build fails due to flate2 being an undeclared crate or module and the non-wasm build succeeds If I change the zlib to rust_backend in the bottom two lines both wasm and non-wasm builds use the rust_backend
righto figured it out. apparently there is a feature resolver version 2 that does some stuff differently, in particular the first bullet point https://doc.rust-lang.org/1.59.0/cargo/reference/features.html#feature-resolver-version-2
Features enabled on platform-specific dependencies for targets not currently being built are ignored.
01:58
will these be added to the main menu?
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
afb205c Check pTexName for nullptr, fix wrongly height->width - Jupeyy f67f4ee Merge #4871 - bors[bot]
11:18
epic
11:57
can anyone tell me what these flags indicate?
11:58
to the left of map names
Avatar
if your name has a finish on this map
11:59
that's really nice feature
11:59
doesn't work in Internet tab tho
Avatar
  • [Client+Server] Exception handling on Windows (Crash reports in %APPDATA%\Teeworlds\dumps) [Jupeyy] Im at rc1 so i have newest version. My client just crashed and report didnt saved there.
Avatar
then it might have been killed by the operating system
12:05
e.g. using too much memory
Avatar
mhh weird one
Avatar
yeah i am also not sure when exactly the lib does not work i created some crashes on purpose and then it worked but with out of memory in 32bit it didnt trigger anything
Avatar
i have 10gb ram unused while running the game.
Avatar
yeah maybe its something different, you can look if it also crashes in the auto demo
12:10
tho it probs didnt write the crashing part to disk yet xd
12:11
or try to reproduce it by remembering if smth special happened
Avatar
no idea i made the exact same thing before it crashed didnt crashed this time lets hope it does not crash again (edited)
Avatar
Avatar
bencie
doesn't work in Internet tab tho
different master servers, ddnet master has all the player info
Avatar
game crashing alot when i'm in assets menu
12:34
rc1, vulkan renderer
Avatar
you run out of VRAM
12:35
press CTRL+SHIFT+D to see how much you are using
Avatar
[quakenet] ChillerDragon BOT 2022-03-23 12:36:08Z
is unique still a thing? does someone have a list of active long lasting clans?
Avatar
Avatar
Jupstar ✪
press CTRL+SHIFT+D to see how much you are using
349529k/1527602k/20992k/49152k
Avatar
how much vram does ur GPU have?
12:38
or what is your GPU?
12:38
i'd defs suggest to remove some assets or skins you dont use
Avatar
1050 ti
Avatar
1.5GB is really a lot
Avatar
yeah thats possible
12:38
but never had this issue with opengl
Avatar
maybe the driver doesnt upload unused images directly, or reads unused images back from gpu and puts them into shared memory
12:39
but that usually slows down the computer anyway i'd suggest to lower the load
12:39
thanks for the help :)
Avatar
but yeah, ddnet should really lazy load more images
12:58
does ddnet do some ban evasion protection with false positives or who is that? kog?
Avatar
why do u take trolls seriously
13:12
just read his name
13:16
@Jupstar ✪
13:16
i get a a segfault
13:16
```WARNING: radv is not a conformant Vulkan implementation, testing use only. [2022-03-23 14:15:52][vulkan]: vulkan error: The device surface capabilities could not be fetched. [2022-03-23 14:15:52][assert]: /home/ryozuki/Documents/ddnet/src/engine/client/backend/vulkan/backend_vulkan.cpp(1094): The device surface capabilities could not be fetched. Illegal instruction (core dumped)```
(edited)
Avatar
[2022-03-23 14:15:52][sdl]: SDL version 2.0.20 (compiled = 2.0.20) [2022-03-23 14:15:52][gfx]: Created Vulkan 1.0 context.
Avatar
"The device surface capabilities could not be fetched." Are you on wayland? XD
13:17
as far as i know no lol
Avatar
On failure, this command returns VK_ERROR_OUT_OF_HOST_MEMORY VK_ERROR_OUT_OF_DEVICE_MEMORY VK_ERROR_SURFACE_LOST_KHR
13:18
mhh weird
13:18
i'd say your setup is broken
Avatar
❯ echo $XDG_SESSION_TYPE tty
13:19
lol
13:19
it should say X11 right
13:19
or wayland
13:19
but it tells tty
13:19
xD
Avatar
XD
Avatar
are u chillerdragon or what
13:19
running everything in terminal
Avatar
i gues i need to add
13:20
export XDG_SESSION_TYPE=X11
13:20
to my xinitrc
13:21
@Jupstar ✪ its because i dont use a login manager
13:21
which usually sets this stuff
13:21
and i forgot to sety this envar
13:21
i guess
13:24
ok it still crashes
Avatar
where now?
13:25
does vkcube work?
13:25
yep
13:25
smooth af
13:25
WARNING: radv is not a conformant Vulkan implementation, testing use only.
13:26
i keep seeing this everywhere tho
Avatar
yeah but u can ignore that xd
Avatar
is there a way to force to use amdvlk or radv?
Avatar
maybe buggy SDL2 version?
Avatar
i got both installed
13:27
SDL version 2.0.20 (compiled = 2.0.20)
Avatar
i dunno, but you can overload vulkan ICD
13:27
VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/radeon_icd.i686.json
13:27
just need to use amdvulkan json
13:27
dunno where that is tho xD
13:28
starting it with amdvlk works
13:28
but
13:29
im missing some font i think
Avatar
yeah
13:29
make clean data dir i'd say
Avatar
oh wait
13:29
i was launching my ddnet not the new one
13:31
i figured it out
13:31
i need to set AMD_VULKAN_ICD=RADV
13:32
amdvlk works too
13:32
i guess without it it simply doesnt choose a driver xd
Avatar
lol
Avatar
which one is better?
13:33
radv or amdvlk
Avatar
radv xd
13:33
but you can test with amdvlk too
13:33
nori has same gpu generation like u
13:33
and he said zooming out is bad with radv
Avatar
Avatar
Jupstar ✪
nori has same gpu generation like u
he has a 6600 xt?
Avatar
i dunno which exactly
13:34
but the architecture 6600xt uses too
13:34
gcn2 or what is it
13:34
navi10
Avatar
if u open the new ddnet and then the old ddnet, on the old the icons are fcked xd
Avatar
cant remember
13:34
^^
Avatar
Built on the 7 nm process, and based on the Navi 23 graphics processor, in its Navi 23 XT variant, the card supports DirectX 12 Ultimate
Avatar
add curent path icons
Avatar
@Jupstar ✪ i noticed, when using radv the reported vulkan version is 1.2.x but with amdvlk its 1.3.x
Avatar
guess your mesa is a bit behind
13:36
or mesa generally
13:36
dunno
Avatar
GPU renderer: AMD RADV DIMGREY_CAVEFISH
13:36
xd
Avatar
@Jupstar ✪ are u using pipewire?
13:51
i migrated from pulseaudio to pipewire today
Avatar
not yet
Avatar
Pipewire: Audio and Video on Linux
Avatar
and is it as great as ppl say?
13:54
since i didnt configure pulseaudio much
13:54
so it was seamless change form e
13:54
but it says it does this
13:54
>
Capture and playback of audio and video with minimal latency. Real-time Multimedia processing on audio and video. Multiprocess architecture to let applications share multimedia content. Seamless support for PulseAudio, JACK, ALSA and GStreamer applications. Sandboxed applications support. See Flatpak for more info.
Avatar
yeah sounds good, i have pulseaudio changes for my mic
13:55
so maybe i'll wait a bit xd
Avatar
and for apps that dont explicitly support pipewire
13:55
there is pipewire-pulse
13:55
which is like a transparent proxy
13:55
xd
13:56
well
13:57
As far as I understand pipewire-alsa and pipewire-pulseaudio were folded in to pipewire upstream, but still exist as separate packages in Arch because of dependencies with 3rd party applications (e.g. requiring/replacing pulseaudio).
13:57
ah thats just an arch linux thing
13:57
xd
13:58
it seems pipewire also has better bluetooth support
14:00
While SDL2-enabled games/applications can already work on PipeWire-based systems like the forthcoming Fedora Workstation 34 thanks to the PulseAudio compatibility layer, the SDL2 library has merged initial support for interfacing with PipeWire.
14:00
maybe we can enable native pipewire support on ddnet
14:04
[2022-03-23 15:04:20][audio-ryo]: audio driver: pulseaudio [2022-03-23 15:04:20][audio-ryo]: audio driver: alsa [2022-03-23 15:04:20][audio-ryo]: audio driver: jack [2022-03-23 15:04:20][audio-ryo]: audio driver: pipewire [2022-03-23 15:04:20][audio-ryo]: audio driver: dsp [2022-03-23 15:04:20][audio-ryo]: audio driver: disk [2022-03-23 15:04:20][audio-ryo]: audio driver: dummy
14:04
oh
14:04
they are already there
14:04
but it chooses pulseaudio first
Avatar
funny how thats the lib for everything
14:08
video audio..... BLUETOOTH xD
14:08
but i assume they mean like bluetooth headsets or smth
Avatar
[2022-03-23 151105][client/sound]: sound init successful using audio driver 'pipewire'
14:11
i can force it with SDL_AUDIODRIVER=pipewire ./DDNet
14:11
xd
14:12
sdl is like the curl of graphics
14:12
it supports everything
Avatar
Is the code for ddnet.tw/mapreview opensource? I have the idea, to but coordinates in the url and make it embeddable in discord.
Avatar
Avatar
Ryozuki
[2022-03-23 151105][client/sound]: sound init successful using audio driver 'pipewire'
nice grass_main
Avatar
the video renderer works well
Avatar
Avatar
CHaBek
will these be added to the main menu?
No, they will be shown when you start client for first time. Try setting cl_show_welcome 0 and restart client to try it out.
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
Avatar
deen
No, they will be shown when you start client for first time. Try setting cl_show_welcome 0 and restart client to try it out.
Is there an argument against adding it to the menu? As cheeser said, some might exit the server and then not find back into the tutorial (https://discord.com/channels/252358080522747904/293493549758939136/955769891787534366)
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
crashed again, now with a different log, any ideas?
[2022-03-23 15:44:30][vulkan]: device lost [2022-03-23 15:44:30][vulkan]: vulkan error: Submitting to graphics queue failed.: device lost [2022-03-23 15:44:30][assert]: /home/deen/isos/ddnet/ddnet-source/src/engine/client/backend/vulkan/backend_vulkan.cpp(1094): Submitting to graphics queue failed.: device lost
Avatar
did u unplug ur gpu
14:46
monkalaugh
Avatar
device lost sounds bad
14:46
thats normally a crash in the GPU
14:46
1050 ti was it right?
Avatar
Avatar
bencie
crashed again, now with a different log, any ideas?
[2022-03-23 15:44:30][vulkan]: device lost [2022-03-23 15:44:30][vulkan]: vulkan error: Submitting to graphics queue failed.: device lost [2022-03-23 15:44:30][assert]: /home/deen/isos/ddnet/ddnet-source/src/engine/client/backend/vulkan/backend_vulkan.cpp(1094): Submitting to graphics queue failed.: device lost
why is there deen in that path
Avatar
asserts save full path
14:47
xD
Avatar
@bencie can you send me the crash assert log
Avatar
Avatar
deen
No, they will be shown when you start client for first time. Try setting cl_show_welcome 0 and restart client to try it out.
oh ok
14:49
If I upload the translation file now, will it be applied to version 16?
Avatar
@bencie so the trigger was a screenshot?
Avatar
i don't think so, as you can see i finished 3 seconds before the crash
14:56
no actually
14:56
i saved a geforce experience replay on 15:44:28, one second after finishing
14:57
could be the finish, screenshot or video capture
Avatar
mhhhhhhhhhhhh
14:57
and then discord probs also attached?
Avatar
how so?
Avatar
are u using discord in a browser?
Avatar
can u open discord overlay?
14:58
in game
Avatar
ok
14:59
so i'll test around with screenshots, nvidia shadow play & its replay feature
Avatar
although i have it enabled, both as a discord setting and both ddnet overlay is enabled
Avatar
steam?
Avatar
i have steam overlay off
Avatar
dont know how i triggered it exactly, i'm trying to redo everything i did when i crashed
15:01
but it's saving the videos correctly without a crash
Avatar
i hate these kind of bugs xDD
Avatar
haha yeah its hard to locate the problem when even i cant recreate it, even after doing the same actions
Avatar
do you use the latest driver?
Avatar
im pretty sure yeah but i'll check
15:07
i was on outdated geforce game ready driver, dont know how relevant that is
Avatar
Avatar
Dragere
Is there an argument against adding it to the menu? As cheeser said, some might exit the server and then not find back into the tutorial (https://discord.com/channels/252358080522747904/293493549758939136/955769891787534366)
done in #4876
👍 1
Avatar
Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test if it works standalone, s...
Avatar
by the way, are the new flag icons only in DDNet tab on purpose?
Avatar
Avatar
CHaBek
If I upload the translation file now, will it be applied to version 16?
Actually @cheeser0613 already sent me chinese translations: https://github.com/ddnet/ddnet/pull/4875
Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test if it works standalone, s...
Avatar
Avatar
bencie
by the way, are the new flag icons only in DDNet tab on purpose?
flags have always been only in ddnet tab, this is by design
Avatar
I'm Korean lol
Avatar
lol
Avatar
Avatar
deen
flags have always been only in ddnet tab, this is by design
these arent new?
Avatar
only their design
Avatar
Avatar
CHaBek
I'm Korean lol
ok, will be in next client, yes
Avatar
oh really, what was the design before? i never noticed 👀
Avatar
Avatar
deen
flags have always been only in ddnet tab, this is by design
hes talking about map pass history
Avatar
Avatar
bencie
i was on outdated geforce game ready driver, dont know how relevant that is
would defs be nice to know the version, can you tell me?
Avatar
its old stuff but the design changed
Avatar
Avatar
Jupstar ✪
would defs be nice to know the version, can you tell me?
497.29
Avatar
did u add translations here too?
15:12
that diff scard me xd
Avatar
I regenerated them, forgot that for the vulkan change
Avatar
Avatar
bencie
oh really, what was the design before? i never noticed 👀
old ones
Avatar
oh wow.. :D
15:21
i never knew what those were
Avatar
What is the program that creates the skin?
Avatar
vector art programs
15:22
(inkscape, illustrator, affinity designer)
Avatar
WHAT ?
Avatar
VECTOR ART PROGRAMS (INKSCAPE, ILLUSTRATOR, AFFINITY DESIGNER)
thonk 4
kek 4
troll 2
Avatar
Inkscape is professional quality vector graphics software which runs on Linux, Mac OS X and Windows desktop computers.
Adobe Illustrator is vector-based graphics software that lets you scale down your artwork for mobile screens or scale up to billboard size — and it always looks crisp and beautiful.
Available for Windows, Mac and iPad, Affinity Designer is an award-winning vector graphics software setting the new industry standard in the world of design.
15:27
im using procreate good aswell but only for ipad https://procreate.art (edited)
Procreate® — the most powerful and intuitive digital illustration app. Available only on iPad, and packed with features artists and creative professionals love.
15:36
I hope there are no more additions until the release twinbop (edited)
Avatar
i want to slow down my fps counter is there a way? its so fast i can only see 3xxx
Avatar
u can activate fps in steam
Avatar
and can i tell games to forcely use more cpu/gpu? i mean it only use 10% at most and i have no problem if it would use more
Avatar
Avatar
Jupstar ✪
u can activate fps in steam
ah yeah true
Avatar
ingame you can only use ctrl+shift+d and then ctrl+shift+g to get a FPS graph
Avatar
i meant with cl_showfps 1
Avatar
Avatar
HappyFray
and can i tell games to forcely use more cpu/gpu? i mean it only use 10% at most and i have no problem if it would use more
its not so ez, the program needs to have coded it for the vulkan backend you can use gfx_render_thread_count 16 to use as many cores as possible but that doesnt mean it will max all cores out
Avatar
ok now it use 20% 😄
15:52
like for real, game use more! (edited)
Avatar
why would you want it to use more xd are you laggy in game?
Avatar
maybe it fixes the discord overlay to cause lags while using mouse
15:53
maybe if i have so many fps it doesnt matter anymore then
Avatar
what cpu u got
Avatar
ryzen 5 1600x (edited)
Avatar
it wont use 100% cpu cuz its not multithreaded
15:56
but its prob using 100% of one cpu core
Avatar
100% divided by 12 threads = 8.3
15:57
makes sense
15:57
thats what i get
15:57
xd
15:57
do u have a gpu?
Avatar
Jupstar — heute um 16:43 Uhr its not so ez, the program needs to have coded it for the vulkan backend you can use gfx_render_thread_count 16 to use as many cores as possible but that doesnt mean it will max all cores out
Avatar
Avatar
Ryozuki
do u have a gpu?
1060 6gb
Avatar
weird then
15:57
i get 2k+ fps
15:57
but i have discord overlay disabled
15:57
never tried it on tho
Avatar
yeah but when i enable it it causes lags like hell ingame while using mouse
Avatar
i have a ryzen 5 5600x and a 6600 xt
Avatar
ok i think i will never be able to use discord overlay in ddnet sadly
15:58
hahaha (edited)
Avatar
r u using the rc with vulkan?
Avatar
Avatar
CHaBek
I hope there are no more additions until the release twinbop (edited)
thanks
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
Avatar
deen
yes
Is there anything that needs to be set on a local server to allow 0.7 clients to connect? I just tried to connect to my ddnet server with the latest teeworlds client and it says "0.7 connections are not accepted at this time". It's not important, I just found out while experimenting.
19:33
nevermind, I guess I have to turn on sv_sixup, but it doesn't work via rcon.
Avatar
what's the diff again between fullscreen & desktop fullscreen?
Avatar
Technically or Practically?
Avatar
probably both
19:51
it's hard like this for a standard user to see the difference by the names
Avatar
Technically in true fullscreen the OS gives the entire monitor to the application exclusively. Practically this means the OS can't render things on top of it like notifications and IMEs and it can cause issues with alt-tabbing like the video mode changing and the screen going black for a sec
Avatar
so desktop fullscreen is like a fake fullscreen
19:54
but rendering what's behind
Avatar
I actually thought you were referring to borderless fullscreen when you said desktop fullscreen
Avatar
I mean the 2 last
19:57
"desktop fullscreen" and "fullscreen"
Avatar
I'm not quite sure what that would imply on Windows. On macOS desktop fullscreen is basically borderless with the new window being in a new workspace/desktop
19:58
Let's both learn what it means 😛
Avatar
@Jupstar ✪ What is a "Desktop fullscreen"?
Avatar
because for now it is very unclear for someone what it is
Avatar
It could be "Windowed borderless" but stuck at full desktop resolution
19:59
No idea, only the gfxman really knows what it is 😛
Avatar
but then it is windowed fullscreen?
20:00
bruh this is confusing af (edited)
Avatar
Hm, true there is that too already
20:00
Too many options gang
Avatar
We'll learn when Jupstar comes by I guess
Avatar
windowed fullscreen = windows compositor active desktop fullscreen = desktop video mode(e.g. if ur desktop is 60hz then u will get exactly that auatomatically managed by SDL)
Avatar
isn't it like borderless fullscreen?
Avatar
is it allowed to modify what's in the external folder?
Avatar
flags may be SDL_WINDOW_FULLSCREEN, for "real" fullscreen with a videomode change; SDL_WINDOW_FULLSCREEN_DESKTOP for "fake" fullscreen that takes the size of the desktop; and 0 for windowed mode.
21:09
borderless is windowed without border
21:09
This will add or remove the window's SDL_WINDOW_BORDERLESS flag and add or remove the border from the actual window. This is a no-op if the window's border already matches the requested state.
Avatar
how do i set up a SQL server according to this https://github.com/ddnet/ddnet#building-on-linux-and-macos (go to TEST_MYSQL)
Avatar
Avatar
Chairn
isn't it like borderless fullscreen?
windows does some fullscreen optimization, so its different
Avatar
Avatar
Chairn
how do i set up a SQL server according to this https://github.com/ddnet/ddnet#building-on-linux-and-macos (go to TEST_MYSQL)
Um, just set up mariadb and create a database as specified?
Avatar
!unknown Reported by T tee on Discord @Jupeyy I guess related to your change.
Avatar
Avatar
c0d3d3v
nevermind, I guess I have to turn on sv_sixup, but it doesn't work via rcon.
sv_sixup and the converted map in maps7
Avatar
Avatar
deen
sv_sixup and the converted map in maps7
ah thanks
Avatar
Avatar
Learath2
Um, just set up mariadb and create a database as specified?
what are the commands to execute?
Avatar
Are you on linux?
Avatar
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/build.yaml at master · ddnet/ddnet
Avatar
ah, that has everything \o/
22:01
Just follow what we do on build.yaml, what deen sent
Avatar
And in your config you'll need add_sqlserver r ddnet record ddnet "thebestpassword" "localhost" 3306 0 add_sqlserver w ddnet record ddnet "thebestpassword" "localhost" 3306 0
Avatar
autoexec_server?
22:03
why do you need it btw?
Avatar
just to test
22:04
procrastinating at the maximum level
22:04
running away from my responsibilities
Avatar
I too enable compiler warnings when procrastinating 😄
Avatar
well, i stll have those that i haven't looked into:
22:06
Wimplicit-fallthrough.txt Wmissing-noreturn.txt Wunused-const-variable.txt Wfloat-conversion.txt Waggregate-return.txt Wfloat-equal.txt Wsign-conversion.txt Wconversion.txt Wsuggest-override.txt Wzero-as-null-pointer-constant.txt Wshadow.txt Wtemplates.txt Wpadded.txt Wsystem-headers.txt Wold-style-cast.txt Weffc++.txt
22:06
i checked the first already 😄
22:07
they are sorted by sizes
22:07
i started doing something for zero-as-null-pointer, but it's like the cast-qual, kinda useless stuff
22:07
at elast, i trained my regex doing so 😄
22:08
sed 's/\b\(\(m_\)\?\(a\|p\)\?\(a\|p\)\w\+\b\)\s*==\s*0/\1 == nullptr/g' -i **/*.cpp **/*.h
22:09
sed 's/\b\(\(m_\)\?\(a\|p\)\?\(a\|\p\)\w*\b\)(0\(x0\)\?)/\1(nullptr)/g' -i **/*.cpp **/*.h
Avatar
sed regex sucks
22:13
cuz u gotta escape all the actual regex
22:16
may i introduce you to a rust tool: https://github.com/chmln/sd
Intuitive find & replace CLI (sed alternative). Contribute to chmln/sd development by creating an account on GitHub.
22:17
welcome to 2022
Avatar

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
Avatar
Ryozuki
may i introduce you to a rust tool: https://github.com/chmln/sd
well, im not looking for a super fast tool as usually i modify only small files
22:26
In place modification of files: - sd: sd before after file.txt
22:26
what if i don't want inplace? like for testing my regex before applying
22:28
lol, it use dollar sign for replacement group... this is fucked up for a CLI tool
Avatar
why doesn't /W work?
Exported 362 message(s)