DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-03-20 00:00:00Z and 2022-03-21 00:00:00Z

[ddnet-maps:master] 1 new commit

775bd2c A downpour - ddnet-maps

[ddnet:master] 2 new commits

3d47274 Add tutorial joining code and tutorial map - def- bdafc37 Merge #4747 - bors[bot]

heartw

3

07:46

[ddnet/ddnet] Issue closed: #269 Tutorial and/or "Getting Started" help

07:46

[ddnet/ddnet] Pull request closed: #4747 Add tutorial joining code and tutorial map (fixes #269)

monkalaugh

can someone send me the documentation of the source

https://wiki.ddnet.tw/wiki/Development https://wiki.ddnet.tw/docs/

This article aims to introduce you into DDNet development, since it's an open-source game, it relies on random people kind enough to contribute to it on their free time.

who needs docs when you got source code :brain:

Btw i latley realized that one can have multiple build directorys :D I mean i always kinda knew but it never came to my mind when i needed it. I even used to copy the whole repo for a short time haha

10:20

So nice to have release for playing a debug for development and a headless one for testing and also a clang-tidy one for testing the CI

10:20

might be even better than bam

yeah, that's the proper cmake way, having multiple build directories

kinda cool

10:22

is there any chance we will ever get str_endswith_nocase? :(

if you need it add it yourself?

10:23

actally all the usages of str_endswith look kind of wrong

10:23

like they should be endswith_nocase

10:23

I'll make a PR

Implement a string compare supporting multibyte my self? nah i dont think that would happen or get merged xd

10:25

talkin baut this issue https://github.com/ddnet/ddnet/pull/4818#discussion_r825480847

Add str_startswith_nocase and str_endswith_nocase by ChillerDragon ...

Gets rid of the more complex str_comp_nocase_num usage Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration...

10:26

got even merged into upstream -.-

10:26

not saying ddnet has lower standards but is usually merge happier

Next time make it clear faster that you are talking about an existing PR: D

10:31

I mised that one, so just started reimplementing it

[ddnet/ddnet] Pull request opened: #4844 Accept uppercase file endings

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

Yea i noticed thats why i posted the link

10:44

didnt mean to be pushy but i feelt like this pr would stale forever

just ping in the pr after a week or so

10:45

or answer the remaining questions, which was the reason why I didn't look into it

well heinrich said its broken and i got no solution for it :(

none of our str_ (without utf8) handle unicode well

10:47

but you could implement a utf8 version by converting to unicode codepoints

10:48

if you have no solution, still write an answer why it doesn't apply or that it should still be merged, but you'll open a new issue etc

10:49

as long as there are unanswered comments the PR is on you basically

yea ik

[ddnet:master] 2 new commits

99b0eb2 Add str_startswith_nocase and str_endswith_nocase - ChillerDragon f49afca Merge #4818 - bors[bot]

10:51

[ddnet/ddnet] Pull request closed: #4818 Add str_startswith_nocase and str_endswith_nocase

I think heinrich has a valid point i didnt want to write "its broken but just merge it pls" on github xd

10:52

Wowo what is this black magic? https://github.com/ddnet/ddnet/blob/f7e0d4d5c687281c9d68fef16cb8b3ffb1e0f00a/src/game/client/components/chat.cpp#L700

ddnet/chat.cpp at f7e0d4d5c687281c9d68fef16cb8b3ffb1e0f00a · ddnet/...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/chat.cpp at f7e0d4d5c687281c9d68fef16cb8b3ffb1e0f00a · ddnet/ddnet

10:52

casting a const char * to a CLine *

10:53

does the server just send the struct fields as a string? :D

10:53

only if its a new enough ddnet client whos receiving it i guess

Where is the cast?

10:54

auto &&FChatMsgCheckAndPrint = [this](CLine *pLine) {...} this generates a lambda function and stores it in FChatMsgCheckAndPrint (The F stands for function), the function takes a pLine parameter

ah right i read it wrong

10:56

still getting used to lambdas

10:56

i just saw pLine a few lines above and thought its the same

I'll try to enable -Wshadow

Ou yea that sounds helpful

[ddnet:master] 4 new commits

18d85fd Update icons font - Jupeyy 343a529 Replace browse icons with icon font - Jupeyy daea2fe Switch to Font-Awesome - Jupeyy 12b7ff3 Merge #4842 - bors[bot]

11:06

[ddnet/ddnet] Pull request closed: #4842 Replace browser icons with font icons

I think I found an actual bug by going through the shadowing: https://github.com/ddnet/ddnet/blob/master/src/engine/client/graphics_threaded.cpp#L1124 CC @Jupstar ✪ by not assigning to the old Data we are not using the alloc result after kicked command buffer at all, so basically no retry

ddnet/graphics_threaded.cpp at master · ddnet/ddnet

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/graphics_threaded.cpp at master · ddnet/ddnet

deen

I think I found an actual bug by going through the shadowing: https://github.com/ddnet/ddnet/blob/master/src/engine/client/graphics_threaded.cpp#L1124 CC @Jupstar ✪ by not assigning to the old Data we are not using the alloc result after kicked command buffer at all, so basically no retry

yeah thats a bug, would be nice to enable wshadow

11:27

our codebase is full of it

I'm doing so right now, lots of stuff to fix

i found another bug a while ago when i enabled it

11:28

or at least a code path that makes no sense

11:29

I started a while ago https://github.com/Jupeyy/ddnet/commit/8593e8e2cc6f4e7cfdbb81c6eff6483eba4bf2ab

Wshadow · Jupeyy/ddnet@8593e8e

11:29

but never finished it

ah, I'm only doing Wshadow=local

11:29

that's easier

11:29

about 50% through

https://github.com/ddnet/ddnet/blob/12b7ff3d4cc11acc699e15a9d4c2e3ec5cd80276/src/game/client/prediction/entities/projectile.cpp#L144-L147

ddnet/projectile.cpp at 12b7ff3d4cc11acc699e15a9d4c2e3ec5cd80276 · ...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/projectile.cpp at 12b7ff3d4cc11acc699e15a9d4c2e3ec5cd80276 · ddnet/ddnet

11:31

TeamMask is used before, so i dunno if this is unintendent

11:31

also dunno what the code acutually does

that's prediction code, it's always a weird copy of server code

the branch always results in -1

11:31

but yeah

on the server side this looks more reasonable

ok

I'll remove the teammask there

c++ is a bitsh :D

11:56

i was using the same source and destination for str_truncate() and it worked fine forever until 8 days ago i merged with upstream and it broke :D

[ddnet/ddnet] Pull request opened: #4845 Enable -Wshadow=local

Warn when a local variable shadows another local variable or parameter.

Found one actual bug in graphics_threaded.cpp Should reduce confusion in the future when reading source code

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bound...

[ddnet/ddnet] Pull request closed: #4844 Accept uppercase file endings

@Ravie you still on https://github.com/ddnet/ddnet/issues/4816 or should i look into it?

sv_spam_mute_duration 0 broken · Issue #4816 · ddnet/ddnet

Helptext says "how many seconds to mute, if player triggers mute on spam. 0 = off" But sv_spam_mute_duration 0 still causes *** 'client2' has been muted for 0 seco...

since you can reproduce it you can try to fix it

oke

If you want, you can also build some test scenarios with headless client, then we can run them in CI as a basic sanity check

wowo new icons!

12:58

@Ravie its on my todo since forever .. but ya know procrastination

[ddnet/ddnet] Pull request opened: #4846 Do not mute if spamprotection is off (closed #4816)

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undef...

Lmao all the backtraces refrencing the first few issues https://github.com/ddnet/ddnet/issues/1

Show time of player you're spectating · Issue #1 · ddnet/ddnet

Probably difficult since spectators don't have a character?

kek

2

[ddnet/ddnet] Issue closed: #4816 sv_spam_mute_duration 0 broken

13:31

[ddnet:master] 2 new commits

b343022 Do not mute if spamprotection is off (closed #4816) - ChillerDragon 1f33fc8 Merge #4846 - bors[bot]

13:31

[ddnet/ddnet] Pull request closed: #4846 Do not mute if spamprotection is off (closed #4816)

[ddnet:master] 2 new commits

729cbb7 Ignore fifo files - ChillerDragon 19415d4 Merge #4819 - bors[bot]

13:56

[ddnet/ddnet] Pull request closed: #4819 Ignore fifo files

[ddnet/ddnet] Pull request opened: #4847 made grenades predict without needing to enable predict weapons

motivation: currently you need to enable both weapon prediction and grenade prediction for either one to work, so i changed it so that projectiles predict with "grenade prediction" and / or "weapon prediction" and lasers predict only with "weapon prediction"

Checklist

[X] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[X] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c ...

are useless visual bugs important to fix? if so i can talk about one that i found

15:37

it's quite irrelevant but

You can report it in #bugs !

[ddnet:master] 3 new commits

8134f9f Enable -Wshadow=local - def- 29571ce Also document why we don't use some other useful warnings - def- 564a59d Merge #4845 - bors[bot]

17:00

[ddnet/ddnet] Pull request closed: #4845 Enable -Wshadow=local

ups wrong chat

hi anyone can send me sqlite3 pls

19:30

i need it for a friend

?xd

19:40

asking for a friend doi u have sume sql?

19:40

here u go https://sqlite.org/index.html

Exported 100 message(s)