DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2022-03-13 00:00:00Z and 2022-03-14 00:00:00Z

check that case where u shoot sg into a grid of weapon teles with no destination

00:35

i believe it is used in Awayza (solo)

[ddnet/ddnet] Issue opened: #4814 Hook tele not predicted

While testing a submitted map that used many hook teles, I noticed that hook tele is not predicted. This caused the map to be much much easier on a LAN server than on testing servers by a large amount.

[quakenet] ChillerDragon

omg weebs we did it "git log --grep=UwU"

leave

[ddnet:master] 2 new commits

9518e44 Full size sound settings - def- a1668e0 Merge #4812 - bors[bot]

07:42

[ddnet/ddnet] Pull request closed: #4812 Full size sound settings

wow vscode ... isnt the purpose of if_supported to not fail if not supported? xd

08:13

Embedded image

how is that vscode's fault tho xd

its full vscode fault!

have you done a compiler upgrade, tried to delete build dir?

just deleted the build dir

what compiler do you even use, clang?

clang

08:16

whatever the errors are gone in the editor it doesnt compile but idc

what version

who compiles with his editor anyways

08:16

only lunatics

you for example

no i would never

i also use vscode variant, and for me it always works

only needed a quick poke to get my syntax highlight back on track

i bet u use like clang 7

i assume it picked up my system clang clang version 13.0.1

ok

08:17

xd

i use arch BTW

xd

im just suprised this error could even happen

08:18

when it looks so failsafe in the cmakelists

dunno, maybe they added compability for the flags, but not actually

08:18

sadly cant test with clang 13

08:19

clang 15 works

its probably bill gates him self using electron to spoof clangs user angent

i think its bcs you are vacinated

xd

08:19

interferrance

08:20

i lose 10 min everytime i want to ungrey those preprocessor if statements -.-

08:21

i should just switch to vim

08:21

no features -> no bugs

08:21

08:21

(end of rant)

[quakenet] ChillerDragon

i lose 10 min everytime i want to ungrey those preprocessor if statements -.-

also works for me

[ddnet/ddnet] Issue opened: #4815 The MySQL mode actually only works correctly only for MariaDB

The actual code does not work correctly using MySql 8.0. The /top5 and /rank commands throw an SQL error. On MySQL 8.0 the Rank column needs to be scaped as `Rank` for some reason (The other columns is not needed). After escaping the column name, the error changes to the following one: ``` #1055 - Expression #4 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'test_db.record_race.Server' which is not functionally dependent on columns in GROUP BY claus...

then drop support for mysql

09:39

say we just suport mariadb

09:39

greenthing

[ddnet/ddnet] Issue opened: #4816 sv_spam_mute_duration 0 broken

Helptext says "how many seconds to mute, if player triggers mute on spam. 0 = off" But sv_spam_mute_duration 0 still causes *** 'client2' has been muted for 0 seconds which swallows one message

10:09

[ddnet/ddnet] Pull request opened: #4817 Don't mute for 0 seconds (fixes #4816)

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

[ddnet/ddnet] Issue closed: #2068 Can't see my current server in server list

10:27

[ddnet/ddnet] Issue closed: #4816 sv_spam_mute_duration 0 broken

10:27

[ddnet:master] 2 new commits

eab52b3 Don't mute for 0 seconds (fixes #4816) - def- e91a4d4 Merge #4817 - bors[bot]

10:27

[ddnet/ddnet] Pull request closed: #4817 Don't mute for 0 seconds (fixes #4816)

10:29

[ddnet/ddnet] Issue closed: #2173 Illegal instruction: 4 after build on Mac OS

[ddnet/ddnet] Issue closed: #2211 Long name when showing id collides with clan tag

10:40

[ddnet/ddnet] Issue closed: #2592 Bundle videorecorder + ffmpeg everywhere by default

[ddnet/ddnet] Pull request opened: #4818 Add str_startswith_nocase and str_endswith_nocase

Gets rid of the more complex str_comp_nocase_num usage

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](htt...

10:49

[ddnet/ddnet] Issue closed: #3026 Many localized texts are too long, especially in 5:4 resolution

10:51

[ddnet/ddnet] Issue closed: #3230 Laser bounce star flickering

10:55

[ddnet/ddnet] Issue closed: #3369 Non-default resolutions in fullscreen get reset

10:56

[ddnet/ddnet] Issue closed: #3370 Crash in RenderServerbrowserServerList while typing in search

11:00

[ddnet/ddnet] Issue closed: #3601 Segmentation fault on 15.2.5 when loading map "Back in Time 2"

11:05

[ddnet/ddnet] Issue closed: #3620 tee eye disappear and mouse is fixed in an angle

11:10

[ddnet/ddnet] Issue closed: #3903 Crash in PurgeUntil with > 60 players on server

11:16

[ddnet/ddnet] Issue closed: #4266 Failed at Building

11:18

[ddnet/ddnet] Issue closed: #4353 Crash when switching from fullscreen to windowed

still 331, so many weird issues xd

[ddnet/ddnet] Pull request opened: #4819 Ignore fifo files

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

suggestion: would it be possible to add an optional parameter to save_replay so you could define the demo's name? save_replay [length] [demo name] (edited)

just implement it xd

Ez to so for someone with programming skills xD

no need to have skills search for "save_replay" see how other commands did it and copy paste xd

[ddnet/ddnet] Issue opened: #4820 Cannot Get Full Servers in Server Browser!

Cannot get Full Servers in Server Browser the latest version of DDNet launcher But i can get All servers in old DDNet!

[ddnet/ddnet] Pull request opened: #4821 Add optional save_replay parameter, filename

As suggested by bencie

suggestion: would it be possible to add an optional parameter to save_replay so you could define the demo's name? save_replay [length] [demo name]

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
...

deep hammer

17:56

cammostripes

[ddnet/ddnet] Pull request opened: #4822 Auto select search string on hot key

Pressing CTRL+F should select the current search string, like basically every text editor and browser does

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the...

would it be possible to add some sort of sorting to the skins? for example after name or after last one added to the folder?

Image attachment

Knuski

would it be possible to add some sort of sorting to the skins? for example after name or after last one added to the folder?

wtf send skin

Image attachment

1

brownbear

3

nouis

3

18:24

@lynn

[ddnet/ddnet] Issue closed: #1647 ninja run_tests doesn't work with -DDOWNLOAD_GTEST=ON

Knuski

@lynn

tq (edited)

[ddnet:master] 2 new commits

cce42d4 Auto select search string on hot key - Jupeyy 8ea73b7 Merge #4822 - bors[bot]

18:35

[ddnet/ddnet] Pull request closed: #4822 Auto select search string on hot key

[ddnet/ddnet] Pull request opened: #4823 Use system.h style for system.h

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

Knuski

would it be possible to add some sort of sorting to the skins? for example after name or after last one added to the folder?

The skins are already sorted by name see https://github.com/ddnet/ddnet/blob/8ea73b7800121eb7fa13f1d24b3c79da4c3475be/src/game/client/components/menus_settings.cpp#L476 What exactly is the point of sorting them by date? Sounds unintuitive at first, which date should be used then, the last accessed date or the last modified date?

ddnet/menus_settings.cpp at 8ea73b7800121eb7fa13f1d24b3c79da4c3475b...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/menus_settings.cpp at 8ea73b7800121eb7fa13f1d24b3c79da4c3475be · ddnet/ddnet

c0d3d3v

The skins are already sorted by name see https://github.com/ddnet/ddnet/blob/8ea73b7800121eb7fa13f1d24b3c79da4c3475be/src/game/client/components/menus_settings.cpp#L476 What exactly is the point of sorting them by date? Sounds unintuitive at first, which date should be used then, the last accessed date or the last modified date?

with sorting by name i just meant that u could add like a wheel sorting with options like these:

name (a-z)
name (z-a)
newly added skins
oldest skins

19:47

i just think its nice to have the skins that u personally downloaded and manually put in the folder on the top of the list

Knuski

with sorting by name i just meant that u could add like a wheel sorting with options like these:

name (a-z)
name (z-a)
newly added skins
oldest skins

You could make a toggle between the detail view and the tile/grid view (best with icon). And offer the two filter options (name/date) in the detail view like in the server list.

c0d3d3v

You could make a toggle between the detail view and the tile/grid view (best with icon). And offer the two filter options (name/date) in the detail view like in the server list.

i have not understood ur message since i have 0 knowledge in this area but i appreciate ur effort in trying to help me

c0d3d3v

You could make a toggle between the detail view and the tile/grid view (best with icon). And offer the two filter options (name/date) in the detail view like in the server list.

hmm i dont think we really need a detail/grid toggle. the way the skins are shown are just fine, it's just how it's sorted

when fix name autocomplete when add fallback skin option

[ddnet/ddnet] Issue opened: #4824 Compact friends tab

Feature request: Add a setting to hide clan row from friends entries in the browser tab. I often don't care to know if the clan matches and people frequently change this anyway, so I want to cut down on the size of these vertically so it is easier to scan. Recommeded names for this:

cl_friends_compact
cl_friends_hide_clan

21:43

[ddnet/ddnet] Issue opened: #4825 Fallback skin option

The ability to add your own skin to your client is not very useful since other clients cannot download it. I understand this is already a common request, but in the meantime I suggest a different feature: an option to provide a fallback skin the case the client does not have the requested skin. For example, I use a variant of the whis skin but I don't want other whis users to show as this skin. My solution would be to use my own name for it, but then everyone complains I am "bald" and I'...

poke https://github.com/ddnet/ddnet/issues/659

Autocompletion of player names resolves to incorrect name · Issue #...

2 players in server: Acadia and TheAdmiralPanda. Acadia has a lower clientId (if that matters). When typing "ad" and pressing tab, Acadia is auto-completed whereas it should obvio...

21:52

@heinrich5991 how the hell did you even notice this https://github.com/ddnet/ddnet/issues/4656

Spectating someone with one jump available shows airjump particles ...

The person themselves doesn't see the airjump particles though.

21:52

hats off to you

he noticed it by spectating someone with one jump available jumping

nouis

1

troll

1

[ddnet:master] 2 new commits

897ba58 Use system.h style for system.h - heinrich5991 5d5aa10 Merge #4823 - bors[bot]

22:19

[ddnet/ddnet] Pull request closed: #4823 Use system.h style for system.h

is there a function in the code that returns rgba values when I input the color id?

color_cast

ty

23:35

i think i found it

23:35

RGB = color_cast<ColorRGBA>(ColorHSLA(g_Config.m_ClLaserOutlineColor));

ColorRGBA c = color_cast<ColorRGBA>(...);

23:35

yeah

nice

Exported 109 message(s)