DDraceNetwork

bencie

for a few days now, ive had this bug where my own hammer's animation doesn't show, only partially, happens with every gameskin, in the video i was on 100 pred and the animation barely showed, on ~60 pred it shows more of the animation but still skips like half of it, any ideas?

@c0d3d3v ^

e36363c2e250419cd0d7fb31295b6bb609b542b5 is the first bad commit
commit e36363c2e250419cd0d7fb31295b6bb609b542b5
Author: c0d3d3v
 deobfuscate players OnRender function

can you look into it?

I don't think this is related to refactoring, but who knows, maybe I missed something. I don't understand the issue at all. I see the hammer in the video doing the animation. Would be great if he would make a comparison video before with the old release version and after with master. The same should also happen in demos there you can slow down the animation, does that happen there?

on china i dont see hammer moving at all

10:46

i used git bisect... if i didnt fucked up completly it must be this commit (edited)

10:48

(with antiping if that helps)

I'll test that tonight too, maybe it's really because of the commit.

bencie

for a few days now, ive had this bug where my own hammer's animation doesn't show, only partially, happens with every gameskin, in the video i was on 100 pred and the animation barely showed, on ~60 pred it shows more of the animation but still skips like half of it, any ideas?

lol you are right, the own hammer animation is not visible (tested with 400+ ping) but in the old version it was. But the hammer animation of other players is shown.

Yes, in demo shown aswell

16:38

for me animation completely stops after around >150 pred

without antiping the hammer animation is shown but delayed (edited)

maybe it's just a subjective feeling, but it generally feels much more jerky when playing with dummy at 400+ ping. in the release version i could still drag dummy well and hammer back and forth, now everything is very stuttery. I'll see if I can find out what the problem is. and go back through the individual commits. (very likely just a false subjective impression) (edited)

1

Jupstar ✪

@c0d3d3v ^

e36363c2e250419cd0d7fb31295b6bb609b542b5 is the first bad commit
commit e36363c2e250419cd0d7fb31295b6bb609b542b5
Author: c0d3d3v
 deobfuscate players OnRender function

can you look into it?

So I come to the same conclusion as you, it's because of my commit. I will see what my error was and submit a fix after.

2

xD have found the error

should have actually already noticed in the review

Probably all had tomatoes on the eyes. Well, good that it was noticed so quickly.

Here the fix for interested: https://github.com/ddnet/ddnet/pull/4811 was a stupid copy paste error

fix bug that sneaked in during refactoring (in #4775) by C0D3D3V · ...

Was detected by missing hammer animation at very high ping by texnonik and bencie Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with pos...

when you zoom out all the way and move your screen to down right this hammering , tee in freeze or other stuff you hear loud , also sometimes left .....

Voxel

I spotted an audio glitch! I was spectating in Back In Time 3, and if you /pause and zoom all the way out, and then scrub really quickly through the entire map, random, much louder and distorted sound effects will start playing, even with no one there. (edited)

I discovered this, too! There's no real indication as to why that happens, but it has to do with the sheer size of the map. It might just be the biggest one in DDNet!

Im 'corneum

when i zoom out to max on a full server like bit3 rn and move my mouse up and down at the border of the map i get loud soundbugs

@texnonik

i was first ez