Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-11-29 00:00:00Z and 2021-11-30 00:00:00Z
Avatar
/media/ddnet/src/game/client/ui_ex.cpp:40:5: runtime error: load of value 190, which is not a valid value for type 'bool' Can't figure this out, asan was also running and found no weird memory overwrite.
13:27
``` Direct leak of 640 byte(s) in 1 object(s) allocated from: #0 0x55f21345f599 in operator new(unsigned long) (/media/ddnet/DDNet+0xa01599) #1 0x55f214587781 in CLayerTiles::BrushGrab(CLayerGroup*, CUIRect) /media/ddnet/src/game/editor/layer_tiles.cpp:391:27 #2 0x55f21440ce74 in CEditor::DoMapEditor(CUIRect) /media/ddnet/src/game/editor/editor.cpp:2419:34 #3 0x55f2144a7ced in CEditor::Render() /media/ddnet/src/game/editor/editor.cpp:5618:3 #4 0x55f2144c8cdf in CEdit...
13:29

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
The CUIEx constructor with arguments is unused and only the default constructor was used but hidden away in the header file therefore missing the initialization. Closes #4408.

Checklist

  • [X] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array inde...
Avatar
083c29f fix initialization of CUIEx::m_MouseSlow - Robyt3 f9d676a Merge #4411 - bors[bot]
Avatar
``` /media/ddnet/src/game/client/gameclient.cpp:1424:7: runtime error: index 64 out of bounds for type 'bool [64]' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /media/ddnet/src/game/client/gameclient.cpp:1424:7 in /media/ddnet/src/game/client/gameclient.cpp:1441:9: runtime error: index 64 out of bounds for type 'bool [64]' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /media/ddnet/src/game/client/gameclient.cpp:1441:9 in /media/ddnet/src/game/client/gameclient.cpp:...
Avatar

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [x] Considered possible null pointers and out of bounds array indexing
  • [x] Changed no physics that affect existing maps
  • [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
advent of code coming up!
23:56
in just about 29 hours
Exported 11 message(s)