DDraceNetwork - developer

there's a horrible fucking bug ive gotten twice now where if you confirm a new map save with enter it just exits the game doesnt save

04:04

like type map name, enter, boom closes game

04:05

i think it's incorrectly setting the enter action to exit game

1

04:07

ok it definitely just crashes the game

04:07

it's not a clean exit (edited)

do you use the new rc build? I can't reproduce it

this is regular steam release, i dont know if this is even version specific

and you're on linux? maybe it's OS specific

lynn

i think it's incorrectly setting the enter action to exit game

are you sure it's not just crashing?

lynn

ok it definitely just crashes the game

.

murpi

and you're on linux? maybe it's OS specific

windows

lol i only hread so far i guess

DDNet editor has so many crashes :(

09:22

Its not fun to map anymore without pressing ctrl s everytime you change something

@lynn do you know the exact steps? If you could make a video while reproducing that would help

it's pretty ez to describe 1) open editor 2) save 3) enter any map name 4) press enter

09:39

seems like it happens invariably though

09:39

so there's something im missing

def-

[ddnet/ddnet] Issue opened: #4370 wasd in editor move map when save dialog is open

09:42

def-

[ddnet/ddnet] Pull request opened: #4371 No wasd moving when dialog is open (fixes #4370)

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

Can't reproduce, but I found another bug at least

yay!

09:47

i think the map name i used was "lair" ???

09:47

if it matters even

def-

[ddnet/ddnet] Issue opened: #4372 Moving texture of quad is hard in editor

i took sometimes to figure why “moving texture” at a quad is very hard and inhuman to control (found this problem before but not report it because less use) i think this should be fix

Reported by cheeser0613

clang format be like:

11:24

image.png

well thats the best u can get it to look i guess

I've also been getting crashes when saving maps using save as, really frustrating as you actually lose the map

ur abusing short ifs

image.png

11:26

id prefer this

11:26

a: buse

try moving the ? to next line

lol now it single lined it :D

11:31

clangformat go brrr

11:31

it even removed \ i add to swallow line breaks :D

11:32

well does not matter its just some debug in a ugly code base anyways just wanted to share clang fromat memes here

Can you send me the text?

u curious? :D

there is also // clang-format off if you really mind

	dbg_msg(
		"drop",
		"dropping weapon=%d (%s) dropped=%ld",
		WeaponID,
		WeaponID == WEAPON_GUN ? "gun" :
					 WeaponID == WEAPON_SHOTGUN ? "shotgun" :
								      WeaponID == WEAPON_GRENADE ? "grenade" :
												   WeaponID == WEAPON_LASER ? "laser" :
															      WeaponID == WEAPON_NINJA ? "ninja" :
																			 WeaponID == WEAPON_HAMMER ? "hammer" : "unknown",
		m_pPlayer->m_vWeaponLimit[WeaponID].size());

i do not mind :D

So far I was mostly able to make clang-format and devs happy

well tbh so far i like clang format

11:35

i found my self even skipping code indentation and just running fix_style.py :D

i would just make a function with a switch tbh

elvis operator is so pretty \o/

ur not even using it

?

elvis operator

Yeah, at work I implemented something like this for automated enum pretty-printing: https://stackoverflow.com/questions/28828957/enum-to-string-in-modern-c11-c14-c17-and-future-c20

enum to string in modern C++11 / C++14 / C++17 and future C++20

Contrary to all other similar questions, this question is about using the new C++ features. 2008 c Is there a simple way to convert C++ enum to string? 2008 c Easy way to use variables of enum typ...

isnt elvis opertaor ? :

it's ternary operator when u do ? cond1 : cond2 (edited)

akak tenary

11:40

thozght its thesame

afaik when u do elvis there's nothing between ? and :

ah i see